[FFmpeg-devel] [PATCH] movtextenc: Use default style information from ASS style

2015-08-22 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Generate the default style for movtext from the ASS style. Earlier, we used a fixed default style. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextenc.c | 110 1 file changed, 82

[FFmpeg-devel] [PATCH] movtextdec: Add support for automatic text wrapping

2015-08-14 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in The value of wrap_flag in the Text Wrap Box specifies if the text is to be wrapped or not. Uses 'end of line wrap' amongst the wrap styles supported by ASS if the text is to be wrapped, i.e; fill as much text in a line as possible, then break to next

[FFmpeg-devel] [PATCH 1/2] movtextdec: Use default style information from movtext header

2015-08-12 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This is the updated patch to set the default style in ASS from the default style information present in the movtext header. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 82

[FFmpeg-devel] [PATCH 2/2] Update fate tests to reflect changes in movtextdec default style

2015-08-12 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in The default style is set in the previous patch from the information present in movtext header. This changes the results of some fate tests. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- tests/ref/fate/sub-movtext | 2 +-

Re: [FFmpeg-devel] [PATCH 2/2] Update fate tests to reflect changes in movtextdec default style

2015-08-12 Thread Niklesh Lalwani
On Wed, Aug 12, 2015 at 3:24 PM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Niklesh Lalwani niklesh.lalwani at iitb.ac.in writes: The default style is set in the previous patch from the information present in movtext header. This changes the results of some fate tests. The fate changes

[FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-12 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in As suggested, posting the combined patch with the fate changes. The patch sets the default style in ASS from the default style information present in the movtext header. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c

[FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-09 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Sets the default style in ASS from the default style information present in movtext header Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 82 ++--- 1 file changed, 78

Re: [FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-09 Thread Niklesh Lalwani
+ +typedef struct { +char *font; +int fontsize; +int color; +int back_color; +int bold; +int italic; +int underline; +int alignment; +} Movtext_default; + This name is inconsistent. Use MovTextDefault. Yes, makes sense. Updated patch

[FFmpeg-devel] [PATCH] movtextdec: Fix memory leaks by freeing mem allocs correctly

2015-08-07 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Initialize m-count_f to 0 at the correct place to free memory allocs properly. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/movtextdec.c

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-05 Thread Niklesh Lalwani
I didn't mean this - it's ok for the value to be 0, but it's not ok for it to be some huge number that will cause you to read beyond the end of the buffer. So like you did for the other variable length fields, you need to sanity check this against the total packet size. +t3xg_ptr += 2;

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-05 Thread Niklesh Lalwani
On Thu, Aug 6, 2015 at 2:02 AM, Philip Langdale phil...@overt.org wrote: On Thu, 6 Aug 2015 00:12:07 +0530 Niklesh Lalwani lalwani1...@gmail.com wrote: From 90f466bb6a5d3cd24d7ea4d9fd8a2915cc68cdb2 Mon Sep 17 00:00:00 2001 From: Niklesh niklesh.lalw...@iitb.ac.in Date: Thu, 6 Aug 2015 00

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-05 Thread Niklesh Lalwani
Changes incorporated. Updated patch attached. Thanks, Niklesh On Thu, Aug 6, 2015 at 7:51 AM, Philip Langdale phil...@overt.org wrote: On Thu, 6 Aug 2015 07:13:07 +0530 Niklesh Lalwani lalwani1...@gmail.com wrote: On Thu, Aug 6, 2015 at 2:02 AM, Philip Langdale phil...@overt.org wrote

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-04 Thread Niklesh Lalwani
Updated patch. Thanks, Niklesh On Tue, Aug 4, 2015 at 8:58 AM, Philip Langdale phil...@overt.org wrote: On Fri, 31 Jul 2015 19:25:58 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in The font names are extracted from the font table

[FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-07-31 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in The font names are extracted from the font table, present in text sample entry. More than one fonts can be present, which is taken care of in the patch. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 86

[FFmpeg-devel] [PATCH] movtextdec.c: Add support for fontsize

2015-07-24 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Add support for fontsize in style records. The patch uses reset to directly change back to default style instead of using closing tags, since we are not handling the default styles right now. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in ---

[FFmpeg-devel] [PATCH] movtextenc.c: Add support for text highlighting

2015-07-20 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch adds support for secondary color changes through highlight and hilightcolor box. The code is also reorganised to make it easier to read and maintain. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextenc.c | 164

Re: [FFmpeg-devel] [PATCH] movtextenc.c: Add support for text highlighting

2015-07-20 Thread Niklesh Lalwani
On Mon, Jul 20, 2015 at 4:29 PM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Niklesh Lalwani niklesh.lalwani at iitb.ac.in writes: This patch adds support for secondary color changes through highlight and hilightcolor box. The code is also reorganised to make it easier to read and maintain

[FFmpeg-devel] [PATCH 2/2] movtextenc.c: Add support for text highlighting

2015-07-20 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch takes care of the secondary color changes in ASS through highlight and hilightcolor boxes. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextenc.c | 60 + 1 file changed,

[FFmpeg-devel] [PATCH 1/2] movtextenc.c: Reorganize the code for easier maintenance

2015-07-20 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch reorganizes the code to make it easier to add support for different text modifier boxes and other styles in the future. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextenc.c | 104

[FFmpeg-devel] [PATCH] movtextdec.c: Correct the highlight tags

2015-07-17 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index d564cf1..ca02107 100644 ---

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-12 Thread Niklesh Lalwani
Updated patch attached. As Philip said, this was not a simple re-indent, so indentation included. Thanks, Niklesh From 7dff4a52e41fabe4748076e152cf600d426a5ee8 Mon Sep 17 00:00:00 2001 From: Niklesh niklesh.lalw...@iitb.ac.in Date: Sun, 12 Jul 2015 12:44:48 +0530 Subject: [PATCH] movtextdec.c:

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-07 Thread Niklesh Lalwani
On Tue, Jul 7, 2015 at 3:12 AM, Clément Bœsch u...@pkh.me wrote: On Mon, Jul 06, 2015 at 10:27:47PM +0530, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 254

[FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-06 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 254 +--- 1 file changed, 173 insertions(+), 81 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index

[FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-05 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch adds support for decoding of Highlight and hilightcolor box as defined by 3GPP standards. The code is also reorganised to make it easier to maintain and read. Separate functions are defined that process each type of box. Signed-off-by:

Re: [FFmpeg-devel] [GSoC 2015] Segmentation fault with av_malloc()

2015-07-04 Thread Niklesh Lalwani
Figured it out. Valgrind was pretty helpful. Thanks again. -Niklesh On Sat, Jul 4, 2015 at 12:40 AM, Niklesh Lalwani lalwani1...@gmail.com wrote: Thanks guys, I'll try it out. -Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

[FFmpeg-devel] [GSoC 2015] Segmentation fault with av_malloc()

2015-07-03 Thread Niklesh Lalwani
Hello everyone, I am working with movtextdec.c to implement support for various Text Modifier Boxes. I am getting a segmentation fault with m-style_temp = av_malloc() and I cannot figure out why. I tried to play around with several things to find out the reason, but in vain. Must be something

Re: [FFmpeg-devel] [GSoC 2015] Segmentation fault with av_malloc()

2015-07-03 Thread Niklesh Lalwani
Thanks guys, I'll try it out. -Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-26 Thread Niklesh Lalwani
On 27-Jun-2015 12:36 AM, Philip Langdale phil...@overt.org wrote: On 2015-06-26 09:48, Niklesh Lalwani wrote: The output produced here was actually different from the expected. Hence the test failed. I produced ASS file for both the original file and the encoded file. The ass file produced

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-26 Thread Niklesh Lalwani
information associated here as far as I can see. Please correct me if I'm going wrong here. Thanks, Niklesh On Tue, 23 Jun 2015 22:09:20 +0200 Michael Niedermayer michae...@gmx.at wrote: On Wed, Jun 24, 2015 at 01:25:53AM +0530, Niklesh Lalwani wrote: Updated patch. Compiles without any

[FFmpeg-devel] [GSoC 2015]Trouble with running specific fate tests

2015-06-25 Thread Niklesh Lalwani
Hi all, I am having trouble in running single fate tests. I want to perform the test binsub-movtextenc. I am using the following command- make fate-binsub-movtextenc FATE = /home/niklesh/FFmpeg/fate-suite/ and the target file MovText_capability_tester.mp4 is located in

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-23 Thread Niklesh Lalwani
On 23-Jun-2015 8:41 PM, Philip Langdale phil...@overt.org wrote: On Tue, 23 Jun 2015 16:54:08 +0200 wm4 nfx...@googlemail.com wrote: In my opinion these warnings should either be silenced, or an av_bprint function taking void* should be added and used. While the warning is indeed a false

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-23 Thread Niklesh Lalwani
Updated patch. Compiles without any warnings. Tested too. Thanks, Niklesh On Tue, Jun 23, 2015 at 9:42 PM, Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: On 23-Jun-2015 8:41 PM, Philip Langdale phil...@overt.org wrote: On Tue, 23 Jun 2015 16:54:08 +0200 wm4 nfx...@googlemail.com

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-22 Thread Niklesh Lalwani
On 6/23/15, Philip Langdale phil...@overt.org wrote: I got a bunch of warnings when I compiled it. Please fix. Thanks. -- CC libavcodec/movtextenc.o libavcodec/movtextenc.c: In function ‘mov_text_style_cb’:

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-22 Thread Niklesh Lalwani
Updated patch. Thanks, Niklesh 0002-movtextenc.c-Support-for-Bold-Italic-and-Underlined-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] movtextdec.c: Improve upon dynarrays and text_to_ass

2015-06-22 Thread Niklesh Lalwani
Updated patch. Thanks, Niklesh 0001-movtextdec.c-Improve-upon-dynarrays-and-text_to_ass.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-18 Thread Niklesh Lalwani
, Clément Bœsch u...@pkh.me wrote: On Wed, Jun 17, 2015 at 08:43:26PM +0530, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Support for Bold, Italic and Underlined styles. The style information is appended into the buffer after the text. Dynarray is used to account for multiple

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-18 Thread Niklesh Lalwani
Updated patch. Thanks, Niklesh movtextenc.c-Support-for-Bold-Italic-and-Underlined-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] movtextdec.c: Improve upon dynarrays and text_to_ass

2015-06-18 Thread Niklesh Lalwani
Updated patch attached. On 18-Jun-2015 2:52 PM, Clément Bœsch u...@pkh.me wrote: av_dynarray_add(style_flags, index, flag); +s_temp-style_flag = AV_RB8(tsmb); +count = i; +av_dynarray_add(s, count, s_temp); missing check (make

Re: [FFmpeg-devel] [PATCH 2/2] Encoding of styles - Bold, Italic, Underlined for timed-text subttiles

2015-06-12 Thread Niklesh Lalwani
Yes, the patch is for single style record only. I'll work on multiple style records now. Thanks, Niklesh On 6/12/15, Philip Langdale phil...@overt.org wrote: On Thu, 11 Jun 2015 10:18:53 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in

Re: [FFmpeg-devel] [PATCH 2/2] Encoding of styles - Bold, Italic, Underlined for timed-text subttiles

2015-06-11 Thread Niklesh Lalwani
Tested on iPhone too. You might need to enable the subtitles first. Thanks, Niklesh On 11-Jun-2015 2:22 PM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Niklesh Lalwani niklesh.lalwani at iitb.ac.in writes: Tested on QuickTime 10.3 on OSX Did you also test on an iPhone or iPad? Carl Eugen

Re: [FFmpeg-devel] [PATCH 1/2] Set subtitle track dimensions for mov_text to display the subtitles properly

2015-06-11 Thread Niklesh Lalwani
Ok so it goes like this. We first find out the height and width of the video stream from the header box. The dimensions of the text track (subtitle track) is then set (in pixels). Here, we have used the width equal to the width of the video, and height equal to 1/10 of the video height. The write

[FFmpeg-devel] [PATCH 2/2] Encoding of styles - Bold, Italic, Underlined for timed-text subttiles

2015-06-10 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Encoding of bold, Italic, underlined styles for 3gpp timed text subtitles. All the formatting information is appended into the buffer after the text, unlike other encoders like srt, which can write out styling information as it goes. Another tricky part

Re: [FFmpeg-devel] [PATCH 2/2] Encoding of styles - Bold, Italic, Underlined for timed-text subttiles

2015-06-10 Thread Niklesh Lalwani
Tested on QuickTime 10.3 on OSX, and VLC. For some reason, it doesn't work on Quicktime Windows, I can't figure out why. Thanks, Niklesh On Thu, Jun 11, 2015 at 10:18 AM, Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Encoding of bold, Italic

[FFmpeg-devel] [PATCH 1/2] Set subtitle track dimensions for mov_text to display the subtitles properly

2015-06-10 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch mostly replicates the concept patch posted by Philip https://ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140299.html. This sets the proper dimensions for the subtitle tracks, by making use of the height and width of the video stream. The

Re: [FFmpeg-devel] [GSoC 2015] Regarding encoding of style descriptors for movtext subtitles

2015-05-27 Thread Niklesh Lalwani
On 27-May-2015 9:38 PM, Clément Bœsch u...@pkh.me wrote: Unless I'm mistaken, my understanding is that srt_style_apply() honors the global style of the dialog. Typically in ASS, each dialogue has is associated with a style (generally Default but can be another one defined in the header), so

[FFmpeg-devel] [GSoC 2015] Regarding encoding of style descriptors for movtext subtitles

2015-05-27 Thread Niklesh Lalwani
Hi everyone, I was trying to understand how to encode the style descriptors for mov text subtitles. Currently, I am looking at srtenc.c. I see that srt_style_cb() handles the callbacks for styling information, but then what does srt_style_apply() do? I am confused at several other steps too. Can

Re: [FFmpeg-devel] [PATCH] Improve upon dynamic arrays- movtext subtitles

2015-05-25 Thread Niklesh Lalwani
Updated Patch. Thanks, Niklesh On Mon, May 25, 2015 at 9:10 PM, Philip Langdale phil...@overt.org wrote: On Mon, 25 May 2015 00:37:03 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in

Re: [FFmpeg-devel] [PATCH] Improve upon dynamic arrays- movtext subtitles

2015-05-25 Thread Niklesh Lalwani
Updated. Thanks, Niklesh From 00647a47883b0b547da77d3101f3f890634a85b4 Mon Sep 17 00:00:00 2001 From: Niklesh niklesh.lalw...@iitb.ac.in Date: Mon, 25 May 2015 22:46:04 +0530 Subject: [PATCH] Improve upon dynamic arrays- movtext subtitles Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in ---

[FFmpeg-devel] [PATCH] Improve upon dynamic arrays- movtext subtitles

2015-05-24 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index 04e1c8a..11934f9

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-21 Thread Niklesh Lalwani
Do you mean using a variable equal to tracksize + 10/18? That wouldn't be of much use imo. -Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-21 Thread Niklesh Lalwani
Yes, that would be good. Thanks. -Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-21 Thread Niklesh Lalwani
Updated patch. Thanks, Niklesh 3gpp-largeboxes-21may.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-20 Thread Niklesh Lalwani
I have done tracksize += 8 if there is a large box. This should account for it? On 20-May-2015 11:17 PM, Philip Langdale phil...@overt.org wrote: On 2015-05-20 07:40, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch is to be applied over the previous patch to fix

[FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-20 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index 53ffef0..6ff02b3 100644 ---

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-20 Thread Niklesh Lalwani
Thanks. I'll do it separately for style entries. -Niklesh On 20-May-2015 11:41 PM, Philip Langdale phil...@overt.org wrote: On 2015-05-20 11:06, Niklesh Lalwani wrote: I have done tracksize += 8 if there is a large box. This should account for it? I see you did, but that's not a good

[FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-20 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch is to be applied over the previous patch to fix movtext crashes (which is yet to be committed) Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] Fix 'while' loop condition to prevent movtext crashes by tracking packet size

2015-05-19 Thread Niklesh Lalwani
Thanks Philip. Updated. -Niklesh 3gpp-fix-crashes-19may.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Fix 'while' loop condition to prevent movtext crashes by tracking packet size

2015-05-18 Thread Niklesh Lalwani
Updated patch. -Niklesh fix-movtext-crashes.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Fix 'while' loop condition to prevent movtext crashes by tracking packet size

2015-05-17 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Hi all, This patch fixes some movtext crashes caused due to incorrect 'while' loop condition. I will post several other patches to improve upon the code and null pointer dereferences once this is applied. Signed-off-by: Niklesh

Re: [FFmpeg-devel] [PATCH] Fix 'while' loop condition to prevent movtext crashes by tracking packet size

2015-05-17 Thread Niklesh Lalwani
Just to be clear, I need to check for avpkt-size after reading box size, box type, style entries because there can be bad packets, otherwise the condition should work, right? Yes, I'll add the support for large boxes after this. I have it in my timeline. Thanks, Niklesh

Re: [FFmpeg-devel] [PATCH 1/2] Support for large boxes(32 bit) for 3gpp timed text

2015-05-17 Thread Niklesh Lalwani
Oh yes. I'll correct that. Thank you. Niklesh. On 17-May-2015 10:40 PM, Philip Langdale phil...@overt.org wrote: On Mon, 27 Apr 2015 04:53:26 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw

Re: [FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-27 Thread Niklesh Lalwani
...) ___ I can try av_dynarray2_add(). Which one of these three do you think will be a better choice? -- Niklesh Lalwani Third Year Undergraduate Electrical Engineering IIT Bombay ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-27 Thread Niklesh Lalwani
be a better option. -- Niklesh Lalwani Third Year Undergraduate Electrical Engineering IIT Bombay ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-26 Thread Niklesh Lalwani
On 26-Apr-2015 10:46 AM, Philip Langdale phil...@overt.org wrote: On Sun, 26 Apr 2015 05:04:07 +0200 Michael Niedermayer michae...@gmx.at wrote: On Sun, Apr 26, 2015 at 08:22:56AM +0530, Niklesh Lalwani wrote: On Sun, Apr 26, 2015 at 6:56 AM, Michael Niedermayer michae...@gmx.at

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-26 Thread Niklesh Lalwani
On 26-Apr-2015 4:00 PM, wm4 nfx...@googlemail.com wrote: We usually write: text_style[i].face_style_flags It's the same. Got it. Thank you. :) -Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 2/2] Using size_t* instead of int** for dynarrays

2015-04-26 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 45 - 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index

[FFmpeg-devel] [PATCH 1/2] Support for large boxes(32 bit) for 3gpp timed text

2015-04-26 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index ab4efdb..a5d995d 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] Using size_t* instead of int** for dynarrays

2015-04-26 Thread Niklesh Lalwani
On Mon, Apr 27, 2015 at 7:10 AM, Michael Niedermayer michae...@gmx.at wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 45 - 1 file changed, 20 insertions(+),

[FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-26 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 54 + 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Niklesh Lalwani
On Sun, Apr 26, 2015 at 6:56 AM, Michael Niedermayer michae...@gmx.at wrote: +struct __attribute__((__packed__)) StyleRecord { you cant do this attribute packed is not ANSI/ISO C How do I implement packed structures then here? ( since I don't want padding for proper alignment with the

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Niklesh Lalwani
On Sun, Apr 26, 2015 at 7:05 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Niklesh Lalwani niklesh.lalwani at iitb.ac.in writes: +if ((text_style + i)-face_style_flags This looks very strange imo... What's wrong? I point my structure to the start of the style records

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-24 Thread Niklesh Lalwani
Hi, I am really sorry for replying late. I was stuck up with my end semester examinations. Anyways, I was working on implementing structs and passing style_start and style_end as indices rather than addresses, but with no proper results till now. Here is my previous patch improved with C code

[FFmpeg-devel] [PATCH] Decoding of Bold-Italic_Underlined styles for 3gpp timed text subtitles

2015-04-24 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Updated Patch. This patch stores indices in style_start and style_end rather than addresses. Also corrected a bug while using av_dyarray_add() which went unnoticed for the particular test samples used. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-23 Thread Niklesh Lalwani
Thank you for your suggestions. I'll try to do as much as I can before the deadline. -Niklesh On Wed, Apr 22, 2015 at 10:57 PM, Philip Langdale phil...@overt.org wrote: On 2015-04-22 03:10, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch supports decoding of Bold

[FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Updated patch for decoding of Bold-Italic-Underlined style records for 3gpp timed text. Fixed several build warnings. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 91 + 1

[FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch supports decoding of Bold, Italic, Underlined styles for 3gpp timed text. While the code can be improved upon to make it more clean and well structured, this works for now, even for multiple style records. Suggestions awaited. Signed-off-by:

[FFmpeg-devel] [PATCH 1/2] Decoding of Bold Italic and Underlined styles for 3GPP timed text subtitles

2015-04-13 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch is a part of my qualification task to implement support for Bold, Italic, and Underlined style records for 3GPP timed text subtitles. I am continuing Wesley's work. This patch supports decoding of no more than one style record. Patch[2/2]

[FFmpeg-devel] [PATCH 2/2] Using dynamic arrays for multiple style records

2015-04-13 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in This patch attempts to use dynamic arrays to support multiple style records. However, I am unable to get proper output with using av_dynamic_array(). It seems I am not using this function properly. Can anyone explain? Signed-off-by: Niklesh

Re: [FFmpeg-devel] [PATCH] HDMV PGS subtitles-Ticket #2622

2015-03-25 Thread Niklesh Lalwani
Apologies. I'll do that. I am relatively new to git, and hence wasn't able to send as you had asked. Thanks Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] HDMV PGS subtitles-Ticket #2622

2015-03-24 Thread Niklesh Lalwani
Hi Everyone, This is the fix for issue #2622 https://trac.ffmpeg.org/ticket/2622. These changes enables to remux m2ts file so that the new file has playable subtitles. Thanks, Niklesh Lalwani --- libavformat/mpegts.h| 2 ++ libavformat/mpegtsenc.c | 3 +++ 2 files changed, 5 insertions

[FFmpeg-devel] Fix Patch for Ticket #2622- Remuxing of hdmv pgs subtitles

2015-03-23 Thread Niklesh Lalwani
is maybe due to missing description for HDMV_PGS_SUBTITLE under case AVMEDIA_TYPE_SUBTITLE in mpegtsenc.c. Can anyone explain what is going on with the descriptor handing? Thanks Niklesh Lalwani ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http