Re: [FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-27 Thread Rahul Chaudhry
de on a MacBook to verify that the build works. Thanks, Rahul On Thu, Apr 19, 2018 at 11:06 AM, Michael Niedermayer wrote: > On Wed, Apr 18, 2018 at 04:40:28PM -0700, Rahul Chaudhry wrote: >> On Wed, Apr 18, 2018 at 3:46 PM, Michael Niedermayer >> wrote: >> > please

Re: [FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-18 Thread Rahul Chaudhry
I've verified that the assembly works with armv7a-cros-linux-gnueabi-clang (version 7.0.0). Updated patch with new commit message is attached. Thanks, Rahul From 2e3318acf266b519e98b680102a07196d6ddbf93 Mon Sep 17 00:00:00 2001 From: Rahul Chaudhry Date: Wed, 18 Apr 2018 16:29:39 -0700 Subj

Re: [FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-17 Thread Rahul Chaudhry
On Tue, Apr 17, 2018 at 6:17 AM, Michael Niedermayer wrote: > why does it go through the PLT at all ? You're right. The branches don't have to go through the PLT at all. Here's an alternate patch that modifies the branches to skip the PLT and jump directly to the targets. Note that unlike the p

Re: [FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-16 Thread Rahul Chaudhry
ch uses an R_ARM_THM_JUMP24 relocation and has a range of 16MB. Rahul On Mon, Apr 16, 2018 at 2:31 AM, Michael Niedermayer wrote: > On Fri, Apr 13, 2018 at 01:43:44PM -0700, Rahul Chaudhry wrote: >> When compiling for THUMB-2, the conditional branch to PLT results in a >> R_ARM_THM_JUMP19 reloc

[FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-14 Thread Rahul Chaudhry
When compiling for THUMB-2, the conditional branch to PLT results in a R_ARM_THM_JUMP19 relocation. Some linkers don't support this relocation in THUMB-2 (ld.gold), while others can end up truncating the relocation to fit (ld.bfd). Adding an "it eq" before the branch converts it into an unconditio

[FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-13 Thread Rahul Chaudhry
ch. Rahul From 8dbb701398cf26a6a2f4686f871c5032dcbf1158 Mon Sep 17 00:00:00 2001 From: Rahul Chaudhry Date: Thu, 12 Apr 2018 16:27:31 -0700 Subject: [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2. When compiling for THUMB-2, the conditional branch to PLT results in a R_ARM_THM_JUMP19 relocatio