Re: [FFmpeg-devel] [PATCH 2/2] avcodec/fitsdec: Prevent division by 0 with huge data_max

2019-07-16 Thread Reimar Döffinger
On 16.07.2019, at 00:50, Michael Niedermayer wrote: > Fixes: division by 0 > Fixes: > 15657/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5738154838982656 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/sanm: Check extradata_size before allocations

2019-07-16 Thread Reimar Döffinger
On 16.07.2019, at 00:50, Michael Niedermayer wrote: > Fixes: Leaks > Fixes: > 15349/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SANM_fuzzer-5102530557640704 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH v6] Fix integer parameters size check in SDP fmtp line

2019-07-15 Thread Reimar Döffinger
This seems reasonable to me, but I have not been involved in any rtp code. The commit message is maybe a bit on the verbose side, but I don't have any strong opinion. On 12.07.2019, at 08:40, Olivier Maignial wrote: > === PROBLEM === > > I was trying to record h264 + aac streams from an RTSP

Re: [FFmpeg-devel] [PATCH 2/6] avformat/vividas: Fixes overflow in shift in recover_key()

2019-07-14 Thread Reimar Döffinger
b.com/google/oss-fuzz/tree/master/projects/ffmpeg >Suggested-by: Reimar Döffinger >Signed-off-by: Michael Niedermayer >--- > libavformat/vividas.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/libavformat/vividas.c b/libavformat/vivi

Re: [FFmpeg-devel] [PATCH v6] Fix integer parameters size check in SDP fmtp line

2019-07-03 Thread Reimar Döffinger
On 03.07.2019, at 09:28, Olivier MAIGNIAL wrote: > Hello, thanks for review, > > 1) Can you give some reason about why we shouldn't use errno? I think it is > more clear to accept the full int32 range, even if min/max int32 values are > very unlikely to be used. It is a global variable, with

Re: [FFmpeg-devel] [PATCH] avutil: add av_memcpy() to avoid undefined behavior with NULL, NULL, 0

2019-07-03 Thread Reimar Döffinger
On 03.07.2019, at 08:29, Michael Niedermayer wrote: > On Tue, Jul 02, 2019 at 08:42:43PM -0300, James Almer wrote: >> On 7/2/2019 5:56 PM, Michael Niedermayer wrote: >>> Signed-off-by: Michael Niedermayer >>> --- >>> doc/APIchanges | 3 +++ >>> libavutil/mem.h | 13 + >>>

Re: [FFmpeg-devel] [PATCH]lavc/frame_thread_encoder: Do not memcpy() from NULL

2019-07-02 Thread Reimar Döffinger
On 01.07.2019, at 00:51, Carl Eugen Hoyos wrote: > Hi! > > I believe attached patch fixes undefined behaviour and ticket #7981. Same here, I think it makes more sense to check the "size" instead of the pointer. But I also suspect we might want to think of a way to not need all these

Re: [FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with NULL argument

2019-07-02 Thread Reimar Döffinger
On 01.07.2019, at 01:12, Carl Eugen Hoyos wrote: > Undefined behaviour was reported in ticket #7981, attached patch tries > to fix it. I suspect it makes more sense to check header_len against 0? And is the NULL pointer really undefined behaviour even if length is 0?

Re: [FFmpeg-devel] Changes in cofigure script

2019-06-29 Thread Reimar Döffinger
On 29.06.2019, at 18:26, Dmitry A wrote: > сб, 29 июн. 2019 г. в 21:43, Dmitry A : > >> >> >> сб, 29 июн. 2019 г. в 19:11, Dmitry A : >> >>> >>> >>> сб, 29 июн. 2019 г. в 19:04, Carl Eugen Hoyos : >>> Am Sa., 29. Juni 2019 um 14:23 Uhr schrieb Dmitry A <

Re: [FFmpeg-devel] [PATCH v6] Fix integer parameters size check in SDP fmtp line

2019-06-28 Thread Reimar Döffinger
I don't think we should be using errno when avoidable, and it is avoidable here by disallowing min/max int32 values themselves. Or using strtoll. I'm also rather sceptical about allowing negative values here, does that make sense? Admittedly the type is set to just "int", but maybe it should be

Re: [FFmpeg-devel] [PATCH 4/4] avformat/vividas: Fixes overflow in shift in recover_key()

2019-06-28 Thread Reimar Döffinger
On 28.06.2019, at 22:53, Michael Niedermayer wrote: > Fixes: left shift of 133 by 24 places cannot be represented in type 'int' > Fixes: > 15365/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5716153105645568 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Reimar Döffinger
e here I would say dead code if nothing else is a reminder of the bug, though admittedly a very poor one. Either way I suggest to discuss such things more relaxed, a few days more or less hardly matters and there might be useful insights from other people (of course I don't mean

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Reimar Döffinger
On 26.06.2019, at 13:15, Andreas Håkon wrote: > Hi Moritz, > >>> Wouldn't this be better if extended to be a BSF version of setpts? In >>> addition to delays, rescaling as well as other ops could be carried out >>> on TS. >> >> I second that notion, or at least the suggestion of a setpts

Re: [FFmpeg-devel] [PATCH V1] lavfi/normalize: improve the performance

2019-06-21 Thread Reimar Döffinger
sion of the normalize function specific to that format and the SIMD instruction set available and call it instead of normalize if applicable. I would expect that you should see at least a 3x speedup if using e.g. SSE2 (which is why I don't consider a 10% speedup worth changing the code for really).

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bink: Fix integer overflow in unquantize_dct_coeffs()

2019-06-21 Thread Reimar Döffinger
On 18.06.2019, at 14:55, Michael Niedermayer wrote: > Fixes: signed integer overflow: -3447 * 2883584 cannot be represented in type > 'int' > Fixes: > 15265/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5088311799971840 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/videodsp_template: Fix overflow of addition

2019-06-21 Thread Reimar Döffinger
On 18.06.2019, at 16:25, Michael Niedermayer wrote: > Fixes: addition of unsigned offset to 0x7f56fc26a9b6 overflowed to > 0x7f56fc26a8be* > Fixes: > clusterfuzz-testcase-minimized-mediasource_MP4_AVC1_pipeline_integration_fuzzer-4917949056679936 > > Reported-by: Matt Wolenetz >

Re: [FFmpeg-devel] [PATCH 3/7] avcodec/alsdec: Fix integer overflow with buffer number

2019-06-21 Thread Reimar Döffinger
On 21.06.2019, at 00:47, Michael Niedermayer wrote: > Fixes: signed integer overflow: 65313 * 65313 cannot be represented in type > 'int' > Fixes: > 15290/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5738074249625600 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/apedec: Fix multiple integer overflows in filter_3800()

2019-06-16 Thread Reimar Döffinger
On 16.06.2019, at 17:12, Paul B Mahol wrote: > On 6/16/19, Reimar Döffinger wrote: >> >> >> On 16.06.2019, at 12:30, Lynne wrote: >> >>> Jun 16, 2019, 10:57 AM by mich...@niedermayer.cc: >>> >>>> Fixes: left shift of negative valu

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/apedec: Fix multiple integer overflows in filter_3800()

2019-06-16 Thread Reimar Döffinger
On 16.06.2019, at 12:30, Lynne wrote: > Jun 16, 2019, 10:57 AM by mich...@niedermayer.cc: > >> Fixes: left shift of negative value -4 >> Fixes: signed integer overflow: -15091694 * 167 cannot be represented in >> type 'int' >> Fixes: signed integer overflow: 1898547155 + 453967445 cannot be

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: unknown codec triggers error

2019-06-16 Thread Reimar Döffinger
On 14.06.2019, at 17:01, James Almer wrote: > On 6/14/2019 11:52 AM, Reimar Döffinger wrote: >> >> >> On 14.06.2019, at 03:15, Chris Cunningham wrote: >> >>> Only "succeed" to read a header if the codec is valid. Otherwise >>> return AVE

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: unknown codec triggers error

2019-06-14 Thread Reimar Döffinger
On 14.06.2019, at 03:15, Chris Cunningham wrote: > Only "succeed" to read a header if the codec is valid. Otherwise > return AVERROR_INVALIDDATA. That doesn't sound right to me, an unknown codec in (possibly) a single stream is not an error. I understood the discussion more to say the if

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_gblur: add x86 SIMD optimizations

2019-06-12 Thread Reimar Döffinger
On 12.06.2019, at 11:44, "Jean-Baptiste Kempf" wrote: > On Wed, Jun 12, 2019, at 07:51, Reimar Döffinger wrote: >> Where does this license come from? > > Original file. > Very classical BSD-3 > >> Is that even GPL-compatible? > > Yes, of course

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_gblur: add x86 SIMD optimizations

2019-06-11 Thread Reimar Döffinger
On 12.06.2019, at 03:00, Ruiling Song wrote: > ffmpeg | branch: master | Ruiling Song | Wed May 15 > 17:54:10 2019 +0800| [83f9da77684e7ea0d8e9f9712ec716424140043a] | committer: > Ruiling Song > > avfilter/vf_gblur: add x86 SIMD optimizations > > The horizontal pass get ~2x performance

Re: [FFmpeg-devel] FFmpeg android support

2019-06-11 Thread Reimar Döffinger
But none of the "reinvented the wheel" build processes are supported. As most objective measure, it seems not tested via fate.ffmpeg.org, which always is a bad sign. Best regards, Reimar Döffinger ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

2019-06-09 Thread Reimar Döffinger
On 09.06.2019, at 03:07, Peter Ross wrote: > On Sat, Jun 08, 2019 at 08:49:15AM +0200, Reimar Döffinger wrote: >> >> >> On 08.06.2019, at 03:08, Peter Ross wrote: >> >>> --- >>> comments against v4 patch addressed. thanks. >>> >&g

Re: [FFmpeg-devel] [PATCH 3/4] avformat/wsddec: Fix undefined shift

2019-06-08 Thread Reimar Döffinger
On 08.06.2019, at 11:28, Michael Niedermayer wrote: > Fixes: left shift of 1 by 31 places cannot be represented in type 'int' > Fixes: > 15123/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5738039235575808 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_sei: Add acces to truncated SEI data

2019-06-08 Thread Reimar Döffinger
looks good to me if maintainer has no objections... On 08.06.2019, at 15:21, Antonin Gouzer wrote: > --- > Some codecs editors had miss interpreted the H264 standart and > have coded a wrong size in the SEI data. > size = SEI size + 1. > The SEI data is detected as "truncated" > Ex: >

Re: [FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

2019-06-08 Thread Reimar Döffinger
On 08.06.2019, at 03:08, Peter Ross wrote: > --- > comments against v4 patch addressed. thanks. > > +#if CONFIG_VP4_DECODER > +static int vp4_get_mb_count(Vp3DecodeContext *s, GetBitContext *gb) > +{ > +int v = 1; > +int bits; > +while ((bits = show_bits(gb, 9)) == 0x1ff && v < >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/vividas: reduce keybits to require half the space

2019-06-08 Thread Reimar Döffinger
On 07.06.2019, at 23:56, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/vividas.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/vividas.c b/libavformat/vividas.c > index 5e303b9c52..72f2093d13 100644 > ---

Re: [FFmpeg-devel] [PATCH v4] vaapi_encode_mjpeg: fix bad component id bug

2019-06-08 Thread Reimar Döffinger
On 07.06.2019, at 23:45, "U. Artie Eoff" wrote: > The compound literals assigned to "components" > only exist within the scope of the if/else > block (thanks Mark Thompson for the better > explanation). > > Thus, after this if/else block, "components" > ends up pointing to an

Re: [FFmpeg-devel] [PATCH] vaapi_encode_mjpeg: WA: fix bad component id bug

2019-06-07 Thread Reimar Döffinger
On 07.06.2019, at 22:28, "U. Artie Eoff" wrote: > When compile time optimizations are enabled and > compiling with GNU GCC 9.x, the pointer assignment > to the inline brace-enclosed list initialized > array does not work and "component" ends up pointing > to an empty array. This is probably a

Re: [FFmpeg-devel] [PATCH] avcodec/h264_sei: Add experimental acces to truncated SEI data

2019-06-05 Thread Reimar Döffinger
On 04.06.2019, at 22:33, Antonin Gouzer wrote: > Hello, > Thanks for your response. > It's difficult to say if this is a common issue. > I have hundred of thousands of files like this from an editor. > > Even the off by one Size is not standart compliant and it would be > incorrect to not

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Reimar Döffinger
On 04.06.2019, at 15:07, Andreas Håkon wrote: > Hi, > > I need to admit that I'm completely wrong in the end. After spending a lot > of time on a patch to solve the problem (making the MPEG-2 QSV encoder > compatible with broadcasts), I discovered that this solution works: > > $ ffmpeg ...

Re: [FFmpeg-devel] [PATCH] avcodec/h264_sei: Add experimental acces to truncated SEI data

2019-06-04 Thread Reimar Döffinger
On 04.06.2019, at 00:21, Antonin Gouzer wrote: > --- > Some codecs editors had miss interpreted the H264 standart and > have coded a wrong size in the SEI data. > size = SEI size + 1. > The SEI data is detected as "truncated" > Ex: >

Re: [FFmpeg-devel] [PATCH 2/4] cbs: Remove useless initializations

2019-06-03 Thread Reimar Döffinger
On 03.06.2019, at 14:07, Andreas Rheinhardt wrote: > Reimar Döffinger: >> On 03.06.2019, at 00:37, Andreas Rheinhardt >> wrote: >> >>> Up until now, a temporary variable was used and initialized every time a >>> value was read in CBS; if reading turne

Re: [FFmpeg-devel] [PATCH 2/4] cbs: Remove useless initializations

2019-06-03 Thread Reimar Döffinger
On 03.06.2019, at 00:37, Andreas Rheinhardt wrote: > Up until now, a temporary variable was used and initialized every time a > value was read in CBS; if reading turned out to be successfull, this > value was overwritten (without having ever been looked at) with the > value read if reading was

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-05-30 Thread Reimar Döffinger
On 28.05.2019, at 12:48, Andreas Håkon wrote: > Hi, > > This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/) > > A new (simpler and more robust) implementationof of the reinsertion of the > missing headers in the MPEG-2 bitstream from the HW QSV encoder. > > The problem

Re: [FFmpeg-devel] [PATCH v5] avformat/ifv: added support for ifv cctv files

2019-05-30 Thread Reimar Döffinger
On 29.05.2019, at 19:51, Swaraj Hota wrote: >> >> Entirely depends on the purpose. >> If the aim is to have a working demuxer, I think it is acceptable from what >> I looked at. >> I guess the only concern might be that not supporting piped input would be a >> bit of a regression from the

Re: [FFmpeg-devel] [PATCH v5] avformat/ifv: added support for ifv cctv files

2019-05-26 Thread Reimar Döffinger
On Sun, May 26, 2019 at 01:46:32AM +0530, Swaraj Hota wrote: > +st = avformat_new_stream(s, NULL); > +if (!st) > +return AVERROR(ENOMEM); > + > +st->codecpar->codec_type = AVMEDIA_TYPE_VIDEO; > +st->codecpar->codec_id = AV_CODEC_ID_H264; > +st->codecpar->width =

Re: [FFmpeg-devel] [PATCH] avcodec/vp3data: combine eob_run_base and eob_run_get_bits tables

2019-05-26 Thread Reimar Döffinger
On Sat, May 25, 2019 at 12:04:49PM +1000, Peter Ross wrote: > --- > This provides a small readability improvement. > I observe no performance change on x86_64 or arm6. Looks good to me, but probably the maintainer should decide. I guess I'd be very mildly curious to know if the asm code the

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-22 Thread Reimar Döffinger
On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote: > > +#define SHIFT(v, shift) ((v) >> (shift)) > > +#define ABS_SHIFT(v, shift) ((v) > 0 ? SHIFT(v, shift) : -SHIFT(-v, shift)) > > Don't we have something like that already? Seems we don't > I thi

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Reimar Döffinger
dc += dc_pred[idx + 1].dc; > +count++; > +} Maybe do dc_pred += idx at the start and then only dc_pred[-6], dc_pred[6] etc? > +#define loop_stride 12 > +uint8_t loop[12 * loop_stride]; Hm, at 144 bytes, might it make sense to have in context instead of on stack? &g

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Reimar Döffinger
On Tue, May 21, 2019 at 11:15:03AM -0300, James Almer wrote: > > I have a feeling this loop should have a stop condition like v < > > SOME_LARGE_VALUE, say INT_MAX-255 or yuv_macroblock_count, to reject > > corrupt/malicious files and not cause undefined behavior > > Using get_bits_left(gb) would

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

2019-05-21 Thread Reimar Döffinger
On Tue, May 21, 2019 at 04:51:19PM +0200, Moritz Barsnick wrote: > (It only matters on hardware which requires double precision software > emulation, but if explicitly using float, make sure to stick to float.) It's a best practice regardless of emulation or not. Even x86 has for example much

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Reimar Döffinger
On Mon, May 20, 2019 at 10:05:49AM +0200, Hendrik Leppkes wrote: > On Mon, May 20, 2019 at 9:44 AM Reimar Döffinger > wrote: > > On 20.05.2019, at 09:23, Mathieu Duponchelle > > wrote: > > > On 5/19/19 7:00 PM, Devin Heitmueller wrote: > > >> Are you

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Reimar Döffinger
On 20.05.2019, at 09:23, Mathieu Duponchelle wrote: > Thanks :) > > On 5/19/19 7:00 PM, Devin Heitmueller wrote: >> Hello Paul, >> >> On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: >>> On 5/17/19, Mathieu Duponchelle wrote: There isn't one, as I said the added indentation is

Re: [FFmpeg-devel] [PATCH] avcodec/v210dec: Fix alignment check for AVX2

2019-05-18 Thread Reimar Döffinger
On 18.05.2019, at 12:15, Michael Niedermayer wrote: > On Sat, May 18, 2019 at 12:02:55PM +0200, James Darnley wrote: >> On 2019-05-18 09:39, Michael Niedermayer wrote: >>> Fixes: "null pointer dereference" >>> Fixes: >>>

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-17 Thread Reimar Döffinger
to keep the feud going, please deal with the consequences yourself and stop dragging the whole project into your self-created messes. Sorry for the bluntness and my excuses if I ruined the chances for a peaceful weekend. Best regards, Reimar Döffinger. On 17.05.2019, at 21:25, Paul B Mahol

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-17 Thread Reimar Döffinger
On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: > ah, i see what you did there! it works perfectly, just missing > UPDATE_CACHE at the start and in the loop. > > test results on i7 decoding 3 minute long 4k video with vp4. Looks fairly close to noise to me, though for me it seemed a

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > > +static int read_mb_value(GetBitContext *gb) > > +{ > > +int v = 1; > > +int size; > > +OPEN_READER(re, gb); > &g

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > v = 127 + SHOW_UBITS(re, gb, 7); Sorry typo, must be 129 instead of 127. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > +static int read_mb_value(GetBitContext *gb) > +{ > +int v = 1; > +int size; > +OPEN_READER(re, gb); > + > +do { > +int bit; > +size = 0; > + > +UPDATE_CACHE(re, gb); > +bit =

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-15 Thread Reimar Döffinger
On Tue, May 14, 2019 at 08:41:02PM +0200, Lynne wrote: > May 14, 2019, 7:12 PM by one...@gmail.com: > > On 5/14/19, Carl Eugen Hoyos <> ceffm...@gmail.com > > > > wrote: > >>> Am 14.05.2019 um 19:17 schrieb Lynne <>>> d...@lynne.ee > >>> : >

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

2019-05-15 Thread Reimar Döffinger
On Wed, May 15, 2019 at 09:39:00AM +, Andreas Rheinhardt wrote: > > This problem really needs to be solved. The bitstream generated breaks the > > standard! > > > If I am not mistaken, then the bitstream generated doesn't break the > standard; it is just inconvenient for streaming purposes.

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-14 Thread Reimar Döffinger
On Tue, May 14, 2019 at 10:37:03PM +1000, Peter Ross wrote: > On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: > > On 12.05.2019, at 08:12, Peter Ross wrote: > > > +static int read_mb_value(GetBitContext *gb) > > > +{ > > >

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-14 Thread Reimar Döffinger
have other options. Compromise and consesus is always better. Though I admit a way to ask the mood more like a poll sounds interesting to me, maybe even anonymous? Best regards, Reimar Döffinger ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Reimar Döffinger
s it harder to enforce our license. Even if nothing happens, the work companies have to do to show compliance (because their customers require it or to reduce their risk) becomes much harder. Which is why the Linux kernel currently is working on cleaning up their license header mess. Best regards, Reimar D

Re: [FFmpeg-devel] Discussion of all-inclusive full stack builds

2019-05-12 Thread Reimar Döffinger
On Sun, May 12, 2019 at 12:07:42PM -0700, Tim Jones wrote: > On May 12, 2019, at 11:54 AM, Nicolas George wrote: > > > > Tim Jones (12019-05-12): > > > >> --disable-all-proprietary/--enable-all-proprietary > > > > As for this one, on the other hand, there will be opposition: we do not > > want

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Reimar Döffinger
On 12.05.2019, at 08:12, Peter Ross wrote: > +static int read_mb_value(GetBitContext *gb) > +{ > +int v = 1; > +int size; > + > +do { > +size = 0; > +if (!get_bits1(gb)) > +break; > +v++; > +do { > +if (!get_bits1(gb)) > +

Re: [FFmpeg-devel] [PATCH v4] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-10 Thread Reimar Döffinger
tially many, many GB large video file for a 8-character string. A false positive has a REALLY high likelihood. I think this needs to be changed into a more clever approach, that actually knows where these strings can appear and removes them in a more targeted way... Best regards, Reimar Döffi

Re: [FFmpeg-devel] [PATCH v9] lavf/flv: Add XV (Xunlei Video) Support. fixes ticket #3720

2019-05-10 Thread Reimar Döffinger
On 10.05.2019, at 15:10, Shivam Goyal wrote: > > -> Making two avio contexts and one calling the other ( I am not sure if > i implemented it in the right way, but still i reached low level ). Can't you at least figure out the header size, decrypt the header and pass that to the normal header

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-08 Thread Reimar Döffinger
cpy(pkt->data + new_size, data + j + 2, end - j -1); > +new_size += end - j - 1; > +w = 1; > +break; > +} else if (j + 1 > end && i > start && i <= end) { > +memcpy(pkt->data

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-08 Thread Reimar Döffinger
On Wed, May 08, 2019 at 03:06:37PM +0530, Swaraj Hota wrote: > On Wed, May 08, 2019 at 12:52:01AM +0200, Reimar Döffinger wrote: > > First, seeking should be handled specially, by resetting the state. > > You should not make the get_packet less efficient because of that. > &g

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-08 Thread Reimar Döffinger
On 08.05.2019, at 08:01, Carl Eugen Hoyos wrote: > Am Mi., 8. Mai 2019 um 00:52 Uhr schrieb Reimar Döffinger > : >> >> On 07.05.2019, at 12:00, Swaraj Hota wrote: >> >>> On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: >>

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-07 Thread Reimar Döffinger
On 07.05.2019, at 12:00, Swaraj Hota wrote: > On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: >> >> >>> +/*read video index*/ >>> +avio_seek(s->pb, 0xf8, SEEK_SET); >> [...] >>> +avio_skip(s->pb, ifv->vi

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-07 Thread Reimar Döffinger
On 07.05.2019, at 01:33, Lynne wrote: > May 6, 2019, 11:41 PM by barsn...@gmx.net: > >> On Mon, May 06, 2019 at 02:23:26 +0200, Lynne wrote: >> >>> This allowed for the exptabs to be computed just once on startup and >>> stored in a global array. >>> >> >> I have no real understanding of

[FFmpeg-devel] Quo vadis, code of conduct?

2019-05-05 Thread Reimar Döffinger
up to it, that is quite a different thing from standing up for it). My apologies for barging in here and starting this kind of thing. But if you haven't lately given it a thought where you stand on the topic, I take the liberty to ask you to. Best regards, Reimar Döffinger P.S.: I followed my own

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-05 Thread Reimar Döffinger
On Sun, May 05, 2019 at 10:05:17PM +0200, Carl Eugen Hoyos wrote: > Am So., 5. Mai 2019 um 21:59 Uhr schrieb Reimar Döffinger > : > > > +if (aud_magic == MKTAG('G','R','A','W')) { > > > +ifv->is_audio_present = 1; > > > +} else i

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-05 Thread Reimar Döffinger
_offset is ordered increasingly (as would be needed for binary search), but that property isn't really checked/enforced. > +av_freep(>vid_index); > +if (ifv->is_audio_present) > +av_freep(>aud_index); Shouldn't the if () be unnecessary? Best regards, Reimar Döffinger ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Reimar Döffinger
On 05.05.2019, at 18:04, Paul B Mahol wrote: > On 5/5/19, Reimar Döffinger wrote: >> On 04.05.2019, at 15:40, Paul B Mahol wrote: >>> Hi, >>> >>> I open voting for 7 days, for inclusion of colorhold filter in FFmpeg, >>> with minor changes. >&g

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Reimar Döffinger
ary vs. the normal development process? I so far assumed voting was purely a last-resort conflict resolution process. Is there a quorum required, or would a vote be accepted even if there was only one vote cast? Best regards, Reimar Döffinger ___ ffmpeg-

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-05 Thread Reimar Döffinger
On 03.05.2019, at 20:16, Michael Niedermayer wrote: > On Fri, May 03, 2019 at 11:08:35AM +0200, Carl Eugen Hoyos wrote: >> Am Fr., 3. Mai 2019 um 07:27 Uhr schrieb Jeyapal, Karthick >> : > >> And finally: What do you suggest to "punish the violator"? > > while this question wasnt directed at

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Reimar Döffinger
ifferent world views meet head-on, and hope you can discuss in that spirit :) Best regards, Reimar Döffinger ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Server upgrades

2019-02-06 Thread Reimar Döffinger
On 6 February 2019 11:46:52 CET, Michael Niedermayer wrote: >On Tue, Feb 05, 2019 at 05:03:02PM +, Eoff, Ullysses A wrote: >> I'm getting an ssl error >> with pwclient today. This is the first time I've tried using >pwclient since this >> upgrade, so not sure if it's related. >> >>

Re: [FFmpeg-devel] [PATCH] avcodec: increase AV_INPUT_BUFFER_PADDING_SIZE to 64

2018-01-08 Thread Reimar Döffinger
lt;= 52 failed at libavformat/oggparseogm.c:109 > > > Aborted (core dumped) > > > > How do you say this should be fixed? Why should > > AV_INPUT_BUFFER_PADDING_SIZE be lower or equal to 52? > > > > I have no idea about OGM, so i could use some help. > &g

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

2017-09-16 Thread Reimar Döffinger
On Fri, Sep 15, 2017 at 02:16:58AM +0200, Michael Niedermayer wrote: > On Wed, Sep 13, 2017 at 08:11:38PM +0200, Reimar Döffinger wrote: > > On Wed, Sep 13, 2017 at 07:12:48PM +0200, Reimar Döffinger wrote: > > > This is the equivalent to what 7d317d4706b49d572a1eb5269438753b

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread Reimar Döffinger
On Wed, Sep 13, 2017 at 02:49:59PM -0300, James Almer wrote: > On 9/13/2017 2:23 PM, Carl Eugen Hoyos wrote: > > 2017-09-13 19:10 GMT+02:00 James Almer : > >> Some targets, like NetBSD and DJGPP, don't seem to support it. > >> > >> Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

2017-09-13 Thread Reimar Döffinger
On Wed, Sep 13, 2017 at 07:12:48PM +0200, Reimar Döffinger wrote: > This is the equivalent to what 7d317d4706b49d572a1eb5269438753be18362c7 > did for the codec-specific options. > av_opt_copy has specific handling so it's fine that we already copied > the whole context before. Btw, if

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-09-13 Thread Reimar Döffinger
On Wed, Aug 23, 2017 at 10:26:45PM +0200, Alexander Strasser wrote: > On 2017-08-22 17:23 +, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Tue Aug 22 18:36:26 2017 +0200| [a2e444d5bb2e3115d3afcc0cca9d1506c90436a2] > > | committer:

[FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

2017-09-13 Thread Reimar Döffinger
This is the equivalent to what 7d317d4706b49d572a1eb5269438753be18362c7 did for the codec-specific options. av_opt_copy has specific handling so it's fine that we already copied the whole context before. Signed-off-by: Reimar Döffinger <reimar.doeffin...@gmx.de> --- liba

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Reimar Döffinger
On Thu, Aug 03, 2017 at 12:40:04AM +0200, Tomas Härdin wrote: > +//statically assert the size of avpriv_codec2_header > +//putting it here because all codec2 things depend on codec2utils > +switch(0) { > +case 0: > +case sizeof(avpriv_codec2_header) == 7: //if false then the

Re: [FFmpeg-devel] [PATCHv2 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-02 Thread Reimar Döffinger
On 02.08.2017, at 19:53, Jorge Ramirez wrote: > On 08/02/2017 07:40 PM, Hendrik Leppkes wrote: >> On Wed, Aug 2, 2017 at 7:14 PM, Jorge Ramirez >> wrote: >>> I just think is wrong and I am a bit surprised we could have no real >>>

Re: [FFmpeg-devel] [PATCH] build: Allow libffmpeg to be built for Chromium-based browsers

2017-07-29 Thread Reimar Döffinger
On 28.07.2017, at 12:07, James Le Cuirot wrote: > diff --git a/ffbuild/libffmpeg.mak b/ffbuild/libffmpeg.mak > new file mode 100644 > index 000..992cf3c > --- /dev/null > +++ b/ffbuild/libffmpeg.mak > @@ -0,0 +1,21 @@ > +LIBFFMPEG = $(SLIBPREF)ffmpeg$(SLIBSUF) >

Re: [FFmpeg-devel] [PATCH] build: Allow libffmpeg to be built for Chromium-based browsers

2017-07-29 Thread Reimar Döffinger
On 29.07.2017, at 01:05, Ivan Kalvachev wrote: > On 7/29/17, Dominik 'Rathann' Mierzejewski wrote: >> On Saturday, 29 July 2017 at 00:20, Hendrik Leppkes wrote: >>> On Fri, Jul 28, 2017 at 12:07 PM, James Le Cuirot >>> wrote: >>

Re: [FFmpeg-devel] [PATCH 3/4] libavcodec: v4l2: add codec formats

2017-07-24 Thread Reimar Döffinger
On 24.07.2017, at 21:08, Jorge Ramirez-Ortiz wrote: > From: Alexis Ballier > > In addition, enable the multi planar raw formats. I see the existing code already does it like that, but I don't think that is the best way. Defining the macro

Re: [FFmpeg-devel] [PATCH 1/4] Move lavd/v4l2-common.* to lavc

2017-07-24 Thread Reimar Döffinger
Hmm... a bit weird that we have a file with a dash in the file name when everything else uses underscore... On 24.07.2017, at 21:08, Jorge Ramirez-Ortiz wrote: > From: Alexis Ballier > > In preparation to support the integation of the

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 13:32, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Jul 23, 2017 at 09:35:12AM +0200, Reimar Döffinger wrote: >> >> >> Btw the comodo certificate Michael mentioned is a domain-validation >> certificate for 7x the price of w

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 12:20, Nicolas George wrote: > >> +if (!q->last_pkt) { >> +q->first_pkt = pkt1; >> +} else { >> +q->last_pkt->next = pkt1; >> +} If kept, I would invert the condition, otherwise the else is essentially a double-negation. >> +

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 09:27, Reimar Döffinger <reimar.doeffin...@gmx.de> wrote: > On 21.07.2017, at 15:31, Ricardo Constantino <wiia...@gmail.com> wrote: > >> On 18 July 2017 at 02:12, Gerion Entrup <gerion.entrup.ff...@flump.de> wrote: >>> Am Dienstag, 18.

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 21.07.2017, at 15:31, Ricardo Constantino <wiia...@gmail.com> wrote: > On 18 July 2017 at 02:12, Gerion Entrup <gerion.entrup.ff...@flump.de> wrote: >> Am Dienstag, 18. Juli 2017, 01:52:53 CEST schrieb Reimar Döffinger: >>> On 18.07.2017, at 00:59, James A

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-22 Thread Reimar Döffinger
On 22.07.2017, at 10:45, Reimar Döffinger <reimar.doeffin...@gmx.de> wrote: > > Sorry for disturbing anyone's fun with too much philosophy ;) I also apologize that I sent my previous mail, which was the first on the topic, to the public mailing list. I SHOULD know better and contac

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-22 Thread Reimar Döffinger
On 21.07.2017, at 20:48, Paul B Mahol wrote: > On 7/21/17, Reimar Doeffinger wrote: >> On 21.07.2017, at 08:48, Paul B Mahol wrote: >> >>> On 7/20/17, Carl Eugen Hoyos wrote: 2017-07-20 17:46 GMT+02:00

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-21 Thread Reimar Döffinger
On 21.07.2017, at 08:48, Paul B Mahol wrote: > On 7/20/17, Carl Eugen Hoyos wrote: >> 2017-07-20 17:46 GMT+02:00 Vittorio Giovara : >> >>> +[AV_PIX_FMT_YUV444F32LE] = { 0, 0 }, >>> +[AV_PIX_FMT_YUV444F32BE] = { 0, 0 },

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-21 Thread Reimar Döffinger
On 21.07.2017, at 16:26, Paras Chadha wrote: > On Fri, Jul 21, 2017 at 3:27 AM, Carl Eugen Hoyos > wrote: > >> 2017-07-20 21:46 GMT+02:00 Paras Chadha : >> >>> +case AV_PIX_FMT_RGB24: >>> +case

Re: [FFmpeg-devel] [PATCHv2 1/2] avdevice/decklink_dec: add support for decoding teletext from 10bit ancillary data

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 18:48, Marton Balint wrote: > > On Wed, 19 Jul 2017, John Warburton wrote: > >> On Tue, Jul 18, 2017 at 6:10 PM, Marton Balint wrote: >>> On Sat, 8 Jul 2017, Marton Balint wrote: >>> This also add supports for 4K DeckLink cards because

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 12:03, Nicolas George wrote: > What I do insist on, is this: > > Look at the find_size() function in this patch: > https://ffmpeg.org/pipermail/ffmpeg-devel/2017-July/213076.html > > Then look at the fits_read_header() in this patch: >

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 12:03, Nicolas George wrote: > Le decadi 30 messidor, an CCXXV, Rostislav Pehlivanov a écrit : > >> I think the image2 demuxer shouldn't handle this type of junk/useless data >> filtering and would rather see a separate demuxer like the current patch >> which

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-17 Thread Reimar Döffinger
On 18.07.2017, at 00:59, James Almer wrote: > On 7/17/2017 7:49 PM, Moritz Barsnick wrote: >> On Mon, Jul 10, 2017 at 13:53:02 +0300, Boris Pek wrote: >>> Latest news about this topic: >>> https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/FKXe-76GO8Y >> >> Ah,

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Reimar Döffinger
On 16.07.2017, at 15:08, Nicolas George wrote: > L'octidi 28 messidor, an CCXXV, Derek Buitenhuis a écrit : >> Why is there no decoder? > > Because the decoder is in a separate patch, and the demuxer in yet > another. And none of them can proceed until Paras Chadha starts

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Reimar Döffinger
On 16.07.2017, at 14:31, Paras Chadha wrote: > +static int write_keyword_value(uint8_t **bytestream, const char * keyword, > int value) > +{ > +int len, ret; > +uint8_t * header = * bytestream; > +len = strlen(keyword); > + > +memcpy(header, keyword,

  1   2   3   4   5   6   7   >