Re: [FFmpeg-devel] is there a trick to building ffmpeg with sdl2 2.0.14 ? (2.0.12 works)

2021-01-31 Thread Reino Wijnsma
On 2021-01-31T16:45:08+0100, Timo Rothenpieler wrote: > Not sure what to make of that attachment to your mail. Is that supposed to be > a log? hydra, please have a look at http://support.microsoft.com/kb/278061/en. -- Reino ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-05-31 Thread Reino Wijnsma
On 2020-05-31T22:37:20+0200, Paul B Mahol wrote: > On 5/31/20, Nicolas George wrote: >> Paul B Mahol (12020-05-31): >>> Signed-off-by: Paul B Mahol >>> --- >>> libavfilter/Makefile | 1 + >>> libavfilter/af_afwtdn.c | 619 +++ >>>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/midivid: Check dimensions to be the multiple assumed by the implementation

2020-02-12 Thread Reino Wijnsma
On 2020-02-12T23:17:09+0100, Paul B Mahol wrote: > This is incorrect. > > On 2/12/20, Michael Niedermayer wrote: >> Fixes: out of array access >> Fixes: >> 20626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVDV_fuzzer-6279905350516736 >> >> Found-by: continuous fuzzing process >>

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add thistogram video filter

2019-12-27 Thread Reino Wijnsma
On 2019-12-27T16:48:22+0100, Paul B Mahol wrote: > On 12/27/19, James Almer wrote: >> On 12/27/2019 12:29 PM, Paul B Mahol wrote: >>> On 12/27/19, Nicolas George wrote: Paul B Mahol (12019-12-27): > I disagree. > > And yet in the meantime somebody found a bug. This is a big

Re: [FFmpeg-devel] [PATCH] avfilter: add anlms filter

2019-10-05 Thread Reino Wijnsma
On 2019-10-04T10:04:46+0200, Paul B Mahol wrote: > +Apply Normalized Least-Mean-Squares algorithm to first audio stream using > second audio stream. Apply Normalized Least-Mean-Squares algorithm to [the] first audio stream using [the] second audio stream. > +This is adaptive filter used to

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-28 Thread Reino Wijnsma
On 2019-09-27T19:37:40+0200, William Martin wrote: > On Wed, Sep 25, 2019 at 2:36 PM Reino Wijnsma wrote: >> On 2019-09-25T20:57:08+0200, William Martin >> wrote: >>> +av_log(s, AV_LOG_ERROR, "App field don't match up: %s <-> %s. " >

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-25 Thread Reino Wijnsma
On 2019-09-25T20:57:08+0200, William Martin wrote: > +av_log(s, AV_LOG_ERROR, "App field don't match up: %s <-> %s. " Although I'm not a native English speaker, since "field" isn't plural, I'm pretty confident "don't" should be "doesn't". -- Reino

Re: [FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2019-08-23 Thread Reino Wijnsma
Hello ffmpeg-devel, I've read through https://patchwork.ffmpeg.org/patch/4587/, https://ffmpeg.org/pipermail/ffmpeg-devel/2017-August/214360.html and all its replies. The discussion suddenly just stops, the path dropped and I can't seem to find the reason why. Can anyone tell me why this patch

Re: [FFmpeg-devel] [PATCH] ffplay: properly detect all window size changes

2019-08-14 Thread Reino Wijnsma
On 2019-08-13T23:20:08+0200, Marton Balint wrote: > SDL_WINDOWEVENT_SIZE_CHANGED should be used instead of SDL_WINDOWEVENT_RESIZED > because SDL_WINDOWEVENT_RESIZED is only emitted if the resize happened due to > an external event. > > Fixes ticket #8072. > > Additional references: >

[FFmpeg-devel] GCC 8.2.0 compiler-warnings on ffmpeg-N-92765-g2744d6b

2018-12-22 Thread Reino Wijnsma
Hello ffmpeg-devel, I can't code in C, so to still contribute to this project I'd like to report the warnings I got while compiling ffmpeg-N-92765-g2744d6b on Windows using Cygwin, MinGW 6.0.0 and GCC 8.2.0. configure options: > Configuring ffmpeg_git as ./configure --arch=x86

Re: [FFmpeg-devel] [PATCH 3/3] configure: speedup x2-x8

2018-08-26 Thread Reino Wijnsma
On 26-8-2018 22:27, Dave Yeo wrote: > On 08/25/18 11:11 AM, avih wrote: >> After the previous speedups, configure spent 20-60% of its runtime >> at check_deps(). It's particularly slow with bash. After some local >> optimizations - mainly avoid pushvar/popvar and abort early in one >> notable

Re: [FFmpeg-devel] [PATCH v3] doc/filters: Add double-pass example for loudnorm

2018-08-23 Thread Reino Wijnsma
On 22-8-2018 12:52, Gyan Doshi wrote: > On 22-08-2018 04:01 PM, Marvin Scholz wrote: >> [Parsed_aresample_1 @ 0x7fb7c540d500] Cannot select channel layout for the >> link between filters Parsed_aresample_1 and format_out_0_1. > For this file, > > aresample=48000:ocl=stereo > > > Gyan Related

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-05-27 Thread Reino Wijnsma
On 27-5-2018 21:23, James Almer wrote: > Pushed the check_lib() change only, after confirming it's needed for static > builds of mbedtls. Thank you, James. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-05-26 Thread Reino Wijnsma
On 23-5-2018 2:11, Reino Wijnsma <rwijn...@xs4all.nl> wrote: > On 22-4-2018 14:47, Thomas Volkert <si...@gmx.net> wrote: >> +enabled mbedtls && { check_pkg_config mbedtls mbedtls >> mbedtls/x509_crt.h mbedtls_x509_crt_init || >> +

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-05-22 Thread Reino Wijnsma
On 22-4-2018 14:47, Thomas Volkert wrote: > +enabled mbedtls && { check_pkg_config mbedtls mbedtls > mbedtls/x509_crt.h mbedtls_x509_crt_init || > + check_pkg_config mbedtls mbedtls > mbedtls/ssl.h mbedtls_ssl_init || > +

Re: [FFmpeg-devel] [PATCH 1/1] configure: add pkg-config check for libmysofa

2018-05-13 Thread Reino Wijnsma
On 13-5-2018 18:11, Paul B Mahol wrote: > Could you wait for new libmysofa release? I'm not a FFmpeg coder/developer, so if you believe that's the best thing to do, then that's fine by me. The current non-pkg-config-file method works fine afterall. -- Reino

Re: [FFmpeg-devel] [PATCH 1/1] configure: add pkg-config check for libmysofa

2018-05-13 Thread Reino Wijnsma
On 7-5-2018 17:59, Reino Wijnsma <rwijn...@xs4all.nl> wrote: > From 8082ba451d089790f0719c4ec6788796b2079e9d Mon Sep 17 00:00:00 2001 > From: Reino17 <rwijn...@xs4all.nl> > Date: Mon, 7 May 2018 17:28:10 +0200 > Subject: [PATCH] configure: add pkg-config check for libmyso

[FFmpeg-devel] [PATCH 1/1] configure: add pkg-config check for libmysofa

2018-05-07 Thread Reino Wijnsma
From 8082ba451d089790f0719c4ec6788796b2079e9d Mon Sep 17 00:00:00 2001 From: Reino17 Date: Mon, 7 May 2018 17:28:10 +0200 Subject: [PATCH] configure: add pkg-config check for libmysofa This does require libmysofa with today's latest commit

Re: [FFmpeg-devel] [PATCH]lavf/rtmpcrypt: Add a cast to silence a warning

2018-04-26 Thread Reino Wijnsma
On 22-4-2018 0:52, Reino Wijnsma <rwijn...@xs4all.nl> wrote: > On 16-4-2018 0:19, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >> rtmpe_write() exploits knowledge about av_rc4_crypt() internals and >> passes the same >> pointer as src and dst. I assume th

Re: [FFmpeg-devel] [PATCH]configure: Assume MSVCRT when compiling with MingW

2018-04-21 Thread Reino Wijnsma
On 21-4-2018 22:43, Carl Eugen Hoyos wrote: > Attached patch is supposed to fix an old issue with debug messages and > a currently reported compilation warning that I believe also indicates > a possible abort() on Windows: > libavformat/hlsenc.c:1676:63: warning: unknown

Re: [FFmpeg-devel] [PATCH]lavf/rtmpcrypt: Add a cast to silence a warning

2018-04-21 Thread Reino Wijnsma
On 16-4-2018 0:19, Carl Eugen Hoyos wrote: > rtmpe_write() exploits knowledge about av_rc4_crypt() internals and > passes the same > pointer as src and dst. I assume this is intentional for performance > reasons, the only > way to silence the resulting warning is a cast

Re: [FFmpeg-devel] lavf/os_support: Only compile inet_aton() if getaddrinfo() is needed

2018-04-21 Thread Reino Wijnsma
On 16-4-2018 1:33, Carl Eugen Hoyos wrote: > Attached patch is supposed to silence a user-reported warning when > inet_aton() is missing but getaddrinfo() is supported. > Untested. > > Please review, Carl Eugen $ make libavformat/os_support.o CC libavformat/os_support.o

Re: [FFmpeg-devel] [RFC] [Vote] Drop Windows XP support

2017-12-14 Thread Reino Wijnsma
On 14-12-2017 20:51, Lou Logan wrote: > Also, I believe Zeranoe stopped providing XP builds in 2016 so it will > be no issue downstream. I still am . But hey, it's your call in the end. -- Reino

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

2017-10-18 Thread Reino Wijnsma
On 19-10-2017 0:22, James Almer wrote: > It think the following should be enough: >> enabled libopenjpeg && { use_pkg_config libopenjpeg "libopenjp2 >= >> 2.1.0" openjpeg.h opj_version || >>{ require_pkg_config libopenjpeg "libopenjp2 >>

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

2017-10-18 Thread Reino Wijnsma
On 18-10-2017 21:46, Michael Bradshaw wrote: > From fb8334d0cecc889ebce3af968c56a3afbd2f6047 Mon Sep 17 00:00:00 2001 > From: Michael Bradshaw > Date: Wed, 18 Oct 2017 11:34:06 -0700 > Subject: [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

Re: [FFmpeg-devel] [PATCH] avformat/libopenmpt: Query duration and metadata after selecting subsong

2017-09-17 Thread Reino Wijnsma
On 17-9-2017 15:35, Jörn Heusipp wrote: > Duration depends on the selected subsong and thus must be queried after > selecting the subsong. There is no compelling reason to query other > metadata earlier either. > > Signed-off-by: Jörn Heusipp

[FFmpeg-devel] Demuxer libopenmpt doesn't show subsong duration

2017-09-10 Thread Reino Wijnsma
Hello, Today I've compiled FFmpeg with libopenmpt (N-87255-gcbe181c) for the first time and I must say I'm very pleased with it. Especially with the subsong option. ffmpeg -i "K_vision.umx" Input #0, libopenmpt, from 'K_vision.umx': Metadata: title : Nightvision - Sandman/KFM

Re: [FFmpeg-devel] configure/libopenjpegdec.c/libopenjpegenc.c: Add support for LibOpenJPEG v2.2/git

2017-06-23 Thread Reino Wijnsma
On 22-6-2017 2:00, Michael Bradshaw wrote: > Almost done! The OPJ_STATIC change that was introduced in OpenJPEG 2.1+ > means FFmepg's configure script has to do some extra work. You'll see that > there are two check_lib calls for openjpeg-2.1. You'll need to

Re: [FFmpeg-devel] configure/libopenjpegdec.c/libopenjpegenc.c: Add support for LibOpenJPEG v2.2/git

2017-06-21 Thread Reino Wijnsma
On 20-6-2017 19:44, Michael Bradshaw wrote: > Please merge these two conditions, since both #if conditions are executing > the same code. That is: > > #if HAVE_OPENJPEG_2_2_OPENJPEG_H || HAVE_OPENJPEG_2_1_OPENJPEG_H > opj_stream_set_user_data(stream, , NULL);

Re: [FFmpeg-devel] configure/libopenjpegdec.c/libopenjpegenc.c: Add support for LibOpenJPEG v2.2/git

2017-06-13 Thread Reino Wijnsma
On 13-6-2017 05:58, Michael Bradshaw wrote: > Are you sure you built ffmpeg using OpenJPEG v2.2? Because your patch is > missing the openjpeg_2_2_openjpeg_h entry in HEADERS_LIST in configure, so > you shouldn't be able to successfully build with OpenJPEG v2.2. Whoops! In my

Re: [FFmpeg-devel] Add libtwolame cppflags in 'configure' to prevent the use of '--extra-cflags'

2017-06-12 Thread Reino Wijnsma
I just tried to build a shared LibTwoLAME, but it gave me errors. Building a shared LibModplug proved more successful. FFmpeg's 'configure' didn't have any problems with it and finished without errors. LibOpenJPEG was the reason

[FFmpeg-devel] configure: Add libcaca cppflags in 'configure' to prevent the use of '--extra-cflags'

2017-06-12 Thread Reino Wijnsma
This patch adds libcaca cppflags in 'configure' to prevent the use of '--extra-cflags'. This is all that's needed to successfully cross-compile FFmpeg with Libcaca. From ba27f7d90c5c3883bd302caf977837d970d46387 Mon Sep 17 00:00:00 2001 From: Reino17 Date: Tue, 13 Jun 2017

[FFmpeg-devel] configure: Add libmodplug cppflags in 'configure' to prevent the use of '--extra-cflags'

2017-06-12 Thread Reino Wijnsma
This patch adds libmodplug cppflags in 'configure' to prevent the use of '--extra-cflags'. This is all that's needed to successfully cross-compile FFmpeg with LibModplug. From 7fe7113ccc79f46610b2a89f8ab17e94c348e568 Mon Sep 17 00:00:00 2001 From: Reino17 Date: Tue, 13 Jun

[FFmpeg-devel] Add libtwolame cppflags in 'configure' to prevent the use of '--extra-cflags'

2017-06-12 Thread Reino Wijnsma
This patch adds libtwolame cppflags in 'configure' to prevent the use of '--extra-cflags'. This is all that's needed to successfully cross-compile FFmpeg with LibTwoLAME. From 9aacc77f0dcb67d375fd3bdf4d0a1dc8d55b1cf7 Mon Sep 17 00:00:00 2001 From: Reino17 Date: Tue, 13 Jun

[FFmpeg-devel] configure/libopenjpegdec.c/libopenjpegenc.c: Add support for LibOpenJPEG v2.2/git

2017-06-12 Thread Reino Wijnsma
This patch adds support for LibOpenJPEG v2.2/git. At the moment v2.1 is the highest version FFmpeg supports. I've successfully cross-compiled FFmpeg this way. From df61d7a295bec74c85d37042051e9dc1ef5cdbce Mon Sep 17 00:00:00 2001 From: Reino17 Date: Tue, 13 Jun 2017 01:01:07

[FFmpeg-devel] configure - "Check 'sdl2-config' first, then 'sdl2.pc'."

2017-05-11 Thread Reino Wijnsma
See https://trac.ffmpeg.org/ticket/6377. From 3f9c065f96815ffefaa39cda7bacd8132bfdf66c Mon Sep 17 00:00:00 2001 From: Reino Wijnsma <rwijn...@xs4all.nl> Date: Wed, 10 May 2017 00:50:30 +0200 Subject: [PATCH] Check 'sdl2-config' first, then 'sdl2.pc'. --- configure | 8 1 file chan

Re: [FFmpeg-devel] configure: Prioritize 'sdl2-config'-check

2017-05-11 Thread Reino Wijnsma
On 11-5-2017 13:56, Stephen Hutchinson <qyo...@gmail.com> wrote: > On 5/11/2017 7:43 AM, Reino Wijnsma wrote: >> https://trac.ffmpeg.org/ticket/6377#comment:2: >>> Inadequate for building FFPlay, yes. But perhaps not for other >>> software. >>> Are there a

Re: [FFmpeg-devel] configure: Prioritize 'sdl2-config'-check

2017-05-11 Thread Reino Wijnsma
https://trac.ffmpeg.org/ticket/6377#comment:2: > Inadequate for building FFPlay, yes. But perhaps not for other software. > Are there any downsides to my proposition? I could of course contact the sdl2 developers, but when 'sdl2-config' already has the librarylist setup right to build FFPlay, why

[FFmpeg-devel] configure: Prioritize 'sdl2-config'-check

2017-05-11 Thread Reino Wijnsma
See https://trac.ffmpeg.org/ticket/6377. By prioritizing the 'sdl2-config'-check the librarylist that's needed to build FFPlay is setup automatically and one doesn't have to patch 'sdl2.pc' anymore. From 3f9c065f96815ffefaa39cda7bacd8132bfdf66c Mon Sep 17 00:00:00 2001 From: Reino Wijnsma <rw