Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-26 Thread Richard Ling
Thanks Paul. Thanks also to all reviewers for your comments! It's very helpful to have extra sets of eyes to find my bugs. Moritz is right, there is an unused #define, I will try to find time to patch. Or maybe Paul can remove it Regards R. ___

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-23 Thread Richard Ling
On Nov 21, 2017 10:32 PM, "Moritz Barsnick" wrote: > > Nice. I personally appreciate your code comments, as I'm no big filter > author (yet). I've never made any contribution to ffmpeg before, so I'm almost certainly a bad example to follow :-P But I do like code to be well

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-21 Thread Richard Ling
Updated patch. The integer overflow is avoided by limiting smoothing parameter to MAX_INT/8. It is later multiplied by 6. Regards R. 0001-avfilter-add-normalize-filter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-20 Thread Richard Ling
Thanks Moritz. I'll update and repost a new patch. I also noticed another error of mine: I hadn't fully updated the examples in the documentation, after changes to the parameter. Regards R. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-20 Thread Richard Ling
Patch attached. R. 0001-avfilter-add-normalize-filter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-19 Thread Richard Ling
OK, trying again. I've worked out how to send to myself without corruption (I think). From 590b3bc8e2675c75c2ff7e75f7fc1fbb1e1a8f71 Mon Sep 17 00:00:00 2001 From: Richard Ling <dive...@rling.com> Date: Thu, 16 Nov 2017 23:00:01 +1100 Subject: [PATCH] avfilter: add normalize filter --

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-16 Thread Richard Ling
On 24 October 2017 at 07:26, Paul B Mahol <one...@gmail.com> wrote: > On 9/14/17, Richard Ling <dive...@rling.com> wrote: >> Hi, >> >> This patch adds a filter to normalize (contrast stretch) RGB video. >> Comments welcome. >> >> R. >

[FFmpeg-devel] How to tell CFR/VFR video apart, and determine frame rate

2017-09-29 Thread Richard Ling
How can I determine whether a filter input is VFR or CFR? static int is_vfr(AVFilterLink *inlink) { return ???; } If I determine the input is CFR, how do I get the frame rate in FPS? Is it always the reciprocal of timebase, if not what is the correct implementation? static float

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-09-21 Thread Richard Ling
> > > Thanks for the patch. Unfortunately, your mail software mangled it with > line breaks, it cannot be applied as is. Still, see a few comments > below. > > I should have posted to myself first to make sure it worked OK. I will do that before posting another patch to the list. > +The amount of

[FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-09-13 Thread Richard Ling
Hi, This patch adds a filter to normalize (contrast stretch) RGB video. Comments welcome. R. From f08f132ecd79718d0ce6fb07f99c84ab5dd52ee4 Mon Sep 17 00:00:00 2001 From: Richard Ling <dive...@rling.com> Date: Thu, 14 Sep 2017 13:18:50 +1000 Subject: [PATCH] avfilter: add normalize

Re: [FFmpeg-devel] Confusion over temporal filters.

2017-09-10 Thread Richard Ling
> On Sun, 10 Sep 2017, Paul B Mahol wrote: > > On 9/10/17, Richard Ling <dive...@rling.com> wrote: >> >>> I'm thinking of adding a temporal filter (one that relies on context from >>> previous frames), and I've realised I'm a bit confused about how they >>

[FFmpeg-devel] Confusion over temporal filters.

2017-09-10 Thread Richard Ling
I'm thinking of adding a temporal filter (one that relies on context from previous frames), and I've realised I'm a bit confused about how they should work. Say I open a file with ffplay and let it play up to frame 100. Then I open the same file with another instance of ffplay and seek directly