Re: [FFmpeg-devel] [PATCH 1/1] Patch for adding Documentation of ff_http_match_no_proxy
On Tue, Mar 3, 2020 at 3:47 AM Michael Niedermayer wrote:
> On Mon, Mar 02, 2020 at 08:32:10PM +0530, Sourabh Sharma wrote:
> > Patch for adding Documentation of ff_http_match_no_proxy
> > Function ff_http_match_no_proxy check for host of proxy address matches
> with
> > the hostname or not.
> >
> > ---
> > libavformat/network.h | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/libavformat/network.h b/libavformat/network.h
> > index 71347e815b..7c93375ae5 100644
> > --- a/libavformat/network.h
> > +++ b/libavformat/network.h
> > @@ -303,6 +303,13 @@ int ff_listen_connect(int fd, const struct sockaddr
> *addr,
> >socklen_t addrlen, int timeout,
> >URLContext *h, int will_try_next);
> >
> > +/**
> > + * It Checks for a host of proxy address matches with the hostname or
> not.
> > + *
> > + * @param no_proxy Server address of proxy server e.g.
> example.domain.com
> > + * @param hostname Server address of hostname e.g. domain.com
> > + * @return 0 if don't match, 1 for exactly match
> > +*/
> > int ff_http_match_no_proxy(const char *no_proxy, const char *hostname);
>
> maybe looking at how this function is used makes it clearer what it does
>
> for example
> libavformat/http.c:use_proxy =
> !ff_http_match_no_proxy(getenv("no_proxy"), hostname) &&
> libavformat/http.c- proxy_path && av_strstart(proxy_path,
> "http://;, NULL);
>
>
> but basically
> no_proxy, is a list of addresses for which not to use the proxy server,
> these may be local addresses
>
Thanks
I will correct it soon.
>
>
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> When you are offended at any man's fault, turn to yourself and study your
> own failings. Then you will forget your anger. -- Epictetus
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 1/1] Patch for adding Documentation of ff_http_match_no_proxy
Patch for adding Documentation of ff_http_match_no_proxy Function ff_http_match_no_proxy check for host of proxy address matches with the hostname or not. --- libavformat/network.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/network.h b/libavformat/network.h index 71347e815b..7c93375ae5 100644 --- a/libavformat/network.h +++ b/libavformat/network.h @@ -303,6 +303,13 @@ int ff_listen_connect(int fd, const struct sockaddr *addr, socklen_t addrlen, int timeout, URLContext *h, int will_try_next); +/** + * It Checks for a host of proxy address matches with the hostname or not. + * + * @param no_proxy Server address of proxy server e.g. example.domain.com + * @param hostname Server address of hostname e.g. domain.com + * @return 0 if don't match, 1 for exactly match +*/ int ff_http_match_no_proxy(const char *no_proxy, const char *hostname); int ff_socket(int domain, int type, int protocol); -- 2.11.0 On Sun, Mar 1, 2020 at 2:49 AM Michael Niedermayer wrote: > On Sat, Feb 29, 2020 at 05:07:30PM +0530, Sourabh Sharma wrote: > > Patch for adding Documentation of ff_http_match_no_proxy > > > > Function ff_http_match_no_proxy check for host of proxy address > > matches with hostname or not. > > --- > > libavformat/network.h | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/network.h b/libavformat/network.h > > index 71347e815b..cd533a7cbc 100644 > > --- a/libavformat/network.h > > +++ b/libavformat/network.h > > @@ -302,7 +302,13 @@ int ff_accept(int fd, int timeout, URLContext *h); > > int ff_listen_connect(int fd, const struct sockaddr *addr, > >socklen_t addrlen, int timeout, > >URLContext *h, int will_try_next); > > - > > > +/** > > + * It Check for host of proxy address matches with hostname or not. > > This has some english grammer issues. > Also look at how other similar function doxy is worded > > > > + * > > + * @param no_proxy URL of proxy address > > + * @param hostname URL of hostname > > I dont think the function would be understood from just this > > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Does the universe only have a finite lifespan? No, its going to go on > forever, its just that you wont like living in it. -- Hiranya Peiri > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH 1/1] Patch for adding Documentation of ff_http_match_no_proxy
Patch for adding Documentation of ff_http_match_no_proxy Function ff_http_match_no_proxy check for host of proxy address matches with hostname or not. --- libavformat/network.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/network.h b/libavformat/network.h index 71347e815b..cd533a7cbc 100644 --- a/libavformat/network.h +++ b/libavformat/network.h @@ -302,7 +302,13 @@ int ff_accept(int fd, int timeout, URLContext *h); int ff_listen_connect(int fd, const struct sockaddr *addr, socklen_t addrlen, int timeout, URLContext *h, int will_try_next); - +/** + * It Check for host of proxy address matches with hostname or not. + * + * @param no_proxy URL of proxy address + * @param hostname URL of hostname + * @return 0 if don't match, 1 for exactly match +*/ int ff_http_match_no_proxy(const char *no_proxy, const char *hostname); int ff_socket(int domain, int type, int protocol); -- 2.11.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] Interested in GSOC 2020
Hi, I am a 3rd Year Computer Science Student Currently Studying at Medi-Caps University, Indore. I want to make a contribution to FFmpeg Project in GSOC 2020. For Gsoc 2020 I interested in Fuzzing FATE tests in libavformat, libavutil and libswscale. I have one minor documentation bug fixed. And I also worked with git in the past. Can I ask my query here or I can only ask in IRC. Regards Sourabh Sharma ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] doc/filters: correct range for contrast in eq filter
Thank you
On Fri, 6 Sep 2019, 2:11 pm Gyan, wrote:
>
>
> On 06-09-2019 01:23 PM, Gyan wrote:
> >
> >
> > On 06-09-2019 08:28 AM, Sourabh Sharma wrote:
> >> ---
> >> doc/filters.texi | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/doc/filters.texi b/doc/filters.texi
> >> index 6c81e1da40..70ea16954f 100644
> >> --- a/doc/filters.texi
> >> +++ b/doc/filters.texi
> >> @@ -9538,7 +9538,7 @@ The filter accepts the following options:
> >> @table @option
> >> @item contrast
> >> Set the contrast expression. The value must be a float value in range
> >> -@code{-2.0} to @code{2.0}. The default value is "1".
> >> +@code{-1000.0} to @code{1000.0}. The default value is "1".
> >>
> >> @item brightness
> >> Set the brightness expression. The value must be a float value in
> >> --
> >> 2.11.0
> >
> > Should reference the ticket as well. Will make that change and push.
>
> Pushed as 3424600e0b19417ebad6da8b28e57e11290abbe7
>
> Gyan
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] doc/filters: correct range for contrast in eq filter
---
doc/filters.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 6c81e1da40..70ea16954f 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -9538,7 +9538,7 @@ The filter accepts the following options:
@table @option
@item contrast
Set the contrast expression. The value must be a float value in range
-@code{-2.0} to @code{2.0}. The default value is "1".
+@code{-1000.0} to @code{1000.0}. The default value is "1".
@item brightness
Set the brightness expression. The value must be a float value in
--
2.11.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] #8111 Bug Solved
---
doc/filters.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 6c81e1da40..70ea16954f 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -9538,7 +9538,7 @@ The filter accepts the following options:
@table @option
@item contrast
Set the contrast expression. The value must be a float value in range
-@code{-2.0} to @code{2.0}. The default value is "1".
+@code{-1000.0} to @code{1000.0}. The default value is "1".
@item brightness
Set the brightness expression. The value must be a float value in
--
2.11.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
