Re: [FFmpeg-devel] [PATCH 137/217] avcodec/cpia: Mark decoder as init-threadsafe

2021-02-20 Thread Stephan Hilb
> libavcodec/cpia.c | 1 + > 1 file changed, 1 insertion(+) lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes

2019-06-09 Thread Stephan Hilb
> Repeated messages only get supressed if there is no interspaced > message if 2 things generate a message per frame, neither will be > supressed So should I leave it at DEBUG level or implement a custom log_once? The "cur_dts invalid" debug message is currently being printed at least as often.

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes

2019-06-07 Thread Stephan Hilb
>> -!ost->copy_initial_nonkeyframes) >> +!ost->copy_initial_nonkeyframes) { >> +av_log(NULL, AV_LOG_DEBUG, "skipping initial >> non-keyframe\n"); return; > > Incorrect indentation. It's actually the same indentation as in other places in the same file, what would be the

Re: [FFmpeg-devel] [PATCH 1/2] avformat/nut: add cpia codec

2019-06-07 Thread Stephan Hilb
> please send a patch to docs/nut4cc.txt first. > (https://git.ffmpeg.org/nut.git or svn://svn.mplayerhq.hu/nut) sent the patch (mail is awaiting moderation) pgpHCCCp43tLk.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] CPIA

2019-06-07 Thread Stephan Hilb
>> I have the file ready, how can I provide it? > > how big is it ? 1.2M, I did 10 frames to get some non-keyframes too. > can it be used for a fate test ? sure > but generally upload it somewhere and provide a link the nut file is now available from ipfs:

Re: [FFmpeg-devel] CPIA

2019-06-06 Thread Stephan Hilb
Michael Niedermayer wrote on 27.05.2019 at 00:22: > [...] maybe just add teh codec id to nut and try to store it in that > with stream copy if it works it should be possible to playback that > nit file I have the file ready, how can I provide it? pgp12neptaV1q.pgp Description: OpenPGP digital

[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes

2019-06-06 Thread Stephan Hilb
If `AV_PKT_FLAG_KEY` stays unset on `pkt->flags`, the output stream stays empty with little information about what is going on. This change makes it easier to debug the situation for the user who could then choose to use the `-copyinkf` option. --- fftools/ffmpeg.c | 4 +++- 1 file changed, 3

[FFmpeg-devel] [PATCH 1/2] avformat/nut: add cpia codec

2019-06-06 Thread Stephan Hilb
--- libavformat/nut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/nut.c b/libavformat/nut.c index 4fbbcb1d26..937f452878 100644 --- a/libavformat/nut.c +++ b/libavformat/nut.c @@ -43,6 +43,7 @@ const AVCodecTag ff_nut_video_tags[] = { { AV_CODEC_ID_XFACE,

Re: [FFmpeg-devel] CPIA

2019-05-27 Thread Stephan Hilb
Michael Niedermayer wrote on 27.05.2019 at 00:22: > ideally some seperation between frames would be kept > for example each frame in its own file might be the easiest > or maybe just add teh codec id to nut and try to store it in that > with stream copy Added the codec id but getting invalid

Re: [FFmpeg-devel] CPIA

2019-05-26 Thread Stephan Hilb
> Can someone who has the right hardware for CPIA, dump some frames into > a file so people and myself can test this without special hw. Would dd'ing /dev/video0 be enough and how can I provide the file? Ftp `upload.ffmpeg.org` seems down. pgpkF1LLjC_Z2.pgp Description: OpenPGP digital

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size

2019-03-25 Thread Stephan Hilb
25 Aug 2018. It seems to have been forgotten, attached again. From 0af8515acca4d598570d03450656adc0ed7ac2d7 Mon Sep 17 00:00:00 2001 From: Stephan Hilb Date: Sun, 10 Jun 2018 21:07:52 +0200 Subject: [PATCH] lavd/v4l2: skip buffers not matching frame_size By adopting the same behaviour as if there w

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: skip buffers not matching frame_size

2018-09-02 Thread Stephan Hilb
> libavdevice/v4l2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Any comments on this? pgp6DLors_XHR.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] lavd/v4l2: skip buffers not matching frame_size

2018-08-25 Thread Stephan Hilb
By adopting the same behaviour as if there was corrupted data in the buffer (see the check for V4L2_BUF_FLAG_ERROR) the resulting rawvideo now at least contains valid data (the previous frame being duplicated). Fixes video capturing for some stk1160 devices. --- libavdevice/v4l2.c | 5 ++--- 1