Re: [FFmpeg-devel] [PATCH] Add doc on ffmpeg-devel, update on -cvslog list (v3)

2017-12-05 Thread Timothy Gu
Hi, On Mon, Dec 4, 2017 at 4:43 AM Carl Eugen Hoyos wrote: > The patch is not ok, Carl Eugen It is clear that you have no respect for community consensus. 9 for removal of mandatory status (10 counting myself): TR:

Re: [FFmpeg-devel] [PATCH] Refactor Developer Docs, update dev list section (v2)

2017-12-02 Thread Timothy Gu
Hi all, On Sun, Nov 26, 2017 at 12:32 AM Jim DeLaHunt wrote: > 1. In doc/developer.texi, eliminate the single chapter, > and promote each section underneath to chapter, and > each subsection to section. Thus content and relative > structure remains the same, but the

Re: [FFmpeg-devel] [PATCH] lavc/utils: simplify lockmgr

2017-11-29 Thread Timothy Gu
On Sun, Nov 26, 2017 at 8:44 PM Rostislav Pehlivanov wrote: > @@ -103,8 +104,7 @@ static int default_lockmgr_cb(void **arg, enum > AVLockOp op) > case AV_LOCK_DESTROY: > if (*mutex) > pthread_mutex_destroy(*mutex); > -av_free(*mutex); > -

[FFmpeg-devel] [PATCH] qsvdec: Fix memory leak

2016-12-05 Thread Timothy Gu
Found by Coverity in FFmpeg. --- libavcodec/qsvdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index ea4abfa..258042d 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -305,8 +305,10 @@ static int

[FFmpeg-devel] [PATCH] qsvdec: Fix memory leak

2016-12-05 Thread Timothy Gu
Fixes CID1396851. --- libavcodec/qsvdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index ea4abfa..258042d 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -305,8 +305,10 @@ static int qsv_decode(AVCodecContext

[FFmpeg-devel] [PATCH] omx: Fix OOM check

2016-12-05 Thread Timothy Gu
Also use av_mallocz_array(). Fixes CID1396839. --- libavcodec/omx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/omx.c b/libavcodec/omx.c index c1b6fb9..b5093f4 100644 --- a/libavcodec/omx.c +++ b/libavcodec/omx.c @@ -352,12 +352,12 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH] travis: setup for automated coverity builds

2016-12-02 Thread Timothy Gu
On Fri, Dec 2, 2016 at 3:22 AM Timo Rothenpieler <t...@rothenpieler.org> wrote: > On 12/2/2016 4:14 AM, Timothy Gu wrote: > > On Thu, Dec 1, 2016 at 1:23 PM Timo Rothenpieler <t...@rothenpieler.org> > > wrote: > > > >> Travis can only run scheduled buil

Re: [FFmpeg-devel] [PATCH] travis: setup for automated coverity builds

2016-12-01 Thread Timothy Gu
On Thu, Dec 1, 2016 at 1:23 PM Timo Rothenpieler wrote: > Travis can only run scheduled builds daily, weekly or monthly. So we run them daily, and use a bit of logic in the .travis.yml to > cancel out early on 3 days per week. > Nice! Didn't know Travis CI could do this.

[FFmpeg-devel] [PATCH] travis.yml: Whitelist "coverity" branch in preparation for Coverity integration

2016-11-27 Thread Timothy Gu
--- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) This patch will needed to be applied to all Git branches because of a Travis CI restriction: https://docs.travis-ci.com/user/customizing-the-build#Building-Specific-Branches diff --git a/.travis.yml b/.travis.yml index e541ee1..a50c46d

Re: [FFmpeg-devel] coverity testing of FFmpeg

2016-11-27 Thread Timothy Gu
On Sun, Nov 27, 2016 at 1:52 PM Michael Niedermayer wrote: > I dont want to give a automated travis_ci system any write or admin > access, some of what i read hinted in that direction, some of what > i read hinted that this was not needed though > giving a automated

Re: [FFmpeg-devel] coverity testing of FFmpeg

2016-11-27 Thread Timothy Gu
On Sun, Nov 27, 2016 at 1:13 PM Philip Langdale wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Sun, 27 Nov 2016 21:26:13 +0100 > Michael Niedermayer wrote: > > > On Sun, Nov 27, 2016 at 11:00:21AM -0800, Philip Langdale wrote: > > >

Re: [FFmpeg-devel] [PATCH 1/2] pixdesc: Order function prototypes semantically

2016-10-05 Thread Timothy Gu
On Mon, Aug 22, 2016 at 5:53 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Aug 21, 2016 at 05:09:00PM -0700, Timothy Gu wrote: > > --- > > libavutil/pixdesc.h | 194 > ++-- > > 1 file changed,

Re: [FFmpeg-devel] [PATCH 2/2] pixfmt: Use enum assignment for aliases

2016-10-05 Thread Timothy Gu
On Tue, Aug 23, 2016 at 12:28 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Aug 21, 2016 at 05:09:01PM -0700, Timothy Gu wrote: > > This way, Doxygen is happier as aliases are now grouped together, and > > it never handled #define's in an enum we

Re: [FFmpeg-devel] [PATCH v2] doc/t2h: use container

2016-10-02 Thread Timothy Gu
On Sun, Oct 02, 2016 at 02:53:22PM +0100, Josh de Kock wrote: > Full width text is really difficult to read, this makes it more > more legible on larger (widescreen) screens. It also means we aren't > inventing our own container instead of using the bootstrap one. > > Signed-off-by: Josh de Kock

Re: [FFmpeg-devel] [PATCH] doc/t2h: add max-width to css.

2016-10-01 Thread Timothy Gu
On Fri, Sep 30, 2016 at 6:28 PM Josh de Kock wrote: > Full width text is really difficult to read, this just makes it > slightly more legible on larger (widescreen) screens. > > Signed-off-by: Josh de Kock > --- > See

Re: [FFmpeg-devel] [PATCH 2/2] pixfmt: Use enum assignment for aliases

2016-08-21 Thread Timothy Gu
On Sun, Aug 21, 2016 at 05:09:01PM -0700, Timothy Gu wrote: > -#define AV_PIX_FMT_XVMC AV_PIX_FMT_XVMC_MPEG2_IDCT > +AV_PIX_FMT_XVMC = AV_PIX_FMT_XVMC_MPEG2_IDCT, I don't think this constitutes an API break, but comments are welcome. T

[FFmpeg-devel] [PATCH 2/2] pixfmt: Use enum assignment for aliases

2016-08-21 Thread Timothy Gu
This way, Doxygen is happier as aliases are now grouped together, and it never handled #define's in an enum well in the first place. Y400A already exists as an enum assignment. --- libavutil/pixfmt.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavutil/pixfmt.h

[FFmpeg-devel] [PATCH 1/2] pixdesc: Order function prototypes semantically

2016-08-21 Thread Timothy Gu
--- libavutil/pixdesc.h | 194 ++-- 1 file changed, 97 insertions(+), 97 deletions(-) diff --git a/libavutil/pixdesc.h b/libavutil/pixdesc.h index 3b0bcdb..a8ad588 100644 --- a/libavutil/pixdesc.h +++ b/libavutil/pixdesc.h @@ -173,78 +173,6 @@

Re: [FFmpeg-devel] [PATCH] mem: Extend and edit Doxygen

2016-08-21 Thread Timothy Gu
On Fri Aug 5 14:15:19 EEST 2016, Michael Niedermayer wrote: > to me it sounds more natural without "the" but english aint my area Changed. > either way the patch overall looks nice (i didnt deeply review) > Acked-by: Michael Thanks. Pushed. Timothy

Re: [FFmpeg-devel] [PATCH 1/5] lavc : yami : add libyami decoder/encoder

2016-08-15 Thread Timothy Gu
Hi On Mon, Aug 15, 2016 at 7:44 PM Jun Zhao wrote: > > > On 2016/8/16 10:14, Chao Liu wrote: > > Sorry for this little diversion: what are the differences between QSV and > > vaapi? > > My understanding is that QSV has better performance, while vaapi supports > > more

Re: [FFmpeg-devel] [PATCH 1/5] lavc : yami : add libyami decoder/encoder

2016-08-15 Thread Timothy Gu
On Mon, Aug 15, 2016 at 6:00 PM Jun Zhao wrote: > I know the worry after read the above thread.For Intel GPU HW accelerate > decode/encode, > now have 3 options in ffmpeg: > > 1. ffmpeg and QSV (Media SDK) > 2. ffmpeg vaapi hw accelerate decoder/native vaapi encoder > 3.

Re: [FFmpeg-devel] [PATCH v7 01/11] avformat: Add fifo pseudo-muxer

2016-08-14 Thread Timothy Gu
On Sun, Aug 14, 2016 at 11:12 AM Marton Balint wrote: > On Thu, 11 Aug 2016, sebechlebsky...@gmail.com wrote: > > +@anchor tee > > I still get error when building the docs: > > doc/muxers.texi:1531: @anchor expected braces > doc/muxers.texi:1443: @ref reference to nonexistent

Re: [FFmpeg-devel] [PATCH] avcodec/vdpau: clean up vdpau_internal.h

2016-08-04 Thread Timothy Gu
On Thu, Aug 4, 2016 at 12:57 AM Carl Eugen Hoyos wrote: > 2016-08-03 6:30 GMT+02:00 James Almer : > > Also don't include it on files that don't need it. > > > > This reduces differences with libav > > > > Signed-off-by: James Almer > >

Re: [FFmpeg-devel] next Outreachy & GSoC ideas braindump [RFC]

2016-08-03 Thread Timothy Gu
On Wed, Aug 3, 2016 at 11:57 AM James Almer wrote: > On 7/31/2016 5:01 PM, Michael Niedermayer wrote: > > Hi all > > > > you have a great idea for a Outreachy task or a GSoC task ? > > Or something you always wanted to do but never had the time and > > it would fit in the time

Re: [FFmpeg-devel] next Outreachy & GSoC ideas braindump [RFC]

2016-08-03 Thread Timothy Gu
On Wed, Aug 3, 2016 at 12:36 PM Michael Niedermayer wrote: > what about writing guides/howtos about how to build/replace FFmpeg > on all kinds of hw > That's the responsibility of the HW vendor. > i mean everything these days uses FFmpeg below one or more layers > and

Re: [FFmpeg-devel] [PATCH] - libavdevices/decklink_*.cpp: formatting change to remove uneeded spaces in initializers

2016-08-02 Thread Timothy Gu
On Tue, Aug 2, 2016 at 10:17 PM Felt, Patrick wrote: > --- > libavdevice/decklink_common.cpp | 10 +- > libavdevice/decklink_dec.cpp| 18 +- > libavdevice/decklink_enc.cpp| 26 +- > 3 files changed, 27 insertions(+),

Re: [FFmpeg-devel] [PATCH] af_hdcd: add flags to AVOption defs

2016-08-02 Thread Timothy Gu
On Mon, Aug 1, 2016 at 8:56 AM Burt P wrote: > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Applied. You might also want to look into using AV_OPT_TYPE_BOOL for these two options.

Re: [FFmpeg-devel] [PATCH] jni, mediacodec: Return ENOSYS on unsupported platforms

2016-08-02 Thread Timothy Gu
On Tue, Aug 2, 2016 at 8:42 PM Timothy Gu <timothyg...@gmail.com> wrote: > On Tue, Aug 2, 2016 at 6:30 PM James Almer <jamr...@gmail.com> wrote: > >> On 8/2/2016 7:28 PM, Timothy Gu wrote: >> > --- >> > libavcodec/jni.c| 9 - >> >

Re: [FFmpeg-devel] [PATCH] jni, mediacodec: Return ENOSYS on unsupported platforms

2016-08-02 Thread Timothy Gu
On Tue, Aug 2, 2016 at 6:30 PM James Almer <jamr...@gmail.com> wrote: > On 8/2/2016 7:28 PM, Timothy Gu wrote: > > --- > > libavcodec/jni.c| 9 - > > libavcodec/mediacodec.c | 6 -- > > 2 files changed, 8 insertions(+), 7 deletions(-) > >

Re: [FFmpeg-devel] snapshots differ from git clone

2016-08-02 Thread Timothy Gu
On Tue, Aug 2, 2016 at 3:10 PM Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXIV, Jan Ehrhardt a écrit : > > Because it is faster to download a snapshot and extract it than > > doing a git clone > > I suggest you consider doing a shallow clone (--depth 1). It should

[FFmpeg-devel] [PATCH] jni, mediacodec: Return ENOSYS on unsupported platforms

2016-08-02 Thread Timothy Gu
--- libavcodec/jni.c| 9 - libavcodec/mediacodec.c | 6 -- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/jni.c b/libavcodec/jni.c index 32456f5..85dcf2a 100644 --- a/libavcodec/jni.c +++ b/libavcodec/jni.c @@ -20,19 +20,18 @@ * Foundation, Inc.,

Re: [FFmpeg-devel] [PATCH 1/2] mem: Order function prototypes semantically

2016-08-02 Thread Timothy Gu
On Tue, Aug 2, 2016 at 3:13 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Jul 31, 2016 at 09:07:03PM -0700, Timothy Gu wrote: > > --- > > libavutil/mem.h | 198 > > > 1 file changed,

Re: [FFmpeg-devel] snapshots differ from git clone

2016-08-02 Thread Timothy Gu
On Tue, Aug 2, 2016 at 1:54 PM Jan Ehrhardt wrote: > I have a script that cross-compiles ffmpeg on Ubuntu for Windows. > Because it is faster to download a snapshot and extract it than > doing a git clone the script uses >

[FFmpeg-devel] [PATCH] jni, mediacodec: Return ENOSYS on unsupported platforms

2016-08-02 Thread Timothy Gu
--- libavcodec/jni.c| 2 +- libavcodec/mediacodec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/jni.c b/libavcodec/jni.c index 32456f5..e08a185 100644 --- a/libavcodec/jni.c +++ b/libavcodec/jni.c @@ -69,7 +69,7 @@ void *av_jni_get_java_vm(void

Re: [FFmpeg-devel] [PATCH] - cosmetic: the decklink_dec* files are used for input from the decklink cards. update the header to reflect that

2016-08-02 Thread Timothy Gu
On Tue, Aug 2, 2016 at 12:51 PM Felt, Patrick wrote: > That’s really odd. Has to be something stupid from my MUA. Let me attach > it as a file and it should go. (I wrote this off a brand new fresh clone). > Pushed, thanks. Timothy

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/bsf: Add list BSF API

2016-08-02 Thread Timothy Gu
Sorry, I seem to have lost the original mail, and as Gmane is dead I had to review using Nicolas's mail. On Tue, Aug 2, 2016 at 8:14 AM Nicolas George wrote: > Le primidi 11 thermidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : > > diff --git a/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH] mem: Extend and edit Doxygen

2016-08-02 Thread Timothy Gu
--- A bit more editing... --- libavutil/mem.h | 588 +++- 1 file changed, 451 insertions(+), 137 deletions(-) diff --git a/libavutil/mem.h b/libavutil/mem.h index 145ac91..4b99342 100644 --- a/libavutil/mem.h +++ b/libavutil/mem.h @@ -20,7

Re: [FFmpeg-devel] [PATCH] doc: add Libav merge document

2016-08-02 Thread Timothy Gu
I've put this document onto the wiki so that it's easier to edit: https://trac.ffmpeg.org/wiki/LibavMerge Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] build: Make API documentation depend on config.mak

2016-08-02 Thread Timothy Gu
On Sun, Jul 31, 2016 at 7:06 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Fri, Jul 29, 2016 at 10:30:37PM -0700, Timothy Gu wrote: > > The Doxygen command is generated from the list of installed headers, > > which may change per configuration (e.g. `

[FFmpeg-devel] [PATCH 1/2] mem: Order function prototypes semantically

2016-07-31 Thread Timothy Gu
--- libavutil/mem.h | 198 1 file changed, 99 insertions(+), 99 deletions(-) diff --git a/libavutil/mem.h b/libavutil/mem.h index 2f53b47..145ac91 100644 --- a/libavutil/mem.h +++ b/libavutil/mem.h @@ -83,6 +83,16 @@ void

[FFmpeg-devel] [PATCH 2/2] mem: Extend and edit Doxygen

2016-07-31 Thread Timothy Gu
--- libavutil/mem.h | 539 ++-- 1 file changed, 406 insertions(+), 133 deletions(-) diff --git a/libavutil/mem.h b/libavutil/mem.h index 145ac91..675b11c 100644 --- a/libavutil/mem.h +++ b/libavutil/mem.h @@ -20,7 +20,8 @@ /** * @file - *

Re: [FFmpeg-devel] [PATCH] dynarray: Change AV_ to FF_ for AV_DYNARRAY_ADD

2016-07-31 Thread Timothy Gu
On Fri, Jul 29, 2016 at 10:18 PM Timothy Gu <timothyg...@gmail.com> wrote: > The header is not installed and the macro isn't used outside libavutil, > so it is obviously privat to libavutil. Make the name reflect that. > --- > libavutil/dynarray.h | 2 +- > libavutil/mem.c

Re: [FFmpeg-devel] [PATCH] mem: Make function attribute usage consistent

2016-07-31 Thread Timothy Gu
On Sun, Jul 31, 2016 at 4:56 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sat, Jul 30, 2016 at 07:13:06PM -0700, Timothy Gu wrote: > > --- > > libavutil/mem.h | 47 +-- > > 1 file changed, 37 insertions(+),

[FFmpeg-devel] [PATCH] mem: Make function attribute usage consistent

2016-07-30 Thread Timothy Gu
--- libavutil/mem.h | 47 +-- 1 file changed, 37 insertions(+), 10 deletions(-) diff --git a/libavutil/mem.h b/libavutil/mem.h index 2f53b47..a6bb6b7 100644 --- a/libavutil/mem.h +++ b/libavutil/mem.h @@ -80,7 +80,9 @@ * be allocated. * @see

[FFmpeg-devel] [PATCH 1/2] build: Make API documentation depend on config.mak

2016-07-29 Thread Timothy Gu
The Doxygen command is generated from the list of installed headers, which may change per configuration (e.g. `--enable-gpl` results in libpostproc to be built and installed). --- doc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/Makefile b/doc/Makefile index

[FFmpeg-devel] [PATCH 2/2] mem: Make function attribute usage consisten

2016-07-29 Thread Timothy Gu
--- libavutil/mem.h | 42 +++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/libavutil/mem.h b/libavutil/mem.h index 2f53b47..ca936e8 100644 --- a/libavutil/mem.h +++ b/libavutil/mem.h @@ -80,7 +80,8 @@ * be allocated. * @see

[FFmpeg-devel] [PATCH] dynarray: Change AV_ to FF_ for AV_DYNARRAY_ADD

2016-07-29 Thread Timothy Gu
The header is not installed and the macro isn't used outside libavutil, so it is obviously privat to libavutil. Make the name reflect that. --- libavutil/dynarray.h | 2 +- libavutil/mem.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/dynarray.h

Re: [FFmpeg-devel] [PATCH] hapdec: remove unused memory.h include

2016-07-28 Thread Timothy Gu
On Thu, Jul 28, 2016 at 6:11 PM Josh de Kock wrote: > Most systems have this, so it isn't really a problem to include it > even if it's not used, but some do not have memory.h as it is > non-standard. Since it's unused just remove it anyway. > --- > libavcodec/hapdec.c | 1 - >

Re: [FFmpeg-devel] [PATCH] lavf/mpegtsenc: add special case for handling timed ID3 packets

2016-07-28 Thread Timothy Gu
On Thu, May 19, 2016 at 1:23 PM Michael Niedermayer wrote: > On Thu, May 19, 2016 at 06:45:41PM +0200, Stefano Sabatini wrote: > > Set the stream_id to 0xbd (private_stream_id_1). Tools seem to assume > > that value, and this is consistent with MPEG TS (ITU-T H.222.0)

Re: [FFmpeg-devel] [PATCH] doc/developer.texi: Add a code of conduct

2016-05-19 Thread Timothy Gu
Hi, On Mon, Mar 28, 2016 at 03:39:22PM +0200, Michael Niedermayer wrote: > On Mon, Mar 28, 2016 at 12:34:05PM +, Kieran Kunhya wrote: > > On Mon, 28 Mar 2016 at 11:58 Moritz Barsnick wrote: > > > > > On Mon, Mar 28, 2016 at 02:18:32 +0200, Michael Niedermayer wrote: > > >

Re: [FFmpeg-devel] [Vote] Code of Conduct

2016-05-19 Thread Timothy Gu
On Wed, May 18, 2016 at 08:40:07PM +0200, Michael Niedermayer wrote: > This is the version i had in my pending branch and should be the last > version of the Code of Conduct from march, IIRC there where no further > comments on the last version, so iam calling everyone to vote on this. >

Re: [FFmpeg-devel] [PATCH 2/2] configure: Enable GCC vectorization on ≥4.9

2016-05-06 Thread Timothy Gu
On Fri, May 06, 2016 at 12:08:14PM +0200, Hendrik Leppkes wrote: > > Just to document it, this has caused build breakage in various > scenarios, even in GCC 5.3 (6.1 not tested). > > The latest reported on IRC just today here: > libavcodec/sbrdsp.c: In function 'sbr_neg_odd_64_c': >

Re: [FFmpeg-devel] Support master branch of OpenJPEG and Grok J2K codecs

2016-04-04 Thread Timothy Gu
On Mon, Apr 04, 2016 at 06:06:28PM -0400, Aaron Boxer wrote: > I could give you an OS image that has a version of FFmpeg that uses > proprietary codecs. Aside from Carl's comment, please define "proprietary codecs." Proprietary codecs have different licenses, just like how both ISC and GNU AGPL

Re: [FFmpeg-devel] Support master branch of OpenJPEG and Grok J2K codecs

2016-04-04 Thread Timothy Gu
Hi, On Mon, Apr 04, 2016 at 03:54:11PM -0400, Aaron Boxer wrote: > > > > > > > > The following changes were made: > > > > > > 1. Removed bpp (redundant as this information is already stored in > > precision) > > > > Does compilation still work without this change? > > > > Yes. Then the change

Re: [FFmpeg-devel] Support master branch of OpenJPEG and Grok J2K codecs

2016-04-04 Thread Timothy Gu
On Sun, Apr 03, 2016 at 05:34:15PM -0400, Aaron Boxer wrote: > From d12c685578f21b403f6c03505edd84db367306c5 Mon Sep 17 00:00:00 2001 > From: Aaron Boxer > Date: Sun, 27 Mar 2016 00:15:20 -0400 > Subject: [PATCH] Support the following jpeg 2000 codecs: > > a) latest release

[FFmpeg-devel] [PATCH 2/2] version.sh: Add next release to the version

2016-03-05 Thread Timothy Gu
Also make consistent the fallback versions. This patch uses a RELEASE-based approach rather than a tag-based one. There are several reasons for this. First, the -dev tags never convey more information than RELEASE. Second, RELEASE can provide a version even without Git. The new script is

[FFmpeg-devel] [PATCH 0/2] New versioning (was: version.sh: Always use latest tag for generated version number)

2016-03-05 Thread Timothy Gu
lease is made. When a release branch is cut, do the following 1. Remove "-master" in RELEASE 2. git commit -a -m "Next release is $(cat RELEASE)" Timothy Gu (2): version.sh: Fix Git directory version.sh: Add next release to

[FFmpeg-devel] [PATCH 1/2] version.sh: Fix Git directory

2016-03-05 Thread Timothy Gu
This is necessary for cases where the FFmpeg directory does not have Git metadata but the parent directories do. See e.g. https://github.com/mxe/mxe/issues/1219. --- version.sh | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/version.sh b/version.sh index

Re: [FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

2016-03-04 Thread Timothy Gu
On Fri, Mar 04, 2016 at 08:46:42PM +0100, Reimar Döffinger wrote: > On 04.03.2016, at 11:24, Nicolas George wrote: > > > The Git (short) hash carries all the information by itself, so it should be > > present. But extra, redundant, information can be added for the convenience >

Re: [FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

2016-03-04 Thread Timothy Gu
On Fri, Mar 04, 2016 at 06:48:04PM +0100, Thilo Borgmann wrote: > Am 04.03.16 um 17:57 schrieb Timothy Gu: > > On Fri, Mar 04, 2016 at 10:55:42AM +0100, Thilo Borgmann wrote: > >> Am 04.03.16 um 08:58 schrieb wm4: > >>> > >>> Being able to see the, we

Re: [FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

2016-03-04 Thread Timothy Gu
On Fri, Mar 04, 2016 at 10:20:09AM +, Carl Eugen Hoyos wrote: > Timo Rothenpieler rothenpieler.org> writes: > > > The current versioning scheme is indeed simple, but > > useless in almost all other aspects. > > FFmpeg has a linear development scheme, how can you call > a continuous

Re: [FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

2016-03-04 Thread Timothy Gu
On Fri, Mar 04, 2016 at 11:24:31AM +0100, Nicolas George wrote: > Basically, the version could be something like > "g510046c:N78879-3.0master417-H20160303": One object that can be raised against this is that the current versioning and the new versioning are both compatible with Git. Try git

Re: [FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

2016-03-04 Thread Timothy Gu
On Fri, Mar 04, 2016 at 10:55:42AM +0100, Thilo Borgmann wrote: > Am 04.03.16 um 08:58 schrieb wm4: > > > > Being able to see the, well, version in the version output (instead of > > random numbers) sounds like a pretty convincing argument. > > Neither a good play on words nor elaborative; not

Re: [FFmpeg-devel] [PATCH] nvenc.c Fix H264 and HEVC vui info update

2016-03-03 Thread Timothy Gu
On Fri, Mar 04, 2016 at 12:45:47PM +0800, Agatha Hu wrote: > --- > libavcodec/nvenc.c | 33 - > 1 file changed, 28 insertions(+), 5 deletions(-) This patched is corrupted by your mail client. What's wrong with the first patch you sent (with git-send-email)?

Re: [FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

2016-03-03 Thread Timothy Gu
On Fri, Mar 04, 2016 at 12:55:35AM +, Carl Eugen Hoyos wrote: > Timothy Gu gmail.com> writes: > > > Of course, this argument operates on the premise that > > making things easier for users is of utmost concern > > for us. Please inspire me if this is not the ca

Re: [FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

2016-03-03 Thread Timothy Gu
On Thu, Mar 03, 2016 at 11:04:09PM +, Carl Eugen Hoyos wrote: > Timo Rothenpieler rothenpieler.org> writes: > > > So instead of > > > > N-78885-g966eade > > The continuous numbering scheme is very convenient when > answering user questions and it reflects very well the > (past and

Re: [FFmpeg-devel] [PATCH v9] VideoToolbox H.264 Encoder

2016-03-01 Thread Timothy Gu
Hi, On Mon, Feb 29, 2016 at 9:42 PM Rick Kern wrote: > Autodetected by default. Encode using -codec:v vtenc. > > Signed-off-by: Rick Kern > --- > MAINTAINERS|1 + > configure | 19 + > libavcodec/Makefile|1 + >

Re: [FFmpeg-devel] [PATCH] x86/vc1dsp: Split the file into MC and loopfilter

2016-02-29 Thread Timothy Gu
On Mon, Feb 29, 2016 at 4:57 AM Ronald S. Bultje wrote: > This is kind of hard to review, but I'm going to assume that there's no > actual code changes, in which case this LGTM. > No there isn't. Applied, thanks. Timothy > ___

[FFmpeg-devel] [PATCH] tests/api: Silence a few uninitialized variables warnings

2016-02-28 Thread Timothy Gu
--- tests/api/api-flac-test.c | 2 +- tests/api/api-seek-test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c index 7b48059..288bc2c 100644 --- a/tests/api/api-flac-test.c +++ b/tests/api/api-flac-test.c @@ -115,7

[FFmpeg-devel] [PATCH] x86/vc1dsp: Split the file into MC and loopfilter

2016-02-28 Thread Timothy Gu
--- libavcodec/x86/Makefile | 3 +- libavcodec/x86/vc1dsp.asm| 585 --- libavcodec/x86/vc1dsp_loopfilter.asm | 317 +++ libavcodec/x86/vc1dsp_mc.asm | 292 + 4 files changed, 611 insertions(+), 586

Re: [FFmpeg-devel] [PATCH] LICENSE: Thorough editing

2016-02-28 Thread Timothy Gu
On Sat, Feb 13, 2016 at 05:41:10PM -0800, Timothy Gu wrote: > The changes in "Incompatible libraries" section are strictly based on > what our configure script says. > --- > LICENSE.md | 64 > +- > 1 file c

Re: [FFmpeg-devel] [PATCH] x86/vf_blend: Add SSE2 optimization for divide

2016-02-28 Thread Timothy Gu
On Sun, Feb 14, 2016 at 03:45:11PM +0100, Henrik Gramner wrote: > You could try doing 8 or 16 bytes per iteration instead of 4, it might > be faster depending on how good your cpu is at OOE. As discussed on IRC, no observable difference has been observed with such changes, mainly because the

[FFmpeg-devel] Retire unused FATE IDs

2016-02-19 Thread Timothy Gu
Hi all, For better security for the FATE server, I have just disabled the SSH keys corresponding to the following owners: - ab (only slot is "ab_haiku_fate;" has not been active for 9 months) - amalia (only slot is "x86_64-Fedora_20-gcc-4.8.3" with one run; has not been active for more than 1

Re: [FFmpeg-devel] [PATCH] vf_blend: Use integers for divide mode

2016-02-19 Thread Timothy Gu
On Sun, Feb 14, 2016 at 10:41:04AM +0100, Paul B Mahol wrote: > > ok Pushed (last week). Thanks. Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/12] avutil/parseutils: use microsecond precision when parsing "now" in av_parse_time()

2016-02-14 Thread Timothy Gu
On Sun, Feb 14, 2016 at 02:54:29AM +0100, Marton Balint wrote: > > I have applied the series except the last one patching ffmpeg_opt. This set seems to cause some issues in some FATE stations: http://fatebeta.ffmpeg.org/report/armel5tej-qemu-debian-gcc4.4/20160214170733#failed_tests

Re: [FFmpeg-devel] [PATCH] x86/vc1dsp: Port vc1_*_hor_16b_shift2 to NASM format

2016-02-14 Thread Timothy Gu
On Sun, Feb 14, 2016 at 01:21:57PM +0100, Christophe Gisquet wrote: > Hi, > > 2016-02-14 6:49 GMT+01:00 Timothy Gu <timothyg...@gmail.com>: > > %if HAVE_MMX_INLINE > > Isn't that macro meant for C code (and in config.asm without much of a > purpose)? Yes, but this

Re: [FFmpeg-devel] [PATCH] vf_blend: Reduce number of arguments for kernel function

2016-02-14 Thread Timothy Gu
On Sun, Feb 14, 2016 at 10:12:21AM +0100, Paul B Mahol wrote: > On 2/14/16, Timothy Gu <timothyg...@gmail.com> wrote: > > --- > > libavfilter/blend.h | 2 +- > > libavfilter/vf_blend.c | 27 ++- > > lib

Re: [FFmpeg-devel] [PATCH] checkasm: Add vf_blend tests

2016-02-14 Thread Timothy Gu
On Sun, Feb 14, 2016 at 10:06:16AM +0100, Paul B Mahol wrote: > On 2/14/16, Timothy Gu <timothyg...@gmail.com> wrote: > > + > > +#include > > +#include "checkasm.h" > > +#include "libavfilter/blend.h" > > +#include "libavutil/common.

Re: [FFmpeg-devel] [PATCH 1/2] vf_blend: Templatize identity function and use a better name

2016-02-14 Thread Timothy Gu
On Sun, Feb 14, 2016 at 10:07:39AM +0100, Paul B Mahol wrote: > On 2/14/16, Timothy Gu <timothyg...@gmail.com> wrote: > > --- > > libavfilter/vf_blend.c | 22 ++ > > 1 file changed, 14 insertions(+), 8 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] fate/source: Do not use GNU extensions in sed

2016-02-13 Thread Timothy Gu
On Sat, Feb 13, 2016 at 02:35:22AM +0100, Michael Niedermayer wrote: > On Fri, Feb 12, 2016 at 05:07:20PM -0800, Timothy Gu wrote: > > --- > > > > Tested on FreeBSD 10.2. > > patch should be ok Pushed, thanks. Timothy __

[FFmpeg-devel] [PATCH] checkasm: Add vf_blend tests

2016-02-13 Thread Timothy Gu
oid checkasm_check_bswapdsp(void); void checkasm_check_flacdsp(void); void checkasm_check_fmtconvert(void); diff --git a/tests/checkasm/vf_blend.c b/tests/checkasm/vf_blend.c new file mode 100644 index 000..51e1391 --- /dev/null +++ b/tests/checkasm/vf_blend.c @@ -0,0 +1,130 @@ +/* + * C

[FFmpeg-devel] [PATCH 1/2] vf_blend: Templatize identity function and use a better name

2016-02-13 Thread Timothy Gu
--- libavfilter/vf_blend.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index 2b734b4..c24013d 100644 --- a/libavfilter/vf_blend.c +++ b/libavfilter/vf_blend.c @@ -118,15 +118,21 @@ static const

[FFmpeg-devel] [PATCH 2/2] vf_blend: Use memcpy when opacity is 0

2016-02-13 Thread Timothy Gu
For xor mode, 1.8x faster on Haswell. --- libavfilter/vf_blend.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index c24013d..599084f 100644 --- a/libavfilter/vf_blend.c +++ b/libavfilter/vf_blend.c @@ -130,6 +130,7 @@ static void

[FFmpeg-devel] [PATCH] x86/vf_blend: Add SSE4.1 optimization for divide

2016-02-13 Thread Timothy Gu
--- The reason why this function uses SSE4.1 is the roundps instruction. Would love to find a way to truncate a float to integer in SSE2. --- libavfilter/x86/vf_blend.asm| 32 libavfilter/x86/vf_blend_init.c | 6 ++ 2 files changed, 38 insertions(+)

Re: [FFmpeg-devel] [PATCH] avutil: Remove x86_cpu.h

2016-02-13 Thread Timothy Gu
On Sun, Feb 07, 2016 at 09:29:23AM -0800, Timothy Gu wrote: > It is private (uninstalled) and unused. > --- > libavutil/x86_cpu.h | 1 - > 1 file changed, 1 deletion(-) > delete mode 100644 libavutil/x86_cpu.h Pushed. Timothy ___ ffmpe

[FFmpeg-devel] [PATCH] x86/vc1dsp: Port vc1_*_hor_16b_shift2 to NASM format

2016-02-13 Thread Timothy Gu
--- libavcodec/x86/vc1dsp.asm | 92 - libavcodec/x86/vc1dsp_mmx.c | 61 -- 2 files changed, 99 insertions(+), 54 deletions(-) diff --git a/libavcodec/x86/vc1dsp.asm b/libavcodec/x86/vc1dsp.asm index 91a1991..2e9f067 100644

[FFmpeg-devel] [PATCH] LICENSE: Thorough editing

2016-02-13 Thread Timothy Gu
The changes in "Incompatible libraries" section are strictly based on what our configure script says. --- LICENSE.md | 64 +- 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/LICENSE.md b/LICENSE.md index 0c53d0f..a70f486

Re: [FFmpeg-devel] [PATCH] x86/vf_blend: Add SSE2 optimization for divide

2016-02-13 Thread Timothy Gu
On Sat, Feb 13, 2016 at 07:21:25PM -0800, Timothy Gu wrote: > --- > libavfilter/x86/vf_blend.asm| 30 ++ > libavfilter/x86/vf_blend_init.c | 2 ++ > 2 files changed, 32 insertions(+) Locally added commit message: 4.5x faster than C f

[FFmpeg-devel] [PATCH] vf_blend: Reduce number of arguments for kernel function

2016-02-13 Thread Timothy Gu
--- libavfilter/blend.h | 2 +- libavfilter/vf_blend.c | 27 ++- libavfilter/x86/vf_blend.asm| 3 +-- libavfilter/x86/vf_blend_init.c | 2 +- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/libavfilter/blend.h

[FFmpeg-devel] [PATCH] vf_blend: Use integers for divide mode

2016-02-13 Thread Timothy Gu
2.5x faster for 8-bit mode without autovectorization in GCC, 2x slower with it on x86. However, since the platforms we enable GCC autovectorization on most probably has support for SSE2 optimization (added in the subsequent commit), this commit should in general do good. ---

[FFmpeg-devel] [PATCH] x86/vf_blend: Add SSE2 optimization for divide

2016-02-13 Thread Timothy Gu
--- libavfilter/x86/vf_blend.asm| 30 ++ libavfilter/x86/vf_blend_init.c | 2 ++ 2 files changed, 32 insertions(+) diff --git a/libavfilter/x86/vf_blend.asm b/libavfilter/x86/vf_blend.asm index a5ea74c..303ea3a 100644 --- a/libavfilter/x86/vf_blend.asm +++

Re: [FFmpeg-devel] [PATCH] x86/vf_blend: Add SSE4.1 optimization for divide

2016-02-13 Thread Timothy Gu
I've already answered these on IRC but for the sake of completion I'll include the answers here as well. On Sat, Feb 13, 2016 at 10:26:58PM -0300, James Almer wrote: > On 2/13/2016 9:27 PM, Timothy Gu wrote: > > --- > > > > The reason why this function uses SSE4.1 is th

[FFmpeg-devel] [PATCH] fate/source: Do not use GNU extensions in sed

2016-02-12 Thread Timothy Gu
--- Tested on FreeBSD 10.2. --- cmdutils.h | 4 ++-- tests/fate/source-check.sh | 8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/cmdutils.h b/cmdutils.h index 7f3db2a..83ea4ad 100644 --- a/cmdutils.h +++ b/cmdutils.h @@ -19,8 +19,8 @@ * Foundation,

[FFmpeg-devel] [PATCH] fate/source: Attempt to fix BSD sed

2016-02-11 Thread Timothy Gu
I apparently used a GNU extension in the !{} syntax. Remove that rule and the cause of it. --- cmdutils.h | 4 ++-- tests/fate/source-check.sh | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/cmdutils.h b/cmdutils.h index 7f3db2a..83ea4ad 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] x86/vf_blend: Move multiplying to a macro

2016-02-10 Thread Timothy Gu
On Wed, Feb 10, 2016 at 08:09:07PM +0100, Paul B Mahol wrote: > On 2/9/16, Timothy Gu <timothyg...@gmail.com> wrote: > > --- > > libavfilter/x86/vf_blend.asm | 16 ++-- > > 1 file changed, 10 insertions(+), 6 deletions(-) &g

[FFmpeg-devel] [PATCH 2/2] checkasm: Add vf_blend tests

2016-02-10 Thread Timothy Gu
oid checkasm_check_bswapdsp(void); void checkasm_check_flacdsp(void); void checkasm_check_fmtconvert(void); diff --git a/tests/checkasm/vf_blend.c b/tests/checkasm/vf_blend.c new file mode 100644 index 000..51c4999 --- /dev/null +++ b/tests/checkasm/vf_blend.c @@ -0,0 +1,111 @@ +/* + * C

Re: [FFmpeg-devel] [PATCH 4/4] tests: Add test for proper header guard

2016-02-10 Thread Timothy Gu
On Sun, Jan 31, 2016 at 3:47 PM Timothy Gu <timothyg...@gmail.com> wrote: > On Fri, Jan 29, 2016 at 10:10:48AM +0100, Clément Bœsch wrote: > > On Thu, Jan 28, 2016 at 06:33:56PM -0800, Timothy Gu wrote: > > > --- > > > tests/fate/source-check.sh | 11 +++

[FFmpeg-devel] [PATCH 1/2] x86/vf_blend: Move multiplying to a macro

2016-02-09 Thread Timothy Gu
--- libavfilter/x86/vf_blend.asm | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavfilter/x86/vf_blend.asm b/libavfilter/x86/vf_blend.asm index 9388a74..50b5f8a 100644 --- a/libavfilter/x86/vf_blend.asm +++ b/libavfilter/x86/vf_blend.asm @@ -102,6 +102,15

[FFmpeg-devel] [PATCH 2/2] x86/vf_blend: Add SSE2 optimization for screen

2016-02-09 Thread Timothy Gu
--- libavfilter/x86/vf_blend.asm| 29 + libavfilter/x86/vf_blend_init.c | 2 ++ 2 files changed, 31 insertions(+) diff --git a/libavfilter/x86/vf_blend.asm b/libavfilter/x86/vf_blend.asm index 50b5f8a..a5ea74c 100644 --- a/libavfilter/x86/vf_blend.asm +++

[FFmpeg-devel] [PATCH] vf_blend: Add SSE2 optimization for multiply

2016-02-08 Thread Timothy Gu
5 times faster than C, 3 times overall. --- Removes constant.c changes in accordance with James's comments --- libavfilter/x86/vf_blend.asm| 29 + libavfilter/x86/vf_blend_init.c | 2 ++ 2 files changed, 31 insertions(+) diff --git

  1   2   3   4   5   6   >