Re: [FFmpeg-devel] [PATCH v5] avcodec/libvpxenc: optimize parsing vpx_svc_ref_frame_config

2021-02-18 Thread Wonkap Jang
On Thu, Feb 18, 2021 at 1:26 PM James Zern wrote: > On Thu, Feb 18, 2021 at 11:01 AM Wonkap Jang > wrote: > > > > Getting rid of unnecessary use of AVDictionary object in parsing > > vpx_svc_ref_frame_config. > > --- &g

[FFmpeg-devel] [PATCH v5] avcodec/libvpxenc: optimize parsing vpx_svc_ref_frame_config

2021-02-18 Thread Wonkap Jang
Getting rid of unnecessary use of AVDictionary object in parsing vpx_svc_ref_frame_config. --- libavcodec/libvpxenc.c | 73 +++--- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: optimize parsing vpx_svc_ref_frame_config parameters

2021-02-18 Thread Wonkap Jang
On Wed, Feb 17, 2021 at 4:41 PM Wonkap Jang wrote: > Getting rid of unnecessary use of AVDictionary object in parsing > vpx_svc_ref_frame_config. > --- > libavcodec/libvpxenc.c | 76 -- > 1 file changed, 58 insertions(+), 18 deletions(-)

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
On Wed, Feb 17, 2021 at 11:30 AM Wonkap Jang wrote: > > > On Wed, Feb 17, 2021 at 9:50 AM Nicolas George wrote: > >> Wonkap Jang (12021-02-17): >> > While parsing ref_frame_config, AVdictionary needs to be manually >> > deallocated. >&g

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: optimize parsing vpx_svc_ref_frame_config parameters

2021-02-17 Thread Wonkap Jang
Getting rid of unnecessary use of AVDictionary object in parsing vpx_svc_ref_frame_config. --- libavcodec/libvpxenc.c | 76 -- 1 file changed, 58 insertions(+), 18 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
On Wed, Feb 17, 2021 at 9:50 AM Nicolas George wrote: > Wonkap Jang (12021-02-17): > > While parsing ref_frame_config, AVdictionary needs to be manually > > deallocated. > > --- > > libavcodec/libvpxenc.c | 21 + > > 1 file chang

[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
While parsing ref_frame_config, AVdictionary needs to be manually deallocated. --- libavcodec/libvpxenc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 284cb9a108..56a1b5aafe 100644 ---

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
On Wed, Feb 17, 2021 at 8:52 AM Wonkap Jang wrote: > Hi Nicolas, > > On Wed, Feb 17, 2021 at 3:00 AM Nicolas George wrote: > >> Wonkap Jang (12021-02-16): >> > While parsing ref_frame_config, AVdictionary needs to be manually >> > deallocated. >&g

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-17 Thread Wonkap Jang
Hi Nicolas, On Wed, Feb 17, 2021 at 3:00 AM Nicolas George wrote: > Wonkap Jang (12021-02-16): > > While parsing ref_frame_config, AVdictionary needs to be manually > > deallocated. > > --- > > libavcodec/libvpxenc.c | 19 --- > > 1 file chang

[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread Wonkap Jang
While parsing ref_frame_config, AVdictionary needs to be manually deallocated. --- libavcodec/libvpxenc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 284cb9a108..b552590b7b 100644 ---

Re: [FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread Wonkap Jang
On Tue, Feb 16, 2021 at 1:02 PM James Zern wrote: > Hi, > > On Mon, Feb 15, 2021 at 10:37 PM Wonkap Jang > wrote: > > > > While parsing ref_frame_config, AVdictionary needs to be manually > > deallocated. > > --- > > libavcodec/libvpxenc.c

[FFmpeg-devel] [PATCH v2] avcodec/libvpxenc: fix potential memory leak.

2021-02-16 Thread Wonkap Jang
While parsing ref_frame_config, AVdictionary needs to be manually deallocated. --- libavcodec/libvpxenc.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 284cb9a108..e71ae54f34 100644 ---

[FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: fix potential memory leak.

2021-02-15 Thread Wonkap Jang
While parsing ref_frame_config, AVdictionary needs to be manually deallocated. --- libavcodec/libvpxenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 284cb9a108..941c3fdd88 100644 --- a/libavcodec/libvpxenc.c +++

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-08 Thread Wonkap Jang
On Fri, Jan 8, 2021 at 3:33 PM Wonkap Jang wrote: > In order to fine-control referencing schemes in VP9 encoding, there > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > provides a way to use the API through frame metadata. > --- > doc/encoders

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-08 Thread Wonkap Jang
In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through frame metadata. --- doc/encoders.texi | 32 libavcodec/libvpxenc.c | 84

Re: [FFmpeg-devel] [PATCH v2] In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API throu

2021-01-08 Thread Wonkap Jang
On Mon, Dec 14, 2020 at 12:46 PM James Zern wrote: > Hi, > > > On Mon, Dec 14, 2020 at 11:54 AM Wonkap Jang wrote: > > > > > > > > On Mon, Dec 7, 2020 at 11:57 PM Wonkap Jang wrote: > >> > >> --- > >> doc/encoders.tex

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-07 Thread Wonkap Jang
In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through frame metadata. --- doc/encoders.texi | 32 +++ libavcodec/libvpxenc.c | 88

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-06 Thread Wonkap Jang
HI JAmes, On Tue, Dec 29, 2020 at 11:54 AM Wonkap Jang < wonkap-at-google@ffmpeg.org> wrote: > Hi James, > > On Tue, Dec 29, 2020 at 11:51 AM Wonkap Jang wrote: > > > In order to fine-control referencing schemes in VP9 encoding, there > > is a need to use

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-29 Thread Wonkap Jang
Hi James, On Tue, Dec 29, 2020 at 11:51 AM Wonkap Jang wrote: > In order to fine-control referencing schemes in VP9 encoding, there > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > provides a way to use the API through frame metadata. > --- > doc/encoders

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-29 Thread Wonkap Jang
In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through frame metadata. --- doc/encoders.texi | 32 + libavcodec/libvpxenc.c | 81

[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-23 Thread Wonkap Jang
In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through frame metadata. --- doc/encoders.texi | 32 + libavcodec/libvpxenc.c | 81

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-21 Thread Wonkap Jang
On Mon, Dec 21, 2020 at 1:40 PM James Zern wrote: > On Thu, Dec 17, 2020 at 2:43 PM Wonkap Jang wrote: > > > > > > > > On Thu, Dec 17, 2020 at 10:48 AM James Zern wrote: > >> > >> On Tue, Dec 15, 2020 at 9:24 AM Wonkap Jang wrote: > >> >

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-17 Thread Wonkap Jang
On Thu, Dec 17, 2020 at 10:48 AM James Zern wrote: > On Tue, Dec 15, 2020 at 9:24 AM Wonkap Jang wrote: > > > > Hi James > > > > On Tue, Dec 15, 2020 at 9:18 AM Wonkap Jang wrote: > >> > >> In order to fine-control referencing schemes

Re: [FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-15 Thread Wonkap Jang
Hi James On Tue, Dec 15, 2020 at 9:18 AM Wonkap Jang wrote: > In order to fine-control referencing schemes in VP9 encoding, there > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit > provides a way to use the API through frame metadata. > --- > doc/encoders

[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2020-12-15 Thread Wonkap Jang
In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through frame metadata. --- doc/encoders.texi | 32 + libavcodec/libvpxenc.c | 81

[FFmpeg-devel] [PATCH v2] In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through f

2020-12-14 Thread Wonkap Jang
--- doc/encoders.texi | 32 + libavcodec/libvpxenc.c | 79 ++ 2 files changed, 111 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 0b1c69e982..aa3a2221b6 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@

Re: [FFmpeg-devel] [PATCH v2] In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API throu

2020-12-14 Thread Wonkap Jang
On Mon, Dec 7, 2020 at 11:57 PM Wonkap Jang wrote: > --- > doc/encoders.texi | 32 + > libavcodec/libvpxenc.c | 79 ++ > 2 files changed, 111 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi

[FFmpeg-devel] [PATCH v2] In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through f

2020-12-07 Thread Wonkap Jang
--- doc/encoders.texi | 32 + libavcodec/libvpxenc.c | 79 ++ 2 files changed, 111 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 0b1c69e982..aa3a2221b6 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@

Re: [FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG.

2020-11-23 Thread Wonkap Jang
Hi James, On Wed, Nov 18, 2020 at 1:13 PM James Zern wrote: > Hi, > > On Mon, Nov 16, 2020 at 2:36 PM Wonkap Jang > wrote: > > > > In order to fine-control referencing schemes in VP9 encoding, there > > is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method.

[FFmpeg-devel] [PATCH v1] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG.

2020-11-16 Thread Wonkap Jang
In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through frame metadata. --- libavcodec/libvpxenc.c | 77 ++ 1 file changed, 77 insertions(+)

[FFmpeg-devel] [PATCH v7] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-10 Thread Wonkap Jang
In order for rate control to correctly allocate bitrate to each temporal layer, correct temporal layer id has to be set to each frame. This commit provides the ability to set correct temporal layer id for each frame. --- doc/encoders.texi | 9 - libavcodec/libvpxenc.c | 13

Re: [FFmpeg-devel] [PATCH v6] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-07 Thread Wonkap Jang
Hi James, On Fri, Feb 7, 2020 at 10:36 AM Wonkap Jang wrote: > In order for rate control to correctly allocate bitrate to each temporal > layer, correct temporal layer id has to be set to each frame. This > commit provides the ability to set correct temporal layer id for eac

[FFmpeg-devel] [PATCH v6] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-07 Thread Wonkap Jang
In order for rate control to correctly allocate bitrate to each temporal layer, correct temporal layer id has to be set to each frame. This commit provides the ability to set correct temporal layer id for each frame. --- doc/encoders.texi | 8 +++- libavcodec/libvpxenc.c | 13

Re: [FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-06 Thread Wonkap Jang
Hi James, On Wed, Feb 5, 2020 at 5:29 PM James Zern wrote: > On Mon, Feb 3, 2020 at 5:45 PM Wonkap Jang > wrote: > > > > Hi > > > > On Mon, Feb 3, 2020 at 12:45 PM James Zern < > jzern-at-google@ffmpeg.org> > > wrote: > > > > &

Re: [FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-03 Thread Wonkap Jang
Hi On Mon, Feb 3, 2020 at 12:45 PM James Zern wrote: > On Mon, Feb 3, 2020 at 10:02 AM Wonkap Jang > wrote: > > > > In order for rate control to correctly allocate bitrate to each temporal > > layer, correct temporal layer id has to be set to each frame. This > &g

[FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-03 Thread Wonkap Jang
In order for rate control to correctly allocate bitrate to each temporal layer, correct temporal layer id has to be set to each frame. This commit provides the ability to set correct temporal layer id for each frame. --- libavcodec/libvpxenc.c | 13 - 1 file changed, 12 insertions(+),

[FFmpeg-devel] [PATCH v5 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-02-03 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- doc/encoders.texi | 18 ++-

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-30 Thread Wonkap Jang
Hi James, My answers are in-line. On Wed, Jan 29, 2020 at 8:36 AM James Zern wrote: > On Fri, Jan 17, 2020 at 1:56 PM Wonkap Jang > wrote: > > > > Hi James, > > > > On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > > > > > This commit reuses t

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-17 Thread Wonkap Jang
Hi James, On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-17 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- doc/encoders.texi | 18 ++-

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-16 Thread Wonkap Jang
Hi James, On Thu, Jan 16, 2020 at 10:28 AM Wonkap Jang wrote: > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-16 Thread Wonkap Jang
James, On Thu, Jan 16, 2020 at 10:58 AM Wonkap Jang < wonkap-at-google@ffmpeg.org> wrote: > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documen

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-16 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- doc/encoders.texi | 18 ++-

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-16 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- doc/encoders.texi | 18 ++-

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-15 Thread Wonkap Jang
HI, My comments are in-line. On Tue, Jan 14, 2020 at 8:55 PM James Zern wrote: > On Tue, Jan 14, 2020 at 11:07 AM Wonkap Jang > wrote: > > > > This commit reuses the configuration options for VP8 that enables > > temporal scalability for VP9. It also adds a way to

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-14 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- doc/encoders.texi | 18 ++-

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-14 Thread Wonkap Jang
Hi James, On Tue, Jan 14, 2020 at 10:59 AM Wonkap Jang wrote: > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-13 Thread Wonkap Jang
HI, On Mon, Jan 13, 2020 at 4:44 PM James Zern wrote: > Hi, > > On Fri, Jan 10, 2020 at 9:59 AM Wonkap Jang > wrote: > > > > This commit reuses the configuration options for VP8 that enables > > temporal scalability for VP9. It also adds a way to enable three

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-10 Thread Wonkap Jang
On Fri, Jan 10, 2020 at 9:59 AM Wonkap Jang wrote: > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be use

[FFmpeg-devel] [PATCH v4 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-01-10 Thread Wonkap Jang
In order for rate control to correctly allocate bitrate to each temporal layer, correct temporal layer id has to be set to each frame. This commit provides the ability to set correct temporal layer id for each frame. --- libavcodec/libvpxenc.c | 13 - 1 file changed, 12 insertions(+),

[FFmpeg-devel] [PATCH v4 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-10 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- doc/encoders.texi | 18 ++-

Re: [FFmpeg-devel] [PATCH v3 3/3] doc/encoders: add VP9 temporal scalability encoding option

2020-01-10 Thread Wonkap Jang
On Thu, Jan 9, 2020 at 8:09 PM James Zern wrote: > On Wed, Jan 8, 2020 at 3:00 PM Wonkap Jang > wrote: > > > > Documentation change for adding support for encoding > > with temporal scalability in VP9. > > --- > > doc/encoders.texi | 18 +++--

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-08 Thread Wonkap Jang
On Wed, Jan 8, 2020 at 3:00 PM Wonkap Jang wrote: > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be use

[FFmpeg-devel] [PATCH v3 2/3] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-01-08 Thread Wonkap Jang
In order for rate control to correctly allocate bitrate to each temporal layer, correct temporal layer id has to be set to each frame. This commit provides the ability to set correct temporal layer id for each frame. --- libavcodec/libvpxenc.c | 13 - 1 file changed, 12 insertions(+),

[FFmpeg-devel] [PATCH v3 1/3] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-08 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- libavcodec/libvpxenc.c | 251

[FFmpeg-devel] [PATCH v3 3/3] doc/encoders: add VP9 temporal scalability encoding option

2020-01-08 Thread Wonkap Jang
Documentation change for adding support for encoding with temporal scalability in VP9. --- doc/encoders.texi | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 61e674cf96..88429aed4c 100644 --- a/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2019-12-18 Thread Wonkap Jang
Hi Michael, On Wed, Dec 18, 2019 at 2:59 PM Michael Niedermayer wrote: > On Tue, Dec 17, 2019 at 02:42:21PM -0800, Wonkap Jang wrote: > > In order for rate control to correctly allocate bitrate to each temporal > > layer, correct temporal layer id has to be set to each frame.

Re: [FFmpeg-devel] [PATCH] doc/encoders: add VP9 temporal scalability encoding option

2019-12-18 Thread Wonkap Jang
Will do. Thanks! Wonkap On Wed, Dec 18, 2019 at 1:37 PM James Zern wrote: > Hi, > > On Wed, Dec 18, 2019 at 10:16 AM Wonkap Jang wrote: > > > > Hi James, > > > > Some of the changes are on lines right next to each other, and will cause > > confli

Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

2019-12-18 Thread Wonkap Jang
Hi James, I have updated the libvpx. https://chromium-review.googlesource.com/c/webm/libvpx/+/1974899 Thank you, Wonkap On Wed, Dec 18, 2019 at 1:39 PM James Zern wrote: > Hi, > > On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang > wrote: > > > > ts_target_bitrate is in kb

[FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

2019-12-18 Thread Wonkap Jang
ts_target_bitrate is in kbps, not bps. This commit clarifies the unit and modifies the example to match the description. --- doc/encoders.texi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 4ee518a124..a207363650 100644 ---

Re: [FFmpeg-devel] [PATCH] doc/encoders: add VP9 temporal scalability encoding option

2019-12-18 Thread Wonkap Jang
? Thank you, Wonkap On Tue, Dec 17, 2019 at 5:59 PM James Zern wrote: > Hi, > > On Mon, Dec 16, 2019 at 2:21 PM Wonkap Jang > wrote: > > > > Documentation change for adding support for encoding > > with temporal scalability in VP9. > > --- > > This part

[FFmpeg-devel] [PATCH v2 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2019-12-17 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- libavcodec/libvpxenc.c | 237

[FFmpeg-devel] [PATCH v2 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2019-12-17 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- libavcodec/libvpxenc.c | 237

[FFmpeg-devel] [PATCH v2 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2019-12-17 Thread Wonkap Jang
In order for rate control to correctly allocate bitrate to each temporal layer, correct temporal layer id has to be set to each frame. This commit provides the ability to set correct temporal layer id for each frame. --- libavcodec/libvpxenc.c | 11 ++- 1 file changed, 10 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add a way to explicitly set temporal layer id.

2019-12-17 Thread Wonkap Jang
Thank you Michael, There is a dependency between this patch and the one before it. I will send out a new patch with both on the same branch as PATCH 1/2 and 2/2. Thank you~ Wonkap On Tue, Dec 17, 2019 at 12:08 PM Michael Niedermayer wrote: > On Mon, Dec 16, 2019 at 02:23:26PM -0800, Won

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2019-12-17 Thread Wonkap Jang
Thank you Michael, I'll send out a new patch along with the other fix that is dependent on this one. Let's review there. Thank you, Wonkap On Tue, Dec 17, 2019 at 11:21 AM Michael Niedermayer wrote: > On Mon, Dec 16, 2019 at 02:23:00PM -0800, Wonkap Jang wrote: > > This comm

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add a way to explicitly set temporal layer id.

2019-12-16 Thread Wonkap Jang
In order for rate control to correctly allocate bitrate to each temporal layer, correct temporal layer id has to be set to each frame. This commit provides the ability to set correct temporal layer id for each frame. --- libavcodec/libvpxenc.c | 11 ++- 1 file changed, 10 insertions(+), 1

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2019-12-16 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- libavcodec/libvpxenc.c | 237

[FFmpeg-devel] [PATCH] doc/encoders: add VP9 temporal scalability encoding option

2019-12-16 Thread Wonkap Jang
Documentation change for adding support for encoding with temporal scalability in VP9. --- doc/encoders.texi | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 4ee518a124..7efc446a6c 100644 ---