Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

Do you know which spec the contains the eratta for top channels? There doesn't seem to be much of value in Amd.6. Do you have any real examples of a multichannel stream with a top center speaker or any supporting documentation you could point me at? Hi The relevant spec is ISO/IEC

Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

Le 25/10/2018 à 12:16 AM, Alex Converse a écrit : On Wed, Oct 24, 2018 at 1:03 PM pkv.stream wrote: Patch updated ; passes all FATE tests. Comments from Alex Converse review incorporated (much thanks to him). Hey, I'm a bit concerned with the outputs this generates for low channel count

[FFmpeg-devel] [PATCH v3 1/3] avcodec/aacenc: Fix LFE layouts in PCE table

Minor change from previous version (change PCE for 3.0 layout). From 11870764c2a9f3e23b710e88a897da359d686607 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 16 Sep 2018 01:41:52 +0200 Subject: [PATCH 1/3] avcodec/aacenc: Fixes in PCE table The LFE layouts were previously replaced by SCE due

[FFmpeg-devel] [PATCH v3 2/3] avcodec/aacenc: Add PCE support for 11 to 15 channels

unchanged from previous version From 85bf92a516779919399979670a185710d4616f6f Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 16 Sep 2018 01:46:05 +0200 Subject: [PATCH 2/3] avcodec/aacenc: Add PCE support for 11 to 15 channels This adds supports to 11 to 15 channels through PCE.

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

Thanks for the patch. Overall I like this approach, but this patch has some must-fix issues. In general make sure make fate-aac works with address sanitizer. Done, I have incorporated all your comments. All fate tests are successful now. Thanks very much. diff --git

[FFmpeg-devel] [PATCH v3 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

Patch updated ; passes all FATE tests. Comments from Alex Converse review incorporated (much thanks to him). From 168411206bc07d6a74097c52b3b88063591787ae Mon Sep 17 00:00:00 2001 From: pkviet Date: Wed, 24 Oct 2018 06:31:52 +0200 Subject: [PATCH 3/3] avcodec/aacdec: Translate pce to avutil

[FFmpeg-devel] [PATCH] avcodec/aacenc: Treat single channel as mono and bypass PCE

A single channel is normally interpreted as mono. However if channelsplit filter is used, the individual channels are given their channel mask (ex: FL) as channel layout. This can cause issue with the native encoder since PCE was added because only channel layouts in spec will be encoded without

[FFmpeg-devel] [PATCH v2 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

(commit message changed to include number of trac tricket solved) For context , search for the discussion: aacenc: remove unsupported PCE mappings Additional details: the aac decoder decodes PCE correctly but since avutil channel layouts are obviously not part of the spec there is no

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacenc: Fix LFE layouts in PCE table

Le 21/10/2018 à 9:08 PM, Carl Eugen Hoyos a écrit : 2018-10-21 14:22 GMT+02:00, pkv.stream : For context , search for the discussion: aacenc: remove unsupported PCE mappings Do your patches fix any of the current AAC regressions? https://trac.ffmpeg.org/ticket/7266 no; the problem is because

[FFmpeg-devel] [PATCH 1/3] avcodec/aacenc: Fix LFE layouts in PCE table

For context , search for the discussion: aacenc: remove unsupported PCE mappings From fb2b44216caa7b52d1a69ce4f03119c3473ebf45 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 16 Sep 2018 01:41:52 +0200 Subject: [PATCH 1/3] avcodec/aacenc: Fix LFE layouts in PCE table The LFE layouts were

[FFmpeg-devel] [PATCH 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

For context , search for the discussion: aacenc: remove unsupported PCE mappings Additional details: the aac decoder decodes PCE correctly but since avutil channel layouts are obviously not part of the spec there is no pre-defined one to one correspondance between ffmpeg channel layouts and

[FFmpeg-devel] [PATCH 2/3] avcodec/aacenc: Add PCE support for 11 to 15 channels

For context , search for the discussion: aacenc: remove unsupported PCE mappings From 69bb2a21b873eb0bd49bba965acb98b09b115331 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 16 Sep 2018 01:46:05 +0200 Subject: [PATCH 2/3] avcodec/aacenc: Add PCE support for 11 to 15 channels This adds

Re: [FFmpeg-devel] [PATCH] aacenc: remove unsupported PCE mappings

Le 29/08/2018 à 1:01 AM, Rostislav Pehlivanov a écrit : On 28 August 2018 at 22:29, Rostislav Pehlivanov > wrote: Turns out those ones make the decoder unable to accurately determine the layout, hence making some API users' guess, and sometimes those

Re: [FFmpeg-devel] [PATCH v4]avocdec/nvenc: Reconfigure bitrate on the fly

Le 03/05/2018 à 7:43 PM, Timo Rothenpieler a écrit : Am 03.05.2018 um 09:51 schrieb pkv.stream: Hi, in previous versions ReconfigureEncoder was called at each frame once bitrate was changed. Fixed that. The patch was rebased against https://github.com/BtbN/FFmpeg/commit

[FFmpeg-devel] [PATCH v4]avocdec/nvenc: Reconfigure bitrate on the fly

Hi, in previous versions ReconfigureEncoder was called at each frame once bitrate was changed. Fixed that. The patch was rebased against https://github.com/BtbN/FFmpeg/commit/4e8265e3a63a71a40730e8eb575d8aa760bdcddc Sorry about the back and forth. Regards From

[FFmpeg-devel] [PATCH v3]avocdec/nvenc: Reconfigure bitrate on the fly

Le 03/05/2018 à 12:21 AM, Timo Rothenpieler a écrit : Hi thanks for your feedback. I was not sure of whether to put the capability check with the others in nvenc_check_capabilities because if the cap is missing this would remove the encoder altogether: ex: ln. 453 :     if ((ret =

Re: [FFmpeg-devel] [PATCH v2]avocdec/nvenc: Reconfigure bitrate on the fly

Le 03/05/2018 à 12:21 AM, Timo Rothenpieler a écrit : Hi thanks for your feedback. I was not sure of whether to put the capability check with the others in nvenc_check_capabilities because if the cap is missing this would remove the encoder altogether: ex: ln. 453 :     if ((ret =

Re: [FFmpeg-devel] [PATCH]avocdec/nvenc: Reconfigure bitrate on the fly

Le 03/05/2018 à 12:14 AM, Timo Rothenpieler a écrit : Am 02.05.2018 um 23:58 schrieb Timo Rothenpieler: Am 02.05.2018 um 23:18 schrieb pkv.stream: Hello, The patch enables dynamic bitrate through ReconfigureEncoder method from nvenc API. This is useful for live streaming in case of network

Re: [FFmpeg-devel] [PATCH]avocdec/nvenc: Reconfigure bitrate on the fly

Le 02/05/2018 à 11:58 PM, Timo Rothenpieler a écrit : Am 02.05.2018 um 23:18 schrieb pkv.stream: Hello, The patch enables dynamic bitrate through ReconfigureEncoder method from nvenc API. This is useful for live streaming in case of network congestion. A similar patch for changing aspect

[FFmpeg-devel] [PATCH]avocdec/nvenc: Reconfigure bitrate on the fly

Hello, The patch enables dynamic bitrate through ReconfigureEncoder method from nvenc API. This is useful for live streaming in case of network congestion. A similar patch for changing aspect ratio dynamically was previously submitted by Miroslav Slugen:

Re: [FFmpeg-devel] ffmpeg_opt.c wrong parameter for Filter

Le 29/03/2018 à 2:53 PM, sebastian-doerf...@t-online.de a écrit : use the ost->enc_ctx->channel_layout for f->channel_layout not f->channel_layout = av_get_default_channel_layout(ost->enc_ctx->channels); ffmpeg_opt.c static int open_output_file(OptionsContext *o, const char

[FFmpeg-devel] [DEVEL][PATCH] ffmpeg: Fix channel_layout bug on non-default layout

Hi Michael, this is a ping. You had reviewed earlier versions of the patch but had left the latest version without comments (3 months ago). This is a patch for ticket 6706 : The -channel_layout option is not working when the channel layout is not a default one (ex: for 4 channels, quad is

Re: [FFmpeg-devel] [DEVEL][PATCH 2/2] ffmpeg: fix ticket 6706

sorry wrong patch, discard previous for this one ! From 532b13fb2a174af0b91a0b08984cbdb8d5027392 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sat, 18 Nov 2017 00:26:50 +0100 Subject: [PATCH 2/2] ffmpeg: fix ticket 6706 Fix regression with channel_layout option which is

[FFmpeg-devel] [DEVEL][PATCH 2/2] ffmpeg: fix ticket 6706

From 532b13fb2a174af0b91a0b08984cbdb8d5027392 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sat, 18 Nov 2017 00:26:50 +0100 Subject: [PATCH 2/2] ffmpeg: fix ticket 6706 Fix regression with channel_layout option which is not passed correctly from output streams to filters

[FFmpeg-devel] [DEVEL][PATCH 1/2] ffmpeg: parse duplicate option

Le 19/11/2017 à 8:28 PM, Michael Niedermayer a écrit : On Sun, Nov 19, 2017 at 11:01:37AM +0100, pkv.stream wrote: [...] @@ -3674,6 +3697,10 @@ const OptionDef options[] = { { "channel_layout", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE |

Re: [FFmpeg-devel] [DEVEL][PATCH 2/2] ffmpeg: fix ticket 6706

Le 19/11/2017 à 8:28 PM, Michael Niedermayer a écrit : On Sun, Nov 19, 2017 at 11:01:37AM +0100, pkv.stream wrote: [...] @@ -3674,6 +3697,10 @@ const OptionDef options[] = { { "channel_layout", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE |

[FFmpeg-devel] [DEVEL][PATCH 1/2] ffmpeg: add ui64 type to SpecifierOpt

Hi Michael Tell me the best course; or if you see a way to make my MATCH_PER_STREAM_OPT() code less hacky. iam sure theres a way to do this less hacky why do you need a 2nd table ? or rather why does it not work if you put the entry in the main table ? (so there are 2 entries one for OPT_SPEC

[FFmpeg-devel] [DEVEL][PATCH 2/2] ffmpeg: fix ticket 6706

From f94f2e8c8878d6dbda540b19d90c2b8f1ba00850 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sat, 18 Nov 2017 00:26:50 +0100 Subject: [PATCH 2/2] ffmpeg: fix ticket 6706 Fix regression with channel_layout option which is not passed correctly from output streams to filters

Re: [FFmpeg-devel] [DEVEL][PATCH v3] ffmpeg: fix channel_layout bug on non-default layout

Le 18/11/2017 à 9:26 PM, Michael Niedermayer a écrit : On Sat, Nov 18, 2017 at 11:41:54AM +0100, pkv.stream wrote: Hi Michael ffmpeg_opt.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) a7c71fb1ccd7d91b61033be70dfd324b4e3f3c34 0001-ffmpeg-fix-channel_layout-bug

Re: [FFmpeg-devel] [DEVEL][PATCH v3] ffmpeg: fix channel_layout bug on non-default layout

Hi Michael ffmpeg_opt.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) a7c71fb1ccd7d91b61033be70dfd324b4e3f3c34 0001-ffmpeg-fix-channel_layout-bug-on-non-default-layout.patch From fb7f7f6e01cc242e13d0e640f583dffe6e7a8ada Mon Sep 17 00:00:00 2001 From:

Re: [FFmpeg-devel] [DEVEL][PATCH v3] ffmpeg: fix channel_layout bug on non-default layout

Le 14/11/2017 à 1:13 PM, Michael Niedermayer a écrit : On Sun, Nov 12, 2017 at 06:26:18PM +0100, pkv.stream wrote: Le 12/11/2017 à 5:38 PM, Michael Niedermayer a écrit : On Sun, Nov 12, 2017 at 05:07:04PM +0100, Kv Pham wrote: Le 12 nov. 2017 5:01 PM, "Michael Niedermayer&

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 14/11/2017 à 11:14 PM, Carl Eugen Hoyos a écrit : 2017-11-14 21:01 GMT+01:00 pkv.stream <pkv.str...@gmail.com>: Le 14/11/2017 à 1:20 AM, Carl Eugen Hoyos a écrit : 2017-11-09 9:01 GMT+01:00 pkv.stream <pkv.str...@gmail.com>: 1) there are changes to make to the list of cha

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 14/11/2017 à 1:20 AM, Carl Eugen Hoyos a écrit : 2017-11-09 9:01 GMT+01:00 pkv.stream <pkv.str...@gmail.com>: 1) there are changes to make to the list of channel layouts not requiring PCE ==> AV_CH_LAYOUT_5POINT0 to AV_CH_LAYOUT_5POINT0_BACK since the previous is 5.0(side) while t

[FFmpeg-devel] [DEVEL][PATCH v3] ffmpeg: fix channel_layout bug on non-default layout

Le 12/11/2017 à 5:38 PM, Michael Niedermayer a écrit : On Sun, Nov 12, 2017 at 05:07:04PM +0100, Kv Pham wrote: Le 12 nov. 2017 5:01 PM, "Michael Niedermayer" <mich...@niedermayer.cc> a écrit : On Sat, Nov 11, 2017 at 02:15:25AM +0100, pkv.stream wrote: Le 11/11/2017 à

Re: [FFmpeg-devel] [DEVEL][PATCH v2] ffmpeg: fix channel_layout bug on non-default layout

Le 12/11/2017 à 5:38 PM, Michael Niedermayer a écrit : On Sun, Nov 12, 2017 at 05:07:04PM +0100, Kv Pham wrote: Le 12 nov. 2017 5:01 PM, "Michael Niedermayer" <mich...@niedermayer.cc> a écrit : On Sat, Nov 11, 2017 at 02:15:25AM +0100, pkv.stream wrote: Le 11/11/2017 à

Re: [FFmpeg-devel] [DEVEL][PATCH v2] ffmpeg: fix channel_layout bug on non-default layout

Le 12/11/2017 à 5:00 PM, Michael Niedermayer a écrit : On Sat, Nov 11, 2017 at 02:15:25AM +0100, pkv.stream wrote: Le 11/11/2017 à 1:07 AM, Michael Niedermayer a écrit : On Fri, Nov 10, 2017 at 10:27:48PM +0100, pkv.stream wrote: Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu

Re: [FFmpeg-devel] [DEVEL][PATCH v2] ffmpeg: fix channel_layout bug on non-default layout

Le 11/11/2017 à 1:07 AM, Michael Niedermayer a écrit : On Fri, Nov 10, 2017 at 10:27:48PM +0100, pkv.stream wrote: Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file

[FFmpeg-devel] [DEVEL][PATCH v2] ffmpeg: fix channel_layout bug on non-default layout

Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823 0001-ffmpeg-fix-channel_layout-bug

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823 0001-ffmpeg-fix-channel_layout-bug

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823 0001-ffmpeg-fix-channel_layout-bug

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823 0001-ffmpeg-fix-channel_layout-bug

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823 0001-ffmpeg-fix-channel_layout-bug-on-non-default-layout.patch From 4ec55dc88923108132307b41300a1abddf32e6f7 Mon Sep 17 00:00:00 2001 From: pkviet

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 09/11/2017 à 4:43 AM, Rostislav Pehlivanov a écrit : On 18 October 2017 at 11:05, pkv.stream <pkv.str...@gmail.com> wrote: Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : On 2 October 2017 at 18:43, pkv.stream <pkv.str...@gmail.com> wrote: Le 02/10/2017 à 7:23

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegts: opus muxing & demuxing expanded

Le 05/11/2017 à 9:35 PM, Carl Eugen Hoyos a écrit : 2017-09-01 1:10 GMT+02:00 pkv.stream <pkv.str...@gmail.com>: Hello per Michael requests: 1) I have split patch in 2 2) added malloc checks 3) changed "for int" loop to C89 style (if I understood well the comment) regard

[FFmpeg-devel] [PATCH v6 1/2 ] avformat/mpegts: opus muxing for mapping family 255

Le 29/10/2017 à 4:44 PM, Michael Niedermayer a écrit : On Sat, Oct 28, 2017 at 03:49:13AM +0200, pkv.stream wrote: mpegtsenc.c | 67 +--- 1 file changed, 60 insertions(+), 7 deletions(-) 1423a193788547952e3c4cdcb424b4724b0f1157

[FFmpeg-devel] [PATCH v6 2/2 ] avformat/mpegts: opus demuxing for mapping family 255

Le 31/10/2017 à 6:28 PM, Michael Niedermayer a écrit : mpegts.c | 84 --- 1 file changed, 70 insertions(+), 14 deletions(-) 6648bab53735f1efaf0d6cd698dbc2398b483c3f 0002-libavf-mpegts-opus-demuxing-for-mapping-family-255.patch From

[FFmpeg-devel] [PATCH v5 1/2 ] avformat/mpegts: opus muxing for mapping family 255

Le 29/10/2017 à 4:44 PM, Michael Niedermayer a écrit : On Sat, Oct 28, 2017 at 03:49:13AM +0200, pkv.stream wrote: mpegtsenc.c | 67 +--- 1 file changed, 60 insertions(+), 7 deletions(-) 1423a193788547952e3c4cdcb424b4724b0f1157

[FFmpeg-devel] [PATCH v5 2/2 ] avformat/mpegts: opus demuxing for mapping family 255

minor change, adding a test for number of channels for mapping_family 1 when channel_config_code is > 0x82 Passes fate + patcheck. Regards pkv From 2e0504728b81e0f35ba856c24cff14fa70680d8b Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 29 Oct 2017 22:57:25 +0100 Subject:

[FFmpeg-devel] [PATCH v4 0/2 ] avformat/mpegts: opus muxing & demuxing for mapping family 255

int ff_parse_mpeg2_descriptor(AVFormatContext *fc, AVStream *st, int stream_type, const uint8_t **pp, const uint8_t *desc_list_end, Mp4Descr *mp4_descr, int mp4_descr_count, int pid, @@ -1887,9 +1898,56 @@ int

[FFmpeg-devel] [PATCH v4 1/2 ] avformat/mpegts: opus muxing for mapping family 255

From 105f20b8af8ce5376165ca30a81276dae2e61e40 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sat, 28 Oct 2017 02:48:08 +0200 Subject: [PATCH 1/2] libavf/mpegts: opus muxing for mapping family 255 Adds to mpegts muxer the capability to mux libopus with mapping family 255,

[FFmpeg-devel] [PATCH v4 2/2 ] avformat/mpegts: opus demuxing for mapping family 255

From 07708cda56bf59606b143db65359de6c0a058ce8 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sat, 28 Oct 2017 02:48:39 +0200 Subject: [PATCH 2/2] libavf/mpegts: opus demuxing for mapping family 255 Adds to mpegts muxer the capability to demux libopus with mapping family

Re: [FFmpeg-devel] [PATCHv3] avformat/mpegts: opus muxing & demuxing for mapping family 255

Le 14/09/2017 à 6:48 PM, pkv.stream a écrit : Thanks for your comments Moritz. Corrected patch in attachment. Regards Le 14/09/2017 à 5:46 PM, Moritz Barsnick a écrit : On Fri, Sep 08, 2017 at 01:46:38 +0200, pkv.stream wrote: - avpriv_request_sample(fc, "Opus in MPEG-TS - channel_config

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : On 2 October 2017 at 18:43, pkv.stream <pkv.str...@gmail.com> wrote: Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Le 04/10/2017 à 11:18 PM, Moritz Barsnick a écrit : On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: if (!ost->stream_copy) { -char *sample_fmt = NULL; + + char *sample_fmt = NULL; This is very obviously a patch which will not be accep

Re: [FFmpeg-devel] [PATCHv3] avformat/mpegts: opus muxing & demuxing for mapping family 255

Le 15/09/2017 à 10:33 PM, Michael Niedermayer a écrit : On Wed, Sep 13, 2017 at 09:36:25PM +0200, pkv.stream wrote: Le 08/09/2017 à 1:46 AM, pkv.stream a écrit : Hi, I've removed inline declarations in the patch since they're not accepted in ffmpeg. Thanks for any more comments or reviews

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Le 02/10/2017 à 9:50 PM, pkv.stream a écrit : Thanks Michael; replaced the offending MSVC function. Le 02/10/2017 à 9:35 PM, Michael Niedermayer a écrit : On Sun, Oct 01, 2017 at 03:17:30AM +0200, pkv.stream wrote: Hello the submitted patch addresses the regression discussed in ticket #6706

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Thanks Michael; replaced the offending MSVC function. Le 02/10/2017 à 9:35 PM, Michael Niedermayer a écrit : On Sun, Oct 01, 2017 at 03:17:30AM +0200, pkv.stream wrote: Hello the submitted patch addresses the regression discussed in ticket #6706. <https://trac.ffmpeg.org/ticket/6

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : 2017-10-02 0:40 GMT+02:00 pkv.stream <pkv.str...@gmail.com>: Hi atomnuker, got your PCE working; the patch you at

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

forgot to say a few things: - only the order and the type of the element (sce, cpe or lfe) really matters for the encoding; the encoder does not use the front, side or back info; I have used that fact for instance for 7.1 and 7.1(wide) or 7.1(wide-side): same PCE config can be used and works

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : 2017-10-02 0:40 GMT+02:00 pkv.stream <pkv.str...@gmail.com>: Hi atomnuker, got your PCE working; the patch you attached contains tabs, they cannot be committed to the FFmpeg repository, please remove them. (Or one tab.)

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Hi atomnuker, got your PCE working; my previous issues where index related and were the reasons ffmpeg aac decoder would issue errors. So found out: - index is not reset between groups of front, side, back; - it runs actually for each type (SCE, CPE, LFE) - for ffmpeg aac decoder to work, the

[FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

Hello the submitted patch addresses the regression discussed in ticket #6706. The -channel_layout option is not working when the channel layout is not a default one (ex: for 4 channels, quad is interpreted as 4.0 which is the default layout for 4

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 24/09/2017 à 5:06 PM, Rostislav Pehlivanov a écrit : On 24 September 2017 at 15:27, pkv.stream <pkv.str...@gmail.com> wrote: Hi atomnuker and others I am interested in working on this patch by atomnuker who did a great job. This could allow encoding to more channels with aa

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

link to original thread: http://ffmpeg.org/pipermail/ffmpeg-devel/2016-October/200566.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Hi atomnuker and others I am interested in working on this patch by atomnuker who did a great job. This could allow encoding to more channels with aac (e.g. ambisonics order three = 16 audio channels). Here's a report about additions I made to the PCE table for all the basic ffmpeg channel

Re: [FFmpeg-devel] [PATCHv3] avformat/mpegts: opus muxing & demuxing for mapping family 255

Thanks for your comments Moritz. Corrected patch in attachment. Regards Le 14/09/2017 à 5:46 PM, Moritz Barsnick a écrit : On Fri, Sep 08, 2017 at 01:46:38 +0200, pkv.stream wrote: -avpriv_request_sample(fc, "Opus in MPEG-TS - channel_config_code

Re: [FFmpeg-devel] [PATCHv3] avformat/mpegts: opus muxing & demuxing for mapping family 255

Le 08/09/2017 à 1:46 AM, pkv.stream a écrit : Hi, I've removed inline declarations in the patch since they're not accepted in ffmpeg. Thanks for any more comments or reviews. Regards bump, initial submission 08/29 Got some comments from Michael (thanks again Michael) but that's all

[FFmpeg-devel] [PATCHv3] avformat/mpegts: opus muxing & demuxing for mapping family 255

Hi, I've removed inline declarations in the patch since they're not accepted in ffmpeg. Thanks for any more comments or reviews. Regards From d05c62039b3edfd151b8c3824cc8f509f9ea8053 Mon Sep 17 00:00:00 2001 From: pkviet Date: Tue, 29 Aug 2017 01:24:12 +0200 Subject:

[FFmpeg-devel] [PATCH 2/2] avocdec/libopus: fix typo

small typo fix From 5dabf59f9f070c7d23da03979f06c136fa6817b4 Mon Sep 17 00:00:00 2001 From: pkviet Date: Fri, 1 Sep 2017 00:44:11 +0200 Subject: [PATCH 2/2] avocdec/libopus: fix typo --- libavcodec/libopusenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 1/2] avformat/mpegts: opus muxing & demuxing expanded

Hello per Michael requests: 1) I have split patch in 2 2) added malloc checks 3) changed  "for int" loop to C89 style (if I understood well the comment) regards libavcodec/libopusenc.c |2 - libavformat/mpegts.c| 54 +---

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: opus muxing & demuxing expanded

This is missing malloc failure checks, also the "for (int i" syntax is something we avoid due to some at least past portability issues. thanks a lot. Will fix. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avformat/mpegts: opus muxing & demuxing expanded

Hello again (patch attached this time), this patch expands support for mapping_family 255 (and part of 1) for mpegts muxer and demuxer. (Ambisonics family 2 & 3 not covered). See commit commentary. My case use (as an example) is that I needed to broadcast in mpeg-ts with 16 audio channels

[FFmpeg-devel] [PATCH] avformat/mpegts: opus muxing & demuxing expanded

Hello, this patch expands support for mapping_family 255 (and part of 1) for mpegts muxer and demuxer. (Ambisonics family 2 & 3 not covered). See commit commentary. My case use (as an example) is that I needed to broadcast in mpeg-ts with 16 audio channels coming from SDI, corresponding to

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

Le 27/08/2017 à 6:14 PM, Marton Balint a écrit : On Wed, 23 Aug 2017, pkv.stream wrote: Hello the following patch extends number of output channel for decklink devices to 16. Previously it was limited to 2 or 8 audio channels. Thanks for any comments. Thanks, applied. Regards, Marton

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Thanks a lot Martin !!! all sorted out thanks to your kind help. I had run fate previously but obviously missed something; so re-run and it's ok. I created two tests per your advice testing for a third channel in a stereo file and then in a 2.1 file. Instead of CRC, I've used MD5 because the

[FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Hi working on creating a fate test. I am stumbling on probably a dumb issue; I want to re-use a file already used for mapchan test: FATE_MAPCHAN-$(CONFIG_CHANNELMAP_FILTER) += fate-mapchan-6ch-extract-2 fate-mapchan-6ch-extract-2: tests/data/asynth-22050-6.wav (first two lines in ffmpeg.mak)

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: Hello, the following patch allows one to add a trailing ? to -map_channel as in -map option. E.g: -map_channel 0.0.2? so that if the channel does not exist, the command does

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

to whatever you need to transport. you provided the right answer to wm4; I had not understood his question. Thanks. @pkv.stream: HDMI 1.x does only support up to 8 channels (7.1), which might be the reason for the missing 16. Did you test what happens when 16 audio channels are requested for HDMI out

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

Le 23/08/2017 à 7:28 PM, wm4 a écrit : On Wed, 23 Aug 2017 18:51:45 +0200 "pkv.stream" <pkv.str...@gmail.com> wrote: Hello the following patch extends number of output channel for decklink devices to 16. Previously it was limited to 2 or 8 audio channels. Thanks for any c

[FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

Hello the following patch extends number of output channel for decklink devices to 16. Previously it was limited to 2 or 8 audio channels. Thanks for any comments. From 681e389e4946e079d7db5892f98a82a5b75ad297 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 2 Jul

[FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Hello, the following patch allows one to add a trailing ? to -map_channel as in -map option. E.g: -map_channel 0.0.2? so that if the channel does not exist, the command does not stop. This is similar to what one can do with -map. Thanks for any input. From