Re: [FFmpeg-devel] tools: crypto_bench: Added support for Twofish

2015-02-21 Thread supraja reddy
Hello, I have made the changes as suggested by Giorgio. Please let me know if any further changes required. Thanks, Supraja On Wed, Feb 18, 2015 at 10:52 PM, Giorgio Vazzana wrote: > Hi, > > 2015-02-14 11:12 GMT+01:00 Giorgio Vazzana : > > Hi, > > > > 2015-02-14 9

[FFmpeg-devel] tests: fate: adding fate-test for twofish

2015-02-18 Thread supraja reddy
Hello, I have attached a patch to add fate-test for twofish. Thanks, Supraja From 577cb83254a0474ef303ec6531304705587f2a94 Mon Sep 17 00:00:00 2001 From: Supraja Meedinti Date: Wed, 18 Feb 2015 18:43:03 +0530 Subject: [PATCH] tests: fate: adding fate-test for twofish Signed-off-by: Supraja Meed

Re: [FFmpeg-devel] libavutil: optimize twofish cipher

2015-02-17 Thread supraja reddy
Hello, I have made changes as suggested. Please let me know if any further changes required. I will soon send a patch for adding a fate test too. Thanks, Supraja On Mon, Feb 16, 2015 at 5:10 PM, Michael Niedermayer wrote: > On Mon, Feb 16, 2015 at 03:11:08PM +0530, supraja reddy wr

[FFmpeg-devel] libavutil: optimize twofish cipher

2015-02-16 Thread supraja reddy
Hello, I have attached a patch with optimization for twofish. Please let me know if any further changes required. Following are the results for crypto_bench after optimization. lavu TWOFISH size: 1048576 runs: 1024 time: 18.799 +- 0.132 gcrypt TWOFISH size: 1048576 run

Re: [FFmpeg-devel] libavutil: optimize camellia cipher

2015-02-14 Thread supraja reddy
Hello, Here are the results. lavu CAMELLIA size: 1048576 runs: 1024 time: 21.476 +- 0.034 crypto CAMELLIA size: 1048576 runs: 1024 time: 20.184 +- 0.043 gcrypt CAMELLIA size: 1048576 runs: 1024 time: 64.362 +- 1.031 tomcrypt CAMELLIA size: 1048576

[FFmpeg-devel] tools: crypto_bench: Added support for Twofish

2015-02-14 Thread supraja reddy
Hello, I have added the necessary functions for twofish in crypto_bench. A note, there is no twofish implementation in openssl library but since the code demands that all the libraries have the impl, i have introduced a dummy function. Please let me know if anything has to be changed. Thanks, Sup

Re: [FFmpeg-devel] libavutil: optimize camellia cipher

2015-02-10 Thread supraja reddy
Hello, > +AV_WB64(y,KE); > > + > KE=SP[0][y[0]]^SP[1][y[1]]^SP[2][y[2]]^SP[3][y[3]]^SP[4][y[4]]^SP[5][y[5]]^SP[6][y[6]]^SP[7][y[7]]; > > +return KE; > > have you tried it without the y[] array ? > storing and loading from memory may (or may not) be slower I have tried without y[] array.

[FFmpeg-devel] libavutil: optimize camellia cipher

2015-02-09 Thread supraja reddy
Hello, I have attached a patch to optimize the camellia block cipher. I ran crypto_bench on the optimized version. Here are the results of runtime using crypto_bench. Before the changes : lavu CAMELLIA size: 1048576 runs: 1024 time: 32.541 +- 0.044 After the changes: lavu C

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-27 Thread supraja reddy
Hello, > +for (i = 0; i < cs->ksize; i++) { > > +Me[i] = Key[2 * i]; > > +Mo[i] = Key[2 * i + 1]; > > +} > > +for (i = 0; i < cs->ksize; i++) > > +cs->S[cs->ksize - i - 1] = tf_RS(Me[i], Mo[i]); > > Can't the previous two for loops be merged together? > > You wa

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-25 Thread supraja reddy
Sorry. I forgot to make a small change. Updated the patch. Thanks, Supraja On Mon, Jan 26, 2015 at 12:12 AM, supraja reddy wrote: > Hello, > > I have made all the changes as suggested. If the number of if-else loops > in init() seem to be too many, please let me know I will cha

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-25 Thread supraja reddy
Hello, I have made all the changes as suggested. If the number of if-else loops in init() seem to be too many, please let me know I will change it but I have put them to handle the return values and overflow issues. If there are any other changes, please let me know. Thanks, Supraja On Sun, Jan

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-20 Thread supraja reddy
15, 2015 at 10:21:22PM +0530, supraja reddy wrote: > > Hello, > > > > I have attached the patch for twofish implementation. Please let me know > if > > there are any changes to be made. > > > > Thank you, > > > > Supraja > > [...

[FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-15 Thread supraja reddy
Hello, I have attached the patch for twofish implementation. Please let me know if there are any changes to be made. Thank you, Supraja From f86554850a8b0be2e32fcd341ca297c7ce73a941 Mon Sep 17 00:00:00 2001 From: Supraja Meedinti Date: Thu, 15 Jan 2015 21:35:16 +0530 Subject: [PATCH] libavutil:

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2015-01-02 Thread supraja reddy
Hello, I have modified the LR128 function slightly to make it more compact. Thanks, Supraja On Wed, Dec 31, 2014 at 9:53 PM, supraja reddy wrote: > Hello, > > I have made the following changes. > > > create mode 100644 libavutil/camellia.h >> >> Missing change

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-31 Thread supraja reddy
Hello, I have made the following changes. > create mode 100644 libavutil/camellia.h > > Missing changelog entry. > I have updated the changelog. I had earlier ignored this because i also had to update changelog for cast128 cbc mode and wanted to do both together. > > We don't need it in this ca

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-29 Thread supraja reddy
Hello, I have updated the patch. Please let me know if any further changes are required. Thanks, Supraja On Sat, Dec 27, 2014 at 11:04 PM, Giorgio Vazzana wrote: > 2014-12-26 20:01 GMT+01:00 Michael Niedermayer : > > [...] > > > >> +static uint64_t F(uint64_t F_IN, uint64_t KE) > >> +{ > >> +

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-26 Thread supraja reddy
Hello, I made a small change in the decrypt function which I should have done so earlier. Please let me know of the further changes/fixes. Thanks, Supraja On Thu, Dec 25, 2014 at 4:11 AM, supraja reddy wrote: > Hello, > > Thank you for your reviews. I have attached the upda

Re: [FFmpeg-devel] libavutil: added camellia block cipher

2014-12-24 Thread supraja reddy
Hello, Thank you for your reviews. I have attached the updated patch . You are using a single array K for all the keys, without distinguishing > between > kw, k and ke as in the rfc. This makes code harder to read/maintain with no > real gain I guess. Any reason why you made this decision? > I h

[FFmpeg-devel] libavutil: added camellia block cipher

2014-12-23 Thread supraja reddy
Hello , I have attached the patch to the basic implementation of camellia block cipher. Please let me know if there are any bugs to be fixed or if any further optimization needed. Thanks , Supraja From 4ace69c4cc76f04e0e795e67290e979925df600c Mon Sep 17 00:00:00 2001 From: Supraja Meedinti Date

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-18 Thread supraja reddy
Updated patch . Thanks, Supraja On Fri, Dec 19, 2014 at 3:01 AM, Giorgio Vazzana wrote: > > 2014-12-18 11:09 GMT+01:00 supraja reddy : > > Sorry for the mistake . I seem to have got cbc completely wrong. > > I have made the changes . Please let me know if there is

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-18 Thread supraja reddy
Sorry for the mistake . I seem to have got cbc completely wrong. I have made the changes . Please let me know if there is anything missing. Supraja On Thu, Dec 18, 2014 at 2:57 PM, Giorgio Vazzana wrote: > > Hello, > > 2014-12-17 19:53 GMT+01:00 supraja reddy : > > I hope

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-17 Thread supraja reddy
I hope this fixes all the issues . Supraja On Wed, Dec 17, 2014 at 10:54 PM, Giorgio Vazzana wrote: > > Hello, > > 2014-12-17 10:27 GMT+01:00 Carl Eugen Hoyos : > > supraja reddy gmail.com> writes: > > > >> -- CAST128 symmetric block cipher, ECB mode &g

[FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-16 Thread supraja reddy
Hi , Attached patch adds cbc mode to the existing code. Supraja From 3255d0bbaf31bf3c39b0e22882e52b34882f37d4 Mon Sep 17 00:00:00 2001 From: Supraja Meedinti Date: Wed, 17 Dec 2014 10:16:43 +0530 Subject: [PATCH] libavutil: Added cbc mode to cast128 Signed-off-by: Supraja Meedinti --- Changel

Re: [FFmpeg-devel] libavutil : cosmetic: added spaces wherever necessary

2014-12-16 Thread supraja reddy
I hope this fixes the issues . Supraja On Tue, Dec 16, 2014 at 9:11 PM, Giorgio Vazzana wrote: > > Hi, > > 2014-12-16 10:30 GMT+01:00 supraja reddy : > > Hi, > > > > Attached patch adds some missing spaces in the cast5.c and cast5.h > > > > Please

[FFmpeg-devel] libavutil : cosmetic: added spaces wherever necessary

2014-12-16 Thread supraja reddy
Hi, Attached patch adds some missing spaces in the cast5.c and cast5.h Please let me know if any further changes needed. Supraja From fe99657fdd233a65f5a09167aa3d5cdb5da4f842 Mon Sep 17 00:00:00 2001 From: Supraja Meedinti Date: Mon, 15 Dec 2014 19:22:36 +0530 Subject: [PATCH] libavutil: cosmet

Re: [FFmpeg-devel] [PATCH] tools/crypto_bench: add CAST5 support

2014-10-20 Thread supraja reddy
Glad to hear that !! :) Supraja ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-17 Thread supraja reddy
Hello , Updated the changes in the patch . Please let me know if any further changes required . Thanks , Supraja On Fri, Oct 17, 2014 at 9:21 AM, Michael Niedermayer wrote: > On Thu, Oct 16, 2014 at 11:09:27PM +0530, supraja reddy wrote: > > Updated the patch . > > Please let m

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-16 Thread supraja reddy
Updated the patch . Please let me know if there are any other changes needed . Thanks , Supraja On Thu, Oct 16, 2014 at 1:37 PM, Giorgio Vazzana wrote: > Hi, > > 2014-10-16 5:32 GMT+02:00 Michael Niedermayer : > > On Thu, Oct 16, 2014 at 03:25:42AM +0530, supraja reddy wrote:

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-15 Thread supraja reddy
Extremely sorry for resending the patch . There was a trailing whitespace which I hadn't corrected . All the changes are done . Please let me if any changes needed further . Thanks , Supraja On Thu, Oct 16, 2014 at 2:28 AM, supraja reddy wrote: > Hello , > > I hadn't rebas

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-15 Thread supraja reddy
Hello , I hadn't rebased my branch . This is after the sync . Apologies for the error . Thanks , Supraja On Thu, Oct 16, 2014 at 12:50 AM, supraja reddy wrote: > I have updated the changes as requested . Please look into the attached > patch and let me know if there is anythi

Re: [FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-15 Thread supraja reddy
I have updated the changes as requested . Please look into the attached patch and let me know if there is anything else you wish me to change. Thanks , Supraja On Sun, Oct 12, 2014 at 8:38 PM, Giorgio Vazzana wrote: > 2014-10-12 13:59 GMT+02:00 supraja reddy : > > Hello , > >

[FFmpeg-devel] Patch for Cast128 algorithm implementation

2014-10-12 Thread supraja reddy
Hello , I , Supraja , am interested to work with ffmpeg as a part of OPW internship . As a part of the qualification task , I have taken up the implementation of Cast 128 algorithm implementation . I have written the code for the same and have attached the patch of the same with this mail . It is