Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Wu Zhiqiang (2017-12-30): > Thanks for the patch, it works fine to me. > Disable is good enough to prevent unnecessary wrap control. Thanks for the testing. Patch pushed. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

2017年12月30日 下午7:30，"Nicolas George" 写道： Wu Zhiqiang (2017-12-30): > The command to generate sample video: > > ffmpeg -f lavfi -i testsrc=duration=120 -c:v h264 -profile:v high -level:v > 10 -pix_fmt yuv420p -r 30 -g 30 -c:a aac test.flv > echo -e "file test.flv\nduration 120" >

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Wu Zhiqiang (2017-12-30): > The command to generate sample video: > > ffmpeg -f lavfi -i testsrc=duration=120 -c:v h264 -profile:v high -level:v > 10 -pix_fmt yuv420p -r 30 -g 30 -c:a aac test.flv > echo -e "file test.flv\nduration 120" > playlist > ffplay -f concat playlist -ss 90

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

On Sat, Dec 30, 2017 at 5:19 AM, Carl Eugen Hoyos wrote: > 2017-12-29 18:38 GMT+01:00 Nicolas George : > > > I am sorry, I do not understand what you are saying at all. > > > > Maybe it would help if you were to give a fully detailed of the simplest > > use

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

2017-12-29 18:38 GMT+01:00 Nicolas George : > I am sorry, I do not understand what you are saying at all. > > Maybe it would help if you were to give a fully detailed of the simplest > use case you are trying to fix Maybe ticket #6908? Carl Eugen

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Wu Zhiqiang (2017-12-30): > But how to decide wrap margin that concat see? > Though monotonic timestamp is always ok, > I do not want that sub-demuxer see unwrapped timestamp but concat see > wrapped one . > Or sub-demuxer disable wrap correction but concat enable it. I am sorry, I do not

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

2017年12月30日 上午12:30，"Nicolas George" 写道： Wu Zhiqiang (2017-12-30): > Normally pts_wrap_reference is based on the first packet when calling > ff_read_packet, > which will call function update_wrap_reference , in libavformat/utils line > 734: > > if (ref == AV_NOPTS_VALUE) >

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Wu Zhiqiang (2017-12-30): > Normally pts_wrap_reference is based on the first packet when calling > ff_read_packet, > which will call function update_wrap_reference , in libavformat/utils line > 734: > > if (ref == AV_NOPTS_VALUE) > ref = pkt->pts; > if (st->pts_wrap_reference !=

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

On Fri, Dec 29, 2017 at 8:00 PM, Nicolas George wrote: > Hi. Sorry for having missed your reply earlier. > > 吴志强 (2017-12-18): > > I see wrap timestamp control is enable by pts_wrap_bits(default 33), > > but mp4 demuxer will later set this to 64 (means disabled). > > Now

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Hi. Sorry for having missed your reply earlier. 吴志强 (2017-12-18): > I see wrap timestamp control is enable by pts_wrap_bits(default 33), > but mp4 demuxer will later set this to 64 (means disabled). > Now pts_wrap_bits are always tied to 33 without copy it, which seems > strange. I understand

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

Thanks for your replay. I see wrap timestamp control is enable by pts_wrap_bits(default 33), but mp4 demuxer will later set this to 64 (means disabled). Now pts_wrap_bits are always tied to 33 without copy it, which seems strange. Normally the pts_wrap_reference is based on first packet of a

Re: [FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

mymoey...@gmail.com (2017-12-14): > From: Wu Zhiqiang > > When using concat protocol, start from middle of file will generate non-zero > wrap reference. > If seek to time before the wrap reference, wrap control will generate wrong > wrapped timestamp. > Copy wrap related

[FFmpeg-devel] [PATCH, V2] avformat/concat: Fix wrong wrapped timestamp

From: Wu Zhiqiang When using concat protocol, start from middle of file will generate non-zero wrap reference. If seek to time before the wrap reference, wrap control will generate wrong wrapped timestamp. Copy wrap related stream properties when reading header can fix