Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-17 Thread Michael Niedermayer
On Tue, Mar 17, 2015 at 07:44:54AM -0500, Jeremy Luce wrote: It appears that c/C doesn't pause the input threads, which results in higher CPU usage than the 'p' pause method. Also, since the input threads continue to read data, the input buffer will continue to grow, which may lead to

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-17 Thread Jeremy Luce
It appears that c/C doesn't pause the input threads, which results in higher CPU usage than the 'p' pause method. Also, since the input threads continue to read data, the input buffer will continue to grow, which may lead to undesirable results. I'm not sure if this is by design or not, so I'm

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-16 Thread Jeremy Luce
Here is the updated patch with documentation and proper line breaks. Jeremy On Fri, Mar 13, 2015 at 1:02 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Mar 11, 2015 at 08:34:39AM -0500, Jeremy Luce wrote: Resubmitting with [PATCH] tag and unified diff. Adds functionality to pause

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-16 Thread Michael Niedermayer
On Mon, Mar 16, 2015 at 11:23:33AM -0500, Jeremy Luce wrote: Here is the updated patch with documentation and proper line breaks. Jeremy On Fri, Mar 13, 2015 at 1:02 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Mar 11, 2015 at 08:34:39AM -0500, Jeremy Luce wrote: Resubmitting

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-14 Thread compn
On Wed, 11 Mar 2015 08:34:39 -0500 Jeremy Luce jeremyl...@gmail.com wrote: Resubmitting with [PATCH] tag and unified diff. Adds functionality to pause transcoding with 'p' key and upause with 'u' key over stdin. Pauses in the main transcode loop as well as the input_thread loop. did not

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Michael Niedermayer
On Wed, Mar 11, 2015 at 08:34:39AM -0500, Jeremy Luce wrote: Resubmitting with [PATCH] tag and unified diff. Adds functionality to pause transcoding with 'p' key and upause with 'u' key over stdin. Pauses in the main transcode loop as well as the input_thread loop. [...] @@ -3346,7 +3371,9

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 01:48:48PM -0500, Jeremy Luce wrote: I'll fix the breaks and resubmit. I don't see the keyboard interaction documented anywhere but in the source code. Where would be the desired location for this info? somewhere hmm, in the ffmpeg docs, doc/ffmpeg.texi seems the

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
I'll fix the breaks and resubmit. I don't see the keyboard interaction documented anywhere but in the source code. Where would be the desired location for this info? Jeremy On Fri, Mar 13, 2015 at 1:02 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Mar 11, 2015 at 08:34:39AM -0500,

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
It's been a couple days, so I wanted to follow up. Would someone mind providing some feedback on this? Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 08:34:48AM -0500, Jeremy Luce wrote: It's been a couple days, so I wanted to follow up. Would someone mind providing some feedback on this? Thanks! what is the advantage of this compared to simply stoping the process? like by hiting ctrl-z ? [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
In my case it would be used by a multi-platform application that does on-the-fly transcoding. It would be nice if this behavior was platform agnostic (there's no ctrl-z equivalent in Windows that I know of). Doing this with OS-specific keys or at the thread level in the application code is less

[FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-12 Thread Jeremy Luce
Resubmitting with [PATCH] tag and unified diff. Adds functionality to pause transcoding with 'p' key and upause with 'u' key over stdin. Pauses in the main transcode loop as well as the input_thread loop. - diff --git a/ffmpeg.c b/ffmpeg.c index 6604ff0..37b351a 100644 ---