Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Carl Eugen Hoyos]

2016-09-14 18:56 GMT+02:00 Yogender Kumar Gupta :
> Please let me know if anything else needs to be taken care of.

if (condition) {
do();
} else {
  do2();
}

like everywhere else in FFmpeg (and on top of your patch).

+if (ctx->aq && ctx->temporalAQ)
+{
+av_log(avctx, AV_LOG_ERROR, "AQ and Temporal AQ are not
supported together\n");
+}

Printing the error is sufficient, neither return nor unsetting one of them?

Please do not top-post here, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Yogender Kumar Gupta]

I have made only changes specific to SDK_7_0 in the attached patch. Also
generated the patch using format-patch.
Please let me know if anything else needs to be taken care of.

Thanks,
Yogender


On Wed, Sep 14, 2016 at 8:48 PM, Carl Eugen Hoyos 
wrote:

> 2016-09-14 15:43 GMT+02:00 Yogender Kumar Gupta  >:
> > Attached is a patch for SDK 7_0 for NVENC. This adds other features
> > available in SDK 7_0 as well as fixes an issue with HEVC profile
>
> The first two hunks do not match your description, please send a
> separate patch for the log changes.
> The positioning of braces should match the FFmpeg style.
>
> > as well as fixes an issue with HEVC profile
>
> I may misunderstand but this could also be separate patch.
>
> Patch made with git format-patch are preferred, Carl Eugen
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


SDK_7_0.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Timo Rothenpieler]

On 9/14/2016 6:30 PM, Carl Eugen Hoyos wrote:
> 2016-09-14 18:26 GMT+02:00 Timo Rothenpieler :
>> On 9/14/2016 3:43 PM, Yogender Kumar Gupta wrote:
>>> Attached is a patch for SDK 7_0 for NVENC. This adds other features
>>> available in SDK 7_0 as well as fixes an issue with HEVC profile
>>>
>>
>> I'd very much dislike applying this change.
> 
> I suspect you answered the wrong thread;-)

Indeed, will re-send.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Carl Eugen Hoyos]

2016-09-14 18:26 GMT+02:00 Timo Rothenpieler :
> On 9/14/2016 3:43 PM, Yogender Kumar Gupta wrote:
>> Attached is a patch for SDK 7_0 for NVENC. This adds other features
>> available in SDK 7_0 as well as fixes an issue with HEVC profile
>>
>
> I'd very much dislike applying this change.

I suspect you answered the wrong thread;-)

Carl Eugen (who agrees and wonders if there is a documentation issue)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Timo Rothenpieler]

On 9/14/2016 3:43 PM, Yogender Kumar Gupta wrote:
> Attached is a patch for SDK 7_0 for NVENC. This adds other features
> available in SDK 7_0 as well as fixes an issue with HEVC profile
> 

I'd very much dislike applying this change.
It makes the list very hard to read.
While it could be re-arranged to look a bit more sane, I don't see the
point of changing this.
Any sane C-Compiler should not complain about this, and never did in all
my tests on various platforms and toolchains.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Carl Eugen Hoyos]

2016-09-14 18:23 GMT+02:00 Timo Rothenpieler :

> I'm not sure what target_quality is supposed to do

Could it be that it moves the time-to-encode / quality-of-encoding
slider? (just guessing, libvpx does this iirc)

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Timo Rothenpieler]

On 9/14/2016 3:43 PM, Yogender Kumar Gupta wrote:
> Attached is a patch for SDK 7_0 for NVENC. This adds other features
> available in SDK 7_0 as well as fixes an issue with HEVC profile
> 

What carl said.

Also, a some of the added options are not used anywhere:
zeroReorderDelay, enableNonRefP

I'm not sure what target_quality is supposed to do, but constant quality
vbr encodes already exist, exposed via global_quality.
If it's some new rate-control mode, it has to be added as such.
If the current way of doing constqp encoding is wrong, it has to be fixed.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Carl Eugen Hoyos]

2016-09-14 15:43 GMT+02:00 Yogender Kumar Gupta :
> Attached is a patch for SDK 7_0 for NVENC. This adds other features
> available in SDK 7_0 as well as fixes an issue with HEVC profile

The first two hunks do not match your description, please send a
separate patch for the log changes.
The positioning of braces should match the FFmpeg style.

> as well as fixes an issue with HEVC profile

I may misunderstand but this could also be separate patch.

Patch made with git format-patch are preferred, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

[Yogender Kumar Gupta]

Attached is a patch for SDK 7_0 for NVENC. This adds other features
available in SDK 7_0 as well as fixes an issue with HEVC profile


sdk_7_0.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel