Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix drift calculation, ticket #6157

[Steven Liu]

2017-02-19 10:42 GMT+08:00 Steven Liu :

>
>
> 2017-02-19 10:22 GMT+08:00 Pavel Koshevoy :
>
>> On 02/18/2017 07:04 PM, Steven Liu wrote:
>>
>>>
>>>
>>> 2017-02-19 6:46 GMT+08:00 > pkoshe...@gmail.com>>:
>>>
>>> From: Pavel Koshevoy > pkoshe...@gmail.com>>
>>>
>>> ---
>>>  libavfilter/af_atempo.c | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c
>>> index a487882..eb62656 100644
>>> --- a/libavfilter/af_atempo.c
>>> +++ b/libavfilter/af_atempo.c
>>> @@ -697,11 +697,11 @@ static int yae_adjust_position(ATempoContext
>>> *atempo)
>>>  AudioFragment   *frag = yae_curr_frag(atempo);
>>>
>>>  const double prev_output_position =
>>> -(double)(prev->position[1] - atempo->origin[1] +
>>> atempo->window / 2);
>>> +(double)(prev->position[1] - atempo->origin[1] +
>>> atempo->window /
>>> 2) *
>>> +atempo->tempo;
>>>
>>>  const double ideal_output_position =
>>> -(double)(prev->position[0] - atempo->origin[0] +
>>> atempo->window /
>>> 2) /
>>> -atempo->tempo;
>>> +(double)(prev->position[0] - atempo->origin[0] +
>>> atempo->window / 2);
>>>
>>>  const int drift = (int)(prev_output_position -
>>> ideal_output_position);
>>>
>>> --
>>> 2.6.6
>>>
>>> ___
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org 
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>> 
>>>
>>>
>>>
>>> LGTM
>>>
>>>
>>> Thanks
>>>
>>
>>
>> Then would someone apply this, please?
>>
>
> Will apply after 24 hours!
>
>>
>>
>> Thank you,
>>
>> Pavel
>>
>>
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
>
pushed


Thanks!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix drift calculation, ticket #6157

[Steven Liu]

2017-02-19 10:22 GMT+08:00 Pavel Koshevoy :

> On 02/18/2017 07:04 PM, Steven Liu wrote:
>
>>
>>
>> 2017-02-19 6:46 GMT+08:00  pkoshe...@gmail.com>>:
>>
>> From: Pavel Koshevoy > >>
>>
>> ---
>>  libavfilter/af_atempo.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c
>> index a487882..eb62656 100644
>> --- a/libavfilter/af_atempo.c
>> +++ b/libavfilter/af_atempo.c
>> @@ -697,11 +697,11 @@ static int yae_adjust_position(ATempoContext
>> *atempo)
>>  AudioFragment   *frag = yae_curr_frag(atempo);
>>
>>  const double prev_output_position =
>> -(double)(prev->position[1] - atempo->origin[1] +
>> atempo->window / 2);
>> +(double)(prev->position[1] - atempo->origin[1] +
>> atempo->window /
>> 2) *
>> +atempo->tempo;
>>
>>  const double ideal_output_position =
>> -(double)(prev->position[0] - atempo->origin[0] +
>> atempo->window /
>> 2) /
>> -atempo->tempo;
>> +(double)(prev->position[0] - atempo->origin[0] +
>> atempo->window / 2);
>>
>>  const int drift = (int)(prev_output_position -
>> ideal_output_position);
>>
>> --
>> 2.6.6
>>
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org 
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>>
>>
>>
>> LGTM
>>
>>
>> Thanks
>>
>
>
> Then would someone apply this, please?
>

Will apply after 24 hours!

>
>
> Thank you,
>
> Pavel
>
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix drift calculation, ticket #6157

[Pavel Koshevoy]

On 02/18/2017 07:04 PM, Steven Liu wrote:



2017-02-19 6:46 GMT+08:00 >:

From: Pavel Koshevoy >

---
 libavfilter/af_atempo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c
index a487882..eb62656 100644
--- a/libavfilter/af_atempo.c
+++ b/libavfilter/af_atempo.c
@@ -697,11 +697,11 @@ static int yae_adjust_position(ATempoContext *atempo)
 AudioFragment   *frag = yae_curr_frag(atempo);

 const double prev_output_position =
-(double)(prev->position[1] - atempo->origin[1] + atempo->window / 
2);
+(double)(prev->position[1] - atempo->origin[1] + atempo->window /
2) *
+atempo->tempo;

 const double ideal_output_position =
-(double)(prev->position[0] - atempo->origin[0] + atempo->window /
2) /
-atempo->tempo;
+(double)(prev->position[0] - atempo->origin[0] + atempo->window / 
2);

 const int drift = (int)(prev_output_position - ideal_output_position);

--
2.6.6

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org 
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel




LGTM


Thanks



Then would someone apply this, please?


Thank you,

Pavel

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix drift calculation, ticket #6157

[Steven Liu]

2017-02-19 6:46 GMT+08:00 :

> From: Pavel Koshevoy 
>
> ---
>  libavfilter/af_atempo.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c
> index a487882..eb62656 100644
> --- a/libavfilter/af_atempo.c
> +++ b/libavfilter/af_atempo.c
> @@ -697,11 +697,11 @@ static int yae_adjust_position(ATempoContext
> *atempo)
>  AudioFragment   *frag = yae_curr_frag(atempo);
>
>  const double prev_output_position =
> -(double)(prev->position[1] - atempo->origin[1] + atempo->window /
> 2);
> +(double)(prev->position[1] - atempo->origin[1] + atempo->window /
> 2) *
> +atempo->tempo;
>
>  const double ideal_output_position =
> -(double)(prev->position[0] - atempo->origin[0] + atempo->window /
> 2) /
> -atempo->tempo;
> +(double)(prev->position[0] - atempo->origin[0] + atempo->window /
> 2);
>
>  const int drift = (int)(prev_output_position - ideal_output_position);
>
> --
> 2.6.6
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


LGTM


Thanks
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/af_atempo: fix drift calculation, ticket #6157

[pkoshevoy]

From: Pavel Koshevoy 

---
 libavfilter/af_atempo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c
index a487882..eb62656 100644
--- a/libavfilter/af_atempo.c
+++ b/libavfilter/af_atempo.c
@@ -697,11 +697,11 @@ static int yae_adjust_position(ATempoContext *atempo)
 AudioFragment   *frag = yae_curr_frag(atempo);
 
 const double prev_output_position =
-(double)(prev->position[1] - atempo->origin[1] + atempo->window / 2);
+(double)(prev->position[1] - atempo->origin[1] + atempo->window / 2) *
+atempo->tempo;
 
 const double ideal_output_position =
-(double)(prev->position[0] - atempo->origin[0] + atempo->window / 2) /
-atempo->tempo;
+(double)(prev->position[0] - atempo->origin[0] + atempo->window / 2);
 
 const int drift = (int)(prev_output_position - ideal_output_position);
 
-- 
2.6.6

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel