Re: [FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types
On Thu, Aug 21, 2014 at 11:42:53AM +0200, Michael Niedermayer wrote: > On Thu, Aug 21, 2014 at 09:32:29AM +0200, Clément Bœsch wrote: > > On Thu, Aug 21, 2014 at 07:34:50AM +0200, Clément Bœsch wrote: > > > On Thu, Aug 21, 2014 at 12:01:51AM +0200, Michael Niedermayer wrote: > > > > On Wed, Aug 20, 2014 at 11:30:27PM +0200, Clément Bœsch wrote: > > > > > --- > > > > > doc/APIchanges| 2 +- > > > > > libavutil/motion_vector.h | 8 > > > > > libavutil/version.h | 2 +- > > > > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > > > > > > > diff --git a/doc/APIchanges b/doc/APIchanges > > > > > index 1bed107..1fbeb09 100644 > > > > > --- a/doc/APIchanges > > > > > +++ b/doc/APIchanges > > > > > @@ -15,7 +15,7 @@ libavutil: 2014-08-09 > > > > > > > > > > API changes, most recent first: > > > > > > > > > > -2014-08-xx - xxx - lavu 54.5.100 - frame.h motion_vector.h > > > > > +2014-08-xx - b0352b1,xxx - lavu 54.6.100 - frame.h > > > > > motion_vector.h > > > > > > > > what is "b0352b1,xxx" ? > > > > > > > > > > b0352b1 is the main commit, at 54.5.100 > > > xxx would be this "fixup" commit, at 54.6.100 > > > > > > We wouldn't really want the users to use the feature in 54.5.100 because > > > of the bug I'm fixing, but "b0352b1 - lavu 54.6.100" would leave a version > > > inconsistency. And OTOH referencing only the new hash doesn't give much > > > insight on the feature/change mentioned. > > > > > > > One solution could be to clearly reference b0352b1 into the new commit, > > and make sure we reference the new hash in the 54.6 in APIChanges. > > > > Would that be fine? > > yes > Thanks, applied > also to clarify what my concern was, it was for that listing 2 > hashes equally is confusing to a reader, we often have 2 hashes > where one is from libav and one fro ffmpeg but i think this variant > is new. Also it could scripts [...] -- Clément B. pgp_wR_cPUr7b.pgp Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types
On Thu, Aug 21, 2014 at 09:32:29AM +0200, Clément Bœsch wrote: > On Thu, Aug 21, 2014 at 07:34:50AM +0200, Clément Bœsch wrote: > > On Thu, Aug 21, 2014 at 12:01:51AM +0200, Michael Niedermayer wrote: > > > On Wed, Aug 20, 2014 at 11:30:27PM +0200, Clément Bœsch wrote: > > > > --- > > > > doc/APIchanges| 2 +- > > > > libavutil/motion_vector.h | 8 > > > > libavutil/version.h | 2 +- > > > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/doc/APIchanges b/doc/APIchanges > > > > index 1bed107..1fbeb09 100644 > > > > --- a/doc/APIchanges > > > > +++ b/doc/APIchanges > > > > @@ -15,7 +15,7 @@ libavutil: 2014-08-09 > > > > > > > > API changes, most recent first: > > > > > > > > -2014-08-xx - xxx - lavu 54.5.100 - frame.h motion_vector.h > > > > +2014-08-xx - b0352b1,xxx - lavu 54.6.100 - frame.h motion_vector.h > > > > > > what is "b0352b1,xxx" ? > > > > > > > b0352b1 is the main commit, at 54.5.100 > > xxx would be this "fixup" commit, at 54.6.100 > > > > We wouldn't really want the users to use the feature in 54.5.100 because > > of the bug I'm fixing, but "b0352b1 - lavu 54.6.100" would leave a version > > inconsistency. And OTOH referencing only the new hash doesn't give much > > insight on the feature/change mentioned. > > > > One solution could be to clearly reference b0352b1 into the new commit, > and make sure we reference the new hash in the 54.6 in APIChanges. > > Would that be fine? yes also to clarify what my concern was, it was for that listing 2 hashes equally is confusing to a reader, we often have 2 hashes where one is from libav and one fro ffmpeg but i think this variant is new. Also it could scripts [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know the Truth, for even if they happen to say it by chance, they would not even known they had done so. -- Xenophanes signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types
On Thu, Aug 21, 2014 at 07:34:50AM +0200, Clément Bœsch wrote: > On Thu, Aug 21, 2014 at 12:01:51AM +0200, Michael Niedermayer wrote: > > On Wed, Aug 20, 2014 at 11:30:27PM +0200, Clément Bœsch wrote: > > > --- > > > doc/APIchanges| 2 +- > > > libavutil/motion_vector.h | 8 > > > libavutil/version.h | 2 +- > > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > > > diff --git a/doc/APIchanges b/doc/APIchanges > > > index 1bed107..1fbeb09 100644 > > > --- a/doc/APIchanges > > > +++ b/doc/APIchanges > > > @@ -15,7 +15,7 @@ libavutil: 2014-08-09 > > > > > > API changes, most recent first: > > > > > > -2014-08-xx - xxx - lavu 54.5.100 - frame.h motion_vector.h > > > +2014-08-xx - b0352b1,xxx - lavu 54.6.100 - frame.h motion_vector.h > > > > what is "b0352b1,xxx" ? > > > > b0352b1 is the main commit, at 54.5.100 > xxx would be this "fixup" commit, at 54.6.100 > > We wouldn't really want the users to use the feature in 54.5.100 because > of the bug I'm fixing, but "b0352b1 - lavu 54.6.100" would leave a version > inconsistency. And OTOH referencing only the new hash doesn't give much > insight on the feature/change mentioned. > One solution could be to clearly reference b0352b1 into the new commit, and make sure we reference the new hash in the 54.6 in APIChanges. Would that be fine? [...] -- Clément B. pgpRD2cNqrdK4.pgp Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types
On Thu, Aug 21, 2014 at 12:01:51AM +0200, Michael Niedermayer wrote: > On Wed, Aug 20, 2014 at 11:30:27PM +0200, Clément Bœsch wrote: > > --- > > doc/APIchanges| 2 +- > > libavutil/motion_vector.h | 8 > > libavutil/version.h | 2 +- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/doc/APIchanges b/doc/APIchanges > > index 1bed107..1fbeb09 100644 > > --- a/doc/APIchanges > > +++ b/doc/APIchanges > > @@ -15,7 +15,7 @@ libavutil: 2014-08-09 > > > > API changes, most recent first: > > > > -2014-08-xx - xxx - lavu 54.5.100 - frame.h motion_vector.h > > +2014-08-xx - b0352b1,xxx - lavu 54.6.100 - frame.h motion_vector.h > > what is "b0352b1,xxx" ? > b0352b1 is the main commit, at 54.5.100 xxx would be this "fixup" commit, at 54.6.100 We wouldn't really want the users to use the feature in 54.5.100 because of the bug I'm fixing, but "b0352b1 - lavu 54.6.100" would leave a version inconsistency. And OTOH referencing only the new hash doesn't give much insight on the feature/change mentioned. > i think an API is only really available and stable after 1 revission Yes, I'm sorry about that mistake, but the code was pushed only very recently. What do you suggest? > > rest LGTM > [...] -- Clément B. pgpUPm0nQqZUb.pgp Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types
On Wed, Aug 20, 2014 at 11:30:27PM +0200, Clément Bœsch wrote: > --- > doc/APIchanges| 2 +- > libavutil/motion_vector.h | 8 > libavutil/version.h | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 1bed107..1fbeb09 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -15,7 +15,7 @@ libavutil: 2014-08-09 > > API changes, most recent first: > > -2014-08-xx - xxx - lavu 54.5.100 - frame.h motion_vector.h > +2014-08-xx - b0352b1,xxx - lavu 54.6.100 - frame.h motion_vector.h what is "b0352b1,xxx" ? i think an API is only really available and stable after 1 revission rest LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types
---
doc/APIchanges| 2 +-
libavutil/motion_vector.h | 8
libavutil/version.h | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 1bed107..1fbeb09 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -15,7 +15,7 @@ libavutil: 2014-08-09
API changes, most recent first:
-2014-08-xx - xxx - lavu 54.5.100 - frame.h motion_vector.h
+2014-08-xx - b0352b1,xxx - lavu 54.6.100 - frame.h motion_vector.h
Add AV_FRAME_DATA_MOTION_VECTORS side data and AVMotionVector structure
2014-08-16 - xxx - lswr 1.1.100 - swresample.h
diff --git a/libavutil/motion_vector.h b/libavutil/motion_vector.h
index 245e511..30cfb99 100644
--- a/libavutil/motion_vector.h
+++ b/libavutil/motion_vector.h
@@ -33,13 +33,13 @@ typedef struct AVMotionVector {
*/
uint8_t w, h;
/**
- * Absolute source position.
+ * Absolute source position. Can be outside the frame area.
*/
-uint16_t src_x, src_y;
+int16_t src_x, src_y;
/**
- * Absolute destination position.
+ * Absolute destination position. Can be outside the frame area.
*/
-uint16_t dst_x, dst_y;
+int16_t dst_x, dst_y;
/**
* Extra flag information.
* Currently unused.
diff --git a/libavutil/version.h b/libavutil/version.h
index d42209d..4236ed2 100644
--- a/libavutil/version.h
+++ b/libavutil/version.h
@@ -56,7 +56,7 @@
*/
#define LIBAVUTIL_VERSION_MAJOR 54
-#define LIBAVUTIL_VERSION_MINOR 5
+#define LIBAVUTIL_VERSION_MINOR 6
#define LIBAVUTIL_VERSION_MICRO 100
#define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
--
2.0.4
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
