[FFmpeg-devel] ?????? [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

2023-03-03 Thread ??????
Thank you for your reminding, George.
I really ignore av_freep() above.
Please ignore this patch.


// xufuji456


----
??: 
   "ffmpeg-devel"   
 
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

2023-03-03 Thread Nicolas George
"zhilizhao(赵志立)" (12023-03-03):
> > av_freep(_files);
> > av_freep(_files);
> > +input_files   = NULL;
> > +output_files  = NULL;
> Until we decided to make ffmpeg cmd works as a library,
> it doesn’t matter.

It is worse than that: the patch completely ignores the semantic of
av_freep().

Useless patch with no explanations at all in the mail => just ignore the
mail.

> I’m interested on the idea to make fftools
> work like a library. But it depends on the community.

That would be more or less what an extended libavfilter with movie
source and sink would be.

Regards,

-- 
  Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

2023-03-03 Thread zhilizhao(赵志立)

> On Mar 3, 2023, at 14:51, xufuji456 <839789...@qq.com> wrote:
> 
> ---
> fftools/ffmpeg.c | 7 +++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 743bc0c6b6..0ce9531235 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -569,6 +569,13 @@ static void ffmpeg_cleanup(int ret)
> av_freep(_files);
> av_freep(_files);
> 
> +nb_input_files= 0;
> +nb_output_files   = 0;
> +nb_filtergraphs   = 0;
> +input_files   = NULL;
> +output_files  = NULL;
> +filtergraphs  = NULL;
> +

Until we decided to make ffmpeg cmd works as a library,
it doesn’t matter. I’m interested on the idea to make fftools
work like a library. But it depends on the community.

https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_929f62ab2f4e5e70082de99ae040769a1...@qq.com/

> uninit_opts();
> 
> avformat_network_deinit();
> -- 
> 2.32.0 (Apple Git-132)
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


[FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

2023-03-02 Thread xufuji456
---
 fftools/ffmpeg.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 743bc0c6b6..0ce9531235 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -569,6 +569,13 @@ static void ffmpeg_cleanup(int ret)
 av_freep(_files);
 av_freep(_files);
 
+nb_input_files= 0;
+nb_output_files   = 0;
+nb_filtergraphs   = 0;
+input_files   = NULL;
+output_files  = NULL;
+filtergraphs  = NULL;
+
 uninit_opts();
 
 avformat_network_deinit();
-- 
2.32.0 (Apple Git-132)

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".