Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-04-06 Thread Michael Niedermayer
On Fri, Apr 05, 2019 at 11:14:23PM -0400, Leo Izen wrote: > On 4/4/19 5:11 AM, Michael Niedermayer wrote: > >On Wed, Jan 09, 2019 at 05:26:53PM -0500, Leo Izen wrote: > >>--- > >> fftools/ffmpeg.c | 19 ++- > >> 1 file changed, 14 insertions(+), 5 deletions(-) > >Does this behave

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-04-06 Thread Carl Eugen Hoyos
2019-04-06 5:14 GMT+02:00, Leo Izen : > On 4/4/19 5:11 AM, Michael Niedermayer wrote: >> On Wed, Jan 09, 2019 at 05:26:53PM -0500, Leo Izen wrote: >>> --- >>> fftools/ffmpeg.c | 19 ++- >>> 1 file changed, 14 insertions(+), 5 deletions(-) >> Does this behave as intended when

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-04-05 Thread Leo Izen
On 4/4/19 5:11 AM, Michael Niedermayer wrote: On Wed, Jan 09, 2019 at 05:26:53PM -0500, Leo Izen wrote: --- fftools/ffmpeg.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) Does this behave as intended when there is also an audio stream ? It depends on what you

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-04-04 Thread Michael Niedermayer
On Wed, Jan 09, 2019 at 05:26:53PM -0500, Leo Izen wrote: > --- > fftools/ffmpeg.c | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) Does this behave as intended when there is also an audio stream ? also a fate test should be added thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-04-01 Thread Leo Izen
Bumping this? I'd like to request a review because I think being able to set the input framerate on streamcopy is worthwhile. In case of formatting issues with the reply email, I've attached the patch file as well. In terms of testing, I've tested this with various input formats (matroska,

[FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-01-09 Thread Leo Izen
--- fftools/ffmpeg.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 544f1a1cef..f4bd5d97b7 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2038,12 +2038,14 @@ static void do_streamcopy(InputStream *ist,

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-21 Thread Leo Izen
On 10/21/18 7:23 AM, Moritz Barsnick wrote: On Sat, Oct 20, 2018 at 22:42:55 -0400, Leo Izen wrote: On 10/20/18 6:47 PM, Michael Niedermayer wrote: This will not apply as it has too many newlines What do you mean by "this will not apply"? Do you mean attempting to apply the patch fails? What

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-21 Thread Moritz Barsnick
On Sat, Oct 20, 2018 at 22:42:55 -0400, Leo Izen wrote: > On 10/20/18 6:47 PM, Michael Niedermayer wrote: > > This will not apply as it has too many newlines > What do you mean by "this will not apply"? Do you mean attempting to > apply the patch fails? What do newline characters have anything to

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-20 Thread Leo Izen
On 10/20/18 6:47 PM, Michael Niedermayer wrote: On Fri, Oct 19, 2018 at 07:29:28PM -0400, Leo Izen wrote: On 10/19/18 3:02 PM, Carl Eugen Hoyos wrote: 2018-10-19 20:39 GMT+02:00, Leo Izen : On 10/19/18 2:26 PM, Carl Eugen Hoyos wrote: 2018-10-19 4:58 GMT+02:00, Leo Izen : ---

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-20 Thread Michael Niedermayer
On Fri, Oct 19, 2018 at 07:29:28PM -0400, Leo Izen wrote: > > On 10/19/18 3:02 PM, Carl Eugen Hoyos wrote: > >2018-10-19 20:39 GMT+02:00, Leo Izen : > >>On 10/19/18 2:26 PM, Carl Eugen Hoyos wrote: > >>>2018-10-19 4:58 GMT+02:00, Leo Izen : > --- > fftools/ffmpeg.c | 8 +--- >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-19 Thread Leo Izen
On 10/19/18 3:02 PM, Carl Eugen Hoyos wrote: 2018-10-19 20:39 GMT+02:00, Leo Izen : On 10/19/18 2:26 PM, Carl Eugen Hoyos wrote: 2018-10-19 4:58 GMT+02:00, Leo Izen : --- fftools/ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-19 Thread Carl Eugen Hoyos
2018-10-19 20:39 GMT+02:00, Leo Izen : > On 10/19/18 2:26 PM, Carl Eugen Hoyos wrote: >> 2018-10-19 4:58 GMT+02:00, Leo Izen : >>> --- >>> fftools/ffmpeg.c | 8 +--- >>> 1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c >>> index

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-19 Thread Leo Izen
On 10/19/18 2:26 PM, Carl Eugen Hoyos wrote: 2018-10-19 4:58 GMT+02:00, Leo Izen : --- fftools/ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index da4259a9a8..5d68194676 100644 --- a/fftools/ffmpeg.c +++

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-19 Thread Carl Eugen Hoyos
2018-10-19 4:58 GMT+02:00, Leo Izen : > --- > fftools/ffmpeg.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index da4259a9a8..5d68194676 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -2045,12 +2045,14 @@

[FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-18 Thread Leo Izen
--- fftools/ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index da4259a9a8..5d68194676 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2045,12 +2045,14 @@ static void do_streamcopy(InputStream *ist, OutputStream