Re: [FFmpeg-devel] [PATCH 1/2] avfilter/dualinput: Add support to skip initial unpaired frames

[Michael Niedermayer]

On Sun, Jun 26, 2016 at 10:23:35AM +0200, Paul B Mahol wrote:
> On 6/26/16, Michael Niedermayer  wrote:
> > On Sun, Jun 26, 2016 at 09:31:33AM +0200, Paul B Mahol wrote:
> >> On 6/26/16, Michael Niedermayer  wrote:
> >> > On Sat, Jun 25, 2016 at 12:43:35AM +0200, Michael Niedermayer wrote:
> >> >> Signed-off-by: Michael Niedermayer 
> >> >> ---
> >> >>  libavfilter/dualinput.c |3 +++
> >> >>  libavfilter/dualinput.h |1 +
> >> >>  2 files changed, 4 insertions(+)
> >> >
> >> > applied
> >> >
> >> > [...]
> >> > --
> >> > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >> >
> >> > It is what and why we do it that matters, not just one of them.
> >> >
> >>
> >> You could wait for Nicolas reply.
> >
> > I waited 24h, and this fixes a crash in the upcoming release
> > should i revert the 2 patches ?
> 
> Then why that is not mentioned in the commit log?

Its mentioned in the other patch of this 2 patch series, which
depends on this one

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/dualinput: Add support to skip initial unpaired frames

[Paul B Mahol]

On 6/26/16, Michael Niedermayer  wrote:
> On Sun, Jun 26, 2016 at 09:31:33AM +0200, Paul B Mahol wrote:
>> On 6/26/16, Michael Niedermayer  wrote:
>> > On Sat, Jun 25, 2016 at 12:43:35AM +0200, Michael Niedermayer wrote:
>> >> Signed-off-by: Michael Niedermayer 
>> >> ---
>> >>  libavfilter/dualinput.c |3 +++
>> >>  libavfilter/dualinput.h |1 +
>> >>  2 files changed, 4 insertions(+)
>> >
>> > applied
>> >
>> > [...]
>> > --
>> > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>> >
>> > It is what and why we do it that matters, not just one of them.
>> >
>>
>> You could wait for Nicolas reply.
>
> I waited 24h, and this fixes a crash in the upcoming release
> should i revert the 2 patches ?

Then why that is not mentioned in the commit log?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/dualinput: Add support to skip initial unpaired frames

[Michael Niedermayer]

On Sun, Jun 26, 2016 at 09:31:33AM +0200, Paul B Mahol wrote:
> On 6/26/16, Michael Niedermayer  wrote:
> > On Sat, Jun 25, 2016 at 12:43:35AM +0200, Michael Niedermayer wrote:
> >> Signed-off-by: Michael Niedermayer 
> >> ---
> >>  libavfilter/dualinput.c |3 +++
> >>  libavfilter/dualinput.h |1 +
> >>  2 files changed, 4 insertions(+)
> >
> > applied
> >
> > [...]
> > --
> > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > It is what and why we do it that matters, not just one of them.
> >
> 
> You could wait for Nicolas reply.

I waited 24h, and this fixes a crash in the upcoming release
should i revert the 2 patches ?


> 
> Now I can commmit my own patches after 5 minutes nobody replied, thanks.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/dualinput: Add support to skip initial unpaired frames

[Paul B Mahol]

On 6/26/16, Michael Niedermayer  wrote:
> On Sat, Jun 25, 2016 at 12:43:35AM +0200, Michael Niedermayer wrote:
>> Signed-off-by: Michael Niedermayer 
>> ---
>>  libavfilter/dualinput.c |3 +++
>>  libavfilter/dualinput.h |1 +
>>  2 files changed, 4 insertions(+)
>
> applied
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> It is what and why we do it that matters, not just one of them.
>

You could wait for Nicolas reply.

Now I can commmit my own patches after 5 minutes nobody replied, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/dualinput: Add support to skip initial unpaired frames

[Michael Niedermayer]

On Sat, Jun 25, 2016 at 12:43:35AM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer 
> ---
>  libavfilter/dualinput.c |3 +++
>  libavfilter/dualinput.h |1 +
>  2 files changed, 4 insertions(+)

applied

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] avfilter/dualinput: Add support to skip initial unpaired frames

[Michael Niedermayer]

Signed-off-by: Michael Niedermayer 
---
 libavfilter/dualinput.c |3 +++
 libavfilter/dualinput.h |1 +
 2 files changed, 4 insertions(+)

diff --git a/libavfilter/dualinput.c b/libavfilter/dualinput.c
index 1a078a2..4475097 100644
--- a/libavfilter/dualinput.c
+++ b/libavfilter/dualinput.c
@@ -66,6 +66,9 @@ int ff_dualinput_init(AVFilterContext *ctx, 
FFDualInputContext *s)
 in[1].after = EXT_NULL;
 in[1].sync  = 0;
 }
+if (s->skip_initial_unpaired) {
+in[1].before = EXT_STOP;
+}
 
 return ff_framesync_configure(>fs);
 }
diff --git a/libavfilter/dualinput.h b/libavfilter/dualinput.h
index 5ff23e6..42b2663 100644
--- a/libavfilter/dualinput.h
+++ b/libavfilter/dualinput.h
@@ -35,6 +35,7 @@ typedef struct {
 AVFrame *(*process)(AVFilterContext *ctx, AVFrame *main, const AVFrame 
*second);
 int shortest;   ///< terminate stream when the second input 
terminates
 int repeatlast; ///< repeat last second frame
+int skip_initial_unpaired;  ///< Skip initial frames that dont have a 2nd 
input
 } FFDualInputContext;
 
 int ff_dualinput_init(AVFilterContext *ctx, FFDualInputContext *s);
-- 
1.7.9.5

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel