Re: [FFmpeg-devel] [PATCH 1/3] mpegtsenc: Allow user to set SDT retransmission period

2015-04-05 Thread Derek Buitenhuis
On 4/5/2015 11:34 PM, Michael Niedermayer wrote: this is missing documentation about the units in which sdt_period is. as is this depends on mux_rate 1 if its intended to stay that way, then this should be documented Yes it depends on muxrate. I'll rework these soon. - Derek

Re: [FFmpeg-devel] [PATCH 1/3] mpegtsenc: Allow user to set SDT retransmission period

2015-04-05 Thread Michael Niedermayer
On Sun, Apr 05, 2015 at 02:37:06PM -0400, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavformat/mpegtsenc.c | 10 +++--- libavformat/version.h | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c

[FFmpeg-devel] [PATCH 1/3] mpegtsenc: Allow user to set SDT retransmission period

2015-04-05 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavformat/mpegtsenc.c | 10 +++--- libavformat/version.h | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index ae0593d..861da95 100644 ---

Re: [FFmpeg-devel] [PATCH 1/3] mpegtsenc: Allow user to set SDT retransmission period

2015-04-05 Thread James Almer
On 05/04/15 3:37 PM, Derek Buitenhuis wrote: diff --git a/libavformat/version.h b/libavformat/version.h index 1c78df2..55287ae 100644 --- a/libavformat/version.h +++ b/libavformat/version.h @@ -30,7 +30,7 @@ #include libavutil/version.h #define LIBAVFORMAT_VERSION_MAJOR 56 -#define

Re: [FFmpeg-devel] [PATCH 1/3] mpegtsenc: Allow user to set SDT retransmission period

2015-04-05 Thread Derek Buitenhuis
On 4/5/2015 7:44 PM, James Almer wrote: Shouldn't this be a micro bump? It's just a new AVOption for a specific muxer. Or at most bump minor only once for both SDT and PAT/PMT options. I have no opinion on the matter myself. - Derek ___ ffmpeg-devel