Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-23 Thread Nicolas George
nablet developer (2017-11-20): > regarding re-using functions from network.c (like ff_network_wait_fd, > ff_accept, etc) > is suggested approach acceptable? is it okay to define such socket_api > structure and pass to > network.c calls? I do not think so. These functions are very specific to

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-21 Thread nablet developer
> On 20 Nov 2017, at 13:35, nablet developer wrote: > > >> >> Thanks for explaining. I think it is not the best decision. >> >> The reason the socket API resembles TCP is because all the sockets API >> resemble each other, since they are based on the old BSD socket API. And

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-19 Thread nablet developer
> > Thanks for explaining. I think it is not the best decision. > > The reason the socket API resembles TCP is because all the sockets API > resemble each other, since they are based on the old BSD socket API. And > the protocol handlers of libavformat too. > > Therefore, I think all the

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-16 Thread Nicolas George
Le decadi 20 brumaire, an CCXXVI, nablet developer a écrit : > the idea is to avoid code duplication as much as possible, and try to re-use > existing, well-maintained and well-tested code. > this time I've chosen tcp.c rather udp.c for two reasons: > 1. SRT socket API actually resembles tcp, as

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread nablet developer
On 10-Nov-17 03:35, Nicolas George wrote: Can you explain the logic of the implementation? I have a hard time understanding why you call the tcp protocol from here after forcing it to call back here. Regards, the idea is to avoid code duplication as much as possible, and try to re-use

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread Nicolas George
Le nonidi 19 brumaire, an CCXXVI, Nablet Developer a écrit : > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed > > Signed-off-by: Nablet Developer > --- > configure | 10 ++ > libavformat/Makefile| 1 + > libavformat/opensrt.c

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread Kv Pham
Le 9 nov. 2017 10:32 AM, "Nablet Developer" a écrit : protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- configure | 10 ++ libavformat/Makefile| 1 + libavformat/opensrt.c |

[FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread Nablet Developer
protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- configure | 10 ++ libavformat/Makefile| 1 + libavformat/opensrt.c | 418