Re: [FFmpeg-devel] [PATCH 4/4] lavc/qsvenc_h264: remove the privite option trellis

2019-03-27 Thread Carl Eugen Hoyos
2019-03-27 15:51 GMT+01:00, Moritz Barsnick : > On Wed, Mar 27, 2019 at 20:51:47 +0800, Zhong Li wrote: >> Just simply remove the private option, and switch to the AVCodecContext >> definition. Compatibility should not a big problem (expect can't exact >> map) >> since the option name is same as

Re: [FFmpeg-devel] [PATCH 4/4] lavc/qsvenc_h264: remove the privite option trellis

2019-03-27 Thread Moritz Barsnick
On Wed, Mar 27, 2019 at 20:51:47 +0800, Zhong Li wrote: > Just simply remove the private option, and switch to the AVCodecContext > definition. Compatibility should not a big problem (expect can't exact map) > since the option name is same as AVCodecContext. You should probably bump libavcodec's

[FFmpeg-devel] [PATCH 4/4] lavc/qsvenc_h264: remove the privite option trellis

2019-03-27 Thread Zhong Li
There are many problems of current qsv trellis option: 1. Duplicated with AVCodecContext definition 2. MFX_TRELLIS_XXX is introduced by MSDK API 1.17 Currently Without MSDK API checking thus may cause compilation issue. 3. user is inclined to enable trellis when set "-trellis 1", but