Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-03-07 Thread Aurelien Jacobs
On Mon, Mar 05, 2018 at 08:46:43PM +, Rostislav Pehlivanov wrote: > On 3 March 2018 at 16:20, Aurelien Jacobs wrote: > > > On Thu, Mar 01, 2018 at 10:46:07PM +, Rostislav Pehlivanov wrote: > > > On 1 March 2018 at 20:45, Aurelien Jacobs wrote > > > >

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-03-05 Thread Rostislav Pehlivanov
On 3 March 2018 at 16:20, Aurelien Jacobs wrote: > On Thu, Mar 01, 2018 at 10:46:07PM +, Rostislav Pehlivanov wrote: > > On 1 March 2018 at 20:45, Aurelien Jacobs wrote > > > > > > > > So what I propose is to rename sbc_delay to sbc_latency (for example),

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-03-03 Thread Aurelien Jacobs
On Thu, Mar 01, 2018 at 10:46:07PM +, Rostislav Pehlivanov wrote: > On 1 March 2018 at 20:45, Aurelien Jacobs wrote > > > > > So what I propose is to rename sbc_delay to sbc_latency (for example), > > and to add a opus_latecy using AV_OPT_TYPE_DURATION that will deprecate >

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-03-01 Thread Rostislav Pehlivanov
On 1 March 2018 at 20:45, Aurelien Jacobs wrote > > So what I propose is to rename sbc_delay to sbc_latency (for example), > and to add a opus_latecy using AV_OPT_TYPE_DURATION that will deprecate > opus_delay. I think that's the best way forward if you care about >

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-03-01 Thread Aurelien Jacobs
On Thu, Mar 01, 2018 at 01:27:06AM +, Rostislav Pehlivanov wrote: > On 28 February 2018 at 23:34, Aurelien Jacobs wrote: > > > On Wed, Feb 28, 2018 at 12:59:40AM +, Rostislav Pehlivanov wrote: > > > On 27 February 2018 at 23:56, Aurelien Jacobs wrote:

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-28 Thread Rostislav Pehlivanov
On 28 February 2018 at 23:34, Aurelien Jacobs wrote: > On Wed, Feb 28, 2018 at 12:59:40AM +, Rostislav Pehlivanov wrote: > > On 27 February 2018 at 23:56, Aurelien Jacobs wrote: > > > > > > > > So I've updated the patch with only a msbc and a delay option

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-28 Thread Aurelien Jacobs
On Wed, Feb 28, 2018 at 12:59:40AM +, Rostislav Pehlivanov wrote: > On 27 February 2018 at 23:56, Aurelien Jacobs wrote: > > > > > So I've updated the patch with only a msbc and a delay option and > > I've added some sane parameters decisions, mainly based on the following

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-27 Thread Rostislav Pehlivanov
On 27 February 2018 at 23:56, Aurelien Jacobs wrote: > > So I've updated the patch with only a msbc and a delay option and > I've added some sane parameters decisions, mainly based on the following > study : > https://pdfs.semanticscholar.org/1f19/561d03bc88b67728375566c95bbf77

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-27 Thread Aurelien Jacobs
On Sat, Feb 24, 2018 at 09:31:30PM +, Rostislav Pehlivanov wrote: > On 24 February 2018 at 12:01, Aurelien Jacobs wrote: > > > On Thu, Feb 22, 2018 at 06:18:48PM +, Rostislav Pehlivanov wrote: > > > On 21 February 2018 at 22:37, Aurelien Jacobs wrote:

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-24 Thread Rostislav Pehlivanov
On 24 February 2018 at 12:01, Aurelien Jacobs wrote: > On Thu, Feb 22, 2018 at 06:18:48PM +, Rostislav Pehlivanov wrote: > > On 21 February 2018 at 22:37, Aurelien Jacobs wrote: > > > > > This was originally based on libsbc, and was fully integrated into

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-24 Thread Aurelien Jacobs
On Thu, Feb 22, 2018 at 06:18:48PM +, Rostislav Pehlivanov wrote: > On 21 February 2018 at 22:37, Aurelien Jacobs wrote: > > > This was originally based on libsbc, and was fully integrated into ffmpeg. > > --- > > doc/general.texi | 2 +- > > libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-22 Thread Rostislav Pehlivanov
On 21 February 2018 at 22:37, Aurelien Jacobs wrote: > This was originally based on libsbc, and was fully integrated into ffmpeg. > --- > doc/general.texi | 2 +- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/sbcdsp.c | 382

[FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2018-02-21 Thread Aurelien Jacobs
This was originally based on libsbc, and was fully integrated into ffmpeg. --- doc/general.texi | 2 +- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/sbcdsp.c | 382 +++ libavcodec/sbcdsp.h | 83

Re: [FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2017-12-23 Thread Aurelien Jacobs
Updated to match new identifier for CRC (AV_CRC_8_EBU). >From 380c36ec392b066d4b70b0f9fd4957a595294f5a Mon Sep 17 00:00:00 2001 From: Aurelien Jacobs Date: Sun, 17 Dec 2017 19:59:30 +0100 Subject: [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec) This was

[FFmpeg-devel] [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)

2017-12-23 Thread Aurelien Jacobs
This was originally based on libsbc, and was fully integrated into ffmpeg. --- doc/general.texi | 2 +- libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 4 +- libavcodec/sbcdsp.c | 382 libavcodec/sbcdsp.h | 83 +