Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

> +av_ts2timestr(duration_ts, _base)); ^ this does not build, and looks like a typo Sorry, this is ugly, I had indeed replaced manually two occurrences (s->time_base => _base) at the last minute just before sending

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

On Mon, Feb 12, 2018 at 10:48:28AM +0100, Nicolas Gaullier wrote: > From: nicolas gaullier > > --- > libavfilter/af_silencedetect.c | 33 +++-- > 1 file changed, 27 insertions(+), 6 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

2018-02-12 16:33 GMT+01:00 Gaullier Nicolas : > Here, the "fix for ticket 6968" should be the header, so I think the format > is correct ? I simply missed it, but a better alternative is: lavfi/silencedetect: Fix missing log at eos. Fixes ticket #6968. Carl Eugen

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

Here, the "fix for ticket 6968" should be the header, so I think the format is correct ? Everything behind ("Fix missing...") should be the body of the commit message. NB: thanks to you to have reported it previously, I was not aware of this ticket when I started work on this issue! Nicolas

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

2018-02-12 10:48 GMT+01:00 Nicolas Gaullier : > From: nicolas gaullier Please mention ticket #6968 in the commit message if it is related. Carl Eugen ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

From: nicolas gaullier --- libavfilter/af_silencedetect.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/libavfilter/af_silencedetect.c b/libavfilter/af_silencedetect.c index 8973049fe5..723136c2a8 100644 ---