Re: [FFmpeg-devel] [PATCH v3] mips/asmdefs: use _ABI64 as defined by gcc

2015-03-12 Thread Michael Niedermayer
On Wed, Mar 11, 2015 at 02:59:28PM +, James Cowgill wrote:
 Unfortunately android  api 21 (lollipop) doesn't have the sgidefs.h header,
 the easiest way around this is to just use the preprocessor definitions from
 gcc / clang.
 
 Signed-off-by: James Cowgill james...@cowgill.org.uk
 ---
 Hi,
 
 Sorry I forgot about this a little.
 
 I think that doing it this way is better than messing around with different
 headers which may not exist. I know it works on GCC and Clang.
 
 Thanks,
 James
 
  libavutil/mips/asmdefs.h | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


[FFmpeg-devel] [PATCH v3] mips/asmdefs: use _ABI64 as defined by gcc

2015-03-11 Thread James Cowgill
Unfortunately android  api 21 (lollipop) doesn't have the sgidefs.h header,
the easiest way around this is to just use the preprocessor definitions from
gcc / clang.

Signed-off-by: James Cowgill james...@cowgill.org.uk
---
Hi,

Sorry I forgot about this a little.

I think that doing it this way is better than messing around with different
headers which may not exist. I know it works on GCC and Clang.

Thanks,
James

 libavutil/mips/asmdefs.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavutil/mips/asmdefs.h b/libavutil/mips/asmdefs.h
index a3a5ee3..fdf82a0 100644
--- a/libavutil/mips/asmdefs.h
+++ b/libavutil/mips/asmdefs.h
@@ -27,9 +27,7 @@
 #ifndef AVUTIL_MIPS_ASMDEFS_H
 #define AVUTIL_MIPS_ASMDEFS_H
 
-#include sgidefs.h
-
-#if _MIPS_SIM == _ABI64
+#if defined(_ABI64)  _MIPS_SIM == _ABI64
 # define PTRSIZE 8 
 # define PTRLOG  3 
 # define PTR_ADDU   daddu 
-- 
2.1.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel