Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add repeatSPSPPS flag for streaming

2015-01-21 Thread Michael Niedermayer 
On Wed, Jan 21, 2015 at 08:32:07AM +0100, Timo Rothenpieler wrote:
 Still using attachment to prevent word-wrapping.
 For video streaming, repeatSPSPPS flag should be set as 1 besides
 disableSPSPPS=0, elsewise if running ffmpeg before vlc/ffmpeg, there
 will be no video header, decoder can't work properly.
 
 Agatha Hu
 
 
 Looks good to merge.

applied

thanks

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add repeatSPSPPS flag for streaming

2015-01-20 Thread Timo Rothenpieler 

Still using attachment to prevent word-wrapping.
For video streaming, repeatSPSPPS flag should be set as 1 besides
disableSPSPPS=0, elsewise if running ffmpeg before vlc/ffmpeg, there
will be no video header, decoder can't work properly.

Agatha Hu



Looks good to merge.




signature.asc
Description: OpenPGP digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/nvenc: add repeatSPSPPS flag for streaming

2015-01-20 Thread Agatha Hu 

Still using attachment to prevent word-wrapping.
For video streaming, repeatSPSPPS flag should be set as 1 besides 
disableSPSPPS=0, elsewise if running ffmpeg before vlc/ffmpeg, there 
will be no video header, decoder can't work properly.


Agatha Hu
From 526f4f37f1fbd8214a2866dad1d6c2ea480ffd9a Mon Sep 17 00:00:00 2001
From: agathah a...@nvidia.com
Date: Wed, 21 Jan 2015 13:53:29 +0800
Subject: [PATCH] set repeatSPSPPS flag for streaming

---
 libavcodec/nvenc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
index 26f010e..7d82d58 100644
--- a/libavcodec/nvenc.c
+++ b/libavcodec/nvenc.c
@@ -683,6 +683,7 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx)
 
ctx-encode_config.encodeCodecConfig.h264Config.h264VUIParameters.videoFullRangeFlag
 = avctx-color_range == AVCOL_RANGE_JPEG;
 
 ctx-encode_config.encodeCodecConfig.h264Config.disableSPSPPS = 
(avctx-flags  CODEC_FLAG_GLOBAL_HEADER) ? 1 : 0;
+ctx-encode_config.encodeCodecConfig.h264Config.repeatSPSPPS = 
(avctx-flags  CODEC_FLAG_GLOBAL_HEADER) ? 0 : 1;
 
 nv_status = p_nvenc-nvEncInitializeEncoder(ctx-nvencoder, 
ctx-init_encode_params);
 if (nv_status != NV_ENC_SUCCESS) {
-- 
1.9.5.github.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel