Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Tue, Feb 20, 2018 at 09:44:29AM +0100, Felix Matouschek wrote: > I rebased the patch on the current master, it does apply again. > > Tested it - still works. ok, this patch was laying around for enough weeks on the mailing list, will be part of my next push (unless some last minute issue is

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

I rebased the patch on the current master, it does apply again. Tested it - still works. Felix Am 19.02.2018 20:39, schrieb Michael Niedermayer: On Mon, Feb 19, 2018 at 08:39:56AM +0100, Felix Matouschek wrote: Hello Michael, do you think the patch could be merged in its current state? It

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Mon, Feb 19, 2018 at 08:39:56AM +0100, Felix Matouschek wrote: > Hello Michael, > > do you think the patch could be merged in its current state? > It is functional, maybe I can do the cosmetic changes later. > I was a bit busy the last weeks. > > Would be nice if it could get into the 3.5 /

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Hello Michael, do you think the patch could be merged in its current state? It is functional, maybe I can do the cosmetic changes later. I was a bit busy the last weeks. Would be nice if it could get into the 3.5 / 4.0 release. Felix Am 02.01.2018 10:23, schrieb Felix Matouschek: Am

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

> Am 28.12.2017 um 19:20 schrieb Michael Niedermayer : >> >> +av_image_copy_to_buffer(pkt.data, pkt_buffer_size, >> +(const uint8_t * const *) image_plane_data, >> +image_linestrides, ctx->image_format, >> +

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Fri, Dec 22, 2017 at 09:36:59PM +0100, Felix Matouschek wrote: > Am 22.12.2017 20:50, schrieb Lou Logan: > > > >I think you forgot to attach the patch. > > Sorry, flaky mail client... attached it again. [...] > +static void image_available(void *context, AImageReader *reader) > +{ > +

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Ping > Am 22.12.2017 um 21:36 schrieb Felix Matouschek : > > Am 22.12.2017 20:50, schrieb Lou Logan: >> I think you forgot to attach the patch. > > Sorry, flaky mail client... attached it again. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Am 22.12.2017 20:50, schrieb Lou Logan: I think you forgot to attach the patch. Sorry, flaky mail client... attached it again.From ba2ccca1200a55b0f1c0331ebd6d26324941fb2e Mon Sep 17 00:00:00 2001 From: Felix Matouschek Date: Fri, 22 Dec 2017 20:10:41 +0100 Subject:

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Fri, Dec 22, 2017, at 10:34 AM, Felix Matouschek wrote: > Hello Michael, > > I fixed the things you mentioned. New patch attached. > > Felix I think you forgot to attach the patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Hello Michael, I fixed the things you mentioned. New patch attached. Felix ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Fri, Dec 08, 2017 at 10:49:56AM +0100, Felix Matouschek wrote: [...] > +static int open_camera(AVFormatContext *avctx) > +{ > +AndroidCameraCtx *ctx = avctx->priv_data; > +camera_status_t ret; > +ACameraIdList *camera_ids; > + > +ret =

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Hello Michael, could you take a look at the patch? Felix > Am 30.11.2017 um 18:15 schrieb Michael Niedermayer : > > On Thu, Nov 30, 2017 at 10:15:48AM +0100, Felix Matouschek wrote: >> Sorry, my mail client swallowed the attachment, sent it again. >> > >> Changelog

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Am 30.11.2017 17:40, schrieb Michael Niedermayer: yes, if you dont set it, it will be computet but it would give some latency on startup as it needs a few frames first to base the computation on. This latency may or may not be a bigger problem than slightly incorrect values. I dont know, its

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Thu, Nov 30, 2017 at 10:15:48AM +0100, Felix Matouschek wrote: > Sorry, my mail client swallowed the attachment, sent it again. > > Changelog|1 > MAINTAINERS |1 > configure|6 > doc/indevs.texi | 40 ++ >

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Thu, Nov 30, 2017 at 05:29:45PM +0100, Felix Matouschek wrote: > Am 30.11.2017 14:48, schrieb Michael Niedermayer: > >>You mean avg_frame_rate and r_frame_rate? > >>The framerate can vary between the values in framerate_range[0] > >>(min) and framerate_range[1] (max). > >>Ideally both values

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Am 30.11.2017 14:48, schrieb Michael Niedermayer: You mean avg_frame_rate and r_frame_rate? The framerate can vary between the values in framerate_range[0] (min) and framerate_range[1] (max). Ideally both values are the same, sometimes min can be lower but for the average the framerate should be

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Thu, Nov 30, 2017 at 10:12:53AM +0100, Felix Matouschek wrote: > Am 29.11.2017 04:31, schrieb Michael Niedermayer: > > >if the identifer and the string always match you could do this > >with a macro avoiding the neede to duplcate each string > >see AV_STRINGIFY > > I changed it, is it ok like

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Sorry, my mail client swallowed the attachment, sent it again. 0001-avdevice-add-android_camera-indev.patch Description: Binary data > Am 30.11.2017 um 10:12 schrieb Felix Matouschek : > > Am 29.11.2017 04:31, schrieb Michael Niedermayer: > >> if the identifer and the

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Am 29.11.2017 04:31, schrieb Michael Niedermayer: if the identifer and the string always match you could do this with a macro avoiding the neede to duplcate each string see AV_STRINGIFY I changed it, is it ok like this? [...] +static int add_video_stream(AVFormatContext *avctx) +{ +

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Fri, Nov 10, 2017 at 09:41:04PM +0100, Felix Matouschek wrote: > Hello, > > here is a new version of the patch with further fixes. [...] > +static const char *camera_status_string(camera_status_t val) > +{ > +switch(val) { > +case ACAMERA_OK: > +return "ACAMERA_OK";

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Sorry... tested it again, it does not break the default compilation. The library check in the configure script just fails and the indev is not included when using the broken NDK. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Am 28.11.2017 14:01, schrieb Carl Eugen Hoyos: The patch breaks default compilation for Android? Actually... you are right, it does. It's a bit unfortunate as the header file in the NDK is broken. We can't work around that in ffmpeg, the NDK needs to be fixed. As soon as you include

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-28 8:50 GMT+01:00 Felix Matouschek : > One last note if you try to build it yourself: > Your NDK needs to have the patch in commit be9b8bc of this > issue https://github.com/android-ndk/ndk/issues/559 applied. Sorry if I misunderstand: The patch breaks default

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Am 22.11.2017 00:20, schrieb Michael Niedermayer: On Tue, Nov 21, 2017 at 08:16:08AM +0100, Felix Matouschek wrote: No more interest? If you hear no more comments for another week, then please ping this with CC to me and ill take a look and apply unless i spot some major issue also you

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On Tue, Nov 21, 2017 at 08:16:08AM +0100, Felix Matouschek wrote: > No more interest? If you hear no more comments for another week, then please ping this with CC to me and ill take a look and apply unless i spot some major issue also you probably want to add yourself to the MAINTAINER file if

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

No more interest? Am 02.11.2017 13:42, schrieb Felix Matouschek: Hello, I've written an indev for Android devices to allow capturing their builtin cameras. What needs to be done to merge this? Greetings, Felix ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Hello, here is a new version of the patch with further fixes. Greetings, Felix 0001-avdevice-add-android_camera-indev.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-07 18:47 GMT+01:00 Felix Matouschek : > >> Am 07.11.2017 um 16:17 schrieb Daniel Kučera : >> >> It's used like here: >>

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

> Am 07.11.2017 um 16:17 schrieb Daniel Kučera : > > It's used like here: > https://github.com/danielkucera/ZidoStreamer/blob/master/app/src/main/java/eu/danman/zidostreamer/zidostreamer/StreamService.java#L62 > > If I open standard streaming or camera app, no camera is

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-07 15:25 GMT+01:00 Felix Matouschek : > Am 02.11.2017 16:20, schrieb Daniel Kučera: > >> some devices have cameras which are unlisted - this condition makes >> them unusable. > > > How does one use unlisted devices? As far as I understood all supported > devices are

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Am 02.11.2017 16:20, schrieb Daniel Kučera: some devices have cameras which are unlisted - this condition makes them unusable. How does one use unlisted devices? As far as I understood all supported devices are listed. If the Camera2 API does not support the camera it cannot be used.

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Hello, I tried to address all issues. I did not have time yet to try more image formats, so it is still only YUV420P. Please review. Greetings, FelixFrom a235f56518fc1f11698a5028dfd4b654989993c5 Mon Sep 17 00:00:00 2001 From: Felix Matouschek Date: Tue, 24 Oct 2017

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-03 16:21 GMT+01:00 Felix Matouschek : >>> +if (format == IMAGE_FORMAT_ANDROID) { >> >> It would be better to support as many pixel formats as possible. > > For now I settled on YUV420P, as the API doc states all > devices must support it. I do not have the

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Hello, Am 02.11.2017 um 14:40 schrieb Nicolas George: When reading the subject of the mail, I first thought it would be about screen capture. Furthermore, there is code for audio, but it is not connected to anything, and it does not seem that the android API connects audio and video together.

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

On 02.11.2017 16:20, Daniel Kučera wrote: > 2017-11-02 13:42 GMT+01:00 Felix Matouschek : >> Hello, >> >> I've written an indev for Android devices to allow capturing their builtin >> cameras. >> What needs to be done to merge this? >> >> Greetings, >> Felix >>

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-02 13:42 GMT+01:00 Felix Matouschek : > Hello, > > I've written an indev for Android devices to allow capturing their builtin > cameras. > What needs to be done to merge this? > > Greetings, > Felix > ___ > ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

In addition to Nicolas's, further (style) comments: > Subject: [PATCH] Add android_capture indev More like: avdevice: add android_capture [or android_camera] indev > configure | 6 + > libavdevice/Makefile | 1 + > libavdevice/alldevices.c | 1 + >

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

Le duodi 12 brumaire, an CCXXVI, Felix Matouschek a écrit : > I've written an indev for Android devices to allow capturing their builtin > cameras. > What needs to be done to merge this? Thanks for the patch. It looks very interesting. Before considering merging, there are a few technical point