Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Ronald S. Bultje
Hi, On Wed, May 13, 2015 at 6:24 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Wed, May 13, 2015 at 12:09 PM, Rainer Hochecker fernetme...@online.de wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes: That sounds impossible since the patch was pushed as

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Carl Eugen Hoyos
Rainer Hochecker fernetmenta at online.de writes: Kodi crashes on Windows when doing 8 channel conversion. This seems to be the source of the problem. That sounds impossible since the patch was pushed as http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a Carl Eugen

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Rainer Hochecker
Carl Eugen Hoyos cehoyos at ag.or.at writes: That sounds impossible since the patch was pushed as http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a Carl Eugen Why exactly is that impossible? It crashes in ff_pack_8ch_float_to_int32_a_sse2 on Windows. Same code, same

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Rainer Hochecker
Michael Niedermayer michaelni at gmx.at writes: can someone who has ICL/MSVC setup test this please failing that, lets apply the patch [...] Kodi crashes on Windows when doing 8 channel conversion. This seems to be the source of the problem.

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Ronald S. Bultje
Hi, On Wed, May 13, 2015 at 7:18 AM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Wed, May 13, 2015 at 6:24 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Wed, May 13, 2015 at 12:09 PM, Rainer Hochecker fernetme...@online.de wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes:

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Rainer Hochecker
Hendrik Leppkes h.leppkes at gmail.com writes: Kodi's build script suggests that FFmpeg is build with gcc - this crash and fix only ever applied to MSVC/ICL builds. It starts crashing with this commit: https://github.com/FFmpeg/FFmpeg/commit/37b35feb64e4e0382cd5e4502dbf0f7ff9aa0 b5f

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Hendrik Leppkes
On Wed, May 13, 2015 at 12:09 PM, Rainer Hochecker fernetme...@online.de wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes: That sounds impossible since the patch was pushed as http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a Carl Eugen Why exactly is that impossible? It

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Carl Eugen Hoyos
Rainer Hochecker fernetmenta at online.de writes: Kodi's build script suggests that FFmpeg is build with gcc - this crash and fix only ever applied to MSVC/ICL builds. It starts crashing with this commit: https://github.com/FFmpeg/FFmpeg/commit/37b35feb So does adding

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-05-13 Thread Rainer Hochecker
Carl Eugen Hoyos cehoyos at ag.or.at writes: So does adding attribute_align_arg to swr_convert_frame() (and friends?) fix the issue? Carl Eugen I added it to swr_convert and it does fix the issue here. Rainer ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-02-06 Thread James Almer
On 11/01/15 10:48 AM, Michael Niedermayer wrote: On Tue, Jan 06, 2015 at 02:04:12AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- I don't have MSVC or ICL 10.x, so i only tested this with gcc after forcing HAVE_ALIGNED_STACK to 0 in config.asm can someone who

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-01-11 Thread Michael Niedermayer
On Tue, Jan 06, 2015 at 02:04:12AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- I don't have MSVC or ICL 10.x, so i only tested this with gcc after forcing HAVE_ALIGNED_STACK to 0 in config.asm can someone who has ICL/MSVC setup test this please failing that,

[FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-01-05 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- I don't have MSVC or ICL 10.x, so i only tested this with gcc after forcing HAVE_ALIGNED_STACK to 0 in config.asm libswresample/x86/audio_convert.asm| 39 -- libswresample/x86/audio_convert_init.c | 4 ++-- 2