Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-24 Thread Michael Niedermayer
On Thu, Jul 24, 2014 at 03:15:56PM +0200, Carl Eugen Hoyos wrote: > On Thursday 24 July 2014 03:00:02 pm Michael Niedermayer wrote: > > On Thu, Jul 24, 2014 at 12:50:55PM +0200, Carl Eugen Hoyos wrote: > > > On Saturday 19 July 2014 04:40:47 pm Joakim Plate wrote: > > > > Carl Eugen Hoyos ag.or.at

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-24 Thread Carl Eugen Hoyos
On Thursday 24 July 2014 03:00:02 pm Michael Niedermayer wrote: > On Thu, Jul 24, 2014 at 12:50:55PM +0200, Carl Eugen Hoyos wrote: > > On Saturday 19 July 2014 04:40:47 pm Joakim Plate wrote: > > > Carl Eugen Hoyos ag.or.at> writes: > > > > Hi! > > > > > > > > Attached patch fixes ticket #3777 fo

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is?wrong

2014-07-24 Thread Michael Niedermayer
On Thu, Jul 24, 2014 at 12:50:55PM +0200, Carl Eugen Hoyos wrote: > On Saturday 19 July 2014 04:40:47 pm Joakim Plate wrote: > > Carl Eugen Hoyos ag.or.at> writes: > > > Hi! > > > > > > Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. > > > > What about streaming growing files?

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-24 Thread Carl Eugen Hoyos
On Saturday 19 July 2014 04:40:47 pm Joakim Plate wrote: > Carl Eugen Hoyos ag.or.at> writes: > > Hi! > > > > Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. > > What about streaming growing files? It's pretty good to know number of > frames of the complete mp3 at start of pla

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-19 Thread Joakim Plate
Carl Eugen Hoyos ag.or.at> writes: > > Hi! > > Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. > > Please comment, Carl Eugen > What about streaming growing files? It's pretty good to know number of frames of the complete mp3 at start of playback? /Joakim

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-17 Thread Nicolas George
Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : > > if (... && min - tolerance < 2 * tolerance) ^^^ ^^^ This bit was a leftover from a slightly different version I tried at first, it was wrong. > > I also find this version easier to understand. > > Thank

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-17 Thread Carl Eugen Hoyos
On Thursday 17 July 2014 09:41:40 pm Nicolas George wrote: > Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : > > > > Attached patch fixes ticket #3777 for me, analyzed by Oliver > > Fromme. > I would suggest to avoid floating point arithmetic if possible. > Possibly something like

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-17 Thread Carl Eugen Hoyos
On Thursday 17 July 2014 09:41:40 pm Nicolas George wrote: > Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : > > Hi! > > > > Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. > > > > Please comment, Carl Eugen > > > > diff --git a/libavformat/mp3dec.c b/libavformat/m

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-17 Thread Nicolas George
Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : > Hi! > > Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. > > Please comment, Carl Eugen > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index 8335388..cdef6d9 100644 > --- a/libavformat/mp3dec.c > +++

[FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-17 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. Please comment, Carl Eugen diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 8335388..cdef6d9 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -138,6 +138,7 @@ static void mp3_parse_info_tag(AVFor