Re: [FFmpeg-devel] [FFmpeg-cvslog] aacenc: support extended channel layouts using PCEs

2017-11-09 Thread Rostislav Pehlivanov 
On 9 November 2017 at 09:37, Kv Pham  wrote:

> Le 9 nov. 2017 10:12 AM, "Nicolas George"  a écrit :
>
> Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit :
> > ffmpeg | branch: master | Rostislav Pehlivanov  |
> Mon Oct  3 19:53:11 2016 +0100| [fbf295e2bd4d48d7a0a094ed5afce2fa5b6cf35a]
> | committer: Rostislav Pehlivanov
> >
> > aacenc: support extended channel layouts using PCEs
> >
> > This commit implements support for PCE (Program Configuration Elements)
> in the
> > AAC encoder, and as such allows for encoding of channel layouts not
> present
> > in the presets defined by the spec (which only lists the 8 most common
> ones).
> >
> > This has been a highly requested feature and is also the first open
> source encoder
> > to support this many layouts.
> >
> > Many thanks to pkviet  who implemented support for
> and
> > verified all channel layouts.
>
> This broke fate-aac-yoraw-encode.
>
> stddev:  160.76 PSNR: 52.21 MAXDIFF: 3105 bytes:   576972/   577536
> stddev: |160.76 - 259| >= 17
>
>
> Regards,
>
> --
>   Nicolas George
>
>
> Thanks a lot.
> That's probably related to the fixes that I pointed out in my last message
> on the thread.
> I'll run fate later today on my aacdev branch on github
> github.com/pkviet/FFmpeg to check that this fixes the issues.
> (amusant de croiser un autre archicube; moi, s92. Les échanges sont parfois
> vraiment musclés ici, il ne faut pas être susceptible ! :) )
> Regards,
> pkv
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Correct, the fix for 5.1/.0 also fixed this test.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] aacenc: support extended channel layouts using PCEs

2017-11-09 Thread Kv Pham 
Le 9 nov. 2017 10:12 AM, "Nicolas George"  a écrit :

Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit :
> ffmpeg | branch: master | Rostislav Pehlivanov  |
Mon Oct  3 19:53:11 2016 +0100| [fbf295e2bd4d48d7a0a094ed5afce2fa5b6cf35a]
| committer: Rostislav Pehlivanov
>
> aacenc: support extended channel layouts using PCEs
>
> This commit implements support for PCE (Program Configuration Elements)
in the
> AAC encoder, and as such allows for encoding of channel layouts not
present
> in the presets defined by the spec (which only lists the 8 most common
ones).
>
> This has been a highly requested feature and is also the first open
source encoder
> to support this many layouts.
>
> Many thanks to pkviet  who implemented support for
and
> verified all channel layouts.

This broke fate-aac-yoraw-encode.

stddev:  160.76 PSNR: 52.21 MAXDIFF: 3105 bytes:   576972/   577536
stddev: |160.76 - 259| >= 17


Regards,

--
  Nicolas George


Thanks a lot.
That's probably related to the fixes that I pointed out in my last message
on the thread.
I'll run fate later today on my aacdev branch on github
github.com/pkviet/FFmpeg to check that this fixes the issues.
(amusant de croiser un autre archicube; moi, s92. Les échanges sont parfois
vraiment musclés ici, il ne faut pas être susceptible ! :) )
Regards,
pkv
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] aacenc: support extended channel layouts using PCEs

2017-11-09 Thread Nicolas George 
Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit :
> ffmpeg | branch: master | Rostislav Pehlivanov  | Mon 
> Oct  3 19:53:11 2016 +0100| [fbf295e2bd4d48d7a0a094ed5afce2fa5b6cf35a] | 
> committer: Rostislav Pehlivanov
> 
> aacenc: support extended channel layouts using PCEs
> 
> This commit implements support for PCE (Program Configuration Elements) in the
> AAC encoder, and as such allows for encoding of channel layouts not present
> in the presets defined by the spec (which only lists the 8 most common ones).
> 
> This has been a highly requested feature and is also the first open source 
> encoder
> to support this many layouts.
> 
> Many thanks to pkviet  who implemented support for and
> verified all channel layouts.

This broke fate-aac-yoraw-encode.

stddev:  160.76 PSNR: 52.21 MAXDIFF: 3105 bytes:   576972/   577536
stddev: |160.76 - 259| >= 17

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel