Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_zoompan: fix specific corner case when no frame was ever requested from input

2017-09-09 Thread Paul B Mahol 
On 9/7/17, Nicolas George  wrote:
> Le primidi 21 fructidor, an CCXXV, Paul B Mahol a ecrit :
>> ffmpeg -lavfi
>> "testsrc2,trim=end_frame=1,zoompan=z='min(zoom+0.0015,1.5)':d=700:x='iw/2-(iw/zoom/2)':y='ih/2-(ih/zoom/2)'"
>> -f framecrc -
>>
>> Should output 700 frames and not 1 frame.
>
> It does. So my patch is valid. Will push soon unless I see a complete
> console output proving it is not.

When amerge filter will be improved?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_zoompan: fix specific corner case when no frame was ever requested from input

2017-09-07 Thread Nicolas George 
Le primidi 21 fructidor, an CCXXV, Paul B Mahol a écrit :
> ffmpeg -lavfi 
> "testsrc2,trim=end_frame=1,zoompan=z='min(zoom+0.0015,1.5)':d=700:x='iw/2-(iw/zoom/2)':y='ih/2-(ih/zoom/2)'"
> -f framecrc -
> 
> Should output 700 frames and not 1 frame.

It does. So my patch is valid. Will push soon unless I see a complete
console output proving it is not.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_zoompan: fix specific corner case when no frame was ever requested from input

2017-09-07 Thread Paul B Mahol 
On 9/7/17, Nicolas George  wrote:
> Le primidi 21 fructidor, an CCXXV, Paul B Mahol a ecrit :
>> Take single image as input, and example as listed in documentation of
>> zoompan:
>>
>> zoompan=z='min(zoom+0.0015,1.5)':d=700:x='iw/2-(iw/zoom/2)':y='ih/2-(ih/zoom/2)'
>
> I am sorry but I have better use of my time than debugging this filter.
> So please, if you want any help about it, give me a complete, exact and
> minimal command-line that I can use, and describe precisely what I am
> supposed to observe both in the case where it works and in the case
> where it does not.

ffmpeg -lavfi 
"testsrc2,trim=end_frame=1,zoompan=z='min(zoom+0.0015,1.5)':d=700:x='iw/2-(iw/zoom/2)':y='ih/2-(ih/zoom/2)'"
-f framecrc -

Should output 700 frames and not 1 frame.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_zoompan: fix specific corner case when no frame was ever requested from input

2017-09-07 Thread Nicolas George 
Le primidi 21 fructidor, an CCXXV, Paul B Mahol a écrit :
> Take single image as input, and example as listed in documentation of zoompan:
> 
> zoompan=z='min(zoom+0.0015,1.5)':d=700:x='iw/2-(iw/zoom/2)':y='ih/2-(ih/zoom/2)'

I am sorry but I have better use of my time than debugging this filter.
So please, if you want any help about it, give me a complete, exact and
minimal command-line that I can use, and describe precisely what I am
supposed to observe both in the case where it works and in the case
where it does not.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_zoompan: fix specific corner case when no frame was ever requested from input

2017-09-07 Thread Paul B Mahol 
On 9/7/17, Nicolas George  wrote:
> Le primidi 21 fructidor, an CCXXV, Paul B Mahol a ecrit :
>> What it should be?
>
> It should look like it does look after this patch. Maybe the change
> breaks something I did not notice, but the general logic should be what
> I wrote.
>
> The things that are wrong in the current state of code: checking
> ff_outlink_frame_wanted(), duplication of the output_single_frame() call
> block, impossible condition about ret < 0, duplicate semantic of the
> "finished" variable, useless conditions that mask the logic of the flow.
>
> Could you show an actual example that works with your current version
> and that does not work with the modified code?

Take single image as input, and example as listed in documentation of zoompan:

zoompan=z='min(zoom+0.0015,1.5)':d=700:x='iw/2-(iw/zoom/2)':y='ih/2-(ih/zoom/2)'
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_zoompan: fix specific corner case when no frame was ever requested from input

2017-09-07 Thread Nicolas George 
Le primidi 21 fructidor, an CCXXV, Paul B Mahol a écrit :
> What it should be?

It should look like it does look after this patch. Maybe the change
breaks something I did not notice, but the general logic should be what
I wrote.

The things that are wrong in the current state of code: checking
ff_outlink_frame_wanted(), duplication of the output_single_frame() call
block, impossible condition about ret < 0, duplicate semantic of the
"finished" variable, useless conditions that mask the logic of the flow.

Could you show an actual example that works with your current version
and that does not work with the modified code?

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_zoompan: fix specific corner case when no frame was ever requested from input

2017-09-07 Thread Paul B Mahol 
On 9/7/17, Nicolas George  wrote:
> Le primidi 21 fructidor, an CCXXV, Paul B Mahol a ecrit :
>> ffmpeg | branch: master | Paul B Mahol  | Thu Sep  7
>> 16:49:46 2017 +0200| [e1524de4546beab75cbf600fdde6c14204a66059] |
>> committer: Paul B Mahol
>>
>> avfilter/vf_zoompan: fix specific corner case when no frame was ever
>> requested from input
>>
>> Reported-by: Nicolas George
>> Signed-off-by: Paul B Mahol 
>
> I am sorry, but it does not fix anything. The logic of the activate()
> callback is still completely bogus and non-conforming to what it should
> be.

What it should be?

>
> I could help you fix it, but apparently you are not interested.

I'm interested in everyone's opinion.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_zoompan: fix specific corner case when no frame was ever requested from input

2017-09-07 Thread Nicolas George 
Le primidi 21 fructidor, an CCXXV, Paul B Mahol a écrit :
> ffmpeg | branch: master | Paul B Mahol  | Thu Sep  7 
> 16:49:46 2017 +0200| [e1524de4546beab75cbf600fdde6c14204a66059] | committer: 
> Paul B Mahol
> 
> avfilter/vf_zoompan: fix specific corner case when no frame was ever 
> requested from input
> 
> Reported-by: Nicolas George
> Signed-off-by: Paul B Mahol 

I am sorry, but it does not fix anything. The logic of the activate()
callback is still completely bogus and non-conforming to what it should
be.

I could help you fix it, but apparently you are not interested.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel