Re: [FFmpeg-devel] [PATCH][RFC] avcodec/dpxenc: add option to force color transfer characteristics

2018-04-11 Thread Hendrik Leppkes
On Wed, Apr 11, 2018 at 10:42 AM, Tobias Rapp wrote: > On 11.04.2018 10:23, Kieran O Leary wrote: >> >> Hi Carl, >> >> On Sat, Dec 16, 2017 at 2:31 PM, Carl Eugen Hoyos >> wrote: >>> >>> 2017-12-15 22:22 GMT+01:00 Tobias Rapp : >>> +{ "dpx_color_trc", "Transfer Characteristics", OFFSET(

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/dpxenc: add option to force color transfer characteristics

2018-04-11 Thread Kieran O Leary
On Wed, Apr 11, 2018 at 9:42 AM, Tobias Rapp wrote: > On 11.04.2018 10:23, Kieran O Leary wrote: >> >> Hi Carl, >> >> On Sat, Dec 16, 2017 at 2:31 PM, Carl Eugen Hoyos >> wrote: >>> >>> 2017-12-15 22:22 GMT+01:00 Tobias Rapp : >>> +{ "dpx_color_trc", "Transfer Characteristics", OFFSET(c

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/dpxenc: add option to force color transfer characteristics

2018-04-11 Thread Tobias Rapp
On 11.04.2018 10:23, Kieran O Leary wrote: Hi Carl, On Sat, Dec 16, 2017 at 2:31 PM, Carl Eugen Hoyos wrote: 2017-12-15 22:22 GMT+01:00 Tobias Rapp : +{ "dpx_color_trc", "Transfer Characteristics", OFFSET(color_trc), AV_OPT_TYPE_INT, { .i64 = DPX_TRC_UNDEFINED }, DPX_TRC_UNDEFINED, DPX

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/dpxenc: add option to force color transfer characteristics

2018-04-11 Thread Kieran O Leary
Hi Carl, On Sat, Dec 16, 2017 at 2:31 PM, Carl Eugen Hoyos wrote: > 2017-12-15 22:22 GMT+01:00 Tobias Rapp : > >> +{ "dpx_color_trc", "Transfer Characteristics", OFFSET(color_trc), >> AV_OPT_TYPE_INT, { .i64 = DPX_TRC_UNDEFINED }, DPX_TRC_UNDEFINED, >> DPX_TRC_NB-1, VE, "trc" }, > > This s

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/dpxenc: add option to force color transfer characteristics

2017-12-16 Thread Carl Eugen Hoyos
2017-12-15 22:22 GMT+01:00 Tobias Rapp : > +{ "dpx_color_trc", "Transfer Characteristics", OFFSET(color_trc), > AV_OPT_TYPE_INT, { .i64 = DPX_TRC_UNDEFINED }, DPX_TRC_UNDEFINED, > DPX_TRC_NB-1, VE, "trc" }, This seems wrong to me, we have colour characteristics in general code. Carl Eugen

[FFmpeg-devel] [PATCH][RFC] avcodec/dpxenc: add option to force color transfer characteristics

2017-12-15 Thread Tobias Rapp
Based on a patch by Kieran O'Leary. Fixes ticket #6023. Open topics: - is there some mapping missing in color_trc_to_dpx? - the default for color_trc is DPX_TRC_UNDEFINED, would it be better to use DPX_TRC_USER_DEFINED instead? - do we need a separate encoder option for the colorimetric s