Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-23 Thread Andreas Cadhalpun
On 22.01.2016 09:55, wm4 wrote: > In any case, what was going on with hw decoding and frame threading > seemed pretty insane. Claiming that things 'seem pretty insane' is a lame argument. One can say that about a lot of things that people expect to work. > So even if this is a "regression", It i

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-22 Thread wm4
On Fri, 22 Jan 2016 00:14:15 +0100 Andreas Cadhalpun wrote: > On 21.01.2016 23:56, Hendrik Leppkes wrote: > > On Thu, Jan 21, 2016 at 8:36 PM, Andreas Cadhalpun > > wrote: > >> On 21.01.2016 02:10, Hendrik Leppkes wrote: > >>> Looks like they added extensive locking around everything to prev

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-21 Thread Andreas Cadhalpun
On 21.01.2016 23:56, Hendrik Leppkes wrote: > On Thu, Jan 21, 2016 at 8:36 PM, Andreas Cadhalpun > wrote: >> On 21.01.2016 02:10, Hendrik Leppkes wrote: >>> Looks like they added extensive locking around everything to prevent >>> this, which is not something that should be required. [...] >>> No,

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-21 Thread Hendrik Leppkes
On Thu, Jan 21, 2016 at 8:36 PM, Andreas Cadhalpun wrote: > On 21.01.2016 02:10, Hendrik Leppkes wrote: >> On Thu, Jan 21, 2016 at 1:14 AM, Andreas Cadhalpun >>> I'm still not sure of the scope that this problem has. >>> >>> If image corruption always happens with MT+HWAccel, why didn't VLC >>> ch

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-21 Thread Andreas Cadhalpun
On 21.01.2016 02:10, Hendrik Leppkes wrote: > On Thu, Jan 21, 2016 at 1:14 AM, Andreas Cadhalpun >> I'm still not sure of the scope that this problem has. >> >> If image corruption always happens with MT+HWAccel, why didn't VLC >> change this long ago due to users complaining about that? > > I don

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread Hendrik Leppkes
On Thu, Jan 21, 2016 at 1:14 AM, Andreas Cadhalpun wrote: > On 20.01.2016 10:22, Hendrik Leppkes wrote: >> On Tue, Jan 19, 2016 at 11:54 PM, Andreas Cadhalpun >>> Can the crashes be reproduced with VLC? >>> If so, are they reported in the VLC bug tracker? >> >> Who knows, I didn't test every singl

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread Andreas Cadhalpun
On 20.01.2016 10:22, Hendrik Leppkes wrote: > On Tue, Jan 19, 2016 at 11:54 PM, Andreas Cadhalpun >> Can the crashes be reproduced with VLC? >> If so, are they reported in the VLC bug tracker? > > Who knows, I didn't test every single player that uses avcodec. > The image corruption on Intel GPUs

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread Andreas Cadhalpun
On 20.01.2016 10:11, wm4 wrote: > On Tue, 19 Jan 2016 23:54:48 +0100 > Andreas Cadhalpun wrote: >> On 19.01.2016 21:46, wm4 wrote: >>> It was discussed to death on #libav-devel too. >> >> And the conclusion was to allow hwaccel with frame threads? > > From what I remember, the VLC developer in

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread Andy Furniss
Hendrik Leppkes wrote: On Wed, Jan 20, 2016 at 12:13 PM, Andy Furniss wrote: wm4 wrote: On Wed, 20 Jan 2016 09:59:12 + Andy Furniss wrote: wm4 wrote: On Wed, 20 Jan 2016 00:42:18 + Andy Furniss wrote: Hendrik Leppkes wrote: I do not agree that it should be a warning. As outl

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread Hendrik Leppkes
On Wed, Jan 20, 2016 at 12:13 PM, Andy Furniss wrote: > wm4 wrote: >> >> On Wed, 20 Jan 2016 09:59:12 + Andy Furniss >> wrote: >> >>> wm4 wrote: On Wed, 20 Jan 2016 00:42:18 + Andy Furniss wrote: > Hendrik Leppkes wrote: > I do not agree that it shoul

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread Andy Furniss
wm4 wrote: On Wed, 20 Jan 2016 09:59:12 + Andy Furniss wrote: wm4 wrote: On Wed, 20 Jan 2016 00:42:18 + Andy Furniss wrote: Hendrik Leppkes wrote: I do not agree that it should be a warning. As outlined in the commit message and this thread, there are serious flaws with frame thr

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread wm4
On Wed, 20 Jan 2016 09:59:12 + Andy Furniss wrote: > wm4 wrote: > > On Wed, 20 Jan 2016 00:42:18 + Andy Furniss > > wrote: > > > >> Hendrik Leppkes wrote: > >> > > I do not agree that it should be a warning. As outlined in > > the commit message and this thread, there are ser

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread Andy Furniss
wm4 wrote: On Wed, 20 Jan 2016 00:42:18 + Andy Furniss wrote: Hendrik Leppkes wrote: I do not agree that it should be a warning. As outlined in the commit message and this thread, there are serious flaws with frame threading and hwaccel. I'm fine with it being an error, but since it is

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread Hendrik Leppkes
On Tue, Jan 19, 2016 at 11:54 PM, Andreas Cadhalpun wrote: > On 19.01.2016 21:46, wm4 wrote: >> On Tue, 19 Jan 2016 21:31:19 +0100 >> Hendrik Leppkes wrote: >>> On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun >>> wrote: On 19.01.2016 21:22, Hendrik Leppkes wrote: > On Tue, Jan 19, 20

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread wm4
On Tue, 19 Jan 2016 23:54:48 +0100 Andreas Cadhalpun wrote: > On 19.01.2016 21:46, wm4 wrote: > > On Tue, 19 Jan 2016 21:31:19 +0100 > > Hendrik Leppkes wrote: > >> On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun > >> wrote: > >>> On 19.01.2016 21:22, Hendrik Leppkes wrote: > On

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-20 Thread wm4
On Wed, 20 Jan 2016 00:42:18 + Andy Furniss wrote: > Hendrik Leppkes wrote: > > >>> I do not agree that it should be a warning. As outlined in the > >>> commit message and this thread, there are serious flaws with > >>> frame threading and hwaccel. > >> > >> I'm fine with it being an error

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andy Furniss
Hendrik Leppkes wrote: I do not agree that it should be a warning. As outlined in the commit message and this thread, there are serious flaws with frame threading and hwaccel. I'm fine with it being an error, but since it is an API change, it should follow the usual deprecation period to allow

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
Hi Ronald, On 19.01.2016 21:53, Ronald S. Bultje wrote: > Crashes are never good and should be fixed immediately. > > What exact issue is left after the crash is fixed, and why? The issue is that VLC from git master doesn't compile with FFmpeg from git master, unless all hardware acceleration o

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
On 19.01.2016 21:46, wm4 wrote: > On Tue, 19 Jan 2016 21:31:19 +0100 > Hendrik Leppkes wrote: >> On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun >> wrote: >>> On 19.01.2016 21:22, Hendrik Leppkes wrote: On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun wrote: They don't la

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Ronald S. Bultje
Hi, On Tue, Jan 19, 2016 at 3:41 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 19.01.2016 21:31, Hendrik Leppkes wrote: > > On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun > > wrote: > >> On 19.01.2016 21:22, Hendrik Leppkes wrote: > >>> On Tue, Jan 19, 2016 at 9:13 PM

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread wm4
On Tue, 19 Jan 2016 21:31:19 +0100 Hendrik Leppkes wrote: > On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun > wrote: > > On 19.01.2016 21:22, Hendrik Leppkes wrote: > >> On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun > >> wrote: > >>> On 22.10.2015 11:44, Hendrik Leppkes wrote: > >

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
On 19.01.2016 21:31, Hendrik Leppkes wrote: > On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun > wrote: >> On 19.01.2016 21:22, Hendrik Leppkes wrote: >>> On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun >>> wrote: On 22.10.2015 11:44, Hendrik Leppkes wrote: They now made VLC's conf

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Hendrik Leppkes
On Tue, Jan 19, 2016 at 9:27 PM, Andreas Cadhalpun wrote: > On 19.01.2016 21:22, Hendrik Leppkes wrote: >> On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun >> wrote: >>> On 22.10.2015 11:44, Hendrik Leppkes wrote: On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: > VLC is using frame

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
On 19.01.2016 21:22, Hendrik Leppkes wrote: > On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun > wrote: >> On 22.10.2015 11:44, Hendrik Leppkes wrote: >>> On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: VLC is using frame threading with hwaccel >>> >>> Then they should fix their usage, i

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Hendrik Leppkes
On Tue, Jan 19, 2016 at 9:13 PM, Andreas Cadhalpun wrote: > On 22.10.2015 11:44, Hendrik Leppkes wrote: >> On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: >>> VLC is using frame threading with hwaccel >> >> Then they should fix their usage, its broken by design, as explained >> in detail my pos

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2016-01-19 Thread Andreas Cadhalpun
On 22.10.2015 11:44, Hendrik Leppkes wrote: > On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: >> VLC is using frame threading with hwaccel > > Then they should fix their usage, its broken by design, as explained > in detail my post earlier in this thread. Care to provide a patch for them? The

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-30 Thread Hendrik Leppkes
On Thu, Oct 29, 2015 at 8:31 PM, Andy Furniss wrote: > Hendrik Leppkes wrote: >> >> On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin >> wrote: >>> >>> VLC is using frame threading with hwaccel >> >> >> Then they should fix their usage, its broken by design, as explained >> in detail my post earlier in

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-29 Thread Andy Furniss
Hendrik Leppkes wrote: On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: VLC is using frame threading with hwaccel Then they should fix their usage, its broken by design, as explained in detail my post earlier in this thread. Seems ffmpeg cli does the same by default - OK so users can speci

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-22 Thread Hendrik Leppkes
On Thu, Oct 22, 2015 at 11:27 AM, Wang Bin wrote: > VLC is using frame threading with hwaccel Then they should fix their usage, its broken by design, as explained in detail my post earlier in this thread. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-22 Thread Wang Bin
VLC is using frame threading with hwaccel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-21 Thread wm4
On Wed, 21 Oct 2015 11:53:46 +0200 Hendrik Leppkes wrote: > On Wed, Oct 21, 2015 at 11:44 AM, Gwenole Beauchesne > wrote: > > 2015-10-21 11:27 GMT+02:00 Hendrik Leppkes : > >> On Sat, Oct 17, 2015 at 9:28 PM, Hendrik Leppkes > >> wrote: > >>> On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppk

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-21 Thread Hendrik Leppkes
On Wed, Oct 21, 2015 at 11:44 AM, Gwenole Beauchesne wrote: > 2015-10-21 11:27 GMT+02:00 Hendrik Leppkes : >> On Sat, Oct 17, 2015 at 9:28 PM, Hendrik Leppkes wrote: >>> On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes >>> wrote: --- libavcodec/utils.c | 6 ++ 1 file changed

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-21 Thread Gwenole Beauchesne
2015-10-21 11:27 GMT+02:00 Hendrik Leppkes : > On Sat, Oct 17, 2015 at 9:28 PM, Hendrik Leppkes wrote: >> On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes wrote: >>> --- >>> libavcodec/utils.c | 6 ++ >>> 1 file changed, 6 insertions(+) >>> >> >> Above patch is submitted as an RFC, however I

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-21 Thread Hendrik Leppkes
On Sat, Oct 17, 2015 at 9:28 PM, Hendrik Leppkes wrote: > On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes wrote: >> --- >> libavcodec/utils.c | 6 ++ >> 1 file changed, 6 insertions(+) >> > > Above patch is submitted as an RFC, however I strongly believe its the > only way to keep hwaccels

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-17 Thread wm4
On Sat, 17 Oct 2015 21:28:50 +0200 Hendrik Leppkes wrote: > On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes wrote: > > --- > > libavcodec/utils.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > Above patch is submitted as an RFC, however I strongly believe its the > only way to keep

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-17 Thread Hendrik Leppkes
On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes wrote: > --- > libavcodec/utils.c | 6 ++ > 1 file changed, 6 insertions(+) > Above patch is submitted as an RFC, however I strongly believe its the only way to keep hwaccels sane in the future. There are several known problems when a hwaccel

[FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-17 Thread Hendrik Leppkes
--- libavcodec/utils.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 0e4f3c0..52b480a 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1006,6 +1006,12 @@ static int setup_hwaccel(AVCodecContext *avctx, AVHWAccel *hwa = find