Re: [FFmpeg-devel] [PATCH][RFC] avutil/reverse: make ff_reverse shared

2017-12-01 Thread Michael Niedermayer
On Thu, Nov 30, 2017 at 10:19:36PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Pros: > Removes duplicate arrays and ugly c file including c files > > Cons: > Makes the array in libavutil effectively part of the ABI. > Might not be worth doing for 256 bytes

Re: [FFmpeg-devel] [PATCH][RFC] avutil/reverse: make ff_reverse shared

2017-12-01 Thread Hendrik Leppkes
On Fri, Dec 1, 2017 at 9:42 AM, Nicolas George wrote: > James Almer (2017-11-30): >> Signed-off-by: James Almer >> --- >> Pros: >> Removes duplicate arrays and ugly c file including c files >> >> Cons: >> Makes the array in libavutil effectively part of the

Re: [FFmpeg-devel] [PATCH][RFC] avutil/reverse: make ff_reverse shared

2017-12-01 Thread Nicolas George
James Almer (2017-11-30): > Signed-off-by: James Almer > --- > Pros: > Removes duplicate arrays and ugly c file including c files > > Cons: > Makes the array in libavutil effectively part of the ABI. > Might not be worth doing for 256 bytes > > > Something like this was

Re: [FFmpeg-devel] [PATCH][RFC] avutil/reverse: make ff_reverse shared

2017-11-30 Thread Steven Liu
2017-12-01 9:19 GMT+08:00 James Almer : > Signed-off-by: James Almer > --- > Pros: > Removes duplicate arrays and ugly c file including c files > > Cons: > Makes the array in libavutil effectively part of the ABI. > Might not be worth doing for 256 bytes > >

[FFmpeg-devel] [PATCH][RFC] avutil/reverse: make ff_reverse shared

2017-11-30 Thread James Almer
Signed-off-by: James Almer --- Pros: Removes duplicate arrays and ugly c file including c files Cons: Makes the array in libavutil effectively part of the ABI. Might not be worth doing for 256 bytes Something like this was probably sent before, so i guess it will be rejected