Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> You can not merge filters by removing other filters as that will break >> user scripts. > > I know how do avoid that, thank you very much. > How would you avoid that? ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
Paul B Mahol (12019-05-12): > You can not merge filters by removing other filters as that will break > user scripts. I know how do avoid that, thank you very much. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> We have both setsar and setdar, > > And that is a mistake. We should have a single "set" filter that can > change all the transparent numeric properties of frames (sar, time base, > timestamp, colorspace, etc.). One of the

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
Paul B Mahol (12019-05-12): > We have both setsar and setdar, And that is a mistake. We should have a single "set" filter that can change all the transparent numeric properties of frames (sar, time base, timestamp, colorspace, etc.). One of the benefits: it can notify users who set inconsistent

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> Calling atempo filter atempo when it also modifies pitch is bad for users >> and >> at same time not having apitch filter, user would think that they can >> not alter pitch. >> Sorry if you can not understand my fears. > > As I

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
Tim Jones (12019-05-12): > Coming from the audio world, tempo, and pitch are different things. Tempo and pitch are not the same thing. But changing them is the same thing. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Tim Jones
On May 12, 2019, at 11:51 AM, Nicolas George wrote: > > Paul B Mahol (12019-05-12): >> Calling atempo filter atempo when it also modifies pitch is bad for users and >> at same time not having apitch filter, user would think that they can >> not alter pitch. >> Sorry if you can not understand my

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
Paul B Mahol (12019-05-12): > Calling atempo filter atempo when it also modifies pitch is bad for users and > at same time not having apitch filter, user would think that they can > not alter pitch. > Sorry if you can not understand my fears. As I have pointed to you (but you made a show of

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> That is hard problem, how would one know what implementation is best for >> user scenario. > > Better developers who know the limits of their filters than users who do > not know. > >> I disagree, current filter have artifacts

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
Paul B Mahol (12019-05-12): > That is hard problem, how would one know what implementation is best for > user scenario. Better developers who know the limits of their filters than users who do not know. > I disagree, current filter have artifacts with small scale factors. And that is what you

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
Hi, On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-11): >> It is currently separate filter for ease of testing. > > Then no problem. But I insist: once it is in shape, for the convenience > of the users and ease of maintenance, it should be a single filter. > > Of course, if you

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
Paul B Mahol (12019-05-11): > It is currently separate filter for ease of testing. Then no problem. But I insist: once it is in shape, for the convenience of the users and ease of maintenance, it should be a single filter. Of course, if you disagree, we can discuss it here. > It can not be

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-11 Thread Paul B Mahol
Hi, On 5/11/19, Nicolas George wrote: > Paul B Mahol (12019-05-11): >> Signed-off-by: Paul B Mahol >> --- >> >> This filter can dynamically change both tempo and pitch of audio. >> Also scale range is bigger, from 0.01 to 100. >> >> --- >> libavfilter/Makefile | 1 + >>

[FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- This filter can dynamically change both tempo and pitch of audio. Also scale range is bigger, from 0.01 to 100. --- libavfilter/Makefile | 1 + libavfilter/af_apitch.c | 764 +++ libavfilter/allfilters.c | 1 + 3

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-11 Thread Nicolas George
Paul B Mahol (12019-05-11): > Signed-off-by: Paul B Mahol > --- > > This filter can dynamically change both tempo and pitch of audio. > Also scale range is bigger, from 0.01 to 100. > > --- > libavfilter/Makefile | 1 + > libavfilter/af_apitch.c | 764