subject:"\[FFmpeg\-devel\] \[PATCH\]\[libavfilter\] codecview\: improved options"

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-06-15 Thread Michael Niedermayer

On Thu, Jun 09, 2016 at 01:24:57PM +, Davinder Singh wrote:
> On Mon, May 30, 2016 at 1:45 PM Michael Niedermayer 
> wrote:
> 
> > On Mon, May 23, 2016 at 05:09:35PM +, Davinder Singh wrote:
> > >  vf_codecview.c |   55
> > +--
> > >  1 file changed, 45 insertions(+), 10 deletions(-)
> > > 464b23c4638d1a408e8237651facf327994945bf
> > 0001-vf_codecview-added-new-options.patch
> > > From 641d6f92e792ea7def3610f5462b6bbec019c4b7 Mon Sep 17 00:00:00 2001
> > > From: dsmudhar 
> > > Date: Mon, 23 May 2016 22:29:51 +0530
> > > Subject: [PATCH] vf_codecview: added new options
> > >
> > > ---
> > >  libavfilter/vf_codecview.c | 55
> > +-
> > >  1 file changed, 45 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/libavfilter/vf_codecview.c b/libavfilter/vf_codecview.c
> > > index e70b397..1cb521d 100644
> > > --- a/libavfilter/vf_codecview.c
> > > +++ b/libavfilter/vf_codecview.c
> > > @@ -38,21 +38,39 @@
> > >  #define MV_P_FOR  (1<<0)
> > >  #define MV_B_FOR  (1<<1)
> > >  #define MV_B_BACK (1<<2)
> > > +#define MV_TYPE_FOR  (1<<0)
> > > +#define MV_TYPE_BACK (1<<1)
> > > +#define FRAME_TYPE_I (1<<0)
> > > +#define FRAME_TYPE_P (1<<1)
> > > +#define FRAME_TYPE_B (1<<2)
> > >
> > >  typedef struct {
> > >  const AVClass *class;
> > >  unsigned mv;
> > > +unsigned frame_type;
> > > +unsigned mv_type;
> > >  int hsub, vsub;
> > >  int qp;
> > >  } CodecViewContext;
> > >
> > >  #define OFFSET(x) offsetof(CodecViewContext, x)
> > >  #define FLAGS AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_VIDEO_PARAM
> > > +#define CONST(name, help, val, unit) { name, help, 0,
> > AV_OPT_TYPE_CONST, {.i64=val}, 0, 0, FLAGS, unit }
> > > +
> > >  static const AVOption codecview_options[] = {
> > >  { "mv", "set motion vectors to visualize", OFFSET(mv),
> > AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv" },
> > > -{"pf", "forward predicted MVs of P-frames",  0,
> > AV_OPT_TYPE_CONST, {.i64 = MV_P_FOR },  INT_MIN, INT_MAX, FLAGS, "mv"},
> > > -{"bf", "forward predicted MVs of B-frames",  0,
> > AV_OPT_TYPE_CONST, {.i64 = MV_B_FOR },  INT_MIN, INT_MAX, FLAGS, "mv"},
> > > -{"bb", "backward predicted MVs of B-frames", 0,
> > AV_OPT_TYPE_CONST, {.i64 = MV_B_BACK }, INT_MIN, INT_MAX, FLAGS, "mv"},
> > > +CONST("pf", "forward predicted MVs of P-frames",  MV_P_FOR,
> > "mv"),
> > > +CONST("bf", "forward predicted MVs of B-frames",  MV_B_FOR,
> > "mv"),
> > > +CONST("bb", "backward predicted MVs of B-frames", MV_B_BACK,
> > "mv"),
> > > +{ "mv_type", "set motion vectors type", OFFSET(mv_type),
> > AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv_type" },
> > > +{ "mvt", "set motion vectors type", OFFSET(mv_type),
> > AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv_type" },
> > > +CONST("fp", "forward predicted MVs",  MV_TYPE_FOR,  "mv_type"),
> > > +CONST("bp", "backward predicted MVs", MV_TYPE_BACK, "mv_type"),
> > > +{ "frame_type", "set frame types to visualize motion vectors of",
> > OFFSET(frame_type), AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS,
> > "frame_type" },
> > > +{ "ft", "set frame types to visualize motion vectors of",
> > OFFSET(frame_type), AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS,
> > "frame_type" },
> > > +CONST("if", "I-frames", FRAME_TYPE_I, "frame_type"),
> > > +CONST("pf", "P-frames", FRAME_TYPE_P, "frame_type"),
> > > +CONST("bf", "B-frames", FRAME_TYPE_B, "frame_type"),
> > >  { "qp", NULL, OFFSET(qp), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, .flags
> > = FLAGS },
> >
> > the new options should be added at the end, inserting them in the middle
> > breaks for example
> > -flags2 +export_mvs -vf codecview=0:1
> >
> > [...]
> >
> > --
> > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > Good people do not need laws to tell them to act responsibly, while bad
> > people will find a way around the laws. -- Plato
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> 
> patch attached.

>  doc/filters.texi   |   38 ---
>  libavfilter/vf_codecview.c |   55 
> -
>  2 files changed, 80 insertions(+), 13 deletions(-)
> 88778603071af6afe4dd2d0ab37a0802449e792c  
> 0001-vf_codecview-added-new-options.patch
> From 44016bf074281bf96ee40567b5aaf6a7d4d9f063 Mon Sep 17 00:00:00 2001
> From: dsmudhar 
> Date: Thu, 9 Jun 2016 18:42:33 +0530
> Subject: [PATCH] vf_codecview: added new options

applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-06-09 Thread Davinder Singh

On Mon, May 30, 2016 at 1:45 PM Michael Niedermayer 
wrote:

> On Mon, May 23, 2016 at 05:09:35PM +, Davinder Singh wrote:
> >  vf_codecview.c |   55
> +--
> >  1 file changed, 45 insertions(+), 10 deletions(-)
> > 464b23c4638d1a408e8237651facf327994945bf
> 0001-vf_codecview-added-new-options.patch
> > From 641d6f92e792ea7def3610f5462b6bbec019c4b7 Mon Sep 17 00:00:00 2001
> > From: dsmudhar 
> > Date: Mon, 23 May 2016 22:29:51 +0530
> > Subject: [PATCH] vf_codecview: added new options
> >
> > ---
> >  libavfilter/vf_codecview.c | 55
> +-
> >  1 file changed, 45 insertions(+), 10 deletions(-)
> >
> > diff --git a/libavfilter/vf_codecview.c b/libavfilter/vf_codecview.c
> > index e70b397..1cb521d 100644
> > --- a/libavfilter/vf_codecview.c
> > +++ b/libavfilter/vf_codecview.c
> > @@ -38,21 +38,39 @@
> >  #define MV_P_FOR  (1<<0)
> >  #define MV_B_FOR  (1<<1)
> >  #define MV_B_BACK (1<<2)
> > +#define MV_TYPE_FOR  (1<<0)
> > +#define MV_TYPE_BACK (1<<1)
> > +#define FRAME_TYPE_I (1<<0)
> > +#define FRAME_TYPE_P (1<<1)
> > +#define FRAME_TYPE_B (1<<2)
> >
> >  typedef struct {
> >  const AVClass *class;
> >  unsigned mv;
> > +unsigned frame_type;
> > +unsigned mv_type;
> >  int hsub, vsub;
> >  int qp;
> >  } CodecViewContext;
> >
> >  #define OFFSET(x) offsetof(CodecViewContext, x)
> >  #define FLAGS AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_VIDEO_PARAM
> > +#define CONST(name, help, val, unit) { name, help, 0,
> AV_OPT_TYPE_CONST, {.i64=val}, 0, 0, FLAGS, unit }
> > +
> >  static const AVOption codecview_options[] = {
> >  { "mv", "set motion vectors to visualize", OFFSET(mv),
> AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv" },
> > -{"pf", "forward predicted MVs of P-frames",  0,
> AV_OPT_TYPE_CONST, {.i64 = MV_P_FOR },  INT_MIN, INT_MAX, FLAGS, "mv"},
> > -{"bf", "forward predicted MVs of B-frames",  0,
> AV_OPT_TYPE_CONST, {.i64 = MV_B_FOR },  INT_MIN, INT_MAX, FLAGS, "mv"},
> > -{"bb", "backward predicted MVs of B-frames", 0,
> AV_OPT_TYPE_CONST, {.i64 = MV_B_BACK }, INT_MIN, INT_MAX, FLAGS, "mv"},
> > +CONST("pf", "forward predicted MVs of P-frames",  MV_P_FOR,
> "mv"),
> > +CONST("bf", "forward predicted MVs of B-frames",  MV_B_FOR,
> "mv"),
> > +CONST("bb", "backward predicted MVs of B-frames", MV_B_BACK,
> "mv"),
> > +{ "mv_type", "set motion vectors type", OFFSET(mv_type),
> AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv_type" },
> > +{ "mvt", "set motion vectors type", OFFSET(mv_type),
> AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv_type" },
> > +CONST("fp", "forward predicted MVs",  MV_TYPE_FOR,  "mv_type"),
> > +CONST("bp", "backward predicted MVs", MV_TYPE_BACK, "mv_type"),
> > +{ "frame_type", "set frame types to visualize motion vectors of",
> OFFSET(frame_type), AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS,
> "frame_type" },
> > +{ "ft", "set frame types to visualize motion vectors of",
> OFFSET(frame_type), AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS,
> "frame_type" },
> > +CONST("if", "I-frames", FRAME_TYPE_I, "frame_type"),
> > +CONST("pf", "P-frames", FRAME_TYPE_P, "frame_type"),
> > +CONST("bf", "B-frames", FRAME_TYPE_B, "frame_type"),
> >  { "qp", NULL, OFFSET(qp), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, .flags
> = FLAGS },
>
> the new options should be added at the end, inserting them in the middle
> breaks for example
> -flags2 +export_mvs -vf codecview=0:1
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Good people do not need laws to tell them to act responsibly, while bad
> people will find a way around the laws. -- Plato
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


patch attached.


0001-vf_codecview-added-new-options.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-30 Thread Michael Niedermayer

On Mon, May 23, 2016 at 05:09:35PM +, Davinder Singh wrote:
>  vf_codecview.c |   55 +--
>  1 file changed, 45 insertions(+), 10 deletions(-)
> 464b23c4638d1a408e8237651facf327994945bf  
> 0001-vf_codecview-added-new-options.patch
> From 641d6f92e792ea7def3610f5462b6bbec019c4b7 Mon Sep 17 00:00:00 2001
> From: dsmudhar 
> Date: Mon, 23 May 2016 22:29:51 +0530
> Subject: [PATCH] vf_codecview: added new options
> 
> ---
>  libavfilter/vf_codecview.c | 55 
> +-
>  1 file changed, 45 insertions(+), 10 deletions(-)
> 
> diff --git a/libavfilter/vf_codecview.c b/libavfilter/vf_codecview.c
> index e70b397..1cb521d 100644
> --- a/libavfilter/vf_codecview.c
> +++ b/libavfilter/vf_codecview.c
> @@ -38,21 +38,39 @@
>  #define MV_P_FOR  (1<<0)
>  #define MV_B_FOR  (1<<1)
>  #define MV_B_BACK (1<<2)
> +#define MV_TYPE_FOR  (1<<0)
> +#define MV_TYPE_BACK (1<<1)
> +#define FRAME_TYPE_I (1<<0)
> +#define FRAME_TYPE_P (1<<1)
> +#define FRAME_TYPE_B (1<<2)
>  
>  typedef struct {
>  const AVClass *class;
>  unsigned mv;
> +unsigned frame_type;
> +unsigned mv_type;
>  int hsub, vsub;
>  int qp;
>  } CodecViewContext;
>  
>  #define OFFSET(x) offsetof(CodecViewContext, x)
>  #define FLAGS AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_VIDEO_PARAM
> +#define CONST(name, help, val, unit) { name, help, 0, AV_OPT_TYPE_CONST, 
> {.i64=val}, 0, 0, FLAGS, unit }
> +
>  static const AVOption codecview_options[] = {
>  { "mv", "set motion vectors to visualize", OFFSET(mv), 
> AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv" },
> -{"pf", "forward predicted MVs of P-frames",  0, AV_OPT_TYPE_CONST, 
> {.i64 = MV_P_FOR },  INT_MIN, INT_MAX, FLAGS, "mv"},
> -{"bf", "forward predicted MVs of B-frames",  0, AV_OPT_TYPE_CONST, 
> {.i64 = MV_B_FOR },  INT_MIN, INT_MAX, FLAGS, "mv"},
> -{"bb", "backward predicted MVs of B-frames", 0, AV_OPT_TYPE_CONST, 
> {.i64 = MV_B_BACK }, INT_MIN, INT_MAX, FLAGS, "mv"},
> +CONST("pf", "forward predicted MVs of P-frames",  MV_P_FOR,  "mv"),
> +CONST("bf", "forward predicted MVs of B-frames",  MV_B_FOR,  "mv"),
> +CONST("bb", "backward predicted MVs of B-frames", MV_B_BACK, "mv"),
> +{ "mv_type", "set motion vectors type", OFFSET(mv_type), 
> AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv_type" },
> +{ "mvt", "set motion vectors type", OFFSET(mv_type), 
> AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv_type" },
> +CONST("fp", "forward predicted MVs",  MV_TYPE_FOR,  "mv_type"),
> +CONST("bp", "backward predicted MVs", MV_TYPE_BACK, "mv_type"),
> +{ "frame_type", "set frame types to visualize motion vectors of", 
> OFFSET(frame_type), AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, 
> "frame_type" },
> +{ "ft", "set frame types to visualize motion vectors of", 
> OFFSET(frame_type), AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, 
> "frame_type" },
> +CONST("if", "I-frames", FRAME_TYPE_I, "frame_type"),
> +CONST("pf", "P-frames", FRAME_TYPE_P, "frame_type"),
> +CONST("bf", "B-frames", FRAME_TYPE_B, "frame_type"),
>  { "qp", NULL, OFFSET(qp), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, .flags = 
> FLAGS },

the new options should be added at the end, inserting them in the middle
breaks for example
-flags2 +export_mvs -vf codecview=0:1

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-23 Thread Davinder Singh

On Mon, May 23, 2016 at 10:15 PM Davinder Singh  wrote:

> On Sun, May 15, 2016 at 1:26 AM Michael Niedermayer 
> wrote:
>
>> it would be better if the previous syntax would still work, in addition
>> to any new things
>>
>> bug reports, mailing list posts, user experience and scripts may
>> use the old syntax
>>
>>
>> [...]
>>
>>
>> --
>> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>
>> Good people do not need laws to tell them to act responsibly, while bad
>> people will find a way around the laws. -- Plato
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
> [...]
>

minor change:
removed frame type condition (... || s->frame_type) from PATCH line 62 and
81, as specifying only frame_type won't do anything.

Thanks,
DSM_
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-14 Thread Michael Niedermayer

On Fri, May 13, 2016 at 06:05:26PM +, Davinder Singh wrote:
> should fix fate :)
> 
> On Wed, May 11, 2016 at 6:32 PM Michael Niedermayer 
> wrote:
> 
> > On Wed, May 11, 2016 at 12:41:43PM +, Davinder Singh wrote:
> > > single patch
> > >
> > > On Sun, May 8, 2016 at 1:18 AM Davinder Singh 
> > wrote:
> > >
> > > > separated motion vector types (forward or backward) from frame picture
> > > > types as MVs are associated with picture types only in video coding.
> > > >
> > > > option `mv` can have two values:
> > > > forward predicted or backward predicted.
> > > >
> > > > option `frames` can have three values:
> > > > p-frames, i-frames and b-frames.
> > > >
> > > > ex:
> > > > only forward predicted mvs of all frames:
> > > > -vf codecview=mv=fp
> > > >
> > > > mvs (both forward or backward predicted) of P or B-frames:
> > > > -vf codecview=mv=fp+bp:frames=pf+bf
> > > >
> > > > Regards,
> > > > DSM_
> > > >
> >
> > >  doc/filters.texi   |   30 --
> > >  libavfilter/vf_codecview.c |   36 ++--
> > >  2 files changed, 50 insertions(+), 16 deletions(-)
> > > 6168c73a45d4b183a4478909e4f8f3b0e47d1738
> > 0001-vf_codecview-improved-filter-options.patch
> > > From 0c2c258bd14d5dd58351271cc8c8859cd5edbf26 Mon Sep 17 00:00:00 2001
> > > From: dsmudhar 
> > > Date: Wed, 11 May 2016 17:57:39 +0530
> > > Subject: [PATCH] vf_codecview: improved filter options
> >
> > this breaks make fate
> >
> > make fate-filter-codecview-mvs
> > TESTfilter-codecview-mvs
> > --- ./tests/ref/fate/filter-codecview-mvs   2016-05-11
> > 04:21:34.187662201 +0200
> > +++ tests/data/fate/filter-codecview-mvs2016-05-11
> > 14:58:43.732467592 +0200
> > @@ -1,65 +0,0 @@
> > -#tb 0: 32768/785647
> > -#media_type 0: video
> > -#codec_id 0: rawvideo
> > -#dimensions 0: 576x320
> > -#sar 0: 0/1
> > -0,  0,  0,1,   276480, 0x5f7a0d4f
> > -0,  1,  1,1,   276480, 0x5f7a0d4f
> > -0,  2,  2,1,   276480, 0x5f7a0d4f
> > -0,  3,  3,1,   276480, 0x5f7a0d4f
> > -0,  4,  4,1,   276480, 0x5f7a0d4f
> > -0,  5,  5,1,   276480, 0x5f7a0d4f
> > -0,  6,  6,1,   276480, 0x5f7a0d4f
> > -0,  7,  7,1,   276480, 0x5f7a0d4f
> > -0,  8,  8,1,   276480, 0x5f7a0d4f
> > -0,  9,  9,1,   276480, 0x5f7a0d4f
> > -0, 10, 10,1,   276480, 0x5f7a0d4f
> > -0, 11, 11,1,   276480, 0x5f7a0d4f
> > -0, 12, 12,1,   276480, 0x5f7a0d4f
> > -0, 13, 13,1,   276480, 0x5f7a0d4f
> > -0, 14, 14,1,   276480, 0x5f7a0d4f
> > -0, 15, 15,1,   276480, 0x5f7a0d4f
> > -0, 16, 16,1,   276480, 0xc3b80edf
> > -0, 17, 17,1,   276480, 0x5f7a0d4f
> > -0, 18, 18,1,   276480, 0x5f7a0d4f
> > -0, 19, 19,1,   276480, 0x5f7a0d4f
> > -0, 20, 20,1,   276480, 0xc3b80edf
> > -0, 21, 21,1,   276480, 0x5f7a0d4f
> > -0, 22, 22,1,   276480, 0x5f7a0d4f
> > -0, 23, 23,1,   276480, 0x5f7a0d4f
> > -0, 24, 24,1,   276480, 0xc3b80edf
> > -0, 25, 25,1,   276480, 0x5f7a0d4f
> > -0, 26, 26,1,   276480, 0x5f7a0d4f
> > -0, 27, 27,1,   276480, 0x5f7a0d4f
> > -0, 28, 28,1,   276480, 0xc3b80edf
> > -0, 29, 29,1,   276480, 0x5f7a0d4f
> > -0, 30, 30,1,   276480, 0x5f7a0d4f
> > -0, 31, 31,1,   276480, 0x5f7a0d4f
> > -0, 32, 32,1,   276480, 0xc3b80edf
> > -0, 33, 33,1,   276480, 0x75641594
> > -0, 34, 34,1,   276480, 0x32ee3526
> > -0, 35, 35,1,   276480, 0xcb53479a
> > -0, 36, 36,1,   276480, 0xe1be6e26
> > -0, 37, 37,1,   276480, 0x5ce39368
> > -0, 38, 38,1,   276480, 0x4ec1e418
> > -0, 39, 39,1,   276480, 0x23c418ae
> > -0, 40, 40,1,   276480, 0x036a5515
> > -0, 41, 41,1,   276480, 0x7946efbd
> > -0, 42, 42,1,   276480, 0xd9aa1382
> > -0, 43, 43,1,   276480, 0x3863f9c8
> > -0, 44, 44,1,   276480, 0x33e47330
> > -0, 45, 45,1,   276480, 0xff6e8038
> > -0, 46, 46,1,   276480, 0xed3ff087
> > -0, 47, 47,1,   276480, 0xe7834514
> > -0, 48, 48,

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-14 Thread Davinder Singh

On Fri, May 13, 2016 at 11:35 PM Davinder Singh  wrote:

> should fix fate :)
>
*attached patch in that mail should fix fate.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-13 Thread Davinder Singh

should fix fate :)

On Wed, May 11, 2016 at 6:32 PM Michael Niedermayer 
wrote:

> On Wed, May 11, 2016 at 12:41:43PM +, Davinder Singh wrote:
> > single patch
> >
> > On Sun, May 8, 2016 at 1:18 AM Davinder Singh 
> wrote:
> >
> > > separated motion vector types (forward or backward) from frame picture
> > > types as MVs are associated with picture types only in video coding.
> > >
> > > option `mv` can have two values:
> > > forward predicted or backward predicted.
> > >
> > > option `frames` can have three values:
> > > p-frames, i-frames and b-frames.
> > >
> > > ex:
> > > only forward predicted mvs of all frames:
> > > -vf codecview=mv=fp
> > >
> > > mvs (both forward or backward predicted) of P or B-frames:
> > > -vf codecview=mv=fp+bp:frames=pf+bf
> > >
> > > Regards,
> > > DSM_
> > >
>
> >  doc/filters.texi   |   30 --
> >  libavfilter/vf_codecview.c |   36 ++--
> >  2 files changed, 50 insertions(+), 16 deletions(-)
> > 6168c73a45d4b183a4478909e4f8f3b0e47d1738
> 0001-vf_codecview-improved-filter-options.patch
> > From 0c2c258bd14d5dd58351271cc8c8859cd5edbf26 Mon Sep 17 00:00:00 2001
> > From: dsmudhar 
> > Date: Wed, 11 May 2016 17:57:39 +0530
> > Subject: [PATCH] vf_codecview: improved filter options
>
> this breaks make fate
>
> make fate-filter-codecview-mvs
> TESTfilter-codecview-mvs
> --- ./tests/ref/fate/filter-codecview-mvs   2016-05-11
> 04:21:34.187662201 +0200
> +++ tests/data/fate/filter-codecview-mvs2016-05-11
> 14:58:43.732467592 +0200
> @@ -1,65 +0,0 @@
> -#tb 0: 32768/785647
> -#media_type 0: video
> -#codec_id 0: rawvideo
> -#dimensions 0: 576x320
> -#sar 0: 0/1
> -0,  0,  0,1,   276480, 0x5f7a0d4f
> -0,  1,  1,1,   276480, 0x5f7a0d4f
> -0,  2,  2,1,   276480, 0x5f7a0d4f
> -0,  3,  3,1,   276480, 0x5f7a0d4f
> -0,  4,  4,1,   276480, 0x5f7a0d4f
> -0,  5,  5,1,   276480, 0x5f7a0d4f
> -0,  6,  6,1,   276480, 0x5f7a0d4f
> -0,  7,  7,1,   276480, 0x5f7a0d4f
> -0,  8,  8,1,   276480, 0x5f7a0d4f
> -0,  9,  9,1,   276480, 0x5f7a0d4f
> -0, 10, 10,1,   276480, 0x5f7a0d4f
> -0, 11, 11,1,   276480, 0x5f7a0d4f
> -0, 12, 12,1,   276480, 0x5f7a0d4f
> -0, 13, 13,1,   276480, 0x5f7a0d4f
> -0, 14, 14,1,   276480, 0x5f7a0d4f
> -0, 15, 15,1,   276480, 0x5f7a0d4f
> -0, 16, 16,1,   276480, 0xc3b80edf
> -0, 17, 17,1,   276480, 0x5f7a0d4f
> -0, 18, 18,1,   276480, 0x5f7a0d4f
> -0, 19, 19,1,   276480, 0x5f7a0d4f
> -0, 20, 20,1,   276480, 0xc3b80edf
> -0, 21, 21,1,   276480, 0x5f7a0d4f
> -0, 22, 22,1,   276480, 0x5f7a0d4f
> -0, 23, 23,1,   276480, 0x5f7a0d4f
> -0, 24, 24,1,   276480, 0xc3b80edf
> -0, 25, 25,1,   276480, 0x5f7a0d4f
> -0, 26, 26,1,   276480, 0x5f7a0d4f
> -0, 27, 27,1,   276480, 0x5f7a0d4f
> -0, 28, 28,1,   276480, 0xc3b80edf
> -0, 29, 29,1,   276480, 0x5f7a0d4f
> -0, 30, 30,1,   276480, 0x5f7a0d4f
> -0, 31, 31,1,   276480, 0x5f7a0d4f
> -0, 32, 32,1,   276480, 0xc3b80edf
> -0, 33, 33,1,   276480, 0x75641594
> -0, 34, 34,1,   276480, 0x32ee3526
> -0, 35, 35,1,   276480, 0xcb53479a
> -0, 36, 36,1,   276480, 0xe1be6e26
> -0, 37, 37,1,   276480, 0x5ce39368
> -0, 38, 38,1,   276480, 0x4ec1e418
> -0, 39, 39,1,   276480, 0x23c418ae
> -0, 40, 40,1,   276480, 0x036a5515
> -0, 41, 41,1,   276480, 0x7946efbd
> -0, 42, 42,1,   276480, 0xd9aa1382
> -0, 43, 43,1,   276480, 0x3863f9c8
> -0, 44, 44,1,   276480, 0x33e47330
> -0, 45, 45,1,   276480, 0xff6e8038
> -0, 46, 46,1,   276480, 0xed3ff087
> -0, 47, 47,1,   276480, 0xe7834514
> -0, 48, 48,1,   276480, 0x4d5d909d
> -0, 49, 49,1,   276480, 0x82eea962
> -0, 50, 50,1,   276480, 0x8075bca3
> -0, 51, 51,1,   276480, 0xd5dc3185
> -0, 52, 52,1,   276480,

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-11 Thread Michael Niedermayer

On Wed, May 11, 2016 at 12:41:43PM +, Davinder Singh wrote:
> single patch
> 
> On Sun, May 8, 2016 at 1:18 AM Davinder Singh  wrote:
> 
> > separated motion vector types (forward or backward) from frame picture
> > types as MVs are associated with picture types only in video coding.
> >
> > option `mv` can have two values:
> > forward predicted or backward predicted.
> >
> > option `frames` can have three values:
> > p-frames, i-frames and b-frames.
> >
> > ex:
> > only forward predicted mvs of all frames:
> > -vf codecview=mv=fp
> >
> > mvs (both forward or backward predicted) of P or B-frames:
> > -vf codecview=mv=fp+bp:frames=pf+bf
> >
> > Regards,
> > DSM_
> >

>  doc/filters.texi   |   30 --
>  libavfilter/vf_codecview.c |   36 ++--
>  2 files changed, 50 insertions(+), 16 deletions(-)
> 6168c73a45d4b183a4478909e4f8f3b0e47d1738  
> 0001-vf_codecview-improved-filter-options.patch
> From 0c2c258bd14d5dd58351271cc8c8859cd5edbf26 Mon Sep 17 00:00:00 2001
> From: dsmudhar 
> Date: Wed, 11 May 2016 17:57:39 +0530
> Subject: [PATCH] vf_codecview: improved filter options

this breaks make fate

make fate-filter-codecview-mvs
TESTfilter-codecview-mvs
--- ./tests/ref/fate/filter-codecview-mvs   2016-05-11 04:21:34.187662201 
+0200
+++ tests/data/fate/filter-codecview-mvs2016-05-11 14:58:43.732467592 
+0200
@@ -1,65 +0,0 @@
-#tb 0: 32768/785647
-#media_type 0: video
-#codec_id 0: rawvideo
-#dimensions 0: 576x320
-#sar 0: 0/1
-0,  0,  0,1,   276480, 0x5f7a0d4f
-0,  1,  1,1,   276480, 0x5f7a0d4f
-0,  2,  2,1,   276480, 0x5f7a0d4f
-0,  3,  3,1,   276480, 0x5f7a0d4f
-0,  4,  4,1,   276480, 0x5f7a0d4f
-0,  5,  5,1,   276480, 0x5f7a0d4f
-0,  6,  6,1,   276480, 0x5f7a0d4f
-0,  7,  7,1,   276480, 0x5f7a0d4f
-0,  8,  8,1,   276480, 0x5f7a0d4f
-0,  9,  9,1,   276480, 0x5f7a0d4f
-0, 10, 10,1,   276480, 0x5f7a0d4f
-0, 11, 11,1,   276480, 0x5f7a0d4f
-0, 12, 12,1,   276480, 0x5f7a0d4f
-0, 13, 13,1,   276480, 0x5f7a0d4f
-0, 14, 14,1,   276480, 0x5f7a0d4f
-0, 15, 15,1,   276480, 0x5f7a0d4f
-0, 16, 16,1,   276480, 0xc3b80edf
-0, 17, 17,1,   276480, 0x5f7a0d4f
-0, 18, 18,1,   276480, 0x5f7a0d4f
-0, 19, 19,1,   276480, 0x5f7a0d4f
-0, 20, 20,1,   276480, 0xc3b80edf
-0, 21, 21,1,   276480, 0x5f7a0d4f
-0, 22, 22,1,   276480, 0x5f7a0d4f
-0, 23, 23,1,   276480, 0x5f7a0d4f
-0, 24, 24,1,   276480, 0xc3b80edf
-0, 25, 25,1,   276480, 0x5f7a0d4f
-0, 26, 26,1,   276480, 0x5f7a0d4f
-0, 27, 27,1,   276480, 0x5f7a0d4f
-0, 28, 28,1,   276480, 0xc3b80edf
-0, 29, 29,1,   276480, 0x5f7a0d4f
-0, 30, 30,1,   276480, 0x5f7a0d4f
-0, 31, 31,1,   276480, 0x5f7a0d4f
-0, 32, 32,1,   276480, 0xc3b80edf
-0, 33, 33,1,   276480, 0x75641594
-0, 34, 34,1,   276480, 0x32ee3526
-0, 35, 35,1,   276480, 0xcb53479a
-0, 36, 36,1,   276480, 0xe1be6e26
-0, 37, 37,1,   276480, 0x5ce39368
-0, 38, 38,1,   276480, 0x4ec1e418
-0, 39, 39,1,   276480, 0x23c418ae
-0, 40, 40,1,   276480, 0x036a5515
-0, 41, 41,1,   276480, 0x7946efbd
-0, 42, 42,1,   276480, 0xd9aa1382
-0, 43, 43,1,   276480, 0x3863f9c8
-0, 44, 44,1,   276480, 0x33e47330
-0, 45, 45,1,   276480, 0xff6e8038
-0, 46, 46,1,   276480, 0xed3ff087
-0, 47, 47,1,   276480, 0xe7834514
-0, 48, 48,1,   276480, 0x4d5d909d
-0, 49, 49,1,   276480, 0x82eea962
-0, 50, 50,1,   276480, 0x8075bca3
-0, 51, 51,1,   276480, 0xd5dc3185
-0, 52, 52,1,   276480, 0x859e0490
-0, 53, 53,1,   276480, 0x6ceebf3e
-0, 54, 54,1,   276480, 0xada5d62d
-0, 55, 55,1,   276480, 0x991a7628
-0, 56, 56,1,   276480, 0xe169042a
-0, 57, 57,1,   276480, 0x226e52c4

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-11 Thread Davinder Singh

single patch

On Sun, May 8, 2016 at 1:18 AM Davinder Singh  wrote:

> separated motion vector types (forward or backward) from frame picture
> types as MVs are associated with picture types only in video coding.
>
> option `mv` can have two values:
> forward predicted or backward predicted.
>
> option `frames` can have three values:
> p-frames, i-frames and b-frames.
>
> ex:
> only forward predicted mvs of all frames:
> -vf codecview=mv=fp
>
> mvs (both forward or backward predicted) of P or B-frames:
> -vf codecview=mv=fp+bp:frames=pf+bf
>
> Regards,
> DSM_
>


0001-vf_codecview-improved-filter-options.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-07 Thread Davinder Singh

changed default value of  `frames` to zero, if `frames` option is not set,
it ignore and check only direction, this way all picture types are
considered if we are drawing MVs for ME, since there are more frame types
available.

On Sun, May 8, 2016 at 3:02 AM Moritz Barsnick  wrote:

> On Sat, May 07, 2016 at 19:48:31 +, Davinder Singh wrote:
>
> > -{ "frames", "set frame types to display MVs of", OFFSET(frames),
> AV_OPT_TYPE_FLAGS, {.i64=3}, 0, INT_MAX, FLAGS, "frames" },
> > +{ "frames", "set frame types to display MVs of", OFFSET(frames),
> AV_OPT_TYPE_FLAGS, {.i64=7}, 0, INT_MAX, FLAGS, "frames" },
>
>  ^
> This could be written symbolically to make its value more obvious.
>
> > -forward predicted MVs of P-frames
> > +predicted frames (p-frames)
> >  @item bf
> > -forward predicted MVs of B-frames
> > -@item bb
> > -backward predicted MVs of B-frames
> > +bi-directionally predicted frames (b-frames)
>
> Didn't you just introduce capitalization of B and P in the 0002 patch,
> and now drop it here?
>
> > +CONST("pf", "p-frames", FRAME_TYPE_P, "frames"),
> > +CONST("bf", "b-frames", FRAME_TYPE_B, "frames"),
>
> Same here.
>

it was in docs only. all capital now. :)


>
> Moritz
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


0003-vf_codecview-ignore-frame-types-ifnset.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-07 Thread Moritz Barsnick

On Sat, May 07, 2016 at 19:48:31 +, Davinder Singh wrote:

> -{ "frames", "set frame types to display MVs of", OFFSET(frames), 
> AV_OPT_TYPE_FLAGS, {.i64=3}, 0, INT_MAX, FLAGS, "frames" },
> +{ "frames", "set frame types to display MVs of", OFFSET(frames), 
> AV_OPT_TYPE_FLAGS, {.i64=7}, 0, INT_MAX, FLAGS, "frames" },

   ^
This could be written symbolically to make its value more obvious.

> -forward predicted MVs of P-frames
> +predicted frames (p-frames)
>  @item bf
> -forward predicted MVs of B-frames
> -@item bb
> -backward predicted MVs of B-frames
> +bi-directionally predicted frames (b-frames)

Didn't you just introduce capitalization of B and P in the 0002 patch,
and now drop it here?

> +CONST("pf", "p-frames", FRAME_TYPE_P, "frames"),
> +CONST("bf", "b-frames", FRAME_TYPE_B, "frames"),

Same here.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

2016-05-07 Thread Davinder Singh

separated motion vector types (forward or backward) from frame picture
types as MVs are associated with picture types only in video coding.

option `mv` can have two values:
forward predicted or backward predicted.

option `frames` can have three values:
p-frames, i-frames and b-frames.

ex:
only forward predicted mvs of all frames:
-vf codecview=mv=fp

mvs (both forward or backward predicted) of P or B-frames:
-vf codecview=mv=fp+bp:frames=pf+bf

Regards,
DSM_


0002-vf_codecview-added-i-frame-support.patch
Description: Binary data


0001-vf_codecview-improved-filter-options.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Re: [FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

[FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

12 matches

Site Navigation

Mail list logo

Footer information