Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-19 Thread Moritz Barsnick
On Tue, Dec 18, 2018 at 13:41:06 -0800, Mohammad Izadi wrote: Nit: > #define LIBAVUTIL_VERSION_MAJOR 56 > -#define LIBAVUTIL_VERSION_MINOR 24 > +#define LIBAVUTIL_VERSION_MINOR 25 > #define LIBAVUTIL_VERSION_MICRO 101 When bumping minor, you need to reset micro to 100. Moritz

[FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-18 Thread Mohammad Izadi
From: Mohammad Izadi The dynamic metadata contains data for color volume transform - application 4 of SPMTE 2094-40:2016 standard. The data comes from HEVC in the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35. I'll add support to HEVC in a follow-up. --- libavutil/Makefile | 2 +

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Tue, Dec 18, 2018 at 12:04 AM Mohammad Izadi wrote: > As Jan mentioned, we need to specify the kind of the HDR metadata. Here are > some alternatives: > > AVDynamicHDRPlus > AVSMPTE2094App4 (Application 4 is HDR10+ while Dolby is application 1) > AVHDRPlusMetadata > > Which one do you

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Mohammad Izadi
As Jan mentioned, we need to specify the kind of the HDR metadata. Here are some alternatives: AVDynamicHDRPlus AVSMPTE2094App4 (Application 4 is HDR10+ while Dolby is application 1) AVHDRPlusMetadata Which one do you prefer? -- Best, Mohammad On Mon, Dec 17, 2018 at 3:07 PM Jan Ekström

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Jan Ekström
On Tue, Dec 18, 2018 at 12:58 AM Vittorio Giovara wrote: > > On Mon, Dec 17, 2018 at 5:53 PM Jan Ekström wrote: > > > On Tue, Dec 18, 2018 at 12:41 AM Vittorio Giovara > > wrote: > > > > > > I like > > VeryLongJavaLikeNamingForFunctionsAndDataTypesAsWellAsEnumsOfCourse > > > as much as the next

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Mon, Dec 17, 2018 at 5:53 PM Jan Ekström wrote: > On Tue, Dec 18, 2018 at 12:41 AM Vittorio Giovara > wrote: > > > > On Mon, Dec 10, 2018 at 2:50 PM Mohammad Izadi > wrote: > > > > > From: Mohammad Izadi > > > > > > The dynamic metadata contains data for color volume transform - > > >

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Jan Ekström
On Tue, Dec 18, 2018 at 12:41 AM Vittorio Giovara wrote: > > On Mon, Dec 10, 2018 at 2:50 PM Mohammad Izadi wrote: > > > From: Mohammad Izadi > > > > The dynamic metadata contains data for color volume transform - > > application 4 of SPMTE 2094-40:2016 standard. The data comes from HEVC in > >

Re: [FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-17 Thread Vittorio Giovara
On Mon, Dec 10, 2018 at 2:50 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > The dynamic metadata contains data for color volume transform - > application 4 of SPMTE 2094-40:2016 standard. The data comes from HEVC in > the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35. > > I'll add support to

[FFmpeg-devel] [PATCH] Add HDR dynamic metadata struct (for SPMTE 2094-40) to libavutil.

2018-12-10 Thread Mohammad Izadi
From: Mohammad Izadi The dynamic metadata contains data for color volume transform - application 4 of SPMTE 2094-40:2016 standard. The data comes from HEVC in the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35. I'll add support to HEVC in a follow-up. --- libavutil/Makefile | 2 +