Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-12-02 Thread wm4
On Wed, 2 Dec 2015 09:28:40 -0500 Alexander Agranovsky wrote: > Hi guys -- where do we stand with this? Are there any additional comments? > > - A. Pushed both patches. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/l

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-12-02 Thread wm4
On Wed, 2 Dec 2015 09:28:40 -0500 Alexander Agranovsky wrote: > Hi guys -- where do we stand with this? Are there any additional comments? > > - A. Looks fine now. The trim_right() still looks a bit awkward IMHO, but it should be correct (whoever really cares can send a follow-up patch to chang

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-12-02 Thread Alexander Agranovsky
On 11/30/15 10:35 AM, Alexander Agranovsky wrote: On 11/30/15 10:24 AM, Nicolas George wrote: Le decadi 10 frimaire, an CCXXIV, Alexander Agranovsky a écrit : Without getting into a religious debate This is the reason I gave practical argument. As pointed later in the thread, lu is used

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-30 Thread Alexander Agranovsky
On 11/30/15 10:24 AM, Nicolas George wrote: Le decadi 10 frimaire, an CCXXIV, Alexander Agranovsky a écrit : Without getting into a religious debate This is the reason I gave practical argument. As pointed later in the thread, lu is used elsewhere. And yes, MS makes it interesting in this c

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-30 Thread Nicolas George
Le decadi 10 frimaire, an CCXXIV, Alexander Agranovsky a écrit : > Without getting into a religious debate This is the reason I gave practical argument. > As pointed later in the thread, lu is used elsewhere. And yes, MS makes it > interesting in this case. wm4 explained that point. Really, long

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-30 Thread Alexander Agranovsky
On 11/30/15 7:34 AM, wm4 wrote: On Mon, 30 Nov 2015 07:27:14 -0500 Alexander Agranovsky wrote: On 11/30/15 2:41 AM, Nicolas George wrote: Le nonidi 9 frimaire, an CCXXIV, Alexander Agranovsky a écrit : Please see the updated patches attached. The trimming loop that was subject of the discu

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-30 Thread Alexander Agranovsky
On 11/30/15 7:34 AM, wm4 wrote: On Mon, 30 Nov 2015 07:27:14 -0500 Alexander Agranovsky wrote: On 11/30/15 2:41 AM, Nicolas George wrote: Le nonidi 9 frimaire, an CCXXIV, Alexander Agranovsky a écrit : Please see the updated patches attached. The trimming loop that was subject of the discu

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-30 Thread Alexander Agranovsky
On 11/30/15 6:37 AM, wm4 wrote: On Mon, 30 Nov 2015 08:41:42 +0100 Nicolas George wrote: +"Expected boundary '%s' not found, instead found a line of %lu bytes\n", +expected_boundary, +strlen(line)); "%lu" is not correct for size_t. The correc

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-30 Thread wm4
On Mon, 30 Nov 2015 07:27:14 -0500 Alexander Agranovsky wrote: > On 11/30/15 2:41 AM, Nicolas George wrote: > > Le nonidi 9 frimaire, an CCXXIV, Alexander Agranovsky a écrit : > >> Please see the updated patches attached. The trimming loop that was subject > >> of the discussion had been rewrit

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-30 Thread Alexander Agranovsky
On 11/30/15 2:41 AM, Nicolas George wrote: Le nonidi 9 frimaire, an CCXXIV, Alexander Agranovsky a écrit : Please see the updated patches attached. The trimming loop that was subject of the discussion had been rewritten to use indices rather than pointer arithmetics. This kind of drastic chan

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-30 Thread wm4
On Mon, 30 Nov 2015 08:41:42 +0100 Nicolas George wrote: > > +"Expected boundary '%s' not found, instead found a line of > > %lu bytes\n", > > +expected_boundary, > > +strlen(line)); > > "%lu" is not correct for size_t. The correct type would be

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-29 Thread Nicolas George
Le nonidi 9 frimaire, an CCXXIV, Alexander Agranovsky a écrit : > Please see the updated patches attached. The trimming loop that was subject > of the discussion had been rewritten to use indices rather than pointer > arithmetics. This kind of drastic change was not necessary, you can do the same

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-29 Thread Alexander Agranovsky
On 11/29/15 1:16 PM, Nicolas George wrote: Le nonidi 9 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : end = p + strlen(p) - 1; Don't know what you are referring to here, but dereferencing is clearly invalid. However, in order to allow common loop idioms, pointer arithmetic one elemen

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-29 Thread Alexander Agranovsky
On 11/29/15 1:00 PM, wm4 wrote: On Wed, 25 Nov 2015 10:35:31 -0500 Alex Agranovsky wrote: From 4797590e11267993c3883e5037619625e1f1dadf Mon Sep 17 00:00:00 2001 From: Alex Agranovsky Date: Tue, 24 Nov 2015 00:07:34 -0500 Subject: [PATCH 2/2] If available, use the actual boundary in HTTP re

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-29 Thread Nicolas George
Le nonidi 9 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > >> end = p + strlen(p) - 1; > Don't know what you are referring to here, but dereferencing is > clearly invalid. However, in order to allow common loop idioms, > pointer arithmetic one element beyond a array (memory) range is val

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-29 Thread Ganesh Ajjanagadde
On Sun, Nov 29, 2015 at 1:00 PM, wm4 wrote: > On Wed, 25 Nov 2015 10:35:31 -0500 > Alex Agranovsky wrote: > >> From 70a6e1b0f3d47698bf49c3c766d5472646bff71a Mon Sep 17 00:00:00 2001 >> From: Alex Agranovsky >> Date: Tue, 24 Nov 2015 00:06:14 -0500 >> Subject: [PATCH 1/2] Allow mpjpeg demuxer to

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-29 Thread wm4
On Wed, 25 Nov 2015 10:35:31 -0500 Alex Agranovsky wrote: > From 4797590e11267993c3883e5037619625e1f1dadf Mon Sep 17 00:00:00 2001 > From: Alex Agranovsky > Date: Tue, 24 Nov 2015 00:07:34 -0500 > Subject: [PATCH 2/2] If available, use the actual boundary in HTTP response's > Content-Type heade

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-29 Thread wm4
On Wed, 25 Nov 2015 10:35:31 -0500 Alex Agranovsky wrote: > From 70a6e1b0f3d47698bf49c3c766d5472646bff71a Mon Sep 17 00:00:00 2001 > From: Alex Agranovsky > Date: Tue, 24 Nov 2015 00:06:14 -0500 > Subject: [PATCH 1/2] Allow mpjpeg demuxer to process MIME parts which do not > include Content-Len

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-27 Thread wm4
On Fri, 27 Nov 2015 15:14:54 -0500 Alex Agranovsky wrote: > > Hi - are there any additional corrections I need to address on this set of > patches, or is it good to go at this point? Sorry, forgot about it, will look tomorrow. Also, the quoting in your replies is completely messed up. I can't

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-27 Thread Alex Agranovsky
On November 25, 2015 at 10:35:33 AM, Alex Agranovsky (a...@sighthound.com) wrote: On November 24, 2015 at 6:06:36 PM, Michael Niedermayer (michae...@gmx.at) wrote: On Tue, Nov 24, 2015 at 03:01:28PM -0500, Alex Agranovsky wrote:  [...]  > From 2c253d7978a6c9c2dc701d393eb5b9d68e831c98 Mon Sep 1

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-25 Thread Alex Agranovsky
On November 24, 2015 at 6:06:36 PM, Michael Niedermayer (michae...@gmx.at) wrote: On Tue, Nov 24, 2015 at 03:01:28PM -0500, Alex Agranovsky wrote:  [...]  > From 2c253d7978a6c9c2dc701d393eb5b9d68e831c98 Mon Sep 17 00:00:00 2001  > From: Alex Agranovsky   > Date: Tue, 24 Nov 2015 00:07:34 -0500 

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-24 Thread Michael Niedermayer
On Tue, Nov 24, 2015 at 03:01:28PM -0500, Alex Agranovsky wrote: [...] > From 2c253d7978a6c9c2dc701d393eb5b9d68e831c98 Mon Sep 17 00:00:00 2001 > From: Alex Agranovsky > Date: Tue, 24 Nov 2015 00:07:34 -0500 > Subject: [PATCH 2/2] If available, use the actual boundary in HTTP response's > Conten

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-24 Thread Alex Agranovsky
--  Alex Agranovsky Sighthound, Inc www.sighthound.com On November 24, 2015 at 12:36:30 PM, wm4 (nfx...@googlemail.com) wrote: On Tue, 24 Nov 2015 11:39:07 -0500 Alex Agranovsky wrote: > On November 24, 2015 at 10:32:47 AM, wm4 (nfx...@googlemail.com) wrote: > > On Tue,

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-24 Thread Alex Agranovsky
On November 24, 2015 at 10:32:47 AM, wm4 (nfx...@googlemail.com) wrote: On Tue, 24 Nov 2015 00:16:06 -0500 Alex Agranovsky wrote: > From a2a0b9e0da14b6e82aa783535ec1878c8ffbede0 Mon Sep 17 00:00:00 2001 > From: Alex Agranovsky > Date: Tue, 24 Nov 2015 00:06:14 -0500 > Subject: [PATCH 1/2] A

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-24 Thread wm4
On Tue, 24 Nov 2015 00:16:06 -0500 Alex Agranovsky wrote: > From a2a0b9e0da14b6e82aa783535ec1878c8ffbede0 Mon Sep 17 00:00:00 2001 > From: Alex Agranovsky > Date: Tue, 24 Nov 2015 00:06:14 -0500 > Subject: [PATCH 1/2] Allow mpjpeg demuxer to process MIME parts which do not > include Content-Len

[FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-23 Thread Alex Agranovsky
This addresses ticket 5023From a2a0b9e0da14b6e82aa783535ec1878c8ffbede0 Mon Sep 17 00:00:00 2001 From: Alex Agranovsky Date: Tue, 24 Nov 2015 00:06:14 -0500 Subject: [PATCH 1/2] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header. Fixes ticket 5023 Signed-off-b