Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-12 Thread Michael Niedermayer
On Sun, Nov 12, 2017 at 04:24:37PM +, Thomas Köppe wrote: > Variables used in inline assembly need to be marked with attribute((used)). > Static constants already were, via the define of DECLARE_ASM_CONST. > But DECLARE_ALIGNED does not add this attribute, and some of the variables > defined

[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-12 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-12 Thread Michael Niedermayer
On Sat, Nov 11, 2017 at 08:36:32AM +, Thomas Köppe wrote: > Variables used in inline assembly need to be marked with attribute((used)). > Static constants already were, via the define of DECLARE_ASM_CONST. > But DECLARE_ALIGNED does not add this attribute, and some of the variables > defined

[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-11 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-09 Thread Thomas Köppe
Thank you, I'll package this up as a patch and send it as a separate mail. On 9 November 2017 at 11:52, Teresa Johnson wrote: > I implemented this change to add a new macro. I tried to find the > variables used in MANGLE and change those to use the new >

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-09 Thread Teresa Johnson
I implemented this change to add a new macro. I tried to find the variables used in MANGLE and change those to use the new DECLARE_ASM_ALIGNED, and the build succeeds with these changes. New changes are in cl/172133815. Teresa On Wed, Nov 1, 2017 at 7:25 AM, Teresa Johnson

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-01 Thread Michael Niedermayer
Hi On Wed, Nov 01, 2017 at 07:25:08AM -0700, Teresa Johnson wrote: > On Tue, Oct 31, 2017 at 5:42 PM, Michael Niedermayer > wrote: > > > Hi > > > > On Tue, Oct 31, 2017 at 04:29:18PM +, Teresa Johnson wrote: > > > It's needed for the same reason the used attribute

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-01 Thread Teresa Johnson
On Tue, Oct 31, 2017 at 5:42 PM, Michael Niedermayer wrote: > Hi > > On Tue, Oct 31, 2017 at 04:29:18PM +, Teresa Johnson wrote: > > It's needed for the same reason the used attribute was already added to > the > > "static const" variables. For those, when building

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Michael Niedermayer
Hi On Tue, Oct 31, 2017 at 04:29:18PM +, Teresa Johnson wrote: > It's needed for the same reason the used attribute was already added to the > "static const" variables. For those, when building with just -O2, they > could be removed by optimization since they had local (file) scope, and we >

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Teresa Johnson
It's needed for the same reason the used attribute was already added to the "static const" variables. For those, when building with just -O2, they could be removed by optimization since they had local (file) scope, and we couldn't see the uses in the inline assembly (without the used attribute).

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Michael Niedermayer
On Tue, Oct 31, 2017 at 03:52:14PM +, Thomas Köppe wrote: > +Teresa, who drafted the patch initially. > > On 31 October 2017 at 15:38, Michael Niedermayer > wrote: > > > On Tue, Oct 31, 2017 at 12:16:18PM +, Thomas Köppe wrote: > > > Variables used in inline

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Thomas Köppe
+Teresa, who drafted the patch initially. On 31 October 2017 at 15:38, Michael Niedermayer wrote: > On Tue, Oct 31, 2017 at 12:16:18PM +, Thomas Köppe wrote: > > Variables used in inline assembly need to be marked with > attribute((used)). > > This should not be the

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Michael Niedermayer
On Tue, Oct 31, 2017 at 12:16:18PM +, Thomas Köppe wrote: > Variables used in inline assembly need to be marked with attribute((used)). This should not be the case. Variables referenced through in/out operands should not need that. Only ones accessed directly bypassing operands should need

[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread Thomas Köppe
Please find below the actual patch: == Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread Thomas Köppe
(I must have forgotten to rebase first!) On 30 October 2017 at 20:14, Thomas Köppe wrote: > It should be under __GNUC__ -- something went wrong with the patch! I'll > make a new one. Sorry about that! > > On 30 October 2017 at 19:31, James Almer wrote: >

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread Thomas Köppe
It should be under __GNUC__ -- something went wrong with the patch! I'll make a new one. Sorry about that! On 30 October 2017 at 19:31, James Almer wrote: > On 10/30/2017 4:17 PM, Thomas Köppe wrote: > > Variables used in inline assembly need to be marked with >

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread James Almer
On 10/30/2017 4:17 PM, Thomas Köppe wrote: > Variables used in inline assembly need to be marked with attribute((used)). > Static constants already were, via the define of DECLARE_ASM_CONST. > But DECLARE_ALIGNED does not add this attribute, and some of the variables > defined with it are const

[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared