RFC-4566 do not give any limit of size on interger parameters given in fmtp
line.
By reading some more RFCs it is possible to find examples where some integers
parameters are greater than 32 (see RFC-6416, 7.4)
Instead I propose to check just check the eventual integer overflow.
Using INT_MIN
2019-03-18 16:08 GMT+01:00, Olivier Maignial :
> +char * end_ptr = NULL;
Assuming you have to send a new patch anyway,
please make this "char *end_ptr"...
> +long int val = strtol(value, _ptr, 10);
> +if (value[0] == '\n' ||
On Mon, Mar 18, 2019 at 04:08:40PM +0100, Olivier Maignial wrote:
> RFC-4566 do not give any limit of size on interger parameters given in fmtp
> line.
> By reading some more RFCs it is possible to find examples where some integers
> parameters are greater than 32 (see RFC-6416, 7.4)
> ---
>
RFC-4566 do not give any limit of size on interger parameters given in fmtp
line.
By reading some more RFCs it is possible to find examples where some integers
parameters are greater than 32 (see RFC-6416, 7.4)
---
libavformat/rtpdec_mpeg4.c | 17 +
1 file changed, 13
Michael Niedermayer (12019-02-27):
> > if (attr_names[i].type == ATTR_NAME_TYPE_INT) {
> > -int val = atoi(value);
> > -if (val > 32) {
> > +long int val = strtol(value, NULL, 10);
> > +if (errno ==
On Mon, Feb 25, 2019 at 02:54:50PM +0100, Olivier Maignial wrote:
> ---
> libavformat/rtpdec_mpeg4.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c
> index 4f70599..f632ebf 100644
> ---
---
libavformat/rtpdec_mpeg4.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c
index 4f70599..f632ebf 100644
--- a/libavformat/rtpdec_mpeg4.c
+++ b/libavformat/rtpdec_mpeg4.c
@@ -289,15 +289,15 @@ static int
