Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
You should get a crash when trying to play this file with ffplay or when trying to open it with avformat_open_input. (Before the patch is applied). Stephan Am 22.06.2015 um 16:41 schrieb Carl Eugen Hoyos ceho...@ag.or.at: stephan.vedder at gmail.com writes: https://bfme2-see.googlecode.com/svn-history/r129/trunk/data/movies/SmallRing.vp6 Before you had to use: ffplay -f ./SmallRing.vp6 since it would use the aac demuxer otherwise (resulting in a crash). How can I reproduce the crash? Crashes are always (very) important, but I cannot reproduce... Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
stephan.vedder at gmail.com writes: https://bfme2-see.googlecode.com/svn-history/r129/trunk/data/movies/SmallRing.vp6 Do you know how to decode the alpha channel for this file? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
I talked with Aurel Jacoubs (the creator of the vp6 deocoder). He said that the implememtation is already capable of decoding this file completly. Apart from that i don't know much about vp6 decoding. However were you able to understand why this patch is required? 2015-06-22 23:22 GMT+02:00 Carl Eugen Hoyos ceho...@ag.or.at: stephan.vedder at gmail.com writes: https://bfme2-see.googlecode.com/svn-history/r129/trunk/data/movies/SmallRing.vp6 Do you know how to decode the alpha channel for this file? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
I just noticed that i got a wrong patch file attached. Let me make a new diff. I didn't mean a real crash, i just meant an error output that this file isn't playable 2015-06-22 20:13 GMT+02:00 Michael Niedermayer michae...@gmx.at: On Mon, Jun 22, 2015 at 02:41:07PM +, Carl Eugen Hoyos wrote: stephan.vedder at gmail.com writes: https://bfme2-see.googlecode.com/svn-history/r129/trunk/data/movies/SmallRing.vp6 Before you had to use: ffplay -f ./SmallRing.vp6 since it would use the aac demuxer otherwise (resulting in a crash). How can I reproduce the crash? Crashes are always (very) important, but I cannot reproduce... i see no crash either also no anomaly under valgrind [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
I attached the fixed patch now.
2015-06-22 20:43 GMT+02:00 Stephan Vedder stephan.ved...@gmail.com:
I just noticed that i got a wrong patch file attached. Let me make a new
diff.
I didn't mean a real crash, i just meant an error output that this file
isn't playable
2015-06-22 20:13 GMT+02:00 Michael Niedermayer michae...@gmx.at:
On Mon, Jun 22, 2015 at 02:41:07PM +, Carl Eugen Hoyos wrote:
stephan.vedder at gmail.com writes:
https://bfme2-see.googlecode.com/svn-history/r129/trunk/data/movies/SmallRing.vp6
Before you had to use: ffplay -f ./SmallRing.vp6
since it would use the aac demuxer otherwise
(resulting in a crash).
How can I reproduce the crash?
Crashes are always (very) important, but
I cannot reproduce...
i see no crash either also no anomaly under valgrind
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid
they
would be bankrupt already.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
commit b1646ba4cbce2d285f7f268ec49ed0362e5fdf55
Author: Stephan Vedder stephan.ved...@gmail.com
Date: Mon Jun 22 20:56:23 2015 +0200
Fixed ea_probe function to accept vp6a videos
diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c
index d6a396b..d999a0b 100644
--- a/libavformat/electronicarts.c
+++ b/libavformat/electronicarts.c
@@ -61,6 +61,7 @@
#define MV0F_TAG MKTAG('M', 'V', '0', 'F')
#define MVIh_TAG MKTAG('M', 'V', 'I', 'h') /* CMV header */
#define MVIf_TAG MKTAG('M', 'V', 'I', 'f') /* CMV I-frame */
+#define AVP6_TAG MKTAG('A', 'V', 'P', '6')
typedef struct EaDemuxContext {
int big_endian;
@@ -458,6 +459,7 @@ static int ea_probe(AVProbeData *p)
case MPCh_TAG:
case MVhd_TAG:
case MVIh_TAG:
+case AVP6_TAG:
break;
default:
return 0;
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
On Mon, Jun 22, 2015 at 02:41:07PM +, Carl Eugen Hoyos wrote: stephan.vedder at gmail.com writes: https://bfme2-see.googlecode.com/svn-history/r129/trunk/data/movies/SmallRing.vp6 Before you had to use: ffplay -f ./SmallRing.vp6 since it would use the aac demuxer otherwise (resulting in a crash). How can I reproduce the crash? Crashes are always (very) important, but I cannot reproduce... i see no crash either also no anomaly under valgrind [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
On Mon, Jun 22, 2015 at 08:58:41PM +0200, Stephan Vedder wrote: I attached the fixed patch now. [...] electronicarts.c |2 ++ 1 file changed, 2 insertions(+) e10466b07ca042720ac60541ca615745edf1434a patch.diff commit b1646ba4cbce2d285f7f268ec49ed0362e5fdf55 Author: Stephan Vedder stephan.ved...@gmail.com Date: Mon Jun 22 20:56:23 2015 +0200 Fixed ea_probe function to accept vp6a videos applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
From: feliwir stephan.ved...@gmail.com
---
libavformat/electronicarts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c
index 859fbb8..ba15b65 100644
--- a/libavformat/electronicarts.c
+++ b/libavformat/electronicarts.c
@@ -427,6 +427,7 @@ static int process_ea_header(AVFormatContext *s)
ea-time_base = (AVRational) { avio_rl16(pb), 1000 };
break;
+ case AVP6_TAG:
case MVhd_TAG:
err = process_video_header_vp6(s);
break;
--
1.9.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
Oh okay, guess i missed the tabs. However here is a sample file: https://code.google.com/p/bfme2-see/source/browse/trunk/data/movies/SmallRing.vp6?r=129 Before you had to use: ffplay -f ./SmallRing.vp6 since it would use the aac demuxer otherwise (resulting in a crash). With this patch you can simply use: ffplay ./SmallRing.vp6 Am 22.06.2015 um 15:49 schrieb Carl Eugen Hoyos ceho...@ag.or.at: Stephan Vedder stephan.vedder at gmail.com writes: +case AVP6_TAG: Tabs cannot be committed to the FFmpeg repository. Could you provide a sample? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
Stephan Vedder stephan.vedder at gmail.com writes: + case AVP6_TAG: Tabs cannot be committed to the FFmpeg repository. Could you provide a sample? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
On 6/22/15, Stephan Vedder stephan.ved...@gmail.com wrote:
From: feliwir stephan.ved...@gmail.com
---
libavformat/electronicarts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c
index 859fbb8..ba15b65 100644
--- a/libavformat/electronicarts.c
+++ b/libavformat/electronicarts.c
@@ -427,6 +427,7 @@ static int process_ea_header(AVFormatContext *s)
ea-time_base = (AVRational) { avio_rl16(pb), 1000 };
break;
+ case AVP6_TAG:
case MVhd_TAG:
err = process_video_header_vp6(s);
break;
--
1.9.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Tabs are forbiden in FFmpeg C code.
Do you have a sample this patch fixes?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
Here is an example file: https://code.google.com/p/bfme2-see/source/browse/trunk/data/movies/SmallRing.vp6?r=129 Before it did chose the AAC demuxer for this file and files of that kind. Resulting in a crash. I can fix the tabs when i am back home Am 22.06.2015 um 15:49 schrieb Carl Eugen Hoyos ceho...@ag.or.at: Stephan Vedder stephan.vedder at gmail.com writes: +case AVP6_TAG: Tabs cannot be committed to the FFmpeg repository. Could you provide a sample? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixed EA vp6 files with alpha not picked up by the EA demuxer
stephan.vedder at gmail.com writes: https://bfme2-see.googlecode.com/svn-history/r129/trunk/data/movies/SmallRing.vp6 Before you had to use: ffplay -f ./SmallRing.vp6 since it would use the aac demuxer otherwise (resulting in a crash). How can I reproduce the crash? Crashes are always (very) important, but I cannot reproduce... Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
