Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Carl Eugen Hoyos
2016-09-14 18:56 GMT+02:00 Yogender Kumar Gupta : > Please let me know if anything else needs to be taken care of. if (condition) { do(); } else { do2(); } like everywhere else in FFmpeg (and on top of your patch). +if (ctx->aq && ctx->temporalAQ) +{ +

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Yogender Kumar Gupta
I have made only changes specific to SDK_7_0 in the attached patch. Also generated the patch using format-patch. Please let me know if anything else needs to be taken care of. Thanks, Yogender On Wed, Sep 14, 2016 at 8:48 PM, Carl Eugen Hoyos wrote: > 2016-09-14 15:43

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Timo Rothenpieler
On 9/14/2016 6:30 PM, Carl Eugen Hoyos wrote: > 2016-09-14 18:26 GMT+02:00 Timo Rothenpieler : >> On 9/14/2016 3:43 PM, Yogender Kumar Gupta wrote: >>> Attached is a patch for SDK 7_0 for NVENC. This adds other features >>> available in SDK 7_0 as well as fixes an issue with

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Carl Eugen Hoyos
2016-09-14 18:26 GMT+02:00 Timo Rothenpieler : > On 9/14/2016 3:43 PM, Yogender Kumar Gupta wrote: >> Attached is a patch for SDK 7_0 for NVENC. This adds other features >> available in SDK 7_0 as well as fixes an issue with HEVC profile >> > > I'd very much dislike applying

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Timo Rothenpieler
On 9/14/2016 3:43 PM, Yogender Kumar Gupta wrote: > Attached is a patch for SDK 7_0 for NVENC. This adds other features > available in SDK 7_0 as well as fixes an issue with HEVC profile > I'd very much dislike applying this change. It makes the list very hard to read. While it could be

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Carl Eugen Hoyos
2016-09-14 18:23 GMT+02:00 Timo Rothenpieler : > I'm not sure what target_quality is supposed to do Could it be that it moves the time-to-encode / quality-of-encoding slider? (just guessing, libvpx does this iirc) Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Timo Rothenpieler
On 9/14/2016 3:43 PM, Yogender Kumar Gupta wrote: > Attached is a patch for SDK 7_0 for NVENC. This adds other features > available in SDK 7_0 as well as fixes an issue with HEVC profile > What carl said. Also, a some of the added options are not used anywhere: zeroReorderDelay, enableNonRefP

Re: [FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Carl Eugen Hoyos
2016-09-14 15:43 GMT+02:00 Yogender Kumar Gupta : > Attached is a patch for SDK 7_0 for NVENC. This adds other features > available in SDK 7_0 as well as fixes an issue with HEVC profile The first two hunks do not match your description, please send a separate patch for

[FFmpeg-devel] [PATCH] Patch for SDK 7.0 for NVENC

2016-09-14 Thread Yogender Kumar Gupta
Attached is a patch for SDK 7_0 for NVENC. This adds other features available in SDK 7_0 as well as fixes an issue with HEVC profile sdk_7_0.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org