Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-10-06 Thread Paul B Mahol
On 9/27/23, Paul B Mahol wrote: > On 9/27/23, Michael Niedermayer wrote: >> On Wed, Sep 27, 2023 at 03:00:35PM +0200, Paul B Mahol wrote: >>> On Wed, Sep 27, 2023 at 2:57 PM Nicolas George wrote: >>> >>> > Paul B Mahol (12023-09-27): >>> > > I think that having parser is much more useful. >>> >

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Paul B Mahol
On 9/27/23, Michael Niedermayer wrote: > On Wed, Sep 27, 2023 at 03:00:35PM +0200, Paul B Mahol wrote: >> On Wed, Sep 27, 2023 at 2:57 PM Nicolas George wrote: >> >> > Paul B Mahol (12023-09-27): >> > > I think that having parser is much more useful. >> > >> > Having a parser when it can be done

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Michael Niedermayer
On Wed, Sep 27, 2023 at 03:00:35PM +0200, Paul B Mahol wrote: > On Wed, Sep 27, 2023 at 2:57 PM Nicolas George wrote: > > > Paul B Mahol (12023-09-27): > > > I think that having parser is much more useful. > > > > Having a parser when it can be done without is a waste of code and > > resources.

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Paul B Mahol
On Wed, Sep 27, 2023 at 3:04 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Nicolas George: > > Andreas Rheinhardt (12023-09-27): > >> Then you could simply reuse the code inside libavformat. > > > > Do you finally support merging the libraries then? > > > > Because otherwise,

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Tomas Härdin
ons 2023-09-27 klockan 14:59 +0200 skrev Paul B Mahol: > On Wed, Sep 27, 2023 at 2:57 PM Tomas Härdin wrote: > > > ons 2023-09-27 klockan 14:56 +0200 skrev Paul B Mahol: > > > On Wed, Sep 27, 2023 at 2:55 PM Tomas Härdin > > > wrote: > > > > > > > Needs a FATE test. > > > > > > > > > > >

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12023-09-27): >> Then you could simply reuse the code inside libavformat. > > Do you finally support merging the libraries then? > > Because otherwise, using from libavformat code for an individual > component of libavcodec requires adding a new avpriv

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Paul B Mahol
On Wed, Sep 27, 2023 at 2:57 PM Nicolas George wrote: > Paul B Mahol (12023-09-27): > > I think that having parser is much more useful. > > Having a parser when it can be done without is a waste of code and > resources. > I already wrote that parser is useful addition. Mainly because of many

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Paul B Mahol
On Wed, Sep 27, 2023 at 2:57 PM Nicolas George wrote: > Paul B Mahol (12023-09-27): > > I think that having parser is much more useful. > > Having a parser when it can be done without is a waste of code and > resources. > > Do not push like that. > As you never pushed anything marginally useful

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Paul B Mahol
On Wed, Sep 27, 2023 at 2:57 PM Tomas Härdin wrote: > ons 2023-09-27 klockan 14:56 +0200 skrev Paul B Mahol: > > On Wed, Sep 27, 2023 at 2:55 PM Tomas Härdin wrote: > > > > > Needs a FATE test. > > > > > > > > Feel free to upload sample(s). > > Don't have any. But I presume you do. Also wasn't

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Nicolas George
Andreas Rheinhardt (12023-09-27): > Then you could simply reuse the code inside libavformat. Do you finally support merging the libraries then? Because otherwise, using from libavformat code for an individual component of libavcodec requires adding a new avpriv function. Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Tomas Härdin
ons 2023-09-27 klockan 14:56 +0200 skrev Paul B Mahol: > On Wed, Sep 27, 2023 at 2:55 PM Tomas Härdin wrote: > > > Needs a FATE test. > > > > > Feel free to upload sample(s). Don't have any. But I presume you do. Also wasn't it decided that new formats/codecs mustn't be added without tests?

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Nicolas George
Paul B Mahol (12023-09-27): > I think that having parser is much more useful. Having a parser when it can be done without is a waste of code and resources. Do not push like that. -- Nicolas George ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Paul B Mahol
On Wed, Sep 27, 2023 at 2:55 PM Tomas Härdin wrote: > Needs a FATE test. > > Feel free to upload sample(s). > /Tomas > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe,

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Tomas Härdin
Needs a FATE test. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Paul B Mahol
On Wed, Sep 27, 2023 at 2:51 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Sun, Sep 24, 2023 at 2:04 AM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> > >>> +if (!qoa->frame_size) { > >>> +

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Andreas Rheinhardt
Paul B Mahol: > On Sun, Sep 24, 2023 at 2:04 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> >>> +if (!qoa->frame_size) { >>> +for (; i < buf_size; i++) { >>> +state = (state << 8) | buf[i]; >>> +if

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-27 Thread Paul B Mahol
On Sun, Sep 24, 2023 at 2:50 AM Paul B Mahol wrote: > > New patches. > Will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-23 Thread Paul B Mahol
New patches. From 63392e60c7106bfcc6dec5fe45a9dd38f4c29e10 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 23 Sep 2023 16:38:35 +0200 Subject: [PATCH 2/2] avformat: add QOA demuxer Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 +

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-23 Thread Paul B Mahol
On Sun, Sep 24, 2023 at 2:04 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > +.flags = AVFMT_GENERIC_INDEX, > > +.extensions = "qoa", > > +.raw_codec_id = AV_CODEC_ID_QOA, > > This will not compile: The codec_id is only added in the

Re: [FFmpeg-devel] [PATCH] QOA decoding support

2023-09-23 Thread Andreas Rheinhardt
Paul B Mahol: > +.flags = AVFMT_GENERIC_INDEX, > +.extensions = "qoa", > +.raw_codec_id = AV_CODEC_ID_QOA, This will not compile: The codec_id is only added in the second patch. > +.priv_data_size = sizeof(FFRawDemuxerContext), > +.priv_class =

[FFmpeg-devel] [PATCH] QOA decoding support

2023-09-23 Thread Paul B Mahol
Patches attached. From 5d57a04d3b4aa9b487302ab89b2a3bca4ccb9330 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 23 Sep 2023 16:49:25 +0200 Subject: [PATCH 2/2] avcodec: add QOA decoder and parser Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 2 + libavcodec/allcodecs.c |