Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-07-26 Thread Vittorio Giovara
On Thu, Jul 26, 2018 at 4:15 PM, Rostislav Pehlivanov wrote: > Hey, > > As of now, the ambisonics API is enabled by default in libopus. We still > don't have a way to signal ambisonics yet. > We still have plenty of bits left in libavutil/channel_layout.h to signal > many orders of ambisonics

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-07-26 Thread Rostislav Pehlivanov
Hey, As of now, the ambisonics API is enabled by default in libopus. We still don't have a way to signal ambisonics yet. We still have plenty of bits left in libavutil/channel_layout.h to signal many orders of ambisonics but some people have had opinions against extending that API. We could

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-05-11 Thread Rostislav Pehlivanov
On 11 May 2018 at 15:55, Drew Allen wrote: > Hi Rostislav et all, > > The IETF document has just been moved to a working group last call. > > Do you think it would it be possible to land this patch under an > experimental flag? No, libopus itself still hides

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-05-11 Thread Drew Allen
Hi Rostislav et all, The IETF document has just been moved to a working group last call. Do you think it would it be possible to land this patch under an experimental flag? Cheers, Drew On Mon, Apr 23, 2018 at 12:28 PM Rostislav Pehlivanov wrote: > On 23 April 2018 at

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-23 Thread Rostislav Pehlivanov
On 23 April 2018 at 17:02, Drew Allen wrote: > We have spent the past 2 years with the draft relatively unchanged aside > from minor edits on the draft. It is headed to a working group for > finalization very soon and no one has yet raised a single issue

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-23 Thread Drew Allen
Hi Rostislav, Here is my feedback: I am sorry, I don't agree that this should be merged quite yet. First of all, the draft upon which how the channel family is interpreted (draft-ietf-codec-ambisonics-04) isn't finalized yet. What if it changes after we make a release? We can't really change

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-20 Thread Rostislav Pehlivanov
On 20 April 2018 at 18:23, Drew Allen wrote: > Hello all, > > Attached is a revised patch based on your suggestions. > > Rostislav Pehlivanov - I'm not sure how to address your concerns. My patch > provides support for the ambisonics features already approved

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-20 Thread Drew Allen
Hello all, Attached is a revised patch based on your suggestions. Rostislav Pehlivanov - I'm not sure how to address your concerns. My patch provides support for the ambisonics features already approved and present in Opus 1.3. If there are ways I can change my patch, please let me know.

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-12 Thread wm4
On Wed, 11 Apr 2018 14:01:08 +0100 Rostislav Pehlivanov wrote: > On 28 March 2018 at 22:59, Drew Allen > wrote: > > > Hello all, > > > > My name is Andrew Allen and I'm a contributor to Opus, supporting new > > channel mappings 2 and 3

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-11 Thread Rostislav Pehlivanov
On 28 March 2018 at 22:59, Drew Allen wrote: > Hello all, > > My name is Andrew Allen and I'm a contributor to Opus, supporting new > channel mappings 2 and 3 for ambisonics compression. I've attached a patch > to support the new OpusProjectionEncoder and

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-10 Thread Michael Niedermayer
On Wed, Mar 28, 2018 at 09:59:00PM +, Drew Allen wrote: > Hello all, > > My name is Andrew Allen and I'm a contributor to Opus, supporting new > channel mappings 2 and 3 for ambisonics compression. I've attached a patch > to support the new OpusProjectionEncoder and OpusProjectionDecoder APIs

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-09 Thread Drew Allen
Friendly weekly ping about this patch. Can someone please let me know if I need to do anything more to submit this patch? Thanks! On Mon, Apr 2, 2018 at 9:13 AM Drew Allen wrote: > Friendly ping to allow this to push to the member list, please. > > On Wed, Mar 28, 2018 at

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-02 Thread Drew Allen
Friendly ping to allow this to push to the member list, please. On Wed, Mar 28, 2018 at 2:58 PM Drew Allen wrote: > Hello all, > > My name is Andrew Allen and I'm a contributor to Opus, supporting new > channel mappings 2 and 3 for ambisonics compression. I've attached a

[FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-03-29 Thread Drew Allen
Hello all, My name is Andrew Allen and I'm a contributor to Opus, supporting new channel mappings 2 and 3 for ambisonics compression. I've attached a patch to support the new OpusProjectionEncoder and OpusProjectionDecoder APIs for handling the new channel mapping 3 in OPUS. Please let me know