Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread Marton Balint
On Mon, 28 Aug 2017, Dale Curtis wrote: On Mon, Aug 28, 2017 at 2:28 AM, wm4 wrote: Seems way too intrusive and the result makes AVOption tables even uglier and harder to read. Agree it's ugly. Any suggestions? I tried some way of forcing the AVOption entry to

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread wm4
On Mon, 28 Aug 2017 13:28:16 -0700 Dale Curtis wrote: > On Mon, Aug 28, 2017 at 12:56 PM, wm4 wrote: > > > > LTO seems unlikely to help in this situation - the linker can't know > > whether struct members and their initializers are unused. > > >

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread Dale Curtis
On Mon, Aug 28, 2017 at 12:56 PM, wm4 wrote: > > LTO seems unlikely to help in this situation - the linker can't know > whether struct members and their initializers are unused. > Correct. > > But I think there's much much bigger fish to fry to save space. For > example,

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread wm4
On Mon, 28 Aug 2017 19:42:44 +0100 Rostislav Pehlivanov wrote: > On 26 August 2017 at 00:20, Dale Curtis wrote: > > > Saves ~12kb of binary size and seems like a good use of > > CONFIG_SMALL. I've only converted some of the largest > > tables in

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread Carl Eugen Hoyos
2017-08-28 20:42 GMT+02:00 Rostislav Pehlivanov : > I disagree with this patch as well. > If you need more space savings use LTO. How is this related? > IMO we should drop CONFIG_SMALL for codec descriptions too. Did this ever hit you in any way? Carl Eugen

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread Rostislav Pehlivanov
On 26 August 2017 at 00:20, Dale Curtis wrote: > Saves ~12kb of binary size and seems like a good use of > CONFIG_SMALL. I've only converted some of the largest > tables in this patch, there's way more to do if this is a > reasonable direction. > > - dale > >

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread Dale Curtis
On Mon, Aug 28, 2017 at 2:28 AM, wm4 wrote: > > > Seems way too intrusive and the result makes AVOption tables even > uglier and harder to read. Agree it's ugly. Any suggestions? I tried some way of forcing the AVOption entry to have zero-storage (thus null always), but

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread wm4
On Fri, 25 Aug 2017 16:20:28 -0700 Dale Curtis wrote: > Saves ~12kb of binary size and seems like a good use of > CONFIG_SMALL. I've only converted some of the largest > tables in this patch, there's way more to do if this is a > reasonable direction. > > - dale Seems

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 04:20:28PM -0700, Dale Curtis wrote: > Saves ~12kb of binary size and seems like a good use of > CONFIG_SMALL. I've only converted some of the largest > tables in this patch, there's way more to do if this is a > reasonable direction. [...] > -{"dump_separator", "set