Re: [FFmpeg-devel] [PATCH] added possibility to set first to ninth audio language for RIFF taged files (e.g. avi files)

2016-10-05 Thread Michael Niedermayer 
On Sun, Oct 02, 2016 at 07:01:05PM +0200, Florian Diemer wrote:
> ---
> Sorry but the first patch was improperly formatted.
> 
> 
> According to this page 
> (http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html#Info) it is 
> possible
> to add language information ("IAS1" (first language) to "IAS9" (ninth 
> language)) to RIFF tagged files (as RIFF Info Tags).
> Programs such as VLC media player or MediaInfo can properly read and display 
> this information. Allowing to set this tags
> with the -metadata option while encoding, would simplify the process.
> ---
>  libavformat/riffenc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

applied

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] added possibility to set first to ninth audio language for RIFF taged files (e.g. avi files)

2016-10-02 Thread Florian Diemer 
---
Sorry but the first patch was improperly formatted.


According to this page 
(http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html#Info) it is 
possible
to add language information ("IAS1" (first language) to "IAS9" (ninth 
language)) to RIFF tagged files (as RIFF Info Tags).
Programs such as VLC media player or MediaInfo can properly read and display 
this information. Allowing to set this tags
with the -metadata option while encoding, would simplify the process.
---
 libavformat/riffenc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c
index 36e6ac7..4b25c06 100644
--- a/libavformat/riffenc.c
+++ b/libavformat/riffenc.c
@@ -304,7 +304,8 @@ void ff_riff_write_info_tag(AVIOContext *pb, const char 
*tag, const char *str)
 }
 
 static const char riff_tags[][5] = {
-"IARL", "IART", "ICMS", "ICMT", "ICOP", "ICRD", "ICRP", "IDIM", "IDPI",
+"IARL", "IART", "IAS1", "IAS2", "IAS3", "IAS4", "IAS5", "IAS6", "IAS7",
+"IAS8", "IAS9", "ICMS", "ICMT", "ICOP", "ICRD", "ICRP", "IDIM", "IDPI",
 "IENG", "IGNR", "IKEY", "ILGT", "ILNG", "IMED", "INAM", "IPLT", "IPRD",
 "IPRT", "ITRK", "ISBJ", "ISFT", "ISHP", "ISMP", "ISRC", "ISRF", "ITCH",
 { 0 }
-- 
2.10.0.windows.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] added possibility to set first to ninth audio language for RIFF taged files (e.g. avi files)

2016-10-02 Thread floriandiemer 


---
According to this page 
(http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html#Info) 
it is possible
to add language information ("IAS1" (first language) to "IAS9" (ninth 
language)) to RIFF tagged files (as RIFF Info Tags).
Programs such as VLC media player or MediaInfo can properly read and 
display this information. Allowing to set this tags

with the -metadata option while encoding, would simplify the process.
---
libavformat/riffenc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c
index 36e6ac7..4b25c06 100644
--- a/libavformat/riffenc.c
+++ b/libavformat/riffenc.c
@@ -304,7 +304,8 @@ void ff_riff_write_info_tag(AVIOContext *pb, const 
char *tag, const char *str)

}

static const char riff_tags[][5] = {
- "IARL", "IART", "ICMS", "ICMT", "ICOP", "ICRD", "ICRP", "IDIM", "IDPI",
+ "IARL", "IART", "IAS1", "IAS2", "IAS3", "IAS4", "IAS5", "IAS6", "IAS7",
+ "IAS8", "IAS9", "ICMS", "ICMT", "ICOP", "ICRD", "ICRP", "IDIM", "IDPI",
"IENG", "IGNR", "IKEY", "ILGT", "ILNG", "IMED", "INAM", "IPLT", "IPRD",
"IPRT", "ITRK", "ISBJ", "ISFT", "ISHP", "ISMP", "ISRC", "ISRF", "ITCH",
{ 0 }
--
2.10.0.windows.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel