Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

On June 22, 2016 at 12:12:02 PM, Amancio Hasty (aha...@gmail.com) wrote:


On Jun 22, 2016, at 10:20 AM, Aman Gupta  wrote:

This patch should fix the assertion failure you see:
https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4

Aman
On Sat, Jun 18, 2016 at 8:43 AM Amancio Hasty  wrote:


On Jun 16, 2016, at 11:16 AM, Aman Gupta  wrote:

The patchset that was merged into libav is now available in ffmpeg as

well:

https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c

You can compile ffmpeg from the master branch
with --enable-omx --enable-omx-rpi

Aman

On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty  wrote:


On May 9, 2016, at 7:55 AM, Amancio Hasty  wrote:

Hi,

So what is the next step?

If you want testers I suggest posting to ccrisan’s motionpie mailing

list.

Cheers
Amancio


On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:

I am not a lawyer…


I updated the patch.  vc264.c now has a the copyright notice embedded

in

a volatile global so if a binary is compiled against vc264.o , the

copyright notice

can be displayed by:
strings ffmpeg | grep -i copyright

LICENSE.md has been updated to include Broadcom’s copyright notice.

A distribution of a  binary that includes vc264.o should include

LICENSE.md and if

that is missing,  the copyright notice can be displayed via the shell
command ‘strings’ .

Amancio


On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:

On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:

From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00

2001

From: Amancio Hasty 
Date: Mon, 21 Mar 2016 18:56:05 -0700
Subject: [PATCH] added support for hardware assist H264  video

encoding for

the Raspberry Pi

---
configure  |  12 ++
libavcodec/Makefile|   1 +
libavcodec/allcodecs.c |   2 +
libavcodec/vc264.c | 387

+

4 files changed, 402 insertions(+)
create mode 100644 libavcodec/vc264.c

[...]

diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
index 2a25d66..3c7bd9b 100644
--- a/libavcodec/allcodecs.c
+++ b/libavcodec/allcodecs.c
@@ -74,6 +74,7 @@ void avcodec_register_all(void)
initialized = 1;


Nit: Whitespace on the line above should be removed.

[...]

--- /dev/null
+++ b/libavcodec/vc264.c
@@ -0,0 +1,387 @@
+/*  H.264 hardware assist video encoding code taken from
+ * raspberry's os :
+ *   /opt/vc/src/hello_pi/hello_encode/encode.c
+ */
+
+/*
+Copyright (c) 2012, Broadcom Europe Ltd
+Copyright (c) 2012, Kalle Vahlman 
+Tuomas Kulve 
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions

are met:

+* Redistributions of source code must retain the above copyright
+  notice, this list of conditions and the following disclaimer.
+  * Redistributions in binary form must reproduce the above

copyright

+  notice, this list of conditions and the following disclaimer

in the

+  documentation and/or other materials provided with the

distribution.

+  * Neither the name of the copyright holder nor the
+  names of its contributors may be used to endorse or promote

products

+  derived from this software without specific prior written

permission.

+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

"AS IS" AND

+ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,

THE IMPLIED

+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE

ARE

+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS

BE LIABLE FOR ANY

+DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL

DAMAGES

+(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR

SERVICES;

+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER

CAUSED AND

+ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,

OR TORT

+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE

USE OF THIS

+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


I wonder if any of the above legalese is compatible. Granted, I see a
similar paragraph in "libavformat/aadec.c".

+ * ffmpeg driver for hardware assist video H.264 encoding using

Broadcom's GPU

+ * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
+ *
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later

version.

+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Jun 22, 2016, at 10:20 AM, Aman Gupta  wrote:
> 
> This patch should fix the assertion failure you see:
> https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4
>  
> 
> 
> Aman
> On Sat, Jun 18, 2016 at 8:43 AM Amancio Hasty  > wrote:
> 
>> 
>>> On Jun 16, 2016, at 11:16 AM, Aman Gupta  wrote:
>>> 
>>> The patchset that was merged into libav is now available in ffmpeg as
>> well:
>>> https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c
>>> 
>>> You can compile ffmpeg from the master branch
>>> with --enable-omx --enable-omx-rpi
>>> 
>>> Aman
>>> 
>>> On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty  wrote:
>>> 
 
> On May 9, 2016, at 7:55 AM, Amancio Hasty  wrote:
> 
> Hi,
> 
> So what is the next step?
> 
> If you want testers I suggest posting to ccrisan’s motionpie mailing
 list.
> Cheers
> Amancio
> 
> 
>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
>> 
>> I am not a lawyer…
>> 
>> 
>> I updated the patch.  vc264.c now has a the copyright notice embedded
>> in
>> a volatile global so if a binary is compiled against vc264.o , the
 copyright notice
>> can be displayed by:
>> strings ffmpeg | grep -i copyright
>> 
>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>> 
>> A distribution of a  binary that includes vc264.o should include
 LICENSE.md and if
>> that is missing,  the copyright notice can be displayed via the shell
>> command ‘strings’ .
>> 
>> Amancio
>> 
>>> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
>>> 
>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>> 
 From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00
>> 2001
 From: Amancio Hasty 
 Date: Mon, 21 Mar 2016 18:56:05 -0700
 Subject: [PATCH] added support for hardware assist H264  video
 encoding for
 the Raspberry Pi
 
 ---
 configure  |  12 ++
 libavcodec/Makefile|   1 +
 libavcodec/allcodecs.c |   2 +
 libavcodec/vc264.c | 387
 +
 4 files changed, 402 insertions(+)
 create mode 100644 libavcodec/vc264.c
 
>>> [...]
 diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
 index 2a25d66..3c7bd9b 100644
 --- a/libavcodec/allcodecs.c
 +++ b/libavcodec/allcodecs.c
 @@ -74,6 +74,7 @@ void avcodec_register_all(void)
 initialized = 1;
 
>>> 
>>> Nit: Whitespace on the line above should be removed.
>>> 
>>> [...]
 --- /dev/null
 +++ b/libavcodec/vc264.c
 @@ -0,0 +1,387 @@
 +/*  H.264 hardware assist video encoding code taken from
 + * raspberry's os :
 + *   /opt/vc/src/hello_pi/hello_encode/encode.c
 + */
 +
 +/*
 +Copyright (c) 2012, Broadcom Europe Ltd
 +Copyright (c) 2012, Kalle Vahlman 
 +Tuomas Kulve 
 +All rights reserved.
 +
 +Redistribution and use in source and binary forms, with or without
 +modification, are permitted provided that the following conditions
 are met:
 +* Redistributions of source code must retain the above copyright
 +  notice, this list of conditions and the following disclaimer.
 +  * Redistributions in binary form must reproduce the above
 copyright
 +  notice, this list of conditions and the following disclaimer
 in the
 +  documentation and/or other materials provided with the
 distribution.
 +  * Neither the name of the copyright holder nor the
 +  names of its contributors may be used to endorse or promote
 products
 +  derived from this software without specific prior written
 permission.
 +
 +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 "AS IS" AND
 +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
 THE IMPLIED
 +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 ARE
 +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS
 BE LIABLE FOR ANY
 +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 DAMAGES
 +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 SERVICES;
 +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 CAUSED AND
 +ON ANY THEORY OF LIABILITY, 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Aman Gupta]

This patch should fix the assertion failure you see:
https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4

Aman
On Sat, Jun 18, 2016 at 8:43 AM Amancio Hasty  wrote:

>
> > On Jun 16, 2016, at 11:16 AM, Aman Gupta  wrote:
> >
> > The patchset that was merged into libav is now available in ffmpeg as
> well:
> > https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c
> >
> > You can compile ffmpeg from the master branch
> > with --enable-omx --enable-omx-rpi
> >
> > Aman
> >
> > On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty  wrote:
> >
> >>
> >>> On May 9, 2016, at 7:55 AM, Amancio Hasty  wrote:
> >>>
> >>> Hi,
> >>>
> >>> So what is the next step?
> >>>
> >>> If you want testers I suggest posting to ccrisan’s motionpie mailing
> >> list.
> >>> Cheers
> >>> Amancio
> >>>
> >>>
>  On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> 
>  I am not a lawyer…
> 
> 
>  I updated the patch.  vc264.c now has a the copyright notice embedded
> in
>  a volatile global so if a binary is compiled against vc264.o , the
> >> copyright notice
>  can be displayed by:
>  strings ffmpeg | grep -i copyright
> 
>  LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
>  A distribution of a  binary that includes vc264.o should include
> >> LICENSE.md and if
>  that is missing,  the copyright notice can be displayed via the shell
>  command ‘strings’ .
> 
>  Amancio
>  
> > On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> >
> > On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> >
> >> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00
> 2001
> >> From: Amancio Hasty 
> >> Date: Mon, 21 Mar 2016 18:56:05 -0700
> >> Subject: [PATCH] added support for hardware assist H264  video
> >> encoding for
> >> the Raspberry Pi
> >>
> >> ---
> >> configure  |  12 ++
> >> libavcodec/Makefile|   1 +
> >> libavcodec/allcodecs.c |   2 +
> >> libavcodec/vc264.c | 387
> >> +
> >> 4 files changed, 402 insertions(+)
> >> create mode 100644 libavcodec/vc264.c
> >>
> > [...]
> >> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> >> index 2a25d66..3c7bd9b 100644
> >> --- a/libavcodec/allcodecs.c
> >> +++ b/libavcodec/allcodecs.c
> >> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
> >>  initialized = 1;
> >>
> >
> > Nit: Whitespace on the line above should be removed.
> >
> > [...]
> >> --- /dev/null
> >> +++ b/libavcodec/vc264.c
> >> @@ -0,0 +1,387 @@
> >> +/*  H.264 hardware assist video encoding code taken from
> >> + * raspberry's os :
> >> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
> >> + */
> >> +
> >> +/*
> >> +Copyright (c) 2012, Broadcom Europe Ltd
> >> +Copyright (c) 2012, Kalle Vahlman 
> >> +Tuomas Kulve 
> >> +All rights reserved.
> >> +
> >> +Redistribution and use in source and binary forms, with or without
> >> +modification, are permitted provided that the following conditions
> >> are met:
> >> +* Redistributions of source code must retain the above copyright
> >> +  notice, this list of conditions and the following disclaimer.
> >> +  * Redistributions in binary form must reproduce the above
> >> copyright
> >> +  notice, this list of conditions and the following disclaimer
> >> in the
> >> +  documentation and/or other materials provided with the
> >> distribution.
> >> +  * Neither the name of the copyright holder nor the
> >> +  names of its contributors may be used to endorse or promote
> >> products
> >> +  derived from this software without specific prior written
> >> permission.
> >> +
> >> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> >> "AS IS" AND
> >> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> >> THE IMPLIED
> >> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> >> ARE
> >> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS
> >> BE LIABLE FOR ANY
> >> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> >> DAMAGES
> >> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> >> SERVICES;
> >> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> >> CAUSED AND
> >> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
> >> OR TORT
> >> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
> >> USE OF THIS
> >> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >
> > I 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Jun 16, 2016, at 11:16 AM, Aman Gupta  wrote:
> 
> The patchset that was merged into libav is now available in ffmpeg as well:
> https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c
> 
> You can compile ffmpeg from the master branch
> with --enable-omx --enable-omx-rpi
> 
> Aman
> 
> On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty  wrote:
> 
>> 
>>> On May 9, 2016, at 7:55 AM, Amancio Hasty  wrote:
>>> 
>>> Hi,
>>> 
>>> So what is the next step?
>>> 
>>> If you want testers I suggest posting to ccrisan’s motionpie mailing
>> list.
>>> Cheers
>>> Amancio
>>> 
>>> 
 On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
 
 I am not a lawyer…
 
 
 I updated the patch.  vc264.c now has a the copyright notice embedded in
 a volatile global so if a binary is compiled against vc264.o , the
>> copyright notice
 can be displayed by:
 strings ffmpeg | grep -i copyright
 
 LICENSE.md has been updated to include Broadcom’s copyright notice.
 
 A distribution of a  binary that includes vc264.o should include
>> LICENSE.md and if
 that is missing,  the copyright notice can be displayed via the shell
 command ‘strings’ .
 
 Amancio
 
> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> 
> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> 
>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>> From: Amancio Hasty 
>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>> Subject: [PATCH] added support for hardware assist H264  video
>> encoding for
>> the Raspberry Pi
>> 
>> ---
>> configure  |  12 ++
>> libavcodec/Makefile|   1 +
>> libavcodec/allcodecs.c |   2 +
>> libavcodec/vc264.c | 387
>> +
>> 4 files changed, 402 insertions(+)
>> create mode 100644 libavcodec/vc264.c
>> 
> [...]
>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>> index 2a25d66..3c7bd9b 100644
>> --- a/libavcodec/allcodecs.c
>> +++ b/libavcodec/allcodecs.c
>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>  initialized = 1;
>> 
> 
> Nit: Whitespace on the line above should be removed.
> 
> [...]
>> --- /dev/null
>> +++ b/libavcodec/vc264.c
>> @@ -0,0 +1,387 @@
>> +/*  H.264 hardware assist video encoding code taken from
>> + * raspberry's os :
>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>> + */
>> +
>> +/*
>> +Copyright (c) 2012, Broadcom Europe Ltd
>> +Copyright (c) 2012, Kalle Vahlman 
>> +Tuomas Kulve 
>> +All rights reserved.
>> +
>> +Redistribution and use in source and binary forms, with or without
>> +modification, are permitted provided that the following conditions
>> are met:
>> +* Redistributions of source code must retain the above copyright
>> +  notice, this list of conditions and the following disclaimer.
>> +  * Redistributions in binary form must reproduce the above
>> copyright
>> +  notice, this list of conditions and the following disclaimer
>> in the
>> +  documentation and/or other materials provided with the
>> distribution.
>> +  * Neither the name of the copyright holder nor the
>> +  names of its contributors may be used to endorse or promote
>> products
>> +  derived from this software without specific prior written
>> permission.
>> +
>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
>> "AS IS" AND
>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>> THE IMPLIED
>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
>> ARE
>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS
>> BE LIABLE FOR ANY
>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
>> DAMAGES
>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
>> SERVICES;
>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
>> CAUSED AND
>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
>> OR TORT
>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
>> USE OF THIS
>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> I wonder if any of the above legalese is compatible. Granted, I see a
> similar paragraph in "libavformat/aadec.c".
> 
>> + * ffmpeg driver for hardware assist video H.264 encoding using
>> Broadcom's GPU
>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>> + *
>> + *
>> + * This file is part of FFmpeg.
>> + *
>> + * FFmpeg is free software; you can redistribute it and/or
>> + * modify it under the terms 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Aman Gupta]

The patchset that was merged into libav is now available in ffmpeg as well:
https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c

You can compile ffmpeg from the master branch
with --enable-omx --enable-omx-rpi

Aman

On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty  wrote:

>
> > On May 9, 2016, at 7:55 AM, Amancio Hasty  wrote:
> >
> > Hi,
> >
> > So what is the next step?
> >
> > If you want testers I suggest posting to ccrisan’s motionpie mailing
> list.
> > Cheers
> > Amancio
> >
> >
> >> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> >>
> >> I am not a lawyer…
> >>
> >>
> >> I updated the patch.  vc264.c now has a the copyright notice embedded in
> >> a volatile global so if a binary is compiled against vc264.o , the
> copyright notice
> >> can be displayed by:
> >> strings ffmpeg | grep -i copyright
> >>
> >> LICENSE.md has been updated to include Broadcom’s copyright notice.
> >>
> >> A distribution of a  binary that includes vc264.o should include
> LICENSE.md and if
> >> that is missing,  the copyright notice can be displayed via the shell
> >> command ‘strings’ .
> >>
> >> Amancio
> >> 
> >>> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> >>>
> >>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> >>>
>  From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>  From: Amancio Hasty 
>  Date: Mon, 21 Mar 2016 18:56:05 -0700
>  Subject: [PATCH] added support for hardware assist H264  video
> encoding for
>  the Raspberry Pi
> 
>  ---
>  configure  |  12 ++
>  libavcodec/Makefile|   1 +
>  libavcodec/allcodecs.c |   2 +
>  libavcodec/vc264.c | 387
> +
>  4 files changed, 402 insertions(+)
>  create mode 100644 libavcodec/vc264.c
> 
> >>> [...]
>  diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>  index 2a25d66..3c7bd9b 100644
>  --- a/libavcodec/allcodecs.c
>  +++ b/libavcodec/allcodecs.c
>  @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>    initialized = 1;
> 
> >>>
> >>> Nit: Whitespace on the line above should be removed.
> >>>
> >>> [...]
>  --- /dev/null
>  +++ b/libavcodec/vc264.c
>  @@ -0,0 +1,387 @@
>  +/*  H.264 hardware assist video encoding code taken from
>  + * raspberry's os :
>  + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>  + */
>  +
>  +/*
>  +Copyright (c) 2012, Broadcom Europe Ltd
>  +Copyright (c) 2012, Kalle Vahlman 
>  +Tuomas Kulve 
>  +All rights reserved.
>  +
>  +Redistribution and use in source and binary forms, with or without
>  +modification, are permitted provided that the following conditions
> are met:
>  +* Redistributions of source code must retain the above copyright
>  +  notice, this list of conditions and the following disclaimer.
>  +  * Redistributions in binary form must reproduce the above
> copyright
>  +  notice, this list of conditions and the following disclaimer
> in the
>  +  documentation and/or other materials provided with the
> distribution.
>  +  * Neither the name of the copyright holder nor the
>  +  names of its contributors may be used to endorse or promote
> products
>  +  derived from this software without specific prior written
> permission.
>  +
>  +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> "AS IS" AND
>  +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> THE IMPLIED
>  +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> ARE
>  +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS
> BE LIABLE FOR ANY
>  +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> DAMAGES
>  +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> SERVICES;
>  +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> CAUSED AND
>  +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
> OR TORT
>  +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
> USE OF THIS
>  +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >>>
> >>> I wonder if any of the above legalese is compatible. Granted, I see a
> >>> similar paragraph in "libavformat/aadec.c".
> >>>
>  + * ffmpeg driver for hardware assist video H.264 encoding using
> Broadcom's GPU
>  + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>  + *
>  + *
>  + * This file is part of FFmpeg.
>  + *
>  + * FFmpeg is free software; you can redistribute it and/or
>  + * modify it under the terms of the GNU Lesser General Public
>  + * License as published by the Free Software Foundation; either
>  + * version 2.1 of the 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On May 9, 2016, at 7:55 AM, Amancio Hasty  wrote:
> 
> Hi,
> 
> So what is the next step?
> 
> If you want testers I suggest posting to ccrisan’s motionpie mailing list.
> Cheers
> Amancio
> 
> 
>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
>> 
>> I am not a lawyer…
>> 
>> 
>> I updated the patch.  vc264.c now has a the copyright notice embedded in 
>> a volatile global so if a binary is compiled against vc264.o , the copyright 
>> notice
>> can be displayed by:
>> strings ffmpeg | grep -i copyright
>> 
>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>> 
>> A distribution of a  binary that includes vc264.o should include LICENSE.md 
>> and if 
>> that is missing,  the copyright notice can be displayed via the shell
>> command ‘strings’ .
>> 
>> Amancio
>> 
>>> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
>>> 
>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>> 
 From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
 From: Amancio Hasty 
 Date: Mon, 21 Mar 2016 18:56:05 -0700
 Subject: [PATCH] added support for hardware assist H264  video encoding for
 the Raspberry Pi
 
 ---
 configure  |  12 ++
 libavcodec/Makefile|   1 +
 libavcodec/allcodecs.c |   2 +
 libavcodec/vc264.c | 387 
 +
 4 files changed, 402 insertions(+)
 create mode 100644 libavcodec/vc264.c
 
>>> [...]
 diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
 index 2a25d66..3c7bd9b 100644
 --- a/libavcodec/allcodecs.c
 +++ b/libavcodec/allcodecs.c
 @@ -74,6 +74,7 @@ void avcodec_register_all(void)
   initialized = 1;
 
>>> 
>>> Nit: Whitespace on the line above should be removed.
>>> 
>>> [...]
 --- /dev/null
 +++ b/libavcodec/vc264.c
 @@ -0,0 +1,387 @@
 +/*  H.264 hardware assist video encoding code taken from
 + * raspberry's os :
 + *   /opt/vc/src/hello_pi/hello_encode/encode.c
 + */
 +
 +/*
 +Copyright (c) 2012, Broadcom Europe Ltd
 +Copyright (c) 2012, Kalle Vahlman 
 +Tuomas Kulve 
 +All rights reserved.
 +
 +Redistribution and use in source and binary forms, with or without
 +modification, are permitted provided that the following conditions are 
 met:
 +* Redistributions of source code must retain the above copyright
 +  notice, this list of conditions and the following disclaimer.
 +  * Redistributions in binary form must reproduce the above copyright
 +  notice, this list of conditions and the following disclaimer in the
 +  documentation and/or other materials provided with the distribution.
 +  * Neither the name of the copyright holder nor the
 +  names of its contributors may be used to endorse or promote products
 +  derived from this software without specific prior written 
 permission.
 +
 +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
 IS" AND
 +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
 IMPLIED
 +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
 LIABLE FOR ANY
 +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
 +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
 SERVICES;
 +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED 
 AND
 +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
 THIS
 +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>>> 
>>> I wonder if any of the above legalese is compatible. Granted, I see a
>>> similar paragraph in "libavformat/aadec.c".
>>> 
 + * ffmpeg driver for hardware assist video H.264 encoding using 
 Broadcom's GPU
 + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
 + *
 + *
 + * This file is part of FFmpeg.
 + *
 + * FFmpeg is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU Lesser General Public
 + * License as published by the Free Software Foundation; either
 + * version 2.1 of the License, or (at your option) any later version.
 + *
 + * FFmpeg is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 + * Lesser General Public License for more details.
 + *
 + * You should have received a copy of the GNU Lesser General Public
 + * License along with FFmpeg; if not, write to the 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

Hi,

So what is the next step?

If you want testers I suggest posting to ccrisan’s motionpie mailing list.
Cheers
Amancio


> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> 
> I am not a lawyer…
> 
> 
> I updated the patch.  vc264.c now has a the copyright notice embedded in 
> a volatile global so if a binary is compiled against vc264.o , the copyright 
> notice
> can be displayed by:
> strings ffmpeg | grep -i copyright
> 
> LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
> A distribution of a  binary that includes vc264.o should include LICENSE.md 
> and if 
> that is missing,  the copyright notice can be displayed via the shell
> command ‘strings’ .
> 
> Amancio
> 
>> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
>> 
>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>> 
>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>> From: Amancio Hasty 
>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>> the Raspberry Pi
>>> 
>>> ---
>>> configure  |  12 ++
>>> libavcodec/Makefile|   1 +
>>> libavcodec/allcodecs.c |   2 +
>>> libavcodec/vc264.c | 387 
>>> +
>>> 4 files changed, 402 insertions(+)
>>> create mode 100644 libavcodec/vc264.c
>>> 
>> [...]
>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>> index 2a25d66..3c7bd9b 100644
>>> --- a/libavcodec/allcodecs.c
>>> +++ b/libavcodec/allcodecs.c
>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>initialized = 1;
>>> 
>> 
>> Nit: Whitespace on the line above should be removed.
>> 
>> [...]
>>> --- /dev/null
>>> +++ b/libavcodec/vc264.c
>>> @@ -0,0 +1,387 @@
>>> +/*  H.264 hardware assist video encoding code taken from
>>> + * raspberry's os :
>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>> + */
>>> +
>>> +/*
>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>> +Copyright (c) 2012, Kalle Vahlman 
>>> +Tuomas Kulve 
>>> +All rights reserved.
>>> +
>>> +Redistribution and use in source and binary forms, with or without
>>> +modification, are permitted provided that the following conditions are met:
>>> +* Redistributions of source code must retain the above copyright
>>> +  notice, this list of conditions and the following disclaimer.
>>> +  * Redistributions in binary form must reproduce the above copyright
>>> +  notice, this list of conditions and the following disclaimer in the
>>> +  documentation and/or other materials provided with the distribution.
>>> +  * Neither the name of the copyright holder nor the
>>> +  names of its contributors may be used to endorse or promote products
>>> +  derived from this software without specific prior written permission.
>>> +
>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>> IS" AND
>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>> IMPLIED
>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>> LIABLE FOR ANY
>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>> SERVICES;
>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>> THIS
>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 
>> I wonder if any of the above legalese is compatible. Granted, I see a
>> similar paragraph in "libavformat/aadec.c".
>> 
>>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>>> GPU
>>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>>> + *
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.1 of the License, or (at your option) any later version.
>>> + *
>>> + * FFmpeg is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with FFmpeg; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
>>> 02110-1301 USA
>>> + *
>>> + */
>>> +
>>> +
>>> +/**
>>> + * @ file vc264.c
>>> + * Broadcom bm2865's Visual Core hardware assist h264 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Aman Gupta]

I confirmed that this patch works on the rpi3, when compiling ffmpeg with
`--enable-omx --enable-omx-rpi` and using `ffmpeg -v:c h264_omx`

I had to make some minor changes for ffmpeg compatibility which I pushed to
my rebase branch.

Aman

On Thu, Apr 21, 2016 at 10:14 AM, Amancio Hasty  wrote:

> Curious,
>
> Do these patches work with ffmpeg running on RPi?
>
> Thanks,
> Amancio
>
> > On Apr 19, 2016, at 12:00 PM, Aman Gupta  wrote:
> >
> > On Thu, Apr 7, 2016 at 3:03 AM, Mark Thompson > wrote:
> >
> >> On 06/04/16 14:25, Amancio Hasty wrote:
> >>>
>  On Apr 6, 2016, at 3:42 AM, wm4  wrote:
> 
>  On Wed, 6 Apr 2016 02:56:49 -0700
>  Amancio Hasty  wrote:
> 
> > If you think is better and it works , are there any plans to
> >> incorporate such an older patch?
> 
>  I asked the author - he's looking into getting it ready for merge.
> 
> >>>
> >>> Curious, any reasonable estimate of when the merge is going to happen?
> >>>
> >>
> >> https://lists.libav.org/pipermail/libav-devel/2016-April/076042.html
> >> https://lists.libav.org/pipermail/libav-devel/2016-April/076040.html
> >> https://lists.libav.org/pipermail/libav-devel/2016-April/076041.html
> >>
> >> Please test/review!  (Make sure it works for you and has the features
> you
> >> want,
> >> at least.)
> >>
> >
> > Looks like these patches were merged into libav already. I've rebased
> them
> > on top of ffmpeg master here:
> > https://github.com/FFmpeg/FFmpeg/compare/master...tmm1:rebase-omx.patch
> 
> >
> > Aman
> >
> >
> >>
> >> ___
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel@ffmpeg.org 
> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel <
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
> >>
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org 
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel <
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

Curious,

Do these patches work with ffmpeg running on RPi?

Thanks,
Amancio

> On Apr 19, 2016, at 12:00 PM, Aman Gupta  wrote:
> 
> On Thu, Apr 7, 2016 at 3:03 AM, Mark Thompson  > wrote:
> 
>> On 06/04/16 14:25, Amancio Hasty wrote:
>>> 
 On Apr 6, 2016, at 3:42 AM, wm4  wrote:
 
 On Wed, 6 Apr 2016 02:56:49 -0700
 Amancio Hasty  wrote:
 
> If you think is better and it works , are there any plans to
>> incorporate such an older patch?
 
 I asked the author - he's looking into getting it ready for merge.
 
>>> 
>>> Curious, any reasonable estimate of when the merge is going to happen?
>>> 
>> 
>> https://lists.libav.org/pipermail/libav-devel/2016-April/076042.html
>> https://lists.libav.org/pipermail/libav-devel/2016-April/076040.html
>> https://lists.libav.org/pipermail/libav-devel/2016-April/076041.html
>> 
>> Please test/review!  (Make sure it works for you and has the features you
>> want,
>> at least.)
>> 
> 
> Looks like these patches were merged into libav already. I've rebased them
> on top of ffmpeg master here:
> https://github.com/FFmpeg/FFmpeg/compare/master...tmm1:rebase-omx.patch 
> 
> 
> Aman
> 
> 
>> 
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org 
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 
>> 
>> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org 
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 
> 
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> 
> I am not a lawyer…
> 
> 
> I updated the patch.  vc264.c now has a the copyright notice embedded in 
> a volatile global so if a binary is compiled against vc264.o , the copyright 
> notice
> can be displayed by:
> strings ffmpeg | grep -i copyright
> 
> LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
> A distribution of a  binary that includes vc264.o should include LICENSE.md 
> and if 
> that is missing,  the copyright notice can be displayed via the shell
> command ‘strings’ .
> 
> Amancio
> 
>> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
>> 
>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>> 
>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>> From: Amancio Hasty 
>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>> the Raspberry Pi
>>> 
>>> ---
>>> configure  |  12 ++
>>> libavcodec/Makefile|   1 +
>>> libavcodec/allcodecs.c |   2 +
>>> libavcodec/vc264.c | 387 
>>> +
>>> 4 files changed, 402 insertions(+)
>>> create mode 100644 libavcodec/vc264.c
>>> 
>> [...]
>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>> index 2a25d66..3c7bd9b 100644
>>> --- a/libavcodec/allcodecs.c
>>> +++ b/libavcodec/allcodecs.c
>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>initialized = 1;
>>> 
>> 
>> Nit: Whitespace on the line above should be removed.
>> 
>> [...]
>>> --- /dev/null
>>> +++ b/libavcodec/vc264.c
>>> @@ -0,0 +1,387 @@
>>> +/*  H.264 hardware assist video encoding code taken from
>>> + * raspberry's os :
>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>> + */
>>> +
>>> +/*
>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>> +Copyright (c) 2012, Kalle Vahlman 
>>> +Tuomas Kulve 
>>> +All rights reserved.
>>> +
>>> +Redistribution and use in source and binary forms, with or without
>>> +modification, are permitted provided that the following conditions are met:
>>> +* Redistributions of source code must retain the above copyright
>>> +  notice, this list of conditions and the following disclaimer.
>>> +  * Redistributions in binary form must reproduce the above copyright
>>> +  notice, this list of conditions and the following disclaimer in the
>>> +  documentation and/or other materials provided with the distribution.
>>> +  * Neither the name of the copyright holder nor the
>>> +  names of its contributors may be used to endorse or promote products
>>> +  derived from this software without specific prior written permission.
>>> +
>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>> IS" AND
>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>> IMPLIED
>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>> LIABLE FOR ANY
>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>> SERVICES;
>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>> THIS
>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 
>> I wonder if any of the above legalese is compatible. Granted, I see a
>> similar paragraph in "libavformat/aadec.c".
>> 
>>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>>> GPU
>>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>>> + *
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.1 of the License, or (at your option) any later version.
>>> + *
>>> + * FFmpeg is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with FFmpeg; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
>>> 02110-1301 USA
>>> + *
>>> + */
>>> +
>>> +
>>> +/**
>>> + * @ file vc264.c
>>> + * Broadcom bm2865's Visual Core hardware assist h264 using
>>> +   openMax interface to the GPU.
>>> +
>>> +*/
>>> +
>>> +#include 
>>> +#include 
>>> +#include 
>>> +#define 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Mark Thompson]

On 06/04/16 14:25, Amancio Hasty wrote:
> 
>> On Apr 6, 2016, at 3:42 AM, wm4  wrote:
>>
>> On Wed, 6 Apr 2016 02:56:49 -0700
>> Amancio Hasty  wrote:
>>
>>> If you think is better and it works , are there any plans to incorporate 
>>> such an older patch?
>>
>> I asked the author - he's looking into getting it ready for merge.
>> 
> 
> Curious, any reasonable estimate of when the merge is going to happen?
> 

https://lists.libav.org/pipermail/libav-devel/2016-April/076042.html
https://lists.libav.org/pipermail/libav-devel/2016-April/076040.html
https://lists.libav.org/pipermail/libav-devel/2016-April/076041.html

Please test/review!  (Make sure it works for you and has the features you want,
at least.)

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Apr 6, 2016, at 3:42 AM, wm4  wrote:
> 
> On Wed, 6 Apr 2016 02:56:49 -0700
> Amancio Hasty  wrote:
> 
>> If you think is better and it works , are there any plans to incorporate 
>> such an older patch?
> 
> I asked the author - he's looking into getting it ready for merge.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 
> 

Curious, any reasonable estimate of when the merge is going to happen?


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[wm4]

On Wed, 6 Apr 2016 02:56:49 -0700
Amancio Hasty  wrote:

> If you think is better and it works , are there any plans to incorporate such 
> an older patch?

I asked the author - he's looking into getting it ready for merge.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Apr 6, 2016, at 1:29 AM, wm4  wrote:
> 
> On Tue, 5 Apr 2016 16:09:42 -0700
> Amancio Hasty > wrote:
> 
>>> On Apr 5, 2016, at 3:57 PM, Michael Niedermayer  
>>> wrote:
>>> 
>>> On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote:  
 On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote:  
> 
>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
>> 
>> I am not a lawyer…
>> 
>> 
>> I updated the patch.  vc264.c now has a the copyright notice embedded in 
>> a volatile global so if a binary is compiled against vc264.o , the 
>> copyright notice
>> can be displayed by:
>> strings ffmpeg | grep -i copyright
>> 
>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>> 
>> A distribution of a  binary that includes vc264.o should include 
>> LICENSE.md and if 
>> that is missing,  the copyright notice can be displayed via the shell
>> command ‘strings’ .
>> 
>> Amancio
>>   
>>> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
>>> 
>>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>>> 
 From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
 From: Amancio Hasty 
 Date: Mon, 21 Mar 2016 18:56:05 -0700
 Subject: [PATCH] added support for hardware assist H264  video 
 encoding for
 the Raspberry Pi
 
 ---
 configure  |  12 ++
 libavcodec/Makefile|   1 +
 libavcodec/allcodecs.c |   2 +
 libavcodec/vc264.c | 387 
 +
 4 files changed, 402 insertions(+)
 create mode 100644 libavcodec/vc264.c
 
>>> [...]  
 diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
 index 2a25d66..3c7bd9b 100644
 --- a/libavcodec/allcodecs.c
 +++ b/libavcodec/allcodecs.c
 @@ -74,6 +74,7 @@ void avcodec_register_all(void)
  initialized = 1;
 
>>> 
>>> Nit: Whitespace on the line above should be removed.
>>> 
>>> [...]  
 --- /dev/null
 +++ b/libavcodec/vc264.c
 @@ -0,0 +1,387 @@
 +/*  H.264 hardware assist video encoding code taken from
 + * raspberry's os :
 + *   /opt/vc/src/hello_pi/hello_encode/encode.c
 + */
 +
 +/*
 +Copyright (c) 2012, Broadcom Europe Ltd
 +Copyright (c) 2012, Kalle Vahlman 
 +Tuomas Kulve 
 +All rights reserved.
 +
 +Redistribution and use in source and binary forms, with or without
 +modification, are permitted provided that the following conditions 
 are met:
 +* Redistributions of source code must retain the above copyright
 +  notice, this list of conditions and the following disclaimer.
 +  * Redistributions in binary form must reproduce the above 
 copyright
 +  notice, this list of conditions and the following disclaimer in 
 the
 +  documentation and/or other materials provided with the 
 distribution.
 +  * Neither the name of the copyright holder nor the
 +  names of its contributors may be used to endorse or promote 
 products
 +  derived from this software without specific prior written 
 permission.
 +
 +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
 "AS IS" AND
 +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
 IMPLIED
 +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
 LIABLE FOR ANY
 +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
 DAMAGES
 +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
 SERVICES;
 +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 
 CAUSED AND
 +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 
 TORT
 +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
 OF THIS
 +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  
>>> 
>>> I wonder if any of the above legalese is compatible. Granted, I see a
>>> similar paragraph in "libavformat/aadec.c".
>>> 
 + * ffmpeg driver for hardware assist video H.264 encoding using 
 Broadcom's GPU
 + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
 + *
 + *
 + * This file is part of FFmpeg.
 + 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[wm4]

On Tue, 5 Apr 2016 16:09:42 -0700
Amancio Hasty  wrote:

> > On Apr 5, 2016, at 3:57 PM, Michael Niedermayer  
> > wrote:
> > 
> > On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote:  
> >> On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote:  
> >>>   
>  On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
>  
>  I am not a lawyer…
>  
>  
>  I updated the patch.  vc264.c now has a the copyright notice embedded in 
>  a volatile global so if a binary is compiled against vc264.o , the 
>  copyright notice
>  can be displayed by:
>  strings ffmpeg | grep -i copyright
>  
>  LICENSE.md has been updated to include Broadcom’s copyright notice.
>  
>  A distribution of a  binary that includes vc264.o should include 
>  LICENSE.md and if 
>  that is missing,  the copyright notice can be displayed via the shell
>  command ‘strings’ .
>  
>  Amancio
>    
> > On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> > 
> > On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> >   
> >> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
> >> From: Amancio Hasty 
> >> Date: Mon, 21 Mar 2016 18:56:05 -0700
> >> Subject: [PATCH] added support for hardware assist H264  video 
> >> encoding for
> >> the Raspberry Pi
> >> 
> >> ---
> >> configure  |  12 ++
> >> libavcodec/Makefile|   1 +
> >> libavcodec/allcodecs.c |   2 +
> >> libavcodec/vc264.c | 387 
> >> +
> >> 4 files changed, 402 insertions(+)
> >> create mode 100644 libavcodec/vc264.c
> >>   
> > [...]  
> >> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> >> index 2a25d66..3c7bd9b 100644
> >> --- a/libavcodec/allcodecs.c
> >> +++ b/libavcodec/allcodecs.c
> >> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
> >>   initialized = 1;
> >>   
> > 
> > Nit: Whitespace on the line above should be removed.
> > 
> > [...]  
> >> --- /dev/null
> >> +++ b/libavcodec/vc264.c
> >> @@ -0,0 +1,387 @@
> >> +/*  H.264 hardware assist video encoding code taken from
> >> + * raspberry's os :
> >> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
> >> + */
> >> +
> >> +/*
> >> +Copyright (c) 2012, Broadcom Europe Ltd
> >> +Copyright (c) 2012, Kalle Vahlman 
> >> +Tuomas Kulve 
> >> +All rights reserved.
> >> +
> >> +Redistribution and use in source and binary forms, with or without
> >> +modification, are permitted provided that the following conditions 
> >> are met:
> >> +* Redistributions of source code must retain the above copyright
> >> +  notice, this list of conditions and the following disclaimer.
> >> +  * Redistributions in binary form must reproduce the above 
> >> copyright
> >> +  notice, this list of conditions and the following disclaimer in 
> >> the
> >> +  documentation and/or other materials provided with the 
> >> distribution.
> >> +  * Neither the name of the copyright holder nor the
> >> +  names of its contributors may be used to endorse or promote 
> >> products
> >> +  derived from this software without specific prior written 
> >> permission.
> >> +
> >> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
> >> "AS IS" AND
> >> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
> >> IMPLIED
> >> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> >> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
> >> LIABLE FOR ANY
> >> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
> >> DAMAGES
> >> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
> >> SERVICES;
> >> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 
> >> CAUSED AND
> >> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 
> >> TORT
> >> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
> >> OF THIS
> >> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  
> > 
> > I wonder if any of the above legalese is compatible. Granted, I see a
> > similar paragraph in "libavformat/aadec.c".
> >   
> >> + * ffmpeg driver for hardware assist video H.264 encoding using 
> >> Broadcom's GPU
> >> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
> >> + *
> >> + *
> >> + * This file is part of FFmpeg.
> >> + *
> >> + * FFmpeg is free software; you can redistribute it and/or
> >> + * 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Apr 5, 2016, at 3:57 PM, Michael Niedermayer  
> wrote:
> 
> On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote:
>> On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote:
>>> 
 On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
 
 I am not a lawyer…
 
 
 I updated the patch.  vc264.c now has a the copyright notice embedded in 
 a volatile global so if a binary is compiled against vc264.o , the 
 copyright notice
 can be displayed by:
 strings ffmpeg | grep -i copyright
 
 LICENSE.md has been updated to include Broadcom’s copyright notice.
 
 A distribution of a  binary that includes vc264.o should include 
 LICENSE.md and if 
 that is missing,  the copyright notice can be displayed via the shell
 command ‘strings’ .
 
 Amancio
 
> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> 
> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> 
>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>> From: Amancio Hasty 
>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>> Subject: [PATCH] added support for hardware assist H264  video encoding 
>> for
>> the Raspberry Pi
>> 
>> ---
>> configure  |  12 ++
>> libavcodec/Makefile|   1 +
>> libavcodec/allcodecs.c |   2 +
>> libavcodec/vc264.c | 387 
>> +
>> 4 files changed, 402 insertions(+)
>> create mode 100644 libavcodec/vc264.c
>> 
> [...]
>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>> index 2a25d66..3c7bd9b 100644
>> --- a/libavcodec/allcodecs.c
>> +++ b/libavcodec/allcodecs.c
>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>   initialized = 1;
>> 
> 
> Nit: Whitespace on the line above should be removed.
> 
> [...]
>> --- /dev/null
>> +++ b/libavcodec/vc264.c
>> @@ -0,0 +1,387 @@
>> +/*  H.264 hardware assist video encoding code taken from
>> + * raspberry's os :
>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>> + */
>> +
>> +/*
>> +Copyright (c) 2012, Broadcom Europe Ltd
>> +Copyright (c) 2012, Kalle Vahlman 
>> +Tuomas Kulve 
>> +All rights reserved.
>> +
>> +Redistribution and use in source and binary forms, with or without
>> +modification, are permitted provided that the following conditions are 
>> met:
>> +* Redistributions of source code must retain the above copyright
>> +  notice, this list of conditions and the following disclaimer.
>> +  * Redistributions in binary form must reproduce the above 
>> copyright
>> +  notice, this list of conditions and the following disclaimer in 
>> the
>> +  documentation and/or other materials provided with the 
>> distribution.
>> +  * Neither the name of the copyright holder nor the
>> +  names of its contributors may be used to endorse or promote 
>> products
>> +  derived from this software without specific prior written 
>> permission.
>> +
>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>> IS" AND
>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>> IMPLIED
>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>> LIABLE FOR ANY
>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
>> DAMAGES
>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>> SERVICES;
>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED 
>> AND
>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 
>> TORT
>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
>> OF THIS
>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> I wonder if any of the above legalese is compatible. Granted, I see a
> similar paragraph in "libavformat/aadec.c".
> 
>> + * ffmpeg driver for hardware assist video H.264 encoding using 
>> Broadcom's GPU
>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>> + *
>> + *
>> + * This file is part of FFmpeg.
>> + *
>> + * FFmpeg is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU Lesser General Public
>> + * License as published by the Free Software Foundation; either
>> + * version 2.1 of the License, or (at your option) any later version.
>> + *
>> + * FFmpeg is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Mark Thompson]

On 01/04/16 03:27, Amancio Hasty wrote:
>  LICENSE.md |  36 +
>  MAINTAINERS|   1 +
>  configure  |  11 ++
>  libavcodec/Makefile|   1 +
>  libavcodec/allcodecs.c |   2 +
>  libavcodec/vc264.c | 389 
> +
>  6 files changed, 440 insertions(+)
>  create mode 100644 libavcodec/vc264.c
>
> diff --git a/LICENSE.md b/LICENSE.md
> index a70f486..363e4e4 100644
> --- a/LICENSE.md
> +++ b/LICENSE.md
> @@ -124,3 +124,39 @@ license, requires a proprietary binary blob at run time, 
> and is deemed to be
>  incompatible with the GPL. We are not certain if it is compatible with the
>  LGPL, but we require `--enable-nonfree` even with LGPL configurations in case
>  it is not.
> +
> +### libilclient and vc264.c hardware assist h264 encoder
> +If libilclient is enabled and vc264.c compiled , then this copyright
> +notice must accompany any binary which is compiled against
> +the library libavcodec. Additionally, this copyright notice can be viewed
> +against such  binary by using the unix shell commands :
> +strings ffmpeg_binary | grep -i copyright
> +
> +--
> +Copyright (c) 2012, Broadcom Europe Ltd
> +Copyright (c) 2012, Kalle Vahlman 
> +Tuomas Kulve 
> +All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are met:
> +* Redistributions of source code must retain the above copyright
> +  notice, this list of conditions and the following disclaimer.
> +  * Redistributions in binary form must reproduce the above copyright
> +  notice, this list of conditions and the following disclaimer in the
> +  documentation and/or other materials provided with the distribution.
> +  * Neither the name of the copyright holder nor the
> +  names of its contributors may be used to endorse or promote products
> +  derived from this software without specific prior written permission.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
> AND
> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE 
> FOR ANY
> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +--
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a993a67..71a321c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -278,6 +278,7 @@ Codecs:
>vble.cDerek Buitenhuis
>vc1*  Kostya Shishkov, Christophe Gisquet
>vc2*  Rostislav Pehlivanov
> +  vc264.c   Amancio Hasty
>vcr1.cMichael Niedermayer
>vda_h264_dec.cXidorn Quan
>videotoolboxenc.c Rick Kern
> diff --git a/configure b/configure
> index e8c4a7b..cd6563a 100755
> --- a/configure
> +++ b/configure
> @@ -277,6 +277,7 @@ External library support:
>--disable-lzma   disable lzma [autodetect]
>--enable-decklinkenable Blackmagic DeckLink I/O support [no]
>--enable-mediacodec  enable Android MediaCodec support [no]
> +  --enable-libilclient enable h264 encoding via ilclient [no]
>--enable-mmalenable decoding via MMAL [no]
>--enable-netcdf  enable NetCDF, needed for sofalizer filter [no]
>--enable-nvenc   enable NVIDIA NVENC support [no]
> @@ -1477,6 +1478,7 @@ EXTERNAL_LIBRARY_LIST="
>  libgsm
>  libiec61883
>  libilbc
> +libilclient
>  libkvazaar
>  libmfx
>  libmodplug
> @@ -2533,6 +2535,9 @@ h264_d3d11va_hwaccel_deps="d3d11va"
>  h264_d3d11va_hwaccel_select="h264_decoder"
>  h264_dxva2_hwaccel_deps="dxva2"
>  h264_dxva2_hwaccel_select="h264_decoder"
> +h264_libilclient_encoder_deps="libilclient"
> +h264_libilclient_encoder_select="libilclient"
> +h264_libilclient_hwaccel_deps="libilclient"

I think you're a little confused about what a hwaccel is here - a hwaccel is a 
decode acceleration tool, not anything to do with encode.  Remove all the 
references to hwaccels, they aren't relevant at all to the patch.

>  h264_mediacodec_decoder_deps="mediacodec"
>  h264_mediacodec_decoder_select="h264_mp4toannexb_bsf h264_parser"
>  h264_mmal_decoder_deps="mmal"
> @@ -5548,6 +5553,12 @@ enabled libgsm&& { for gsm_hdr in 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Michael Niedermayer]

On Tue, Apr 05, 2016 at 11:06:48PM +0200, Michael Niedermayer wrote:
> On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote:
> > 
> > > On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> > > 
> > > I am not a lawyer…
> > > 
> > > 
> > > I updated the patch.  vc264.c now has a the copyright notice embedded in 
> > > a volatile global so if a binary is compiled against vc264.o , the 
> > > copyright notice
> > > can be displayed by:
> > > strings ffmpeg | grep -i copyright
> > > 
> > > LICENSE.md has been updated to include Broadcom’s copyright notice.
> > > 
> > > A distribution of a  binary that includes vc264.o should include 
> > > LICENSE.md and if 
> > > that is missing,  the copyright notice can be displayed via the shell
> > > command ‘strings’ .
> > > 
> > > Amancio
> > > 
> > >> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> > >> 
> > >> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> > >> 
> > >>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
> > >>> From: Amancio Hasty 
> > >>> Date: Mon, 21 Mar 2016 18:56:05 -0700
> > >>> Subject: [PATCH] added support for hardware assist H264  video encoding 
> > >>> for
> > >>> the Raspberry Pi
> > >>> 
> > >>> ---
> > >>> configure  |  12 ++
> > >>> libavcodec/Makefile|   1 +
> > >>> libavcodec/allcodecs.c |   2 +
> > >>> libavcodec/vc264.c | 387 
> > >>> +
> > >>> 4 files changed, 402 insertions(+)
> > >>> create mode 100644 libavcodec/vc264.c
> > >>> 
> > >> [...]
> > >>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> > >>> index 2a25d66..3c7bd9b 100644
> > >>> --- a/libavcodec/allcodecs.c
> > >>> +++ b/libavcodec/allcodecs.c
> > >>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
> > >>>initialized = 1;
> > >>> 
> > >> 
> > >> Nit: Whitespace on the line above should be removed.
> > >> 
> > >> [...]
> > >>> --- /dev/null
> > >>> +++ b/libavcodec/vc264.c
> > >>> @@ -0,0 +1,387 @@
> > >>> +/*  H.264 hardware assist video encoding code taken from
> > >>> + * raspberry's os :
> > >>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
> > >>> + */
> > >>> +
> > >>> +/*
> > >>> +Copyright (c) 2012, Broadcom Europe Ltd
> > >>> +Copyright (c) 2012, Kalle Vahlman 
> > >>> +Tuomas Kulve 
> > >>> +All rights reserved.
> > >>> +
> > >>> +Redistribution and use in source and binary forms, with or without
> > >>> +modification, are permitted provided that the following conditions are 
> > >>> met:
> > >>> +* Redistributions of source code must retain the above copyright
> > >>> +  notice, this list of conditions and the following disclaimer.
> > >>> +  * Redistributions in binary form must reproduce the above 
> > >>> copyright
> > >>> +  notice, this list of conditions and the following disclaimer in 
> > >>> the
> > >>> +  documentation and/or other materials provided with the 
> > >>> distribution.
> > >>> +  * Neither the name of the copyright holder nor the
> > >>> +  names of its contributors may be used to endorse or promote 
> > >>> products
> > >>> +  derived from this software without specific prior written 
> > >>> permission.
> > >>> +
> > >>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
> > >>> "AS IS" AND
> > >>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
> > >>> IMPLIED
> > >>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> > >>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
> > >>> LIABLE FOR ANY
> > >>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
> > >>> DAMAGES
> > >>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
> > >>> SERVICES;
> > >>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 
> > >>> CAUSED AND
> > >>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 
> > >>> TORT
> > >>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
> > >>> OF THIS
> > >>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> > >> 
> > >> I wonder if any of the above legalese is compatible. Granted, I see a
> > >> similar paragraph in "libavformat/aadec.c".
> > >> 
> > >>> + * ffmpeg driver for hardware assist video H.264 encoding using 
> > >>> Broadcom's GPU
> > >>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
> > >>> + *
> > >>> + *
> > >>> + * This file is part of FFmpeg.
> > >>> + *
> > >>> + * FFmpeg is free software; you can redistribute it and/or
> > >>> + * modify it under the terms of the GNU Lesser General Public
> > >>> + * License as published by the Free Software Foundation; either
> > >>> + * version 2.1 of the License, or (at your option) any later version.
> > >>> + *
> > >>> + * FFmpeg is distributed in the hope that it will be useful,
> > >>> + * but WITHOUT 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Michael Niedermayer]

On Tue, Apr 05, 2016 at 12:00:26PM -0700, Amancio Hasty wrote:
> 
> > On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> > 
> > I am not a lawyer…
> > 
> > 
> > I updated the patch.  vc264.c now has a the copyright notice embedded in 
> > a volatile global so if a binary is compiled against vc264.o , the 
> > copyright notice
> > can be displayed by:
> > strings ffmpeg | grep -i copyright
> > 
> > LICENSE.md has been updated to include Broadcom’s copyright notice.
> > 
> > A distribution of a  binary that includes vc264.o should include LICENSE.md 
> > and if 
> > that is missing,  the copyright notice can be displayed via the shell
> > command ‘strings’ .
> > 
> > Amancio
> > 
> >> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> >> 
> >> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> >> 
> >>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
> >>> From: Amancio Hasty 
> >>> Date: Mon, 21 Mar 2016 18:56:05 -0700
> >>> Subject: [PATCH] added support for hardware assist H264  video encoding 
> >>> for
> >>> the Raspberry Pi
> >>> 
> >>> ---
> >>> configure  |  12 ++
> >>> libavcodec/Makefile|   1 +
> >>> libavcodec/allcodecs.c |   2 +
> >>> libavcodec/vc264.c | 387 
> >>> +
> >>> 4 files changed, 402 insertions(+)
> >>> create mode 100644 libavcodec/vc264.c
> >>> 
> >> [...]
> >>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> >>> index 2a25d66..3c7bd9b 100644
> >>> --- a/libavcodec/allcodecs.c
> >>> +++ b/libavcodec/allcodecs.c
> >>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
> >>>initialized = 1;
> >>> 
> >> 
> >> Nit: Whitespace on the line above should be removed.
> >> 
> >> [...]
> >>> --- /dev/null
> >>> +++ b/libavcodec/vc264.c
> >>> @@ -0,0 +1,387 @@
> >>> +/*  H.264 hardware assist video encoding code taken from
> >>> + * raspberry's os :
> >>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
> >>> + */
> >>> +
> >>> +/*
> >>> +Copyright (c) 2012, Broadcom Europe Ltd
> >>> +Copyright (c) 2012, Kalle Vahlman 
> >>> +Tuomas Kulve 
> >>> +All rights reserved.
> >>> +
> >>> +Redistribution and use in source and binary forms, with or without
> >>> +modification, are permitted provided that the following conditions are 
> >>> met:
> >>> +* Redistributions of source code must retain the above copyright
> >>> +  notice, this list of conditions and the following disclaimer.
> >>> +  * Redistributions in binary form must reproduce the above copyright
> >>> +  notice, this list of conditions and the following disclaimer in the
> >>> +  documentation and/or other materials provided with the 
> >>> distribution.
> >>> +  * Neither the name of the copyright holder nor the
> >>> +  names of its contributors may be used to endorse or promote 
> >>> products
> >>> +  derived from this software without specific prior written 
> >>> permission.
> >>> +
> >>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
> >>> IS" AND
> >>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
> >>> IMPLIED
> >>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> >>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
> >>> LIABLE FOR ANY
> >>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
> >>> DAMAGES
> >>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
> >>> SERVICES;
> >>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED 
> >>> AND
> >>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 
> >>> TORT
> >>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
> >>> THIS
> >>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >> 
> >> I wonder if any of the above legalese is compatible. Granted, I see a
> >> similar paragraph in "libavformat/aadec.c".
> >> 
> >>> + * ffmpeg driver for hardware assist video H.264 encoding using 
> >>> Broadcom's GPU
> >>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
> >>> + *
> >>> + *
> >>> + * This file is part of FFmpeg.
> >>> + *
> >>> + * FFmpeg is free software; you can redistribute it and/or
> >>> + * modify it under the terms of the GNU Lesser General Public
> >>> + * License as published by the Free Software Foundation; either
> >>> + * version 2.1 of the License, or (at your option) any later version.
> >>> + *
> >>> + * FFmpeg is distributed in the hope that it will be useful,
> >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> >>> + * Lesser General Public License for more details.
> >>> + *
> >>> + * You should have received a copy of the GNU Lesser General Public
> >>> + * License along with FFmpeg; if not, write to 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> 
> I am not a lawyer…
> 
> 
> I updated the patch.  vc264.c now has a the copyright notice embedded in 
> a volatile global so if a binary is compiled against vc264.o , the copyright 
> notice
> can be displayed by:
> strings ffmpeg | grep -i copyright
> 
> LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
> A distribution of a  binary that includes vc264.o should include LICENSE.md 
> and if 
> that is missing,  the copyright notice can be displayed via the shell
> command ‘strings’ .
> 
> Amancio
> 
>> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
>> 
>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>> 
>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>> From: Amancio Hasty 
>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>> the Raspberry Pi
>>> 
>>> ---
>>> configure  |  12 ++
>>> libavcodec/Makefile|   1 +
>>> libavcodec/allcodecs.c |   2 +
>>> libavcodec/vc264.c | 387 
>>> +
>>> 4 files changed, 402 insertions(+)
>>> create mode 100644 libavcodec/vc264.c
>>> 
>> [...]
>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>> index 2a25d66..3c7bd9b 100644
>>> --- a/libavcodec/allcodecs.c
>>> +++ b/libavcodec/allcodecs.c
>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>initialized = 1;
>>> 
>> 
>> Nit: Whitespace on the line above should be removed.
>> 
>> [...]
>>> --- /dev/null
>>> +++ b/libavcodec/vc264.c
>>> @@ -0,0 +1,387 @@
>>> +/*  H.264 hardware assist video encoding code taken from
>>> + * raspberry's os :
>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>> + */
>>> +
>>> +/*
>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>> +Copyright (c) 2012, Kalle Vahlman 
>>> +Tuomas Kulve 
>>> +All rights reserved.
>>> +
>>> +Redistribution and use in source and binary forms, with or without
>>> +modification, are permitted provided that the following conditions are met:
>>> +* Redistributions of source code must retain the above copyright
>>> +  notice, this list of conditions and the following disclaimer.
>>> +  * Redistributions in binary form must reproduce the above copyright
>>> +  notice, this list of conditions and the following disclaimer in the
>>> +  documentation and/or other materials provided with the distribution.
>>> +  * Neither the name of the copyright holder nor the
>>> +  names of its contributors may be used to endorse or promote products
>>> +  derived from this software without specific prior written permission.
>>> +
>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>> IS" AND
>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>> IMPLIED
>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>> LIABLE FOR ANY
>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>> SERVICES;
>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>> THIS
>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 
>> I wonder if any of the above legalese is compatible. Granted, I see a
>> similar paragraph in "libavformat/aadec.c".
>> 
>>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>>> GPU
>>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>>> + *
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.1 of the License, or (at your option) any later version.
>>> + *
>>> + * FFmpeg is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with FFmpeg; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
>>> 02110-1301 USA
>>> + *
>>> + */
>>> +
>>> +
>>> +/**
>>> + * @ file vc264.c
>>> + * Broadcom bm2865's Visual Core hardware assist h264 using
>>> +   openMax interface to the GPU.
>>> +
>>> +*/
>>> +
>>> +#include 
>>> +#include 
>>> +#include 
>>> +#define 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Apr 4, 2016, at 10:41 AM, wm4  wrote:
> 
> On Mon, 4 Apr 2016 10:08:56 -0700
> Amancio Hasty > wrote:
> 
>>> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
>>> 
>>> I am not a lawyer…
>>> 
>>> 
>>> I updated the patch.  vc264.c now has a the copyright notice embedded in 
>>> a volatile global so if a binary is compiled against vc264.o , the 
>>> copyright notice
>>> can be displayed by:
>>> strings ffmpeg | grep -i copyright
>>> 
>>> LICENSE.md has been updated to include Broadcom’s copyright notice.
>>> 
>>> A distribution of a  binary that includes vc264.o should include LICENSE.md 
>>> and if 
>>> that is missing,  the copyright notice can be displayed via the shell
>>> command ‘strings’ .
>>> 
>>> Amancio
>>>   
 On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
 
 On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
 
> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
> From: Amancio Hasty 
> Date: Mon, 21 Mar 2016 18:56:05 -0700
> Subject: [PATCH] added support for hardware assist H264  video encoding 
> for
> the Raspberry Pi
> 
> ---
> configure  |  12 ++
> libavcodec/Makefile|   1 +
> libavcodec/allcodecs.c |   2 +
> libavcodec/vc264.c | 387 
> +
> 4 files changed, 402 insertions(+)
> create mode 100644 libavcodec/vc264.c
> 
 [...]  
> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> index 2a25d66..3c7bd9b 100644
> --- a/libavcodec/allcodecs.c
> +++ b/libavcodec/allcodecs.c
> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>   initialized = 1;
> 
 
 Nit: Whitespace on the line above should be removed.
 
 [...]  
> --- /dev/null
> +++ b/libavcodec/vc264.c
> @@ -0,0 +1,387 @@
> +/*  H.264 hardware assist video encoding code taken from
> + * raspberry's os :
> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
> + */
> +
> +/*
> +Copyright (c) 2012, Broadcom Europe Ltd
> +Copyright (c) 2012, Kalle Vahlman 
> +Tuomas Kulve 
> +All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are 
> met:
> +* Redistributions of source code must retain the above copyright
> +  notice, this list of conditions and the following disclaimer.
> +  * Redistributions in binary form must reproduce the above copyright
> +  notice, this list of conditions and the following disclaimer in the
> +  documentation and/or other materials provided with the 
> distribution.
> +  * Neither the name of the copyright holder nor the
> +  names of its contributors may be used to endorse or promote 
> products
> +  derived from this software without specific prior written 
> permission.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
> IS" AND
> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
> IMPLIED
> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
> LIABLE FOR ANY
> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
> DAMAGES
> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
> SERVICES;
> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED 
> AND
> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 
> TORT
> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
> THIS
> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  
 
 I wonder if any of the above legalese is compatible. Granted, I see a
 similar paragraph in "libavformat/aadec.c".
 
> + * ffmpeg driver for hardware assist video H.264 encoding using 
> Broadcom's GPU
> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
> + *
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[wm4]

On Mon, 4 Apr 2016 10:08:56 -0700
Amancio Hasty  wrote:

> > On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> > 
> > I am not a lawyer…
> > 
> > 
> > I updated the patch.  vc264.c now has a the copyright notice embedded in 
> > a volatile global so if a binary is compiled against vc264.o , the 
> > copyright notice
> > can be displayed by:
> > strings ffmpeg | grep -i copyright
> > 
> > LICENSE.md has been updated to include Broadcom’s copyright notice.
> > 
> > A distribution of a  binary that includes vc264.o should include LICENSE.md 
> > and if 
> > that is missing,  the copyright notice can be displayed via the shell
> > command ‘strings’ .
> > 
> > Amancio
> >   
> >> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> >> 
> >> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> >>   
> >>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
> >>> From: Amancio Hasty 
> >>> Date: Mon, 21 Mar 2016 18:56:05 -0700
> >>> Subject: [PATCH] added support for hardware assist H264  video encoding 
> >>> for
> >>> the Raspberry Pi
> >>> 
> >>> ---
> >>> configure  |  12 ++
> >>> libavcodec/Makefile|   1 +
> >>> libavcodec/allcodecs.c |   2 +
> >>> libavcodec/vc264.c | 387 
> >>> +
> >>> 4 files changed, 402 insertions(+)
> >>> create mode 100644 libavcodec/vc264.c
> >>>   
> >> [...]  
> >>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> >>> index 2a25d66..3c7bd9b 100644
> >>> --- a/libavcodec/allcodecs.c
> >>> +++ b/libavcodec/allcodecs.c
> >>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
> >>>initialized = 1;
> >>>   
> >> 
> >> Nit: Whitespace on the line above should be removed.
> >> 
> >> [...]  
> >>> --- /dev/null
> >>> +++ b/libavcodec/vc264.c
> >>> @@ -0,0 +1,387 @@
> >>> +/*  H.264 hardware assist video encoding code taken from
> >>> + * raspberry's os :
> >>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
> >>> + */
> >>> +
> >>> +/*
> >>> +Copyright (c) 2012, Broadcom Europe Ltd
> >>> +Copyright (c) 2012, Kalle Vahlman 
> >>> +Tuomas Kulve 
> >>> +All rights reserved.
> >>> +
> >>> +Redistribution and use in source and binary forms, with or without
> >>> +modification, are permitted provided that the following conditions are 
> >>> met:
> >>> +* Redistributions of source code must retain the above copyright
> >>> +  notice, this list of conditions and the following disclaimer.
> >>> +  * Redistributions in binary form must reproduce the above copyright
> >>> +  notice, this list of conditions and the following disclaimer in the
> >>> +  documentation and/or other materials provided with the 
> >>> distribution.
> >>> +  * Neither the name of the copyright holder nor the
> >>> +  names of its contributors may be used to endorse or promote 
> >>> products
> >>> +  derived from this software without specific prior written 
> >>> permission.
> >>> +
> >>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
> >>> IS" AND
> >>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
> >>> IMPLIED
> >>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> >>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
> >>> LIABLE FOR ANY
> >>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
> >>> DAMAGES
> >>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
> >>> SERVICES;
> >>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED 
> >>> AND
> >>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 
> >>> TORT
> >>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
> >>> THIS
> >>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.  
> >> 
> >> I wonder if any of the above legalese is compatible. Granted, I see a
> >> similar paragraph in "libavformat/aadec.c".
> >>   
> >>> + * ffmpeg driver for hardware assist video H.264 encoding using 
> >>> Broadcom's GPU
> >>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
> >>> + *
> >>> + *
> >>> + * This file is part of FFmpeg.
> >>> + *
> >>> + * FFmpeg is free software; you can redistribute it and/or
> >>> + * modify it under the terms of the GNU Lesser General Public
> >>> + * License as published by the Free Software Foundation; either
> >>> + * version 2.1 of the License, or (at your option) any later version.
> >>> + *
> >>> + * FFmpeg is distributed in the hope that it will be useful,
> >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> >>> + * Lesser General Public License for more details.
> >>> + *
> >>> + * You should have received a copy of the GNU Lesser General Public
> >>> + * License along with 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 31, 2016, at 7:27 PM, Amancio Hasty  wrote:
> 
> I am not a lawyer…
> 
> 
> I updated the patch.  vc264.c now has a the copyright notice embedded in 
> a volatile global so if a binary is compiled against vc264.o , the copyright 
> notice
> can be displayed by:
> strings ffmpeg | grep -i copyright
> 
> LICENSE.md has been updated to include Broadcom’s copyright notice.
> 
> A distribution of a  binary that includes vc264.o should include LICENSE.md 
> and if 
> that is missing,  the copyright notice can be displayed via the shell
> command ‘strings’ .
> 
> Amancio
> 
>> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
>> 
>> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
>> 
>>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>>> From: Amancio Hasty 
>>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>>> the Raspberry Pi
>>> 
>>> ---
>>> configure  |  12 ++
>>> libavcodec/Makefile|   1 +
>>> libavcodec/allcodecs.c |   2 +
>>> libavcodec/vc264.c | 387 
>>> +
>>> 4 files changed, 402 insertions(+)
>>> create mode 100644 libavcodec/vc264.c
>>> 
>> [...]
>>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>>> index 2a25d66..3c7bd9b 100644
>>> --- a/libavcodec/allcodecs.c
>>> +++ b/libavcodec/allcodecs.c
>>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>>>initialized = 1;
>>> 
>> 
>> Nit: Whitespace on the line above should be removed.
>> 
>> [...]
>>> --- /dev/null
>>> +++ b/libavcodec/vc264.c
>>> @@ -0,0 +1,387 @@
>>> +/*  H.264 hardware assist video encoding code taken from
>>> + * raspberry's os :
>>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>>> + */
>>> +
>>> +/*
>>> +Copyright (c) 2012, Broadcom Europe Ltd
>>> +Copyright (c) 2012, Kalle Vahlman 
>>> +Tuomas Kulve 
>>> +All rights reserved.
>>> +
>>> +Redistribution and use in source and binary forms, with or without
>>> +modification, are permitted provided that the following conditions are met:
>>> +* Redistributions of source code must retain the above copyright
>>> +  notice, this list of conditions and the following disclaimer.
>>> +  * Redistributions in binary form must reproduce the above copyright
>>> +  notice, this list of conditions and the following disclaimer in the
>>> +  documentation and/or other materials provided with the distribution.
>>> +  * Neither the name of the copyright holder nor the
>>> +  names of its contributors may be used to endorse or promote products
>>> +  derived from this software without specific prior written permission.
>>> +
>>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
>>> IS" AND
>>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>>> IMPLIED
>>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>>> LIABLE FOR ANY
>>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
>>> SERVICES;
>>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>>> THIS
>>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> 
>> I wonder if any of the above legalese is compatible. Granted, I see a
>> similar paragraph in "libavformat/aadec.c".
>> 
>>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>>> GPU
>>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>>> + *
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.1 of the License, or (at your option) any later version.
>>> + *
>>> + * FFmpeg is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with FFmpeg; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
>>> 02110-1301 USA
>>> + *
>>> + */
>>> +
>>> +
>>> +/**
>>> + * @ file vc264.c
>>> + * Broadcom bm2865's Visual Core hardware assist h264 using
>>> +   openMax interface to the GPU.
>>> +
>>> +*/
>>> +
>>> +#include 
>>> +#include 
>>> +#include 
>>> +#define 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

I am not a lawyer…


I updated the patch.  vc264.c now has a the copyright notice embedded in 
a volatile global so if a binary is compiled against vc264.o , the copyright 
notice
can be displayed by:
strings ffmpeg | grep -i copyright

LICENSE.md has been updated to include Broadcom’s copyright notice.

A distribution of a  binary that includes vc264.o should include LICENSE.md and 
if 
that is missing,  the copyright notice can be displayed via the shell
command ‘strings’ .

Amancio


c-0001-added-support-for-hardware-assist-H264-video-encodin.patch
Description: Binary data

> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> 
> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> 
>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>> From: Amancio Hasty 
>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>> the Raspberry Pi
>> 
>> ---
>> configure  |  12 ++
>> libavcodec/Makefile|   1 +
>> libavcodec/allcodecs.c |   2 +
>> libavcodec/vc264.c | 387 
>> +
>> 4 files changed, 402 insertions(+)
>> create mode 100644 libavcodec/vc264.c
>> 
> [...]
>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>> index 2a25d66..3c7bd9b 100644
>> --- a/libavcodec/allcodecs.c
>> +++ b/libavcodec/allcodecs.c
>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>> initialized = 1;
>> 
> 
> Nit: Whitespace on the line above should be removed.
> 
> [...]
>> --- /dev/null
>> +++ b/libavcodec/vc264.c
>> @@ -0,0 +1,387 @@
>> +/*  H.264 hardware assist video encoding code taken from
>> + * raspberry's os :
>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>> + */
>> +
>> +/*
>> +Copyright (c) 2012, Broadcom Europe Ltd
>> +Copyright (c) 2012, Kalle Vahlman 
>> +Tuomas Kulve 
>> +All rights reserved.
>> +
>> +Redistribution and use in source and binary forms, with or without
>> +modification, are permitted provided that the following conditions are met:
>> +* Redistributions of source code must retain the above copyright
>> +  notice, this list of conditions and the following disclaimer.
>> +  * Redistributions in binary form must reproduce the above copyright
>> +  notice, this list of conditions and the following disclaimer in the
>> +  documentation and/or other materials provided with the distribution.
>> +  * Neither the name of the copyright holder nor the
>> +  names of its contributors may be used to endorse or promote products
>> +  derived from this software without specific prior written permission.
>> +
>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
>> AND
>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>> IMPLIED
>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>> LIABLE FOR ANY
>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>> THIS
>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> I wonder if any of the above legalese is compatible. Granted, I see a
> similar paragraph in "libavformat/aadec.c".
> 
>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>> GPU
>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>> + *
>> + *
>> + * This file is part of FFmpeg.
>> + *
>> + * FFmpeg is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU Lesser General Public
>> + * License as published by the Free Software Foundation; either
>> + * version 2.1 of the License, or (at your option) any later version.
>> + *
>> + * FFmpeg is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * Lesser General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU Lesser General Public
>> + * License along with FFmpeg; if not, write to the Free Software
>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
>> USA
>> + *
>> + */
>> +
>> +
>> +/**
>> + * @ file vc264.c
>> + * Broadcom bm2865's Visual Core hardware assist h264 using
>> +   openMax interface to the GPU.
>> +
>> +*/
>> +
>> +#include 
>> +#include 
>> +#include 
>> +#define OMX_SKIP64BIT
>> +#include "bcm_host.h"
>> +#include "ilclient.h"
>> +#include "avcodec.h"
>> +#include "internal.h"
>> +
>> +typedef 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 23, 2016, at 8:17 AM, Michael Niedermayer  
> wrote:
> 
> On Tue, Mar 22, 2016 at 06:40:27PM -0700, Amancio Hasty wrote:
> [...]
> 
>> +static int vc264_init(AVCodecContext *avctx) {
>> +
>> +
>> +
>> +   OMX_ERRORTYPE r;
>> +   int error;
>> +
>> +
>> +
>> +   VC264Context *vc = avctx->priv_data;
>> +
>> +   vc->width = avctx->width;
>> +   vc->height = avctx->height;
>> +   vc->bit_rate = avctx->bit_rate;
>> +#if FF_API_CODED_FRAME
>> +FF_DISABLE_DEPRECATION_WARNINGS
>> +
>> +   avctx->coded_frame = av_frame_alloc();
>> +   avctx->coded_frame->pict_type = AV_PICTURE_TYPE_I;
>> +FF_ENABLE_DEPRECATION_WARNINGS
>> +#endif
>> +
>> +
>> +   memset(>list, 0, sizeof(vc->list));
>> +   bcm_host_init();
>> +   if ((vc->client = ilclient_init()) == NULL) {
>> +  return -3;
>> +   }
>> +   error = OMX_Init();
>> +
>> +   if (error  != OMX_ErrorNone) {
>> +  ilclient_destroy(vc->client);
>> +  av_log(avctx,AV_LOG_ERROR,"in vc264_init OMX_Init failed ");
>> + return -4;
>> +}
>> +
>> +   // create video_encode
>> +   r = ilclient_create_component(vc->client, >video_encode, (char *) 
>> "video_encode",
>> + ILCLIENT_DISABLE_ALL_PORTS |
>> + ILCLIENT_ENABLE_INPUT_BUFFERS |
>> + ILCLIENT_ENABLE_OUTPUT_BUFFERS);
>> +
>> +   if (r != 0) {
>> +av_log(avctx,AV_LOG_ERROR,"ilclient_create_component() for 
>> video_encode failed with %x!",
>> +  r);
> 
>> +  exit(1);
> 
> a library cannot call exit()
> 
> also indention looks rather odd and random
> 
> [...]
> 
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle 


Fixed the indentation and style by running :
indent -i4 -kr -nut vc264.c

fixed the error return values and the exit calls.

Amancio



b-0001-added-support-for-hardware-assist-H264-video-encodin.patch
Description: Binary data


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Ronald S. Bultje]

Hi,

On Wed, Mar 23, 2016 at 11:41 AM, Amancio Hasty  wrote:

> Is there a pretty formatter for ffmpeg’s coding style and
> coding style guideline?


https://ffmpeg.org/developer.html#Coding-Rules-1

Please don't top-post.

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

Is there a pretty formatter for ffmpeg’s coding style and
coding style guideline?

Amancio


> On Mar 23, 2016, at 8:17 AM, Michael Niedermayer  
> wrote:
> 
> On Tue, Mar 22, 2016 at 06:40:27PM -0700, Amancio Hasty wrote:
> [...]
> 
>> +static int vc264_init(AVCodecContext *avctx) {
>> +
>> +
>> +
>> +   OMX_ERRORTYPE r;
>> +   int error;
>> +
>> +
>> +
>> +   VC264Context *vc = avctx->priv_data;
>> +
>> +   vc->width = avctx->width;
>> +   vc->height = avctx->height;
>> +   vc->bit_rate = avctx->bit_rate;
>> +#if FF_API_CODED_FRAME
>> +FF_DISABLE_DEPRECATION_WARNINGS
>> +
>> +   avctx->coded_frame = av_frame_alloc();
>> +   avctx->coded_frame->pict_type = AV_PICTURE_TYPE_I;
>> +FF_ENABLE_DEPRECATION_WARNINGS
>> +#endif
>> +
>> +
>> +   memset(>list, 0, sizeof(vc->list));
>> +   bcm_host_init();
>> +   if ((vc->client = ilclient_init()) == NULL) {
>> +  return -3;
>> +   }
>> +   error = OMX_Init();
>> +
>> +   if (error  != OMX_ErrorNone) {
>> +  ilclient_destroy(vc->client);
>> +  av_log(avctx,AV_LOG_ERROR,"in vc264_init OMX_Init failed ");
>> + return -4;
>> +}
>> +
>> +   // create video_encode
>> +   r = ilclient_create_component(vc->client, >video_encode, (char *) 
>> "video_encode",
>> + ILCLIENT_DISABLE_ALL_PORTS |
>> + ILCLIENT_ENABLE_INPUT_BUFFERS |
>> + ILCLIENT_ENABLE_OUTPUT_BUFFERS);
>> +
>> +   if (r != 0) {
>> +av_log(avctx,AV_LOG_ERROR,"ilclient_create_component() for 
>> video_encode failed with %x!",
>> +  r);
> 
>> +  exit(1);
> 
> a library cannot call exit()
> 
> also indention looks rather odd and random
> 
> [...]
> 
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Michael Niedermayer]

On Tue, Mar 22, 2016 at 06:40:27PM -0700, Amancio Hasty wrote:
[...]

> +static int vc264_init(AVCodecContext *avctx) {
> +
> +
> +
> +   OMX_ERRORTYPE r;
> +   int error;
> +
> +
> +
> +   VC264Context *vc = avctx->priv_data;
> +
> +   vc->width = avctx->width;
> +   vc->height = avctx->height;
> +   vc->bit_rate = avctx->bit_rate;
> +#if FF_API_CODED_FRAME
> +FF_DISABLE_DEPRECATION_WARNINGS
> +
> +   avctx->coded_frame = av_frame_alloc();
> +   avctx->coded_frame->pict_type = AV_PICTURE_TYPE_I;
> +FF_ENABLE_DEPRECATION_WARNINGS
> +#endif
> +
> +
> +   memset(>list, 0, sizeof(vc->list));
> +   bcm_host_init();
> +   if ((vc->client = ilclient_init()) == NULL) {
> +  return -3;
> +   }
> +   error = OMX_Init();
> +
> +   if (error  != OMX_ErrorNone) {
> +  ilclient_destroy(vc->client);
> +  av_log(avctx,AV_LOG_ERROR,"in vc264_init OMX_Init failed ");
> + return -4;
> +}
> +
> +   // create video_encode
> +   r = ilclient_create_component(vc->client, >video_encode, (char *) 
> "video_encode",
> + ILCLIENT_DISABLE_ALL_PORTS |
> + ILCLIENT_ENABLE_INPUT_BUFFERS |
> + ILCLIENT_ENABLE_OUTPUT_BUFFERS);
> +
> +   if (r != 0) {
> +av_log(avctx,AV_LOG_ERROR,"ilclient_create_component() for 
> video_encode failed with %x!",
> +  r);

> +  exit(1);

a library cannot call exit()

also indention looks rather odd and random

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 22, 2016, at 12:12 PM, Lou Logan  wrote:
> 
> On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:
> 
>> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
>> From: Amancio Hasty 
>> Date: Mon, 21 Mar 2016 18:56:05 -0700
>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>> the Raspberry Pi
>> 
>> ---
>> configure  |  12 ++
>> libavcodec/Makefile|   1 +
>> libavcodec/allcodecs.c |   2 +
>> libavcodec/vc264.c | 387 
>> +
>> 4 files changed, 402 insertions(+)
>> create mode 100644 libavcodec/vc264.c
>> 
> [...]
>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
>> index 2a25d66..3c7bd9b 100644
>> --- a/libavcodec/allcodecs.c
>> +++ b/libavcodec/allcodecs.c
>> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>> initialized = 1;
>> 
> 
> Nit: Whitespace on the line above should be removed.
> 
> [...]
>> --- /dev/null
>> +++ b/libavcodec/vc264.c
>> @@ -0,0 +1,387 @@
>> +/*  H.264 hardware assist video encoding code taken from
>> + * raspberry's os :
>> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
>> + */
>> +
>> +/*
>> +Copyright (c) 2012, Broadcom Europe Ltd
>> +Copyright (c) 2012, Kalle Vahlman 
>> +Tuomas Kulve 
>> +All rights reserved.
>> +
>> +Redistribution and use in source and binary forms, with or without
>> +modification, are permitted provided that the following conditions are met:
>> +* Redistributions of source code must retain the above copyright
>> +  notice, this list of conditions and the following disclaimer.
>> +  * Redistributions in binary form must reproduce the above copyright
>> +  notice, this list of conditions and the following disclaimer in the
>> +  documentation and/or other materials provided with the distribution.
>> +  * Neither the name of the copyright holder nor the
>> +  names of its contributors may be used to endorse or promote products
>> +  derived from this software without specific prior written permission.
>> +
>> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
>> AND
>> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
>> IMPLIED
>> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
>> LIABLE FOR ANY
>> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
>> THIS
>> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> I wonder if any of the above legalese is compatible. Granted, I see a
> similar paragraph in "libavformat/aadec.c".
> 
>> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
>> GPU
>> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
>> + *
>> + *
>> + * This file is part of FFmpeg.
>> + *
>> + * FFmpeg is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU Lesser General Public
>> + * License as published by the Free Software Foundation; either
>> + * version 2.1 of the License, or (at your option) any later version.
>> + *
>> + * FFmpeg is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * Lesser General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU Lesser General Public
>> + * License along with FFmpeg; if not, write to the Free Software
>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
>> USA
>> + *
>> + */
>> +
>> +
>> +/**
>> + * @ file vc264.c
>> + * Broadcom bm2865's Visual Core hardware assist h264 using
>> +   openMax interface to the GPU.
>> +
>> +*/
>> +
>> +#include 
>> +#include 
>> +#include 
>> +#define OMX_SKIP64BIT
>> +#include "bcm_host.h"
>> +#include "ilclient.h"
>> +#include "avcodec.h"
>> +#include "internal.h"
>> +
>> +typedef struct VC264Context {
>> +  OMX_VIDEO_PARAM_PORTFORMATTYPE format;
>> +  OMX_PARAM_PORTDEFINITIONTYPE def;
>> +  COMPONENT_T *video_encode;
>> +  COMPONENT_T *list[5];
>> +  OMX_BUFFERHEADERTYPE *buf;
>> +  OMX_BUFFERHEADERTYPE *out;
>> +  ILCLIENT_T *client;
>> +  OMX_VIDEO_PARAM_BITRATETYPE bitrateType;
>> +  int  width;
>> +  int height;
>> +  int bit_rate;
>> +} VC264Context;
>> +
>> +
>> +static int vc264_init(AVCodecContext *avctx) {
>> +
>> +
>> +
>> +   OMX_ERRORTYPE r;
>> +   int error;
>> +
>> +
>> +
>> +   VC264Context *vc = avctx->priv_data;
>> +
>> +   vc->width 

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Moritz Barsnick]

On Tue, Mar 22, 2016 at 11:12:18 -0800, Lou Logan wrote:
> > +* Redistributions of source code must retain the above copyright
> > +  notice, this list of conditions and the following disclaimer.
> > +  * Redistributions in binary form must reproduce the above copyright
> > +  notice, this list of conditions and the following disclaimer in the
> > +  documentation and/or other materials provided with the distribution.
> > +  * Neither the name of the copyright holder nor the
> > +  names of its contributors may be used to endorse or promote products
> > +  derived from this software without specific prior written permission.
> 
> I wonder if any of the above legalese is compatible. Granted, I see a
> similar paragraph in "libavformat/aadec.c".

IANAL, but the big difference is that aadec.c only requires replication
of the notice in source code, while this license demands the notice be
distributed in binary packages. I don't know whether - from ffmpeg
source i.e. developer view - it suffices to drop this into LICENSE.md,
or it needs to be marked as unfree because this cannot be ensured.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Lou Logan]

On Mon, 21 Mar 2016 20:07:01 -0700, Amancio Hasty wrote:

> From 874a72eec2a78f4935fea091003e534b5f8d5413 Mon Sep 17 00:00:00 2001
> From: Amancio Hasty 
> Date: Mon, 21 Mar 2016 18:56:05 -0700
> Subject: [PATCH] added support for hardware assist H264  video encoding for
>  the Raspberry Pi
> 
> ---
>  configure  |  12 ++
>  libavcodec/Makefile|   1 +
>  libavcodec/allcodecs.c |   2 +
>  libavcodec/vc264.c | 387 
> +
>  4 files changed, 402 insertions(+)
>  create mode 100644 libavcodec/vc264.c
> 
[...]
> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> index 2a25d66..3c7bd9b 100644
> --- a/libavcodec/allcodecs.c
> +++ b/libavcodec/allcodecs.c
> @@ -74,6 +74,7 @@ void avcodec_register_all(void)
>  initialized = 1;
>  

Nit: Whitespace on the line above should be removed.

[...]
> --- /dev/null
> +++ b/libavcodec/vc264.c
> @@ -0,0 +1,387 @@
> +/*  H.264 hardware assist video encoding code taken from
> + * raspberry's os :
> + *   /opt/vc/src/hello_pi/hello_encode/encode.c
> + */
> +
> +/*
> +Copyright (c) 2012, Broadcom Europe Ltd
> +Copyright (c) 2012, Kalle Vahlman 
> +Tuomas Kulve 
> +All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are met:
> +* Redistributions of source code must retain the above copyright
> +  notice, this list of conditions and the following disclaimer.
> +  * Redistributions in binary form must reproduce the above copyright
> +  notice, this list of conditions and the following disclaimer in the
> +  documentation and/or other materials provided with the distribution.
> +  * Neither the name of the copyright holder nor the
> +  names of its contributors may be used to endorse or promote products
> +  derived from this software without specific prior written permission.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
> AND
> +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
> +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE 
> FOR ANY
> +DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> +(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> +ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> +SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

I wonder if any of the above legalese is compatible. Granted, I see a
similar paragraph in "libavformat/aadec.c".

> + * ffmpeg driver for hardware assist video H.264 encoding using Broadcom's 
> GPU
> + * Copyright (C) 2016 Amancio Hasty aha...@gmail.com
> + *
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
> USA
> + *
> + */
> +
> +
> +/**
> + * @ file vc264.c
> + * Broadcom bm2865's Visual Core hardware assist h264 using
> +   openMax interface to the GPU.
> +
> +*/
> +
> +#include 
> +#include 
> +#include 
> +#define OMX_SKIP64BIT
> +#include "bcm_host.h"
> +#include "ilclient.h"
> +#include "avcodec.h"
> +#include "internal.h"
> +
> +typedef struct VC264Context {
> +  OMX_VIDEO_PARAM_PORTFORMATTYPE format;
> +  OMX_PARAM_PORTDEFINITIONTYPE def;
> +  COMPONENT_T *video_encode;
> +  COMPONENT_T *list[5];
> +  OMX_BUFFERHEADERTYPE *buf;
> +  OMX_BUFFERHEADERTYPE *out;
> +  ILCLIENT_T *client;
> +  OMX_VIDEO_PARAM_BITRATETYPE bitrateType;
> +  int  width;
> +  int height;
> +  int bit_rate;
> +} VC264Context;
> +
> +
> +static int vc264_init(AVCodecContext *avctx) {
> +
> +
> +
> +   OMX_ERRORTYPE r;
> +   int error;
> +
> +
> +
> +   VC264Context *vc = avctx->priv_data;
> +
> +   vc->width = avctx->width;
> +   vc->height = avctx->height;
> +   vc->bit_rate = avctx->bit_rate;
> +   printf("vc264: bit rate %d \n", avctx->bit_rate);
> +#if FF_API_CODED_FRAME
> +FF_DISABLE_DEPRECATION_WARNINGS
> +
> +   

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

> On Mar 18, 2016, at 12:20 PM, Lou Logan  wrote:
> 
> On Fri, 18 Mar 2016 12:12:24 -0700, Amancio Hasty wrote:
> 
>> The patch was against:
>> 2016-02-26-raspbian-jessie.img
>> 
>> In my Raspberry Pi  system:
>> /opt/vc/include/bcm_host.h
>> 
>> in ffmpeg/configure:
>> if enabled vc264_encoder &&  [ -n "$target_os_default"="linux" ] ; then
>>add_cflags ' -I/opt/vc/include/… 
> 
> I should have mentioned that I tested your patch on Linux x86_64 to
> show that it fails on systems without this "bcm_host.h" file.
> 
> Please avoid top-posting on this mailing list.

I tested the patch on Raspberry PI, Mac OS and Ubuntu running under vmware so
it does not cause any compilation errors .

Amancio


0001-added-support-for-hardware-assist-H264-video-encodin.patch
Description: Binary data




___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Lou Logan]

On Fri, 18 Mar 2016 12:12:24 -0700, Amancio Hasty wrote:

> The patch was against:
> 2016-02-26-raspbian-jessie.img
> 
> In my Raspberry Pi  system:
> /opt/vc/include/bcm_host.h
> 
> in ffmpeg/configure:
>  if enabled vc264_encoder &&  [ -n "$target_os_default"="linux" ] ; then
> add_cflags ' -I/opt/vc/include/… 

I should have mentioned that I tested your patch on Linux x86_64 to
show that it fails on systems without this "bcm_host.h" file.

Please avoid top-posting on this mailing list.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Lou Logan]

On Fri, 18 Mar 2016 11:13:58 -0700, Amancio Hasty wrote:

> From be5f142f820e05b411bfdc95719e0ab6388bcbe5 Mon Sep 17 00:00:00 2001
> From: Amancio Hasty 
> Date: Fri, 18 Mar 2016 10:00:14 -0700
> Subject: [PATCH] added support for hardware assist H264  video encoding for
>  the Raspberry Pi
> 
> ---
>  configure  |   4 +
>  libavcodec/Makefile|   1 +
>  libavcodec/allcodecs.c |   1 +
>  libavcodec/vc264.c | 387 
> +
>  4 files changed, 393 insertions(+)
>  create mode 100644 libavcodec/vc264.c

Tabs and trailing whitespaces should be avoided.

Fails to compile:

libavcodec/vc264.c:70:22: fatal error: bcm_host.h: No such file or
directory compilation terminated.
common.mak:60: recipe for target 'libavcodec/vc264.o' failed
make: *** [libavcodec/vc264.o] Error 1
make: *** Waiting for unfinished jobs
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

I wrote this driver a while ago before the mmal decoding was submitted…

Amancio


> On Mar 18, 2016, at 11:57 AM, wm4  wrote:
> 
> On Fri, 18 Mar 2016 11:13:58 -0700
> Amancio Hasty  wrote:
> 
>> Amancio Hasty
>> 
> 
> It seems a bit strange that decoding now uses MMAL, and encoding OMX?
> 
> Probably also precludes transcoding without copying.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

0001-added-support-for-hardware-assist-H264-video-encodin.patch
Description: Binary data


Amancio Hasty

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[wm4]

On Fri, 18 Mar 2016 11:13:58 -0700
Amancio Hasty  wrote:

> Amancio Hasty
> 

It seems a bit strange that decoding now uses MMAL, and encoding OMX?

Probably also precludes transcoding without copying.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

[Amancio Hasty]

The patch was against:
2016-02-26-raspbian-jessie.img

In my Raspberry Pi  system:
/opt/vc/include/bcm_host.h

in ffmpeg/configure:
 if enabled vc264_encoder &&  [ -n "$target_os_default"="linux" ] ; then
add_cflags ' -I/opt/vc/include/… 
———

Amancio


> On Mar 18, 2016, at 11:50 AM, Lou Logan  wrote:
> 
> On Fri, 18 Mar 2016 11:13:58 -0700, Amancio Hasty wrote:
> 
>> From be5f142f820e05b411bfdc95719e0ab6388bcbe5 Mon Sep 17 00:00:00 2001
>> From: Amancio Hasty 
>> Date: Fri, 18 Mar 2016 10:00:14 -0700
>> Subject: [PATCH] added support for hardware assist H264  video encoding for
>> the Raspberry Pi
>> 
>> ---
>> configure  |   4 +
>> libavcodec/Makefile|   1 +
>> libavcodec/allcodecs.c |   1 +
>> libavcodec/vc264.c | 387 
>> +
>> 4 files changed, 393 insertions(+)
>> create mode 100644 libavcodec/vc264.c
> 
> Tabs and trailing whitespaces should be avoided.
> 
> Fails to compile:
> 
> libavcodec/vc264.c:70:22: fatal error: bcm_host.h: No such file or
> directory compilation terminated.
> common.mak:60: recipe for target 'libavcodec/vc264.o' failed
> make: *** [libavcodec/vc264.o] Error 1
> make: *** Waiting for unfinished jobs

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel