Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

2015-11-14 Thread Ganesh Ajjanagadde
On Fri, Nov 13, 2015 at 11:43 AM, Ganesh Ajjanagadde wrote: > On Wed, Nov 11, 2015 at 6:53 AM, Michael Niedermayer > wrote: >> On Tue, Nov 10, 2015 at 10:35:23PM -0500, Ganesh Ajjanagadde wrote: >>> This uses M_SQRT2, M_PI, and M_E instead of the actual

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

2015-11-13 Thread Ganesh Ajjanagadde
On Wed, Nov 11, 2015 at 6:53 AM, Michael Niedermayer wrote: > On Tue, Nov 10, 2015 at 10:35:23PM -0500, Ganesh Ajjanagadde wrote: >> This uses M_SQRT2, M_PI, and M_E instead of the actual literals. >> Benefits include: >> 1. Reduced scope for copy/paste errors and improved

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

2015-11-11 Thread Paul B Mahol
On 11/11/15, Ganesh Ajjanagadde wrote: > This uses M_SQRT2, M_PI, and M_E instead of the actual literals. > Benefits include: > 1. Reduced scope for copy/paste errors and improved readability. > 2. Consistency across the codebase. > 3. Actually fixes an incorrect sqrt(2)

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

2015-11-11 Thread Ganesh Ajjanagadde
On Wed, Nov 11, 2015 at 3:28 AM, Paul B Mahol wrote: > On 11/11/15, Ganesh Ajjanagadde wrote: >> This uses M_SQRT2, M_PI, and M_E instead of the actual literals. >> Benefits include: >> 1. Reduced scope for copy/paste errors and improved readability. >>

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

2015-11-11 Thread Clément Bœsch
On Tue, Nov 10, 2015 at 10:35:23PM -0500, Ganesh Ajjanagadde wrote: > This uses M_SQRT2, M_PI, and M_E instead of the actual literals. > Benefits include: > 1. Reduced scope for copy/paste errors and improved readability. > 2. Consistency across the codebase. > 3. Actually fixes an incorrect

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

2015-11-11 Thread Ganesh Ajjanagadde
On Wed, Nov 11, 2015 at 10:21 AM, Clément Bœsch wrote: > On Tue, Nov 10, 2015 at 10:35:23PM -0500, Ganesh Ajjanagadde wrote: >> This uses M_SQRT2, M_PI, and M_E instead of the actual literals. >> Benefits include: >> 1. Reduced scope for copy/paste errors and improved readability. >>

Re: [FFmpeg-devel] [PATCH] all: use predefined mathematics macros

2015-11-11 Thread Michael Niedermayer
On Tue, Nov 10, 2015 at 10:35:23PM -0500, Ganesh Ajjanagadde wrote: > This uses M_SQRT2, M_PI, and M_E instead of the actual literals. > Benefits include: > 1. Reduced scope for copy/paste errors and improved readability. > 2. Consistency across the codebase. > 3. Actually fixes an incorrect

[FFmpeg-devel] [PATCH] all: use predefined mathematics macros

2015-11-10 Thread Ganesh Ajjanagadde
This uses M_SQRT2, M_PI, and M_E instead of the actual literals. Benefits include: 1. Reduced scope for copy/paste errors and improved readability. 2. Consistency across the codebase. 3. Actually fixes an incorrect sqrt(2) in avcodec/ppc. 4. Greater precision in avcodec/ac3. Patch tested with