Re: [FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 8:18 PM, Thilo Borgmann wrote: > I'm quite sure that changing the number of channels is invalid for ALS > so there is no sense in implementing it. Ah, OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

Re: [FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Andreas Cadhalpun
On 04.01.2016 21:18, Thilo Borgmann wrote: > Am 04.01.16 um 18:31 schrieb Derek Buitenhuis: >> On 1/4/2016 3:18 PM, Andreas Cadhalpun wrote: >>> Supporting this would require re-initialization to change buffer sizes. >> >> I may be mistaken, but don't we already support some codecs which do >> this

Re: [FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Thilo Borgmann
Am 04.01.16 um 18:31 schrieb Derek Buitenhuis: > On 1/4/2016 3:18 PM, Andreas Cadhalpun wrote: >> Supporting this would require re-initialization to change buffer sizes. > > I may be mistaken, but don't we already support some codecs which do > this, properly? I'm quite sure that changing the num

Re: [FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Andreas Cadhalpun
On 04.01.2016 16:29, Thilo Borgmann wrote: > Am 04.01.16 um 16:18 schrieb Andreas Cadhalpun: >> Supporting this would require re-initialization to change buffer sizes. >> >> This fixes out of bounds reads. > > Can you upload a sample for this? Unfortunately (or fortunately?) the sample doesn't tr

Re: [FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 3:18 PM, Andreas Cadhalpun wrote: > Supporting this would require re-initialization to change buffer sizes. I may be mistaken, but don't we already support some codecs which do this, properly? - Derek ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Thilo Borgmann
Am 04.01.16 um 16:18 schrieb Andreas Cadhalpun: > Supporting this would require re-initialization to change buffer sizes. > > This fixes out of bounds reads. Can you upload a sample for this? -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

[FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Andreas Cadhalpun
Supporting this would require re-initialization to change buffer sizes. This fixes out of bounds reads. Signed-off-by: Andreas Cadhalpun --- libavcodec/alsdec.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index ebd364e..5efa0cc 100644 -