Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: Fix opus parser dependency.

2017-12-09 Thread Michael Niedermayer 
On Fri, Dec 08, 2017 at 11:35:06AM -0800, Jacob Trimble wrote:
> On Fri, Dec 8, 2017 at 10:39 AM, Michael Niedermayer
>  wrote:
> > On Thu, Dec 07, 2017 at 11:30:13AM -0800, Jacob Trimble wrote:
> >> The opus.c file uses variables that are defined in opustab.c.  The
> >> opus parser needs to include that file to avoid linker errors when
> >> not including the opus encoder/decoder.
> >
> > please list the symbols needed or the error message in the commmit
> > message, so the reader knows about which symbols this is
> >
> > thx
> 
> Done

>  Makefile |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> dac7fd9255ebedc1e5db63bf6079aa8d1b6c9c8b  opus-parser-v2.patch
> From 8519e5192bc3dbbc5aa49204321419b6e5a8bf4b Mon Sep 17 00:00:00 2001
> From: Jacob Trimble 
> Date: Thu, 7 Dec 2017 11:05:46 -0800
> Subject: [PATCH] avcodec/Makefile: Fix opus parser dependency.
> 
> The opus.c file uses ff_celt_freq_range and ff_celt_freq_bands which are
> defined in opustab.c.  The opus parser needs to include that file to
> avoid linker errors when not including the opus encoder/decoder.

will apply

thanks

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: Fix opus parser dependency.

2017-12-08 Thread Jacob Trimble 
On Fri, Dec 8, 2017 at 10:39 AM, Michael Niedermayer
 wrote:
> On Thu, Dec 07, 2017 at 11:30:13AM -0800, Jacob Trimble wrote:
>> The opus.c file uses variables that are defined in opustab.c.  The
>> opus parser needs to include that file to avoid linker errors when
>> not including the opus encoder/decoder.
>
> please list the symbols needed or the error message in the commmit
> message, so the reader knows about which symbols this is
>
> thx

Done
From 8519e5192bc3dbbc5aa49204321419b6e5a8bf4b Mon Sep 17 00:00:00 2001
From: Jacob Trimble 
Date: Thu, 7 Dec 2017 11:05:46 -0800
Subject: [PATCH] avcodec/Makefile: Fix opus parser dependency.

The opus.c file uses ff_celt_freq_range and ff_celt_freq_bands which are
defined in opustab.c.  The opus parser needs to include that file to
avoid linker errors when not including the opus encoder/decoder.

Signed-off-by: Jacob Trimble 
---
 libavcodec/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index ab7893f560..ca72138c02 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -1005,7 +1005,7 @@ OBJS-$(CONFIG_PNG_PARSER)  += png_parser.o
 OBJS-$(CONFIG_MPEGAUDIO_PARSER)+= mpegaudio_parser.o
 OBJS-$(CONFIG_MPEGVIDEO_PARSER)+= mpegvideo_parser.o\
   mpeg12.o mpeg12data.o
-OBJS-$(CONFIG_OPUS_PARSER) += opus_parser.o opus.o vorbis_data.o
+OBJS-$(CONFIG_OPUS_PARSER) += opus_parser.o opus.o opustab.o vorbis_data.o
 OBJS-$(CONFIG_PNG_PARSER)  += png_parser.o
 OBJS-$(CONFIG_PNM_PARSER)  += pnm_parser.o pnm.o
 OBJS-$(CONFIG_RV30_PARSER) += rv34_parser.o
-- 
2.15.1.424.g9478a66081-goog

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: Fix opus parser dependency.

2017-12-08 Thread Michael Niedermayer 
On Thu, Dec 07, 2017 at 11:30:13AM -0800, Jacob Trimble wrote:
> The opus.c file uses variables that are defined in opustab.c.  The
> opus parser needs to include that file to avoid linker errors when
> not including the opus encoder/decoder.

please list the symbols needed or the error message in the commmit
message, so the reader knows about which symbols this is

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/Makefile: Fix opus parser dependency.

2017-12-07 Thread Jacob Trimble 
The opus.c file uses variables that are defined in opustab.c.  The
opus parser needs to include that file to avoid linker errors when
not including the opus encoder/decoder.

Signed-off-by: Jacob Trimble 
---
 libavcodec/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index ab7893f560..ca72138c02 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -1005,7 +1005,7 @@ OBJS-$(CONFIG_PNG_PARSER)  += png_parser.o
 OBJS-$(CONFIG_MPEGAUDIO_PARSER)+= mpegaudio_parser.o
 OBJS-$(CONFIG_MPEGVIDEO_PARSER)+= mpegvideo_parser.o\
   mpeg12.o mpeg12data.o
-OBJS-$(CONFIG_OPUS_PARSER) += opus_parser.o opus.o vorbis_data.o
+OBJS-$(CONFIG_OPUS_PARSER) += opus_parser.o opus.o opustab.o 
vorbis_data.o
 OBJS-$(CONFIG_PNG_PARSER)  += png_parser.o
 OBJS-$(CONFIG_PNM_PARSER)  += pnm_parser.o pnm.o
 OBJS-$(CONFIG_RV30_PARSER) += rv34_parser.o
-- 
2.15.1.424.g9478a66081-goog

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel